pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedThe order of columns about WAL activity in pg_stat_statements
3+ messages / 2 participants
[nested] [flat]
* The order of columns about WAL activity in pg_stat_statements
@ 2020-05-13 15:11 Fujii Masao <masao.fujii@oss.nttdata.com>
2020-05-13 15:41 ` Re: The order of columns about WAL activity in pg_stat_statements Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Fujii Masao @ 2020-05-13 15:11 UTC (permalink / raw)
To: pgsql-docs
Hi,
https://www.postgresql.org/docs/devel/pgstatstatements.html
In pg_stat_statements docs, the columns about WAL activity are put
in the table in the order of wal_bytes, wal_records and wal_fpi. But
in the definition of pg_stat_statements view, wal_bytes is put last.
So I think that it's better to reorder those columns in a consistent
with the view definition. Patch attached. Thought?
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Attachments:
pgss_docs.patch (text/plain, 952B) download
diff --git a/doc/src/sgml/pgstatstatements.sgml b/doc/src/sgml/pgstatstatements.sgml
index b1d5f3d1dc..edacda971f 100644
--- a/doc/src/sgml/pgstatstatements.sgml
+++ b/doc/src/sgml/pgstatstatements.sgml
@@ -264,15 +264,6 @@
</entry>
</row>
- <row>
- <entry><structfield>wal_bytes</structfield></entry>
- <entry><type>numeric</type></entry>
- <entry></entry>
- <entry>
- Total amount of WAL bytes generated by the statement
- </entry>
- </row>
-
<row>
<entry><structfield>wal_records</structfield></entry>
<entry><type>bigint</type></entry>
@@ -291,6 +282,15 @@
</entry>
</row>
+ <row>
+ <entry><structfield>wal_bytes</structfield></entry>
+ <entry><type>numeric</type></entry>
+ <entry></entry>
+ <entry>
+ Total amount of WAL bytes generated by the statement
+ </entry>
+ </row>
+
</tbody>
</tgroup>
</table>
* Re: The order of columns about WAL activity in pg_stat_statements
2020-05-13 15:11 The order of columns about WAL activity in pg_stat_statements Fujii Masao <masao.fujii@oss.nttdata.com>
@ 2020-05-13 15:41 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-05-13 16:12 ` Re: The order of columns about WAL activity in pg_stat_statements Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2020-05-13 15:41 UTC (permalink / raw)
To: Fujii Masao <masao.fujii@oss.nttdata.com>; +Cc: pgsql-docs
Fujii Masao <masao.fujii@oss.nttdata.com> writes:
> In pg_stat_statements docs, the columns about WAL activity are put
> in the table in the order of wal_bytes, wal_records and wal_fpi. But
> in the definition of pg_stat_statements view, wal_bytes is put last.
> So I think that it's better to reorder those columns in a consistent
> with the view definition. Patch attached. Thought?
I already fixed this in my pending patch to restructure the catalog
docs [1].
regards, tom lane
[1] https://www.postgresql.org/message-id/14810.1589128043%40sss.pgh.pa.us
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: The order of columns about WAL activity in pg_stat_statements
2020-05-13 15:11 The order of columns about WAL activity in pg_stat_statements Fujii Masao <masao.fujii@oss.nttdata.com>
2020-05-13 15:41 ` Re: The order of columns about WAL activity in pg_stat_statements Tom Lane <tgl@sss.pgh.pa.us>
@ 2020-05-13 16:12 ` Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2020-05-13 16:12 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-docs
On 2020/05/14 0:41, Tom Lane wrote:
> Fujii Masao <masao.fujii@oss.nttdata.com> writes:
>> In pg_stat_statements docs, the columns about WAL activity are put
>> in the table in the order of wal_bytes, wal_records and wal_fpi. But
>> in the definition of pg_stat_statements view, wal_bytes is put last.
>> So I think that it's better to reorder those columns in a consistent
>> with the view definition. Patch attached. Thought?
>
> I already fixed this in my pending patch to restructure the catalog
> docs [1].
Sounds nice. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2020-05-13 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-05-13 15:11 The order of columns about WAL activity in pg_stat_statements Fujii Masao <masao.fujii@oss.nttdata.com>
2020-05-13 15:41 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-05-13 16:12 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox