public inbox for [email protected]
help / color / mirror / Atom feed[PATCH 3/3] Clarify merror messages
2+ messages / 2 participants
[nested] [flat]
* [PATCH 3/3] Clarify merror messages
@ 2021-04-28 08:25 Kyotaro Horiguchi <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Kyotaro Horiguchi @ 2021-04-28 08:25 UTC (permalink / raw)
---
src/backend/commands/conversioncmds.c | 2 +-
src/backend/commands/typecmds.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/commands/conversioncmds.c b/src/backend/commands/conversioncmds.c
index 5fed97a2f9..307afb909d 100644
--- a/src/backend/commands/conversioncmds.c
+++ b/src/backend/commands/conversioncmds.c
@@ -127,7 +127,7 @@ CreateConversionCommand(CreateConversionStmt *stmt)
if (DatumGetInt32(funcresult) != 0)
ereport(ERROR,
(errcode(ERRCODE_INVALID_OBJECT_DEFINITION),
- errmsg("encoding conversion function %s returned incorrect result for empty input",
+ errmsg("encoding conversion function %s must return zero for empty input",
NameListToString(func_name))));
/*
diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c
index 036fa69d17..3dd4323386 100644
--- a/src/backend/commands/typecmds.c
+++ b/src/backend/commands/typecmds.c
@@ -4291,7 +4291,7 @@ AlterType(AlterTypeStmt *stmt)
if (!superuser())
ereport(ERROR,
(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
- errmsg("must be superuser to alter a type")));
+ errmsg("must be superuser to perform all operations")));
}
else
{
--
2.27.0
----Next_Part(Wed_Apr_28_17_36_33_2021_627)----
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Add checkpoint and redo LSN to LogCheckpointEnd log message
@ 2022-01-31 18:30 Nathan Bossart <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Bossart @ 2022-01-31 18:30 UTC (permalink / raw)
To: Bharath Rupireddy <[email protected]>; +Cc: Stephen Frost <[email protected]>; Kyotaro Horiguchi <[email protected]>; Bossart, Nathan <[email protected]>; Julien Rouhaud <[email protected]>; Michael Paquier <[email protected]>; PostgreSQL Hackers <[email protected]>
On Mon, Jan 31, 2022 at 11:45:19PM +0530, Bharath Rupireddy wrote:
> Thanks. Here are 2 patches, 0001 for adding checkpoint lsn and redo
> lsn in the checkpoint completed message and 0002 for changing the
> "location" to LSN in pg_controdata's output. With the 0002,
> pg_control_checkpont, pg_controldata and checkpoint completed message
> will all be in sync with the checkpoint lsn and redo lsn.
I think the pg_controldata change needs some extra spaces for alignment,
but otherwise these patches seem reasonable to me.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2022-01-31 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-04-28 08:25 [PATCH 3/3] Clarify merror messages Kyotaro Horiguchi <[email protected]>
2022-01-31 18:30 Re: Add checkpoint and redo LSN to LogCheckpointEnd log message Nathan Bossart <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox