From: Sergei Kornilov <sk@zsrv.org>
To: Ildar Musin <i.musin@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Fri, 09 Mar 2018 17:51:25 +0300
Message-ID: <2947361520607085@web26g.yandex.ru> (raw)
In-Reply-To: <082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru>
References: <880511520351578@web5j.yandex.ru>
<20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
<1715451520361128@web26o.yandex.ru>
<1142.1520362313@sss.pgh.pa.us>
<082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru>
Hello all!
Summarizing, how i must update tests?
We want test real skip of verify phase or only result correctness?
I can verify what i do not break alter table by tests in v4 of my patch. But here is no check code path. So my feature may be broken in future without test fail. alter table will be correct regardless this feature.
Or i must test code path too? I understood Tom and will remove INFO ereport from patch anyway. But currently i have no idea how check code path. As mentioned earlier using debug ereport is uncomfortable too. Here is no suitable event trigger to track what exactly happens with table. Adding new one for test purposes seems overkill.
regards, Sergei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sk@zsrv.org, i.musin@postgrespro.ru, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, sfrost@snowman.net, robertmhaas@gmail.com
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-Reply-To: <2947361520607085@web26g.yandex.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox