pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Wed, 13 Mar 2019 13:09:32 -0400
Message-ID: <7254.1552496972@sss.pgh.pa.us> (raw)
In-Reply-To: <2815991552495610@myt1-4903e6646a45.qloud-c.yandex.net>
References: <880511520351578@web5j.yandex.ru>
	<20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
	<1715451520361128@web26o.yandex.ru>
	<1142.1520362313@sss.pgh.pa.us>
	<082cf493-a989-dcd6-7baf-a94a40d07ea0@postgrespro.ru>
	<2947361520607085@web26g.yandex.ru>
	<5376321520674521@web1j.yandex.ru>
	<979461523301587@web39j.yandex.ru>
	<247201523472946@web58j.yandex.ru>
	<3654591523776151@web39j.yandex.ru>
	<CAKJS1f8DOXOSTwt+WXfG9V45t48_tB6mCVQAhR3xVoAiAa7PmQ@mail.gmail.com>
	<9345791551814869@myt2-cd7fa496c4f7.qloud-c.yandex.net>
	<CAKJS1f_X_z0AAFBW-7_=jeNCiAcyRLYCNwcctJCC2N_uRgMPog@mail.gmail.com>
	<7479161552216397@iva6-19b25c513db4.qloud-c.yandex.net>
	<CAKJS1f_+T_y2sDPz8ZPB7wUi7Ob-aO6iaUbd1KOx2-K+tksk=Q@mail.gmail.com>
	<CA+TgmobvUHVkOVpMkNU=BA5nCyn4GkQ3dCVzj0qdCBX8af_q=Q@mail.gmail.com>
	<694691552422467@myt1-06117f29c1ea.qloud-c.yandex.net>
	<CA+TgmoYYm_TPXoWgucr99RCZQpO84f6rjOYMk9GcRCv5zaaqsw@mail.gmail.com>
	<21516.1552489217@sss.pgh.pa.us>
	<2123251552490241@myt6-fe24916a5562.qloud-c.yandex! .net>
	<CA+TgmoZWSLUjVcc9KBSVvbn=U5QRgW1O-MgUX0y5CnLZOA2qyQ@mail.gmail.com>
	<2815991552495610@myt1-4903e6646a45.qloud-c.yandex.net>

Sergei Kornilov <sk@zsrv.org> writes:
>> Ugh, I guess so. Or how about changing the message itself to use
>> INFO, like we already do in QueuePartitionConstraintValidation?

> Fine for me. But year ago this was implemented in my patch and Tom voted against using INFO level for such purpose: https://www.postgresql.org/message-id/1142.1520362313%40sss.pgh.pa.us

What I thought then was that you didn't need the message at all,
at any debug level.  I still think that.  It might have been useful
for development purposes but it does not belong in committed code.
INFO (making it impossible for anybody to not have the message
in-their-face) is right out.

			regards, tom lane




view thread (73+ messages)  latest in thread

Message-ID: <7254.1552496972@sss.pgh.pa.us>
Permalink:  ../7254.1552496972@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/7254.1552496972@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, sk@zsrv.org, robertmhaas@gmail.com, david.rowley@2ndquadrant.com, alvherre@alvh.no-ip.org, sfrost@snowman.net, i.musin@postgrespro.ru
  Subject: Re: using index or check in ALTER TABLE SET NOT NULL
  In-Reply-To: <7254.1552496972@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox