pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: Fri, 30 Sep 2022 19:05:38 -0400
Message-ID: <749976.1664579138@sss.pgh.pa.us> (raw)
In-Reply-To: <20220930223257.GA190214@nathanxps13>
References: <20220920235010.GB378596@nathanxps13>
	<Yyppg/c4SB7s1IAv@paquier.xyz>
	<20220921043126.GA382738@nathanxps13>
	<20220928185034.GA1397229@nathanxps13>
	<CAOuzzgpQtdqj2BfwheD9+fjUnVSo1cmdrQmwcr-qbvKjC5cfyg@mail.gmail.com>
	<20220928201222.GA1400058@nathanxps13>
	<20220930192350.GA171832@nathanxps13>
	<678838.1664568924@sss.pgh.pa.us>
	<20220930214728.GA177925@nathanxps13>
	<742523.1664575253@sss.pgh.pa.us>
	<20220930223257.GA190214@nathanxps13>

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Sep 30, 2022 at 06:00:53PM -0400, Tom Lane wrote:
>> ... and now requires double alignment ... did you fix its typalign?

> Nope, I missed that, thanks for pointing it out.  Should we move ai_privs
> to the beginning of the struct, too?

Don't see any point, there won't be any padding.  If we ever change the
sizeof(Oid), or add more fields, we can consider what to do then.

			regards, tom lane





view thread (63+ messages)  latest in thread

Message-ID: <749976.1664579138@sss.pgh.pa.us>
Permalink:  ../749976.1664579138@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/749976.1664579138@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, sfrost@snowman.net, bharath.rupireddyforpostgres@gmail.com, david.g.johnston@gmail.com, horikyota.ntt@gmail.com, michael@paquier.xyz, robertmhaas@gmail.com
  Subject: Re: predefined role(s) for VACUUM and ANALYZE
  In-Reply-To: <749976.1664579138@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox