pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg_upgrade check fails on Solaris 10
5+ messages / 2 participants
[nested] [flat]
* pg_upgrade check fails on Solaris 10
@ 2019-09-17 16:07 Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-18 14:36 ` Re: pg_upgrade check fails on Solaris 10 Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 1 reply; 5+ messages in thread
From: Marina Polyakova @ 2019-09-17 16:07 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org; +Cc: Victor Wagner <v.wagner@postgrespro.ru>
Hello, hackers!
We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
argument to the sed command is not enclosed in quotation marks (see
[1]):
$ gmake -C src/bin/pg_upgrade/ check
<...>
MAKE=gmake
bindir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/bin"
libdir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/lib"
EXTRA_REGRESS_OPTS="" /bin/sh test.sh --install
test.sh: MSYS/MINGW/: not found
gmake: *** [check] Error 1
gmake: Leaving directory
`/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/src/bin/pg_upgrade'
$ sed: command garbled: s/
Attached diff.patch fixes the problem.
About the system: SunOS, Release 5.10, KernelID Generic_141444-09.
About the used shell: according to the manual, it comes from the package
SUNWcsu.
Thanks to Victor Wagner for his help to investigate this issue.
[1] $ man sh
<...>
Quoting
The following characters have a special meaning to the shell and cause
termination of a word unless quoted:
; & ( ) | ^ < > newline space tab
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachments:
[text/x-diff] diff.patch (520B, ../../feba89f89e8925b3535cb7d72b9e05e1@postgrespro.ru/2-diff.patch)
download | inline diff:
diff --git a/src/bin/pg_upgrade/test.sh b/src/bin/pg_upgrade/test.sh
index 424d89c3feeced91531920e919a2d9e06cc4baa6..f258983b18f8276cfef3db0a425d59fead6493d9 100644
--- a/src/bin/pg_upgrade/test.sh
+++ b/src/bin/pg_upgrade/test.sh
@@ -33,7 +33,7 @@ standard_initdb() {
# What flavor of host are we on?
# Treat MINGW* (msys1) and MSYS* (msys2) the same.
-testhost=`uname -s | sed s/^MSYS/MINGW/`
+testhost=`uname -s | sed 's/^MSYS/MINGW/'`
# Establish how the server will listen for connections
case $testhost in
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_upgrade check fails on Solaris 10
2019-09-17 16:07 pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
@ 2019-09-18 14:36 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-09-23 15:57 ` Re: pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
0 siblings, 1 reply; 5+ messages in thread
From: Alvaro Herrera @ 2019-09-18 14:36 UTC (permalink / raw)
To: Marina Polyakova <m.polyakova@postgrespro.ru>; +Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner <v.wagner@postgrespro.ru>
On 2019-Sep-17, Marina Polyakova wrote:
> Hello, hackers!
>
> We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
> argument to the sed command is not enclosed in quotation marks (see [1]):
Hmm, I'm surprised it has taken this long to detect the problem.
> Attached diff.patch fixes the problem.
I have pushed it to all branches that have src/bin/pg_upgrade (namely,
9.5 onwards), thanks. I hope this won't make the msys/mingw machines
angry ;-)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_upgrade check fails on Solaris 10
2019-09-17 16:07 pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-18 14:36 ` Re: pg_upgrade check fails on Solaris 10 Alvaro Herrera <alvherre@2ndquadrant.com>
@ 2019-09-23 15:57 ` Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-23 16:41 ` Re: pg_upgrade check fails on Solaris 10 Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 1 reply; 5+ messages in thread
From: Marina Polyakova @ 2019-09-23 15:57 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner <v.wagner@postgrespro.ru>
On 2019-09-18 17:36, Alvaro Herrera wrote:
> On 2019-Sep-17, Marina Polyakova wrote:
>
>> Hello, hackers!
>>
>> We got an error for pg_upgrade check on the branch REL_11_STABLE
>> (commit
>> 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC
>> the
>> argument to the sed command is not enclosed in quotation marks (see
>> [1]):
>
> Hmm, I'm surprised it has taken this long to detect the problem.
Looking at the members of buildfarm [1] castoroides and protosciurus -
IIUC they do not check pg_upgrade. And I was that lucky one who have run
the branch with the latest commits at our buildfarm...
>> Attached diff.patch fixes the problem.
>
> I have pushed it to all branches that have src/bin/pg_upgrade (namely,
> 9.5 onwards), thanks. I hope this won't make the msys/mingw machines
> angry ;-)
Thank you! I ran pg_upgrade tests for MSYS, everything is fine.
The branch REL9_4_STABLE (commit
8a17afe84be6fefe76d0d2f4d26c5ee075e64487) has the same issue - according
to the release table [2] it is still supported, isn't it?...
[1] https://buildfarm.postgresql.org/cgi-bin/show_members.pl
[2] https://www.postgresql.org/support/versioning/
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_upgrade check fails on Solaris 10
2019-09-17 16:07 pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-18 14:36 ` Re: pg_upgrade check fails on Solaris 10 Alvaro Herrera <alvherre@2ndquadrant.com>
2019-09-23 15:57 ` Re: pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
@ 2019-09-23 16:41 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-09-24 07:00 ` Re: pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
0 siblings, 1 reply; 5+ messages in thread
From: Alvaro Herrera @ 2019-09-23 16:41 UTC (permalink / raw)
To: Marina Polyakova <m.polyakova@postgrespro.ru>; +Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner <v.wagner@postgrespro.ru>
On 2019-Sep-23, Marina Polyakova wrote:
> On 2019-09-18 17:36, Alvaro Herrera wrote:
> > On 2019-Sep-17, Marina Polyakova wrote:
> >
> > > We got an error for pg_upgrade check on the branch REL_11_STABLE
> > > (commit
> > > 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC
> > > the
> > > argument to the sed command is not enclosed in quotation marks (see
> > > [1]):
> >
> > Hmm, I'm surprised it has taken this long to detect the problem.
>
> Looking at the members of buildfarm [1] castoroides and protosciurus - IIUC
> they do not check pg_upgrade. And I was that lucky one who have run the
> branch with the latest commits at our buildfarm...
Argh.
But I meant "how come nobody runs pg_upgrade tests on old Solaris?"
> > I have pushed it to all branches that have src/bin/pg_upgrade (namely,
> > 9.5 onwards), thanks. I hope this won't make the msys/mingw machines
> > angry ;-)
>
> Thank you! I ran pg_upgrade tests for MSYS, everything is fine.
>
> The branch REL9_4_STABLE (commit 8a17afe84be6fefe76d0d2f4d26c5ee075e64487)
> has the same issue - according to the release table [2] it is still
> supported, isn't it?...
Yeah, but pg_upgrade is in contrib/ in 9.4, so nowhere as good as from
9.5 onwards; and it's going to die in a couple of months anyway, so I'm
not thrilled about fixing this there.
If you *need* to have this fixed in 9.4, we can do that, but do you?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_upgrade check fails on Solaris 10
2019-09-17 16:07 pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-18 14:36 ` Re: pg_upgrade check fails on Solaris 10 Alvaro Herrera <alvherre@2ndquadrant.com>
2019-09-23 15:57 ` Re: pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-23 16:41 ` Re: pg_upgrade check fails on Solaris 10 Alvaro Herrera <alvherre@2ndquadrant.com>
@ 2019-09-24 07:00 ` Marina Polyakova <m.polyakova@postgrespro.ru>
0 siblings, 0 replies; 5+ messages in thread
From: Marina Polyakova @ 2019-09-24 07:00 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@2ndquadrant.com>; +Cc: pgsql-hackers@lists.postgresql.org, Victor Wagner <v.wagner@postgrespro.ru>
On 2019-09-23 19:41, Alvaro Herrera wrote:
> On 2019-Sep-23, Marina Polyakova wrote:
>> The branch REL9_4_STABLE (commit
>> 8a17afe84be6fefe76d0d2f4d26c5ee075e64487)
>> has the same issue - according to the release table [2] it is still
>> supported, isn't it?...
>
> Yeah, but pg_upgrade is in contrib/ in 9.4, so nowhere as good as from
> 9.5 onwards; and it's going to die in a couple of months anyway, so I'm
> not thrilled about fixing this there.
>
> If you *need* to have this fixed in 9.4, we can do that, but do you?
No, we don't. I just noticed :-)
--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2019-09-24 07:00 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-09-17 16:07 pg_upgrade check fails on Solaris 10 Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-18 14:36 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-09-23 15:57 ` Marina Polyakova <m.polyakova@postgrespro.ru>
2019-09-23 16:41 ` Alvaro Herrera <alvherre@2ndquadrant.com>
2019-09-24 07:00 ` Marina Polyakova <m.polyakova@postgrespro.ru>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox