public inbox for [email protected]help / color / mirror / Atom feed
PFA: Patch to generate universal(arm64, x86_64) binaries for macOS 7+ messages / 2 participants [nested] [flat]
* PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-07-30 10:40 Semab Tariq <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Semab Tariq @ 2021-07-30 10:40 UTC (permalink / raw) To: pgadmin-hackers Hi Team Can someone please push this patch to the *master* branch of *pgAgent* repo? For more details Please refer to JIRA PPS-310 <https://enterprisedb.atlassian.net/browse/PPS-310; -- Thanks & Regards, Semab Attachments: [application/octet-stream] PPS-310-master-1.patch (662B, 3-PPS-310-master-1.patch) download | inline diff: diff --git a/CMakeLists.txt b/CMakeLists.txt index 7e66c5d..ec0df1f 100755 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -40,7 +40,7 @@ IF(APPLE) SET(CMAKE_OSX_SYSROOT ${CMAKE_OSX_SYSROOT} CACHE FILEPATH "isysroot used for universal binary support" FORCE) ENDIF(EXISTS ${CMAKE_OSX_SYSROOT}) - IF(NOT ${CMAKE_OSX_ARCHITECTURES} STREQUAL "") + IF(NOT "${CMAKE_OSX_ARCHITECTURES}" STREQUAL "") SET(CMAKE_OSX_ARCHITECTURES ${CMAKE_OSX_ARCHITECTURES} CACHE STRING "Build architectures for OSX" FORCE) ELSE() SET(CMAKE_OSX_ARCHITECTURES "x86_64" CACHE STRING "Build architectures for OSX" FORCE) ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-08-01 17:57 Semab Tariq <[email protected]> parent: Semab Tariq <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Semab Tariq @ 2021-08-01 17:57 UTC (permalink / raw) To: pgadmin-hackers Hi Team In my previous email, I attached a link to the JIRA ticket and I was hoping that you can access that ticket and see the details about my patch but I was unaware that JIRA is not accessible to the community so now I am attaching the details here *Details about my patch* While trying to generate *pgAgent-4.2.1* universal binaries on *macOS BigSur x86_64* architecture via following command 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.app/ Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" -DCMAKE_OSX_DEPLOYMENT_TARGET :STRING=10.14 -DSTATIC_BUILD=NO -D CMAKE_OSX_SYSROOT:FILEPATH=/Library/ Developer/CommandLineTools/SDKs/MacOSX11.1.sdk CMakeLists.txt I got this error in configure log 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- Configuring incomplete, errors occurred! After some debugging, I found out that the *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition so I added that, and now I am able to build pgAgent universal binaries successfully. If you don't have any concerns with my patch can someone please push the changes to the source? Thanks & Regards, Semab On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <[email protected]> wrote: > Hi Team > > Can someone please push this patch to the *master* branch of *pgAgent* > repo? > For more details Please refer to JIRA PPS-310 > <https://enterprisedb.atlassian.net/browse/PPS-310; > > -- > Thanks & Regards, > Semab > -- ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-08-02 08:11 Dave Page <[email protected]> parent: Semab Tariq <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2021-08-02 08:11 UTC (permalink / raw) To: Semab Tariq <[email protected]>; +Cc: pgadmin-hackers Thanks, patch applied. On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq <[email protected]> wrote: > Hi Team > > In my previous email, I attached a link to the JIRA ticket and I was > hoping that you can access that ticket and see the details about my patch > but I was unaware that JIRA is not accessible to the community so now I am > attaching the details here > > *Details about my patch* > > While trying to generate *pgAgent-4.2.1* universal binaries on *macOS > BigSur x86_64* architecture via following command > 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.app/ > Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - > DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - > DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D > CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ > MacOSX11.1.sdk CMakeLists.txt > > I got this error in configure log > 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" > "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- > Configuring incomplete, errors occurred! > > After some debugging, I found out that the > *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double > quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition so > I added that, and now I am able to build pgAgent universal binaries > successfully. If you don't have any concerns with my patch can someone > please push the changes to the source? Thanks & Regards, > Semab > > On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <[email protected]> > wrote: > >> Hi Team >> >> Can someone please push this patch to the *master* branch of *pgAgent* >> repo? >> For more details Please refer to JIRA PPS-310 >> <https://enterprisedb.atlassian.net/browse/PPS-310; >> >> -- >> Thanks & Regards, >> Semab >> > > > -- > -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-08-02 08:27 Semab Tariq <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Semab Tariq @ 2021-08-02 08:27 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers Great, thanks for letting me know. On Mon, Aug 2, 2021 at 1:12 PM Dave Page <[email protected]> wrote: > Thanks, patch applied. > > On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq <[email protected]> > wrote: > >> Hi Team >> >> In my previous email, I attached a link to the JIRA ticket and I was >> hoping that you can access that ticket and see the details about my patch >> but I was unaware that JIRA is not accessible to the community so now I am >> attaching the details here >> >> *Details about my patch* >> >> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >> BigSur x86_64* architecture via following command >> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake.app >> /Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >> MacOSX11.1.sdk CMakeLists.txt >> >> I got this error in configure log >> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >> Configuring incomplete, errors occurred! >> >> After some debugging, I found out that the >> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition >> so I added that, and now I am able to build pgAgent universal binaries >> successfully. If you don't have any concerns with my patch can someone >> please push the changes to the source? Thanks & Regards, >> Semab >> >> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq <[email protected]> >> wrote: >> >>> Hi Team >>> >>> Can someone please push this patch to the *master* branch of *pgAgent* >>> repo? >>> For more details Please refer to JIRA PPS-310 >>> <https://enterprisedb.atlassian.net/browse/PPS-310; >>> >>> -- >>> Thanks & Regards, >>> Semab >>> >> >> >> -- >> > > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- Thanks & Regards, Semab ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-10-01 10:21 Semab Tariq <[email protected]> parent: Semab Tariq <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Semab Tariq @ 2021-10-01 10:21 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers; Sandeep Thakkar <[email protected]>; Ashesh Vashi <[email protected]> (Adding Ashesh, Sandeep) Hi Team Do we have any possible date for the pgAgent-4.2.2 release? I am interested in 4.2.2 because 4.2.1 doesn't have support to build universal binaries on macOS but 4.2.2 will have this support because this <https://github.com/postgres/pgagent/commit/6df18a9a0ac79f1d913f4279f36f2c95c9b9aa08; commit is already pushed to the master branch Also, we plan to release pgAgent for PG-14.0, and for this, we need pgAgent-4.2.2(Due to its universal binaries support) Thanks & Regards, Semab On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq <[email protected]> wrote: > Great, thanks for letting me know. > > On Mon, Aug 2, 2021 at 1:12 PM Dave Page <[email protected]> wrote: > >> Thanks, patch applied. >> >> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq <[email protected]> >> wrote: >> >>> Hi Team >>> >>> In my previous email, I attached a link to the JIRA ticket and I was >>> hoping that you can access that ticket and see the details about my patch >>> but I was unaware that JIRA is not accessible to the community so now I am >>> attaching the details here >>> >>> *Details about my patch* >>> >>> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >>> BigSur x86_64* architecture via following command >>> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake. >>> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >>> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >>> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >>> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >>> MacOSX11.1.sdk CMakeLists.txt >>> >>> I got this error in configure log >>> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >>> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >>> Configuring incomplete, errors occurred! >>> >>> After some debugging, I found out that the >>> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >>> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition >>> so I added that, and now I am able to build pgAgent universal binaries >>> successfully. If you don't have any concerns with my patch can someone >>> please push the changes to the source? Thanks & Regards, >>> Semab >>> >>> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq < >>> [email protected]> wrote: >>> >>>> Hi Team >>>> >>>> Can someone please push this patch to the *master* branch of *pgAgent* >>>> repo? >>>> For more details Please refer to JIRA PPS-310 >>>> <https://enterprisedb.atlassian.net/browse/PPS-310; >>>> >>>> -- >>>> Thanks & Regards, >>>> Semab >>>> >>> >>> >>> -- >>> >> >> >> -- >> Dave Page >> Blog: https://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: https://www.enterprisedb.com >> >> > > -- > Thanks & Regards, > Semab > -- ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-10-04 11:00 Dave Page <[email protected]> parent: Semab Tariq <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Dave Page @ 2021-10-04 11:00 UTC (permalink / raw) To: Semab Tariq <[email protected]>; +Cc: pgadmin-hackers; Sandeep Thakkar <[email protected]>; Ashesh Vashi <[email protected]> Hi I've tagged 4.2.2. On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq <[email protected]> wrote: > (Adding Ashesh, Sandeep) > > Hi Team > > Do we have any possible date for the pgAgent-4.2.2 release? > I am interested in 4.2.2 because 4.2.1 doesn't have support to build > universal binaries on macOS but 4.2.2 will have this support because this > <https://github.com/postgres/pgagent/commit/6df18a9a0ac79f1d913f4279f36f2c95c9b9aa08; > commit is already pushed to the master branch > Also, we plan to release pgAgent for PG-14.0, and for this, we need > pgAgent-4.2.2(Due to its universal binaries support) > > Thanks & Regards, > Semab > > On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq <[email protected]> > wrote: > >> Great, thanks for letting me know. >> >> On Mon, Aug 2, 2021 at 1:12 PM Dave Page <[email protected]> wrote: >> >>> Thanks, patch applied. >>> >>> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq <[email protected]> >>> wrote: >>> >>>> Hi Team >>>> >>>> In my previous email, I attached a link to the JIRA ticket and I was >>>> hoping that you can access that ticket and see the details about my patch >>>> but I was unaware that JIRA is not accessible to the community so now I am >>>> attaching the details here >>>> >>>> *Details about my patch* >>>> >>>> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >>>> BigSur x86_64* architecture via following command >>>> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake. >>>> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >>>> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >>>> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >>>> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >>>> MacOSX11.1.sdk CMakeLists.txt >>>> >>>> I got this error in configure log >>>> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >>>> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >>>> Configuring incomplete, errors occurred! >>>> >>>> After some debugging, I found out that the >>>> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >>>> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* condition >>>> so I added that, and now I am able to build pgAgent universal binaries >>>> successfully. If you don't have any concerns with my patch can someone >>>> please push the changes to the source? Thanks & Regards, >>>> Semab >>>> >>>> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq < >>>> [email protected]> wrote: >>>> >>>>> Hi Team >>>>> >>>>> Can someone please push this patch to the *master* branch of *pgAgent* >>>>> repo? >>>>> For more details Please refer to JIRA PPS-310 >>>>> <https://enterprisedb.atlassian.net/browse/PPS-310; >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Semab >>>>> >>>> >>>> >>>> -- >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: https://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EDB: https://www.enterprisedb.com >>> >>> >> >> -- >> Thanks & Regards, >> Semab >> > > > -- > > -- Dave Page Blog: https://pgsnake.blogspot.com Twitter: @pgsnake EDB: https://www.enterprisedb.com ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: PFA: Patch to generate universal(arm64, x86_64) binaries for macOS @ 2021-10-04 17:45 Semab Tariq <[email protected]> parent: Dave Page <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: Semab Tariq @ 2021-10-04 17:45 UTC (permalink / raw) To: Dave Page <[email protected]>; +Cc: pgadmin-hackers; Sandeep Thakkar <[email protected]>; Ashesh Vashi <[email protected]> Awesome, thanks! Thanks & Regards, Semab On Mon, Oct 4, 2021 at 4:00 PM Dave Page <[email protected]> wrote: > Hi > > I've tagged 4.2.2. > > On Fri, Oct 1, 2021 at 11:22 AM Semab Tariq <[email protected]> > wrote: > >> (Adding Ashesh, Sandeep) >> >> Hi Team >> >> Do we have any possible date for the pgAgent-4.2.2 release? >> I am interested in 4.2.2 because 4.2.1 doesn't have support to build >> universal binaries on macOS but 4.2.2 will have this support because this >> <https://github.com/postgres/pgagent/commit/6df18a9a0ac79f1d913f4279f36f2c95c9b9aa08; >> commit is already pushed to the master branch >> Also, we plan to release pgAgent for PG-14.0, and for this, we need >> pgAgent-4.2.2(Due to its universal binaries support) >> >> Thanks & Regards, >> Semab >> >> On Mon, Aug 2, 2021 at 1:27 PM Semab Tariq <[email protected]> >> wrote: >> >>> Great, thanks for letting me know. >>> >>> On Mon, Aug 2, 2021 at 1:12 PM Dave Page <[email protected]> wrote: >>> >>>> Thanks, patch applied. >>>> >>>> On Mon, Aug 2, 2021 at 2:44 AM Semab Tariq < >>>> [email protected]> wrote: >>>> >>>>> Hi Team >>>>> >>>>> In my previous email, I attached a link to the JIRA ticket and I was >>>>> hoping that you can access that ticket and see the details about my patch >>>>> but I was unaware that JIRA is not accessible to the community so now I am >>>>> attaching the details here >>>>> >>>>> *Details about my patch* >>>>> >>>>> While trying to generate *pgAgent-4.2.1* universal binaries on *macOS >>>>> BigSur x86_64* architecture via following command >>>>> 1BOOST_ROOT=/tmp/PG-pgAgent PGDIR=/tmp/PG-pgAgent /Applications/CMake. >>>>> app/Contents/bin/cmake -DCMAKE_INSTALL_PREFIX=/tmp/PG-pgAgent - >>>>> DCMAKE_OSX_ARCHITECTURES:STRING="x86_64;arm64" - >>>>> DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.14 -DSTATIC_BUILD=NO -D >>>>> CMAKE_OSX_SYSROOT:FILEPATH=/Library/Developer/CommandLineTools/SDKs/ >>>>> MacOSX11.1.sdk CMakeLists.txt >>>>> >>>>> I got this error in configure log >>>>> 1CMake Error at CMakeLists.txt:43 (IF): 2 if given arguments: 3 "NOT" >>>>> "x86_64" "arm64" "STREQUAL" "" 4 Unknown arguments specified 5-- >>>>> Configuring incomplete, errors occurred! >>>>> >>>>> After some debugging, I found out that the >>>>> *pgAgent-4.2.1-Source/CMakeLists.txt* file doesn't have proper double >>>>> quotes around *CMAKE_OSX_ARCHITECTURES* variable inside *if* >>>>> condition so I added that, and now I am able to build pgAgent universal >>>>> binaries successfully. If you don't have any concerns with my patch can >>>>> someone please push the changes to the source? Thanks & Regards, >>>>> Semab >>>>> >>>>> On Fri, Jul 30, 2021 at 3:40 PM Semab Tariq < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Team >>>>>> >>>>>> Can someone please push this patch to the *master* branch of >>>>>> *pgAgent* repo? >>>>>> For more details Please refer to JIRA PPS-310 >>>>>> <https://enterprisedb.atlassian.net/browse/PPS-310; >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Semab >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: https://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EDB: https://www.enterprisedb.com >>>> >>>> >>> >>> -- >>> Thanks & Regards, >>> Semab >>> >> >> >> -- >> >> > > -- > Dave Page > Blog: https://pgsnake.blogspot.com > Twitter: @pgsnake > > EDB: https://www.enterprisedb.com > > -- ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2021-10-04 17:45 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-07-30 10:40 PFA: Patch to generate universal(arm64, x86_64) binaries for macOS Semab Tariq <[email protected]> 2021-08-01 17:57 ` Semab Tariq <[email protected]> 2021-08-02 08:11 ` Dave Page <[email protected]> 2021-08-02 08:27 ` Semab Tariq <[email protected]> 2021-10-01 10:21 ` Semab Tariq <[email protected]> 2021-10-04 11:00 ` Dave Page <[email protected]> 2021-10-04 17:45 ` Semab Tariq <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox