public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin4][RM 5271] To change the switch control colors 10+ messages / 4 participants [nested] [flat]
* [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 07:13 Murtuza Zabuawala <[email protected]> 0 siblings, 2 replies; 10+ messages in thread From: Murtuza Zabuawala @ 2020-03-18 07:13 UTC (permalink / raw) To: pgadmin-hackers Hello, As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Attachments: [application/octet-stream] pgadmin4_switch_changes.diff (7.3K, 3-pgadmin4_switch_changes.diff) download | inline diff: diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/synonyms/static/js/synonym.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/synonyms/static/js/synonym.js index 1731ce3a0..8cb7cbe86 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/synonyms/static/js/synonym.js +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/synonyms/static/js/synonym.js @@ -182,8 +182,8 @@ define('pgadmin.node.synonym', [ },{ id: 'is_public_synonym', label: gettext('Public synonym?'), type: 'switch', mode: ['properties'], cell: 'switch', - options: { onText: gettext('Yes'), offText: gettext('No'), onColor: 'success', - offColor: 'ternary', size: 'mini'}, + options: { onText: gettext('Yes'), offText: gettext('No'), onColor: 'switch-primary', + offColor: 'switch-ternary', size: 'mini'}, }, ], validate: function() { diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.js index cef365d7d..51c43b7ad 100644 --- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.js +++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/columns/static/js/column.js @@ -219,7 +219,7 @@ define('pgadmin.node.column', [ deps:['name'], cellHeaderClasses:'width_percent_5', options: { onText: gettext('Yes'), offText: gettext('No'), - onColor: 'success', offColor: 'ternary', + onColor: 'switch-primary', offColor: 'switch-ternary', }, visible: function(m) { return _.isUndefined( @@ -524,7 +524,7 @@ define('pgadmin.node.column', [ id: 'attnotnull', label: gettext('Not NULL?'), cell: 'switch', type: 'switch', cellHeaderClasses:'width_percent_20', group: gettext('Constraints'), editable: 'editable_check_for_table', - options: { onText: gettext('Yes'), offText: gettext('No'), onColor: 'success', offColor: 'ternary' }, + options: { onText: gettext('Yes'), offText: gettext('No'), onColor: 'switch-primary', offColor: 'switch-ternary' }, deps: ['colconstype'], disabled: function(m) { if (m.get('colconstype') == 'i') { diff --git a/web/pgadmin/misc/statistics/static/js/statistics.js b/web/pgadmin/misc/statistics/static/js/statistics.js index 657d47463..0fb6360e0 100644 --- a/web/pgadmin/misc/statistics/static/js/statistics.js +++ b/web/pgadmin/misc/statistics/static/js/statistics.js @@ -102,8 +102,8 @@ define('misc.statistics', [ PGBooleanCell.prototype.defaults.options, { onText: gettext('True'), offText: gettext('False'), - onColor: 'success', - offColor: 'ternary', + onColor: 'switch-primary', + offColor: 'switch-ternary', size: 'mini', } ); diff --git a/web/pgadmin/preferences/static/js/preferences.js b/web/pgadmin/preferences/static/js/preferences.js index 7e097233e..a9254b319 100644 --- a/web/pgadmin/preferences/static/js/preferences.js +++ b/web/pgadmin/preferences/static/js/preferences.js @@ -213,8 +213,8 @@ define('pgadmin.preferences', [ p.options = { onText: gettext('True'), offText: gettext('False'), - onColor: 'success', - offColor: 'ternary', + onColor: 'switch-primary', + offColor: 'switch-ternary', size: 'mini', }; return 'switch'; @@ -222,8 +222,8 @@ define('pgadmin.preferences', [ p.options = { onText: gettext('Show'), offText: gettext('Hide'), - onColor: 'success', - offColor: 'ternary', + onColor: 'switch-primary', + offColor: 'switch-ternary', size: 'mini', width: '56', }; diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js index a1c898890..c37ee7b1f 100644 --- a/web/pgadmin/static/js/backform.pgadmin.js +++ b/web/pgadmin/static/js/backform.pgadmin.js @@ -567,8 +567,8 @@ define([ options: { onText: gettext('Yes'), offText: gettext('No'), - onColor: 'success', - offColor: 'ternary', + onColor: 'switch-primary', + offColor: 'switch-ternary', size: 'mini', width: null, height: null, diff --git a/web/pgadmin/static/js/backgrid.pgadmin.js b/web/pgadmin/static/js/backgrid.pgadmin.js index e82da8bec..9bb4ed55a 100644 --- a/web/pgadmin/static/js/backgrid.pgadmin.js +++ b/web/pgadmin/static/js/backgrid.pgadmin.js @@ -624,8 +624,8 @@ define([ options: _.defaults({ onText: gettext('Yes'), offText: gettext('No'), - onColor: 'success', - offColor: 'ternary', + onColor: 'switch-primary', + offColor: 'switch-ternary', size: 'mini', width: null, height: null, diff --git a/web/pgadmin/static/scss/_bootstrap.overrides.scss b/web/pgadmin/static/scss/_bootstrap.overrides.scss index c09465d60..bc13794ef 100644 --- a/web/pgadmin/static/scss/_bootstrap.overrides.scss +++ b/web/pgadmin/static/scss/_bootstrap.overrides.scss @@ -111,6 +111,14 @@ legend { @include button-variant($color-ternary, $btn-ternary-border, $btn-ternary-hover-bg); } +.btn-switch-primary { + @include button-variant($color-switch-primary, $btn-switch-primary-border, $btn-switch-primary-hover-bg); +} + +.btn-switch-ternary { + @include button-variant($color-switch-ternary, $btn-switch-ternary-border, $btn-switch-ternary-hover-bg); +} + .form-group fieldset { background-color: $color-gray-lighter; border-color: $color-gray-lighter; diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss index 14db912f0..fc7ad0595 100644 --- a/web/pgadmin/static/scss/resources/_default.variables.scss +++ b/web/pgadmin/static/scss/resources/_default.variables.scss @@ -276,3 +276,12 @@ $schemadiff-target-row-color: #fbe3bf !default; $custom-forms-transition: none; $custom-control-indicator-focus-border-color: $input-focus-border-color; $custom-control-indicator-border-color: $input-border-color; + +/* Switch control */ +$color-switch-primary: #43a047 !default; +$btn-switch-primary-border: $color-switch-primary !default; +$btn-switch-primary-hover-bg: darken($color-switch-primary, 7.5%) !default; + +$color-switch-ternary: #6b6b6b !default; +$btn-switch-ternary-border: $color-switch-ternary !default; +$btn-switch-ternary-hover-bg: darken($color-switch-ternary, 7.5%) !default; diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss index e82640eba..f713ef86d 100644 --- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss +++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss @@ -79,3 +79,5 @@ $loader-icon-small: url("data:image/svg+xml,%3C%3Fxml version='1.0' encoding='ut $schemadiff-diff-row-color: #807a48 !default; $schemadiff-source-row-color: #402025 !default; $schemadiff-target-row-color: #6b5438 !default; + +$color-switch-ternary: #646464 !default; ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 08:21 Aditya Toshniwal <[email protected]> parent: Murtuza Zabuawala <[email protected]> 1 sibling, 1 reply; 10+ messages in thread From: Aditya Toshniwal @ 2020-03-18 08:21 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers Hi Murtuza, Why do we need to add new variable swith-ternary ? What was the issue you were facing ? On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < [email protected]> wrote: > Hello, > > As per discussion with Chethana, We need to make switch box color change > for light and dark theme, Color details provided by Chethana is updated on > ticket. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 08:36 Chethana Kumar <[email protected]> parent: Murtuza Zabuawala <[email protected]> 1 sibling, 1 reply; 10+ messages in thread From: Chethana Kumar @ 2020-03-18 08:36 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers Hi Murtuza, The changes are already incorporated so no worries :) Thanks, --- Chethana kumar On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < [email protected]> wrote: > Hello, > > As per discussion with Chethana, We need to make switch box color change > for light and dark theme, Color details provided by Chethana is updated on > ticket. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Chethana Kumar Principal UI/UX Designer EnterpriseDB Corporation The Postgres Database Company P: +91 86981 57146 www.enterprisedb.com ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 08:37 Murtuza Zabuawala <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 0 replies; 10+ messages in thread From: Murtuza Zabuawala @ 2020-03-18 08:37 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Hi Aditya, On Wed, Mar 18, 2020 at 1:52 PM Aditya Toshniwal < [email protected]> wrote: > Hi Murtuza, > > Why do we need to add new variable swith-ternary ? What was the issue you > were facing ? > Just to make both class names consistent, I missed to git add those changes in the patch in which I removed the ternary scss variable. > On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < > [email protected]> wrote: > >> Hello, >> >> As per discussion with Chethana, We need to make switch box color change >> for light and dark theme, Color details provided by Chethana is updated on >> ticket. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 08:42 Murtuza Zabuawala <[email protected]> parent: Chethana Kumar <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Murtuza Zabuawala @ 2020-03-18 08:42 UTC (permalink / raw) To: Chethana Kumar <[email protected]>; +Cc: pgadmin-hackers Hi Chethana, No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < [email protected]> wrote: > Hi Murtuza, > > The changes are already incorporated so no worries :) > > Thanks, > > --- > Chethana kumar > > On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < > [email protected]> wrote: > >> Hello, >> >> As per discussion with Chethana, We need to make switch box color change >> for light and dark theme, Color details provided by Chethana is updated on >> ticket. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > -- > Chethana Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > The Postgres Database Company > > P: +91 86981 57146 > www.enterprisedb.com > ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 08:53 Chethana Kumar <[email protected]> parent: Murtuza Zabuawala <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Chethana Kumar @ 2020-03-18 08:53 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers Let us discuss on a call for better clarity and the conclusion part we can put it on mail. --- Chethana kumar On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < [email protected]> wrote: > Hi Chethana, > > No it is not, As per current dark theme implementation we have used > primary color '#1a522b' for switch but the color you suggested is '#43A047' > for both theme. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < > [email protected]> wrote: > >> Hi Murtuza, >> >> The changes are already incorporated so no worries :) >> >> Thanks, >> >> --- >> Chethana kumar >> >> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >> [email protected]> wrote: >> >>> Hello, >>> >>> As per discussion with Chethana, We need to make switch box color change >>> for light and dark theme, Color details provided by Chethana is updated on >>> ticket. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> >> -- >> Chethana Kumar >> Principal UI/UX Designer >> EnterpriseDB Corporation >> >> The Postgres Database Company >> >> P: +91 86981 57146 >> www.enterprisedb.com >> > -- Chethana Kumar Principal UI/UX Designer EnterpriseDB Corporation The Postgres Database Company P: +91 86981 57146 www.enterprisedb.com ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-18 08:56 Aditya Toshniwal <[email protected]> parent: Chethana Kumar <[email protected]> 0 siblings, 1 reply; 10+ messages in thread From: Aditya Toshniwal @ 2020-03-18 08:56 UTC (permalink / raw) To: Chethana Kumar <[email protected]>; +Cc: Murtuza Zabuawala <[email protected]>; pgadmin-hackers Hi Murtuza/Chethana, Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off. Having a separate green color for each and every control is absurd. If the green changes, it should change for all. On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < [email protected]> wrote: > Let us discuss on a call for better clarity and the conclusion part we can > put it on mail. > > --- > Chethana kumar > > On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < > [email protected]> wrote: > >> Hi Chethana, >> >> No it is not, As per current dark theme implementation we have used >> primary color '#1a522b' for switch but the color you suggested is '#43A047' >> for both theme. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> >> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >> [email protected]> wrote: >> >>> Hi Murtuza, >>> >>> The changes are already incorporated so no worries :) >>> >>> Thanks, >>> >>> --- >>> Chethana kumar >>> >>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>> [email protected]> wrote: >>> >>>> Hello, >>>> >>>> As per discussion with Chethana, We need to make switch box color >>>> change for light and dark theme, Color details provided by Chethana is >>>> updated on ticket. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>> >>> -- >>> Chethana Kumar >>> Principal UI/UX Designer >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >>> P: +91 86981 57146 >>> www.enterprisedb.com >>> >> > > -- > Chethana Kumar > Principal UI/UX Designer > EnterpriseDB Corporation > > The Postgres Database Company > > P: +91 86981 57146 > www.enterprisedb.com > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-19 06:40 Murtuza Zabuawala <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 2 replies; 10+ messages in thread From: Murtuza Zabuawala @ 2020-03-19 06:40 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: Chethana Kumar <[email protected]>; pgadmin-hackers Hello, PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal < [email protected]> wrote: > Hi Murtuza/Chethana, > > Irrespective of what color you suggest, there is no need to add new > variables for switch buttons. It should use success for on and ternary for > off. > Having a separate green color for each and every control is absurd. If the > green changes, it should change for all. > > On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < > [email protected]> wrote: > >> Let us discuss on a call for better clarity and the conclusion part we >> can put it on mail. >> >> --- >> Chethana kumar >> >> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < >> [email protected]> wrote: >> >>> Hi Chethana, >>> >>> No it is not, As per current dark theme implementation we have used >>> primary color '#1a522b' for switch but the color you suggested is '#43A047' >>> for both theme. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> >>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >>> [email protected]> wrote: >>> >>>> Hi Murtuza, >>>> >>>> The changes are already incorporated so no worries :) >>>> >>>> Thanks, >>>> >>>> --- >>>> Chethana kumar >>>> >>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>>> [email protected]> wrote: >>>> >>>>> Hello, >>>>> >>>>> As per discussion with Chethana, We need to make switch box color >>>>> change for light and dark theme, Color details provided by Chethana is >>>>> updated on ticket. >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>> >>>> -- >>>> Chethana Kumar >>>> Principal UI/UX Designer >>>> EnterpriseDB Corporation >>>> >>>> The Postgres Database Company >>>> >>>> P: +91 86981 57146 >>>> www.enterprisedb.com >>>> >>> >> >> -- >> Chethana Kumar >> Principal UI/UX Designer >> EnterpriseDB Corporation >> >> The Postgres Database Company >> >> P: +91 86981 57146 >> www.enterprisedb.com >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > Attachments: [application/octet-stream] RM_5271_v1.diff (1.2K, 3-RM_5271_v1.diff) download | inline diff: diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss index 14db912f0..9fe30cb9e 100644 --- a/web/pgadmin/static/scss/resources/_default.variables.scss +++ b/web/pgadmin/static/scss/resources/_default.variables.scss @@ -25,7 +25,7 @@ $color-danger-lighter: #FAECEC !default; $color-success: #43a047 !default; $color-success-fg: $black !default; -$color-success-light: #DDF1DE !default; +$color-success-light: #D9ECDA !default; $color-warning: #eea236 !default; $color-warning-fg: $black !default; diff --git a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss index e82640eba..872fe6f62 100644 --- a/web/pgadmin/static/scss/resources/dark/_theme.variables.scss +++ b/web/pgadmin/static/scss/resources/dark/_theme.variables.scss @@ -17,9 +17,9 @@ $color-danger-fg: $white; $color-danger-light: #914649; $color-danger-lighter: #212121; -$color-success: #1a522b; +$color-success: #43a047; $color-success-fg: $black; -$color-success-light: #5a7863; +$color-success-light: #2B472C; $color-warning: #eea236; $color-warning-fg: $black; ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-19 07:03 Aditya Toshniwal <[email protected]> parent: Murtuza Zabuawala <[email protected]> 1 sibling, 0 replies; 10+ messages in thread From: Aditya Toshniwal @ 2020-03-19 07:03 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: Chethana Kumar <[email protected]>; pgadmin-hackers Hi Murtuza, The patch looks good to me. On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala < [email protected]> wrote: > Hello, > > PFA updated patch with new colors provided by Chethana, As discussed we > will be using the same primary success color in both theme so we don't have > add new variable. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Murtuza/Chethana, >> >> Irrespective of what color you suggest, there is no need to add new >> variables for switch buttons. It should use success for on and ternary for >> off. >> Having a separate green color for each and every control is absurd. If >> the green changes, it should change for all. >> >> On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < >> [email protected]> wrote: >> >>> Let us discuss on a call for better clarity and the conclusion part we >>> can put it on mail. >>> >>> --- >>> Chethana kumar >>> >>> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < >>> [email protected]> wrote: >>> >>>> Hi Chethana, >>>> >>>> No it is not, As per current dark theme implementation we have used >>>> primary color '#1a522b' for switch but the color you suggested is '#43A047' >>>> for both theme. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >>>> [email protected]> wrote: >>>> >>>>> Hi Murtuza, >>>>> >>>>> The changes are already incorporated so no worries :) >>>>> >>>>> Thanks, >>>>> >>>>> --- >>>>> Chethana kumar >>>>> >>>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>>>> [email protected]> wrote: >>>>> >>>>>> Hello, >>>>>> >>>>>> As per discussion with Chethana, We need to make switch box color >>>>>> change for light and dark theme, Color details provided by Chethana is >>>>>> updated on ticket. >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Chethana Kumar >>>>> Principal UI/UX Designer >>>>> EnterpriseDB Corporation >>>>> >>>>> The Postgres Database Company >>>>> >>>>> P: +91 86981 57146 >>>>> www.enterprisedb.com >>>>> >>>> >>> >>> -- >>> Chethana Kumar >>> Principal UI/UX Designer >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >>> P: +91 86981 57146 >>> www.enterprisedb.com >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 10+ messages in thread
* Re: [pgAdmin4][RM 5271] To change the switch control colors @ 2020-03-19 08:29 Akshay Joshi <[email protected]> parent: Murtuza Zabuawala <[email protected]> 1 sibling, 0 replies; 10+ messages in thread From: Akshay Joshi @ 2020-03-19 08:29 UTC (permalink / raw) To: Murtuza Zabuawala <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; Chethana Kumar <[email protected]>; pgadmin-hackers Thanks, patch applied. On Thu, Mar 19, 2020 at 12:10 PM Murtuza Zabuawala < [email protected]> wrote: > Hello, > > PFA updated patch with new colors provided by Chethana, As discussed we > will be using the same primary success color in both theme so we don't have > add new variable. > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Murtuza/Chethana, >> >> Irrespective of what color you suggest, there is no need to add new >> variables for switch buttons. It should use success for on and ternary for >> off. >> Having a separate green color for each and every control is absurd. If >> the green changes, it should change for all. >> >> On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < >> [email protected]> wrote: >> >>> Let us discuss on a call for better clarity and the conclusion part we >>> can put it on mail. >>> >>> --- >>> Chethana kumar >>> >>> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < >>> [email protected]> wrote: >>> >>>> Hi Chethana, >>>> >>>> No it is not, As per current dark theme implementation we have used >>>> primary color '#1a522b' for switch but the color you suggested is '#43A047' >>>> for both theme. >>>> >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >>>> [email protected]> wrote: >>>> >>>>> Hi Murtuza, >>>>> >>>>> The changes are already incorporated so no worries :) >>>>> >>>>> Thanks, >>>>> >>>>> --- >>>>> Chethana kumar >>>>> >>>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>>>> [email protected]> wrote: >>>>> >>>>>> Hello, >>>>>> >>>>>> As per discussion with Chethana, We need to make switch box color >>>>>> change for light and dark theme, Color details provided by Chethana is >>>>>> updated on ticket. >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> Murtuza Zabuawala >>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> >>>>> >>>>> -- >>>>> Chethana Kumar >>>>> Principal UI/UX Designer >>>>> EnterpriseDB Corporation >>>>> >>>>> The Postgres Database Company >>>>> >>>>> P: +91 86981 57146 >>>>> www.enterprisedb.com >>>>> >>>> >>> >>> -- >>> Chethana Kumar >>> Principal UI/UX Designer >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >>> P: +91 86981 57146 >>> www.enterprisedb.com >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 10+ messages in thread
end of thread, other threads:[~2020-03-19 08:29 UTC | newest] Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-03-18 07:13 [pgAdmin4][RM 5271] To change the switch control colors Murtuza Zabuawala <[email protected]> 2020-03-18 08:21 ` Aditya Toshniwal <[email protected]> 2020-03-18 08:37 ` Murtuza Zabuawala <[email protected]> 2020-03-18 08:36 ` Chethana Kumar <[email protected]> 2020-03-18 08:42 ` Murtuza Zabuawala <[email protected]> 2020-03-18 08:53 ` Chethana Kumar <[email protected]> 2020-03-18 08:56 ` Aditya Toshniwal <[email protected]> 2020-03-19 06:40 ` Murtuza Zabuawala <[email protected]> 2020-03-19 07:03 ` Aditya Toshniwal <[email protected]> 2020-03-19 08:29 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox