public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin][RM5292] Alertify header buttons focus color issue 4+ messages / 3 participants [nested] [flat]
* [pgAdmin][RM5292] Alertify header buttons focus color issue @ 2020-03-26 04:44 Nagesh Dhope <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Nagesh Dhope @ 2020-03-26 04:44 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Please find a patch which includes 1. Use *btn-secondary* styles for all buttons in alertify dialog header. 2. Added *!default *for $active-border variable, so that it can be overridden if required. 3. Added entry for *.scss *in .editorconfig -- Thanks, Nagesh Attachments: [application/octet-stream] RM5292.patch (1.4K, 3-RM5292.patch) download | inline diff: diff --git a/web/.editorconfig b/web/.editorconfig index f7e28ea..fb3c027 100644 --- a/web/.editorconfig +++ b/web/.editorconfig @@ -22,6 +22,9 @@ indent_size = 2 [*.css] indent_size = 2 +[*.scss] +indent_size = 2 + # Matches the exact file package.json [{package.json}] indent_size = 2 diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss index 6380754..6859a74 100644 --- a/web/pgadmin/static/scss/_alertify.overrides.scss +++ b/web/pgadmin/static/scss/_alertify.overrides.scss @@ -288,8 +288,18 @@ } -.ajs-maximize { +.ajs-commands { + button { @extend .btn-secondary; outline: none !important; + } } +.wizard-header { + .ml-auto { + button { + @extend .btn-secondary; + outline: none !important; + } + } +} diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss index f148c67..0d6cd5e 100644 --- a/web/pgadmin/static/scss/resources/_default.variables.scss +++ b/web/pgadmin/static/scss/resources/_default.variables.scss @@ -182,7 +182,7 @@ $color-editor-foldmarker: #0000FF !default; $color-editor-activeline: #50B0F0 !default; $active-color: $color-primary !default; -$active-border: 3px solid $active-color; +$active-border: 3px solid $active-color !default; $panel-border-width: $border-width; $panel-border-color: $border-color; $panel-border-radius: $border-radius; ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM5292] Alertify header buttons focus color issue @ 2020-03-26 04:53 Aditya Toshniwal <[email protected]> parent: Nagesh Dhope <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Aditya Toshniwal @ 2020-03-26 04:53 UTC (permalink / raw) To: Nagesh Dhope <[email protected]>; +Cc: pgadmin-hackers Hi Nagesh, I cannot see any change related to $active-border variable apart from !default. Plus, $active-border should not be allowed to edit. It is a structural variable and not a variable which affects theme change. Please revert the $active-border change and send the patch. On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope <[email protected]> wrote: > Hi Hackers, > > Please find a patch which includes > > 1. Use *btn-secondary* styles for all buttons in alertify dialog > header. > 2. Added *!default *for $active-border variable, so that it can be > overridden if required. > 3. Added entry for *.scss *in .editorconfig > > -- > Thanks, > Nagesh > -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM5292] Alertify header buttons focus color issue @ 2020-03-26 05:29 Nagesh Dhope <[email protected]> parent: Aditya Toshniwal <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Nagesh Dhope @ 2020-03-26 05:29 UTC (permalink / raw) To: Aditya Toshniwal <[email protected]>; +Cc: pgadmin-hackers Please find an updated patch, which fixes review comments. On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < [email protected]> wrote: > Hi Nagesh, > > I cannot see any change related to $active-border variable apart from > !default. Plus, $active-border should not be allowed to edit. It is a > structural variable and not a variable which affects theme change. > Please revert the $active-border change and send the patch. > > On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < > [email protected]> wrote: > >> Hi Hackers, >> >> Please find a patch which includes >> >> 1. Use *btn-secondary* styles for all buttons in alertify dialog >> header. >> 2. Added *!default *for $active-border variable, so that it can be >> overridden if required. >> 3. Added entry for *.scss *in .editorconfig >> >> -- >> Thanks, >> Nagesh >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks, Nagesh Attachments: [application/octet-stream] RM5292_v2.patch (817B, 3-RM5292_v2.patch) download | inline diff: diff --git a/web/.editorconfig b/web/.editorconfig index f7e28ea..fb3c027 100644 --- a/web/.editorconfig +++ b/web/.editorconfig @@ -22,6 +22,9 @@ indent_size = 2 [*.css] indent_size = 2 +[*.scss] +indent_size = 2 + # Matches the exact file package.json [{package.json}] indent_size = 2 diff --git a/web/pgadmin/static/scss/_alertify.overrides.scss b/web/pgadmin/static/scss/_alertify.overrides.scss index 09cca7b..b20b5ca 100644 --- a/web/pgadmin/static/scss/_alertify.overrides.scss +++ b/web/pgadmin/static/scss/_alertify.overrides.scss @@ -281,8 +281,18 @@ } -.ajs-maximize { +.ajs-commands { + button { @extend .btn-secondary; outline: none !important; + } } +.wizard-header { + .ml-auto { + button { + @extend .btn-secondary; + outline: none !important; + } + } +} ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM5292] Alertify header buttons focus color issue @ 2020-03-26 10:01 Akshay Joshi <[email protected]> parent: Nagesh Dhope <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Akshay Joshi @ 2020-03-26 10:01 UTC (permalink / raw) To: Nagesh Dhope <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers Thanks, patch applied. On Thu, Mar 26, 2020 at 11:00 AM Nagesh Dhope <[email protected]> wrote: > Please find an updated patch, which fixes review comments. > > On Thu, Mar 26, 2020 at 10:24 AM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Nagesh, >> >> I cannot see any change related to $active-border variable apart from >> !default. Plus, $active-border should not be allowed to edit. It is a >> structural variable and not a variable which affects theme change. >> Please revert the $active-border change and send the patch. >> >> On Thu, Mar 26, 2020 at 10:14 AM Nagesh Dhope < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Please find a patch which includes >>> >>> 1. Use *btn-secondary* styles for all buttons in alertify dialog >>> header. >>> 2. Added *!default *for $active-border variable, so that it can be >>> overridden if required. >>> 3. Added entry for *.scss *in .editorconfig >>> >>> -- >>> Thanks, >>> Nagesh >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2020-03-26 10:01 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2020-03-26 04:44 [pgAdmin][RM5292] Alertify header buttons focus color issue Nagesh Dhope <[email protected]> 2020-03-26 04:53 ` Aditya Toshniwal <[email protected]> 2020-03-26 05:29 ` Nagesh Dhope <[email protected]> 2020-03-26 10:01 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox