pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 15:19:48 -0400
Message-ID: <279981.1648667988@sss.pgh.pa.us> (raw)
In-Reply-To: <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de>
References: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
	<CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com>
	<144620.1648326272@sss.pgh.pa.us>
	<20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de>
	<20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de>
	<228044.1648658074@sss.pgh.pa.us>
	<20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de>
	<230838.1648659506@sss.pgh.pa.us>
	<A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de>
	<CA+TgmoY7smOGpvcNJwzsK5Y4TyA-Wk=8dnRGjaDRqUOoGfUSTA@mail.gmail.com>
	<20220330191251.sgxjox64k3eteylb@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-03-30 13:16:47 -0400, Robert Haas wrote:
>> On Wed, Mar 30, 2022 at 1:11 PM Andres Freund <andres@anarazel.de> wrote:
>>> My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before.

>> Makes no difference. We know that the string /tmp_install contains no
>> shell metacharacters, so why does it need to be in quotes? I would've
>> probably written it the way it is here, rather than what you are
>> proposing.

> It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on this,
> so I'll leave it be...

FWIW, I agree with Andres that I'd probably have put the quote
at the end.  But Robert is right that it's functionally equivalent;
so I doubt it's worth changing.

			regards, tom lane





view thread (66+ messages)  latest in thread

Message-ID: <279981.1648667988@sss.pgh.pa.us>
Permalink:  ../279981.1648667988@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/279981.1648667988@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <279981.1648667988@sss.pgh.pa.us>
  References: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> <A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de> <CA+TgmoY7smOGpvcNJwzsK5Y4TyA-Wk=8dnRGjaDRqUOoGfUSTA@mail.gmail.com> <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> <279981.1648667988@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox