pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Sun, 10 Oct 2021 14:42:11 -0400
Message-ID: <318519.1633891331@sss.pgh.pa.us> (raw)
In-Reply-To: <313640.1633886230@sss.pgh.pa.us>
References: <173186.1633635888@sss.pgh.pa.us>
	<20211008025659.GA398563@rfd.leadboat.com>
	<197091.1633664351@sss.pgh.pa.us>
	<20211008042454.GB398563@rfd.leadboat.com>
	<03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se>
	<234637.1633709021@sss.pgh.pa.us>
	<20211009192333.GA450252@rfd.leadboat.com>
	<245162.1633808657@sss.pgh.pa.us>
	<20211009195947.GB450252@rfd.leadboat.com>
	<247872.1633811686@sss.pgh.pa.us>
	<20211010022553.GB458218@rfd.leadboat.com>
	<313640.1633886230@sss.pgh.pa.us>

I wrote:
> The closest I can get to what we want using cpanm is with this recipe:

>     cpanm install Test::Simple@0.87_01
>     cpanm install IPC::Run@0.79
>     cpanm install ExtUtils::MakeMaker@6.50  # downgrade

Upon trying to actually use the perlbrew installation, I discovered
another oversight in the recipe: at least with old perl versions,
you end up with a non-shared libperl, so that --with-perl fails.

That leads me to the attached revision...

			regards, tom lane

Attachments:

improve-test-perl-README-3.patch (text/x-diff, 1.9K) download diff --git a/src/test/perl/README b/src/test/perl/README index bfc7cdcfa3..67a050b9d4 100644 --- a/src/test/perl/README +++ b/src/test/perl/README @@ -70,20 +70,36 @@ perldoc for the test modules, e.g.: perldoc src/test/perl/PostgresNode.pm -Required Perl -------------- +Portability +----------- + +Avoid using any bleeding-edge Perl features. We have buildfarm animals +running Perl versions as old as 5.8.3, so your tests will be expected +to pass on that. -Tests must run on perl 5.8.3 and newer. perlbrew is a good way to obtain such -a Perl; see http://perlbrew.pl . +Also, do not use any non-core Perl modules except IPC::Run. Or, if you +must do so for a particular test, arrange to skip the test when the needed +module isn't present. If unsure, you can consult Module::CoreList to find +out whether a given module is part of the Perl core, and which module +versions shipped with which Perl releases. -Just install and +One way to test for compatibility with old Perl versions is to use +perlbrew; see http://perlbrew.pl . After installing that, do + export PERLBREW_CONFIGURE_FLAGS='-de -Duseshrplib' perlbrew --force install 5.8.3 perlbrew use 5.8.3 perlbrew install-cpanm - cpanm install IPC::Run + cpanm install Test::Simple@0.87_01 + cpanm install IPC::Run@0.79 + cpanm install ExtUtils::MakeMaker@6.50 # downgrade -then re-run configure to ensure the correct Perl is used when running -tests. To verify that the right Perl was found: +Then re-run Postgres' configure to ensure the correct Perl is used when +running tests. To verify that the right Perl was found: grep ^PERL= config.log + +Due to limitations of cpanm, this recipe doesn't exactly duplicate the +module list of older buildfarm animals. The discrepancies should seldom +matter, but if you want to be sure, bypass cpanm and instead manually +install the desired versions of Test::Simple and IPC::Run.

view thread (33+ messages)  latest in thread

Message-ID: <318519.1633891331@sss.pgh.pa.us>
Permalink:  ../318519.1633891331@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/318519.1633891331@sss.pgh.pa.us

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, daniel@yesql.se, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <318519.1633891331@sss.pgh.pa.us>
  References: <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> <234637.1633709021@sss.pgh.pa.us> <20211009192333.GA450252@rfd.leadboat.com> <245162.1633808657@sss.pgh.pa.us> <20211009195947.GB450252@rfd.leadboat.com> <247872.1633811686@sss.pgh.pa.us> <20211010022553.GB458218@rfd.leadboat.com> <313640.1633886230@sss.pgh.pa.us> <318519.1633891331@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox