pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Mon, 11 Oct 2021 10:57:53 -0400
Message-ID: <876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net> (raw)
In-Reply-To: <20211010022553.GB458218@rfd.leadboat.com>
References: <173186.1633635888@sss.pgh.pa.us>
	<20211008025659.GA398563@rfd.leadboat.com>
	<197091.1633664351@sss.pgh.pa.us>
	<20211008042454.GB398563@rfd.leadboat.com>
	<03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se>
	<234637.1633709021@sss.pgh.pa.us>
	<20211009192333.GA450252@rfd.leadboat.com>
	<245162.1633808657@sss.pgh.pa.us>
	<20211009195947.GB450252@rfd.leadboat.com>
	<247872.1633811686@sss.pgh.pa.us>
	<20211010022553.GB458218@rfd.leadboat.com>


On 10/9/21 10:25 PM, Noah Misch wrote:
> On Sat, Oct 09, 2021 at 04:34:46PM -0400, Tom Lane wrote:
>> Hah ... your backpan link led me to realize the actual problem with
>> Test::More.  It got folded into Test::Simple at some point, and
>> evidently cpanm isn't smart enough to handle a request for a back
>> version in such cases.  But this works:
>>
>> $ cpanm install Test::Simple@0.87_01
>> ...
>> $ perl -MTest::More -e 'print $Test::More::VERSION, "\n";'
>> 0.8701
>>
>> So we oughta recommend that instead.  Now I'm wondering what
>> version of IPC::Run to recommend.
> You mentioned prairiedog uses IPC::Run 0.79.  That's from 2005.  (Perl 5.8.3
> is from 2004, and Test::More 0.87 is from 2009.)  I'd just use 0.79 in the
> README recipe.  IPC::Run is easy to upgrade, so if we find cause to rely on a
> newer version, I'd be fine updating that requirement.
>
>

Why don't we specify the minimum versions required of these somewhere in
the perl code? Perl is pretty good at this.


e.g.


    use IPC::Run 0.79;

    use Test::More 0.87;


It will choke if the supplied version is older.


We could even put lines like this in a small script that configure could
run.


cheers


andrew

-- 

Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (33+ messages)  latest in thread

Message-ID: <876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net>
Permalink:  ../876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net/
Also on:    postgresql.org/message-id/876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, noah@leadboat.com, tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net>
  References: <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> <234637.1633709021@sss.pgh.pa.us> <20211009192333.GA450252@rfd.leadboat.com> <245162.1633808657@sss.pgh.pa.us> <20211009195947.GB450252@rfd.leadboat.com> <247872.1633811686@sss.pgh.pa.us> <20211010022553.GB458218@rfd.leadboat.com> <876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox