public inbox for [email protected]
help / color / mirror / Atom feedRe: doc: add missing "id" attributes to extension packaging page
35+ messages / 10 participants
[nested] [flat]
* Re: doc: add missing "id" attributes to extension packaging page
@ 2023-03-23 09:35 Alvaro Herrera <[email protected]>
2023-03-23 10:13 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 13:02 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 3 replies; 35+ messages in thread
From: Alvaro Herrera @ 2023-03-23 09:35 UTC (permalink / raw)
To: Karl O. Pinc <[email protected]>; +Cc: Brar Piening <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
Thanks, Brar and Karl, I hope we can get this done soon.
As with the <simplelist> patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited. See this commit for an example:
https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=0b89ea0fff28d29ed177c82a274144453e3c7f...
In order to test locally that your patched stylesheet works correctly,
you'd have to compile the docs with "make html STYLE=website" in the doc
subdir, and tweak one of the CSS files there (I think it's
docs-complete.css) so that it references your local copy instead of
fetching it from the website.
> diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
> index cc14efa1ca..15bcc95d41 100644
> --- a/doc/src/sgml/stylesheet.css
> +++ b/doc/src/sgml/stylesheet.css
> @@ -169,3 +169,13 @@ acronym { font-style: inherit; }
> width: 75%;
> }
> }
> +
> +/* Links to ids of headers and definition terms */
> +a.id_link {
> + color: inherit;
> + visibility: hidden;
> +}
> +
> +*:hover > a.id_link {
> + visibility: visible;
> +}
I'm not clear on what exactly becomes visible when one hovers over what.
Can you please share a screenshot?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
@ 2023-03-23 10:13 ` Brar Piening <[email protected]>
2 siblings, 0 replies; 35+ messages in thread
From: Brar Piening @ 2023-03-23 10:13 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 23.03.2023 at 10:35, Alvaro Herrera wrote:
> As with the <simplelist> patch, we'll need to patch the CSS used in the
> website for the docs too, as that's the most important place where docs
> are visited. See this commit for an example:
> https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=0b89ea0fff28d29ed177c82a274144453e3c7f...
>
> In order to test locally that your patched stylesheet works correctly,
> you'd have to compile the docs with "make html STYLE=website" in the doc
> subdir, and tweak one of the CSS files there (I think it's
> docs-complete.css) so that it references your local copy instead of
> fetching it from the website.
Thanks I'll take care of this tonight.
> I'm not clear on what exactly becomes visible when one hovers over what.
> Can you please share a screenshot?
I could, but since hover effects don't really come across in screenshots
I've posted a build of the docs including the patch to
https://pgdocs.piening.info
See https://pgdocs.piening.info/app-psql.html as an example.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
@ 2023-03-23 13:02 ` Karl O. Pinc <[email protected]>
2 siblings, 0 replies; 35+ messages in thread
From: Karl O. Pinc @ 2023-03-23 13:02 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; +Cc: Brar Piening <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Thu, 23 Mar 2023 10:35:55 +0100
Alvaro Herrera <[email protected]> wrote:
> As with the <simplelist> patch, we'll need to patch the CSS used in
> the website for the docs too, as that's the most important place
> where docs are visited. See this commit for an example:
> https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=0b89ea0fff28d29ed177c82a274144453e3c7f...
>
> In order to test locally that your patched stylesheet works correctly,
> you'd have to compile the docs with "make html STYLE=website" in the
> doc subdir, and tweak one of the CSS files there (I think it's
> docs-complete.css) so that it references your local copy instead of
> fetching it from the website.
I should have known to put the css in a separate patch.
> I'm not clear on what exactly becomes visible when one hovers over
> what. Can you please share a screenshot?
Attached are 2 screenshots. I don't know why, but for
some reason you can't see the mouse pointer.
"#' shows up when the mouse is anywhere over the html heading element.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
Attachments:
[image/png] with_mouseover.png (40.5K, ../../[email protected]/2-with_mouseover.png)
download | view image
[image/png] without_mouseover.png (40.2K, ../../[email protected]/3-without_mouseover.png)
download | view image
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
@ 2023-03-23 19:08 ` Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2 siblings, 3 replies; 35+ messages in thread
From: Brar Piening @ 2023-03-23 19:08 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 23.03.2023 at 10:35, Alvaro Herrera wrote:
> As with the <simplelist> patch, we'll need to patch the CSS used in the
> website for the docs too, as that's the most important place where docs
> are visited.
Ok, I've created and tested a patch for this too.
Since the need for ids is starting to grow again (ecb696527c added an id
to a varlistentry in doc/src/sgml/ref/create_subscription.sgml) I've
also amended the add-needed-ids patch once again so that the build does
not fail after applying the make_html_ids_discoverable patch.
I've also attached the (unchanged) make_html_ids_discoverable patch for
convenience so this email now contains two patches for postgresql
(ending with .postgresql.patch) and one patch for pgweb (ending with
.pgweb.patch).
TBH I'm a bit afraid that people will immediately start complaining
about the failing docs builds after this got applied since it forces
them to add ids to all varlistenries in a variablelist if they add one,
which can be perceived as quite a burden (also committers and reviewers
will have to get used to always watch out for failing docs builds
because of this).
Since breaking the build on missing ids was an intentional decision we
can theoretically soften this by only issuing a warning or removing the
check for missing id's altogether but this would probably defeat the
purpose since it would lead to an increasing number of entries that lack
an id after a while.
Regards,
Brar
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 3836d13ad3..1432c67c2a 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -252,7 +252,7 @@
additional columns not provided by the published table. Any such columns
will be filled with the default value as specified in the definition of the
target table. However, logical replication in binary format is more
- restrictive. See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ restrictive. See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details.
</para>
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml
index 9a0241a8d6..62d9f9eb22 100644
--- a/doc/src/sgml/pgwalinspect.sgml
+++ b/doc/src/sgml/pgwalinspect.sgml
@@ -157,7 +157,7 @@ combined_size_percentage | 2.8634072910530795
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="pgwalinspect-funcs-pg-get-wal-block-info">
<term>
<function>pg_get_wal_block_info(start_lsn pg_lsn, end_lsn pg_lsn) returns setof record</function>
</term>
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e92346edef..f0ab6a918e 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -178,7 +178,7 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
<literal>origin</literal> parameter.
</para>
<para>
- See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details
about copying pre-existing data in binary format.
</para>
diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml
index 9d4b9d4e33..605b11bc67 100644
--- a/doc/src/sgml/ref/create_subscription.sgml
+++ b/doc/src/sgml/ref/create_subscription.sgml
@@ -61,7 +61,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<title>Parameters</title>
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-subscription-name">
<term><replaceable class="parameter">subscription_name</replaceable></term>
<listitem>
<para>
@@ -70,7 +70,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-connection">
<term><literal>CONNECTION '<replaceable class="parameter">conninfo</replaceable>'</literal></term>
<listitem>
<para>
@@ -81,7 +81,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-publication">
<term><literal>PUBLICATION <replaceable class="parameter">publication_name</replaceable> [, ...]</literal></term>
<listitem>
<para>
@@ -90,7 +90,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with">
<term><literal>WITH ( <replaceable class="parameter">subscription_parameter</replaceable> [= <replaceable class="parameter">value</replaceable>] [, ... ] )</literal></term>
<listitem>
<para>
@@ -102,7 +102,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-connect">
<term><literal>connect</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -129,7 +129,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-create-slot">
<term><literal>create_slot</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -145,7 +145,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-enabled">
<term><literal>enabled</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -156,7 +156,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-slot-name">
<term><literal>slot_name</literal> (<type>string</type>)</term>
<listitem>
<para>
@@ -185,7 +185,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
+ <varlistentry id="sql-createsubscription-with-binary" xreflabel="binary">
<term><literal>binary</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -222,7 +222,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-copy-data">
<term><literal>copy_data</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -243,7 +243,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-streaming">
<term><literal>streaming</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -271,7 +271,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-synchronous-commit">
<term><literal>synchronous_commit</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -303,7 +303,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-two-phase">
<term><literal>two_phase</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -334,7 +334,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-disable-on-error">
<term><literal>disable_on_error</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -346,7 +346,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-origin">
<term><literal>origin</literal> (<type>string</type>)</term>
<listitem>
<para>
diff --git a/doc/src/sgml/stylesheet-html-common.xsl b/doc/src/sgml/stylesheet-html-common.xsl
index 9df2782ce4..65c58ba750 100644
--- a/doc/src/sgml/stylesheet-html-common.xsl
+++ b/doc/src/sgml/stylesheet-html-common.xsl
@@ -301,4 +301,126 @@ set toc,title
</xsl:choose>
</xsl:template>
+
+<!-- Override the standard section heading generation to add an id link -->
+<xsl:template name="section.heading">
+ <xsl:param name="section" select="."/>
+ <xsl:param name="level" select="1"/>
+ <xsl:param name="allow-anchors" select="1"/>
+ <xsl:param name="title"/>
+ <xsl:param name="class" select="'title'"/>
+ <xsl:variable name="id">
+ <xsl:choose>
+ <!-- Make sure the subtitle doesn't get the same id as the title -->
+ <xsl:when test="self::subtitle">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="."/>
+ </xsl:call-template>
+ </xsl:when>
+ <!-- if title is in an *info wrapper, get the grandparent -->
+ <xsl:when test="contains(local-name(..), 'info')">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="../.."/>
+ </xsl:call-template>
+ </xsl:when>
+ <xsl:otherwise>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select=".."/>
+ </xsl:call-template>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+
+ <!-- HTML H level is one higher than section level -->
+ <xsl:variable name="hlevel">
+ <xsl:choose>
+ <!-- highest valid HTML H level is H6; so anything nested deeper
+ than 5 levels down just becomes H6 -->
+ <xsl:when test="$level > 5">6</xsl:when>
+ <xsl:otherwise>
+ <xsl:value-of select="$level + 1"/>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+ <xsl:element name="h{$hlevel}" namespace="http://www.w3.org/1999/xhtml";
+ <xsl:attribute name="class"><xsl:value-of select="$class"/></xsl:attribute>
+ <xsl:if test="$css.decoration != '0'">
+ <xsl:if test="$hlevel<3">
+ <xsl:attribute name="style">clear: both</xsl:attribute>
+ </xsl:if>
+ </xsl:if>
+ <xsl:if test="$allow-anchors != 0">
+ <xsl:call-template name="anchor">
+ <xsl:with-param name="node" select="$section"/>
+ <xsl:with-param name="conditional" select="0"/>
+ </xsl:call-template>
+ </xsl:if>
+ <xsl:copy-of select="$title"/>
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="$section"/>
+ </xsl:call-template>
+ </xsl:element>
+</xsl:template>
+
+
+<!-- Override the standard varlistentry/term generation to add an id link
+ after the last term -->
+<xsl:template match="varlistentry/term">
+ <xsl:apply-imports/>
+ <xsl:if test="position() = last()">
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="parent::varlistentry"/>
+ </xsl:call-template>
+ </xsl:if>
+</xsl:template>
+
+
+<!-- Creates a link pointing to an id within the document -->
+<xsl:template name="pg.id.link">
+ <xsl:param name="object" select="."/>
+ <xsl:choose>
+ <xsl:when test="$object/@id or $object/@xml:id">
+ <xsl:text> </xsl:text>
+ <a>
+ <xsl:attribute name="href">
+ <xsl:text>#</xsl:text>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="$object"/>
+ </xsl:call-template>
+ </xsl:attribute>
+ <xsl:attribute name="class">
+ <xsl:text>id_link</xsl:text>
+ </xsl:attribute>
+ <xsl:text>#</xsl:text>
+ </a>
+ </xsl:when>
+ <xsl:otherwise>
+ <!-- Only complain about varlistentries if at least one entry in
+ the list has an id -->
+ <xsl:if test="name($object) != 'varlistentry'
+ or $object/parent::variablelist/varlistentry[@id]">
+ <xsl:message terminate="yes">
+ <xsl:text> </xsl:text> <!-- leading newline -->
+ <xsl:text>Ids are required in order to provide the public</xsl:text>
+ <xsl:text> HTML documentation with stable URLs for <</xsl:text>
+ <xsl:value-of select ="name($object)"/>
+ <xsl:text>> element content; id missing at: </xsl:text>
+ <xsl:for-each select="$object/ancestor::*">
+ <xsl:text>/</xsl:text>
+ <xsl:value-of select ="name(.)"/>
+ <xsl:if test="@id|@xml:id">
+ <xsl:text>[@</xsl:text>
+ <xsl:value-of select ="name(@id|@xml:id)"/>
+ <xsl:text> = '</xsl:text>
+ <xsl:value-of select ="@id"/>
+ <xsl:text>']</xsl:text>
+ </xsl:if>
+ </xsl:for-each>
+ <xsl:text> </xsl:text> <!-- trailing newline -->
+ </xsl:message>
+ </xsl:if>
+ </xsl:otherwise>
+ </xsl:choose>
+</xsl:template>
+
</xsl:stylesheet>
diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
index cc14efa1ca..15bcc95d41 100644
--- a/doc/src/sgml/stylesheet.css
+++ b/doc/src/sgml/stylesheet.css
@@ -169,3 +169,13 @@ acronym { font-style: inherit; }
width: 75%;
}
}
+
+/* Links to ids of headers and definition terms */
+a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+*:hover > a.id_link {
+ visibility: visible;
+}
diff --git a/media/css/main.css b/media/css/main.css
index 5f8bfdd5..c3464cd0 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -1175,6 +1175,16 @@ code,
padding-right: 2em;
}
+/** Links to ids of headers and definition terms */
+#docContent a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+#docContent *:hover > a.id_link {
+ visibility: visible;
+}
+
/**
* Various callout boxes for docs, including warning, caution, note, tip
*/
Attachments:
[text/plain] 001-add-needed-ids_v2.postgresql.patch (7.4K, ../../[email protected]/2-001-add-needed-ids_v2.postgresql.patch)
download | inline diff:
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 3836d13ad3..1432c67c2a 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -252,7 +252,7 @@
additional columns not provided by the published table. Any such columns
will be filled with the default value as specified in the definition of the
target table. However, logical replication in binary format is more
- restrictive. See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ restrictive. See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details.
</para>
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml
index 9a0241a8d6..62d9f9eb22 100644
--- a/doc/src/sgml/pgwalinspect.sgml
+++ b/doc/src/sgml/pgwalinspect.sgml
@@ -157,7 +157,7 @@ combined_size_percentage | 2.8634072910530795
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="pgwalinspect-funcs-pg-get-wal-block-info">
<term>
<function>pg_get_wal_block_info(start_lsn pg_lsn, end_lsn pg_lsn) returns setof record</function>
</term>
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e92346edef..f0ab6a918e 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -178,7 +178,7 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
<literal>origin</literal> parameter.
</para>
<para>
- See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details
about copying pre-existing data in binary format.
</para>
diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml
index 9d4b9d4e33..605b11bc67 100644
--- a/doc/src/sgml/ref/create_subscription.sgml
+++ b/doc/src/sgml/ref/create_subscription.sgml
@@ -61,7 +61,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<title>Parameters</title>
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-subscription-name">
<term><replaceable class="parameter">subscription_name</replaceable></term>
<listitem>
<para>
@@ -70,7 +70,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-connection">
<term><literal>CONNECTION '<replaceable class="parameter">conninfo</replaceable>'</literal></term>
<listitem>
<para>
@@ -81,7 +81,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-publication">
<term><literal>PUBLICATION <replaceable class="parameter">publication_name</replaceable> [, ...]</literal></term>
<listitem>
<para>
@@ -90,7 +90,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with">
<term><literal>WITH ( <replaceable class="parameter">subscription_parameter</replaceable> [= <replaceable class="parameter">value</replaceable>] [, ... ] )</literal></term>
<listitem>
<para>
@@ -102,7 +102,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-connect">
<term><literal>connect</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -129,7 +129,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-create-slot">
<term><literal>create_slot</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -145,7 +145,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-enabled">
<term><literal>enabled</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -156,7 +156,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-slot-name">
<term><literal>slot_name</literal> (<type>string</type>)</term>
<listitem>
<para>
@@ -185,7 +185,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
+ <varlistentry id="sql-createsubscription-with-binary" xreflabel="binary">
<term><literal>binary</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -222,7 +222,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-copy-data">
<term><literal>copy_data</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -243,7 +243,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-streaming">
<term><literal>streaming</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -271,7 +271,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-synchronous-commit">
<term><literal>synchronous_commit</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -303,7 +303,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-two-phase">
<term><literal>two_phase</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -334,7 +334,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-disable-on-error">
<term><literal>disable_on_error</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -346,7 +346,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-origin">
<term><literal>origin</literal> (<type>string</type>)</term>
<listitem>
<para>
[text/plain] 002-make_html_ids_discoverable_v4.postgresql.patch (5.2K, ../../[email protected]/3-002-make_html_ids_discoverable_v4.postgresql.patch)
download | inline diff:
diff --git a/doc/src/sgml/stylesheet-html-common.xsl b/doc/src/sgml/stylesheet-html-common.xsl
index 9df2782ce4..65c58ba750 100644
--- a/doc/src/sgml/stylesheet-html-common.xsl
+++ b/doc/src/sgml/stylesheet-html-common.xsl
@@ -301,4 +301,126 @@ set toc,title
</xsl:choose>
</xsl:template>
+
+<!-- Override the standard section heading generation to add an id link -->
+<xsl:template name="section.heading">
+ <xsl:param name="section" select="."/>
+ <xsl:param name="level" select="1"/>
+ <xsl:param name="allow-anchors" select="1"/>
+ <xsl:param name="title"/>
+ <xsl:param name="class" select="'title'"/>
+ <xsl:variable name="id">
+ <xsl:choose>
+ <!-- Make sure the subtitle doesn't get the same id as the title -->
+ <xsl:when test="self::subtitle">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="."/>
+ </xsl:call-template>
+ </xsl:when>
+ <!-- if title is in an *info wrapper, get the grandparent -->
+ <xsl:when test="contains(local-name(..), 'info')">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="../.."/>
+ </xsl:call-template>
+ </xsl:when>
+ <xsl:otherwise>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select=".."/>
+ </xsl:call-template>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+
+ <!-- HTML H level is one higher than section level -->
+ <xsl:variable name="hlevel">
+ <xsl:choose>
+ <!-- highest valid HTML H level is H6; so anything nested deeper
+ than 5 levels down just becomes H6 -->
+ <xsl:when test="$level > 5">6</xsl:when>
+ <xsl:otherwise>
+ <xsl:value-of select="$level + 1"/>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+ <xsl:element name="h{$hlevel}" namespace="http://www.w3.org/1999/xhtml">
+ <xsl:attribute name="class"><xsl:value-of select="$class"/></xsl:attribute>
+ <xsl:if test="$css.decoration != '0'">
+ <xsl:if test="$hlevel<3">
+ <xsl:attribute name="style">clear: both</xsl:attribute>
+ </xsl:if>
+ </xsl:if>
+ <xsl:if test="$allow-anchors != 0">
+ <xsl:call-template name="anchor">
+ <xsl:with-param name="node" select="$section"/>
+ <xsl:with-param name="conditional" select="0"/>
+ </xsl:call-template>
+ </xsl:if>
+ <xsl:copy-of select="$title"/>
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="$section"/>
+ </xsl:call-template>
+ </xsl:element>
+</xsl:template>
+
+
+<!-- Override the standard varlistentry/term generation to add an id link
+ after the last term -->
+<xsl:template match="varlistentry/term">
+ <xsl:apply-imports/>
+ <xsl:if test="position() = last()">
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="parent::varlistentry"/>
+ </xsl:call-template>
+ </xsl:if>
+</xsl:template>
+
+
+<!-- Creates a link pointing to an id within the document -->
+<xsl:template name="pg.id.link">
+ <xsl:param name="object" select="."/>
+ <xsl:choose>
+ <xsl:when test="$object/@id or $object/@xml:id">
+ <xsl:text> </xsl:text>
+ <a>
+ <xsl:attribute name="href">
+ <xsl:text>#</xsl:text>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="$object"/>
+ </xsl:call-template>
+ </xsl:attribute>
+ <xsl:attribute name="class">
+ <xsl:text>id_link</xsl:text>
+ </xsl:attribute>
+ <xsl:text>#</xsl:text>
+ </a>
+ </xsl:when>
+ <xsl:otherwise>
+ <!-- Only complain about varlistentries if at least one entry in
+ the list has an id -->
+ <xsl:if test="name($object) != 'varlistentry'
+ or $object/parent::variablelist/varlistentry[@id]">
+ <xsl:message terminate="yes">
+ <xsl:text> </xsl:text> <!-- leading newline -->
+ <xsl:text>Ids are required in order to provide the public</xsl:text>
+ <xsl:text> HTML documentation with stable URLs for <</xsl:text>
+ <xsl:value-of select ="name($object)"/>
+ <xsl:text>> element content; id missing at: </xsl:text>
+ <xsl:for-each select="$object/ancestor::*">
+ <xsl:text>/</xsl:text>
+ <xsl:value-of select ="name(.)"/>
+ <xsl:if test="@id|@xml:id">
+ <xsl:text>[@</xsl:text>
+ <xsl:value-of select ="name(@id|@xml:id)"/>
+ <xsl:text> = '</xsl:text>
+ <xsl:value-of select ="@id"/>
+ <xsl:text>']</xsl:text>
+ </xsl:if>
+ </xsl:for-each>
+ <xsl:text> </xsl:text> <!-- trailing newline -->
+ </xsl:message>
+ </xsl:if>
+ </xsl:otherwise>
+ </xsl:choose>
+</xsl:template>
+
</xsl:stylesheet>
diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
index cc14efa1ca..15bcc95d41 100644
--- a/doc/src/sgml/stylesheet.css
+++ b/doc/src/sgml/stylesheet.css
@@ -169,3 +169,13 @@ acronym { font-style: inherit; }
width: 75%;
}
}
+
+/* Links to ids of headers and definition terms */
+a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+*:hover > a.id_link {
+ visibility: visible;
+}
[text/plain] 003-add-discoverable-id-style_v1.pgweb.patch (467B, ../../[email protected]/4-003-add-discoverable-id-style_v1.pgweb.patch)
download | inline diff:
diff --git a/media/css/main.css b/media/css/main.css
index 5f8bfdd5..c3464cd0 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -1175,6 +1175,16 @@ code,
padding-right: 2em;
}
+/** Links to ids of headers and definition terms */
+#docContent a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+#docContent *:hover > a.id_link {
+ visibility: visible;
+}
+
/**
* Various callout boxes for docs, including warning, caution, note, tip
*/
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-23 19:40 ` Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2 siblings, 1 reply; 35+ messages in thread
From: Corey Huinker @ 2023-03-23 19:40 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
>
> TBH I'm a bit afraid that people will immediately start complaining
> about the failing docs builds after this got applied since it forces
> them to add ids to all varlistenries in a variablelist if they add one,
> which can be perceived as quite a burden (also committers and reviewers
> will have to get used to always watch out for failing docs builds
> because of this).
>
As a person who had to re-rebase a patch because I discovered that id tags
had been added to one of the files I was working on, I can confidently say
"don't worry". It wasn't that big of a deal, I wasn't even following this
thread at the time and I immediately figured out what had happened and what
was expected of me. So it isn't that much of an inconvenience. If there is
a negative consequence to this change, it would be that it might
incentivize patch writers to omit documentation completely at the early
stages. But I don't think that's a problem because people generally see a
lack of documentation as a clue that maybe the patch isn't ready to be
reviewed, and this change would only reinforce that litmus test.
I had suggested we do something like this a few years back (the ids, that
is. the idea that we could check for compliance was beyond my imagination
at the time), and I'm glad to see both finally happening.
While I can foresee people overlooking the docs build, such oversights
won't go long before being caught, and the fix is simple. Now if we can
just get a threaded version of xlstproc to make the builds faster...
p.s. I'm "Team Paperclip" when it comes to the link hint, but let's get the
feature in first and worry about the right character later.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
@ 2023-03-23 22:31 ` Karl O. Pinc <[email protected]>
2023-03-23 22:55 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-24 05:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 2 replies; 35+ messages in thread
From: Karl O. Pinc @ 2023-03-23 22:31 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Corey Huinker <[email protected]>; Alvaro Herrera <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
Hi Brar,
It occurs to me that I had not actually tested the
way the anchor is put only after the last term in a
varlistentry. (The code looked obviously right
and should work if any varlistentry terms have anchors,
which they do, but....)
Have you tested this? If not, catalog.sgml, the
DEPENDENCY_PARTITION_SEC term is a 2nd term and usable
for at test case. But, at the moment there are no ids
for any of these varlistentries so you'd have to hack
them in.
Apologies for missing this.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2023-03-23 22:55 ` Karl O. Pinc <[email protected]>
2023-03-24 04:09 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
1 sibling, 1 reply; 35+ messages in thread
From: Karl O. Pinc @ 2023-03-23 22:55 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Corey Huinker <[email protected]>; Alvaro Herrera <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
This is for the committer, as an FYI.
I cut out the <xsl:template name="section.heading"> portion
of the docbook XSLT and diffed it with the code for the
same template in the patch. The diff looks like:
-- /tmp/sections.xsl 2023-03-22 13:00:33.432968357 -0500
+++ /tmp/make_html_ids_discoverable_v3.patch 2023-03-22 13:03:39.776930603 -0500
@@ -52,5 +52,8 @@
</xsl:call-template>
</xsl:if>
<xsl:copy-of select="$title"/>
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="$section"/>
+ </xsl:call-template>
</xsl:element>
</xsl:template>
(So, this output would start with line 52 of the template,
not from the top of the stock sections.xsl file.)
However, I am not really familiar with exactly what flavor
of docbook, version, namespace-d or not, etc., that PG
uses. So I could be diffing with the wrong thing.
Hope this helps and is not just noise.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-23 22:55 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2023-03-24 04:09 ` Karl O. Pinc <[email protected]>
2023-03-24 05:48 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Karl O. Pinc @ 2023-03-24 04:09 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Corey Huinker <[email protected]>; Alvaro Herrera <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
Hi Brar,
An observation: The # that shows up when hovering
over section-level headings is styled as the
section-level heading is. But the # that shows
up when hovering over varlistentrys has the default
text style.
This works for me. It's nice to have the "section #"s
look like the section heading. But the varlistentry's
terms are smaller than the normal font, and their
line width is less heavy than normal. I'm not really
invested one way or the other, but I find it kind of
nice that the varlistentry's #s are easier to click
on and more noticable because they're slightly larger
than might be expected.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-23 22:55 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-24 04:09 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2023-03-24 05:48 ` Brar Piening <[email protected]>
2023-03-24 05:59 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Brar Piening @ 2023-03-24 05:48 UTC (permalink / raw)
To: Karl O. Pinc <[email protected]>; +Cc: Corey Huinker <[email protected]>; Alvaro Herrera <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 24.03.2023 at 05:09, Karl O. Pinc wrote:
> Hi Brar,
>
> An observation: The # that shows up when hovering
> over section-level headings is styled as the
> section-level heading is. But the # that shows
> up when hovering over varlistentrys has the default
> text style.
>
> This works for me. It's nice to have the "section #"s
> look like the section heading. But the varlistentry's
> terms are smaller than the normal font, and their
> line width is less heavy than normal. I'm not really
> invested one way or the other, but I find it kind of
> nice that the varlistentry's #s are easier to click
> on and more noticable because they're slightly larger
> than might be expected.
TBH I didn't bother a lot with this.
Most of the time it's actually not the font size but rather the
font-family which gets inherited from the parent element if you don't
set it explicitly.
The link just inherits everithing (including the color, which I have set
to inherit explicitly since links don't inherit the parent's color by
default) from it's parent, which is the HTML <dt> element (ultimately
the inheritance probably goes up to the <body> element style in pretty
much all cases).
In some instances the input <term> element contains elements that are
styled differently in the output (e.g.: <literal> which translates to
HTML <code> which has "font-family: monospace;") which makes the # from
the link appear differently than the visible element it appears after.
Since (after tweaking the color) the general visual appearence looked ok
to me, I didn't bother with this any further.
Regards,
Brar
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-23 22:55 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-24 04:09 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-24 05:48 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-24 05:59 ` Brar Piening <[email protected]>
0 siblings, 0 replies; 35+ messages in thread
From: Brar Piening @ 2023-03-24 05:59 UTC (permalink / raw)
To: Karl O. Pinc <[email protected]>; +Cc: Corey Huinker <[email protected]>; Alvaro Herrera <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 24.03.2023 at 06:48, Brar Piening wrote:
>
> Since (after tweaking the color) the general visual appearence looked
> ok to me, I didn't bother with this any further.
Also, if we go on with this we'll probably end up in an almost
prototypical bikeshedding scenario where PostgreSQL itself is the
nuclear power plant and the visual appearence of the hover links on the
documentation website is the color of the bikeshed.
;-)
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2023-03-24 05:05 ` Brar Piening <[email protected]>
2023-03-24 09:45 ` Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
1 sibling, 1 reply; 35+ messages in thread
From: Brar Piening @ 2023-03-24 05:05 UTC (permalink / raw)
To: Karl O. Pinc <[email protected]>; +Cc: Corey Huinker <[email protected]>; Alvaro Herrera <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 23.03.2023 at 23:31, Karl O. Pinc wrote:
> Hi Brar,
>
> It occurs to me that I had not actually tested the
> way the anchor is put only after the last term in a
> varlistentry. (The code looked obviously right
> and should work if any varlistentry terms have anchors,
> which they do, but....)
>
> Have you tested this?
Yes, I have. See
https://pgdocs.piening.info/app-psql.html#APP-PSQL-META-COMMAND-DE for
an extreme case.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-23 19:40 ` Re: doc: add missing "id" attributes to extension packaging page Corey Huinker <[email protected]>
2023-03-23 22:31 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-03-24 05:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-24 09:45 ` Alvaro Herrera <[email protected]>
0 siblings, 0 replies; 35+ messages in thread
From: Alvaro Herrera @ 2023-03-24 09:45 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Karl O. Pinc <[email protected]>; Corey Huinker <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 2023-Mar-24, Brar Piening wrote:
> On 23.03.2023 at 23:31, Karl O. Pinc wrote:
> > Hi Brar,
> >
> > It occurs to me that I had not actually tested the
> > way the anchor is put only after the last term in a
> > varlistentry. (The code looked obviously right
> > and should work if any varlistentry terms have anchors,
> > which they do, but....)
> >
> > Have you tested this?
>
> Yes, I have. See
> https://pgdocs.piening.info/app-psql.html#APP-PSQL-META-COMMAND-DE for
> an extreme case.
But why are there no anchors next to <h3> items on that page? For
example, how do I get the link for the "Meta Commands" subsection?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
<inflex> really, I see PHP as like a strange amalgamation of C, Perl, Shell
<crab> inflex: you know that "amalgam" means "mixture with mercury",
more or less, right?
<crab> i.e., "deadly poison"
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-27 17:05 ` Brar Piening <[email protected]>
2023-03-27 22:11 ` Re: doc: add missing "id" attributes to extension packaging page Peter Smith <[email protected]>
2 siblings, 1 reply; 35+ messages in thread
From: Brar Piening @ 2023-03-27 17:05 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 23.03.2023 at 20:08, Brar Piening wrote:
> Since the need for ids is starting to grow again (ecb696527c added an
> id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
> I've also amended the add-needed-ids patch once again so that the
> build does not fail after applying the make_html_ids_discoverable patch.
New add-needed-ids patch since it was outdated again.
Regards,
Brar
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 71730cc52f..b0546f47b4 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -1132,7 +1132,7 @@ include_dir 'conf.d'
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="guc-scram-iterations">
<term><varname>scram_iterations</varname> (<type>integer</type>)
<indexterm>
<primary><varname>scram_iterations</varname> configuration parameter</primary>
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 3836d13ad3..1432c67c2a 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -252,7 +252,7 @@
additional columns not provided by the published table. Any such columns
will be filled with the default value as specified in the definition of the
target table. However, logical replication in binary format is more
- restrictive. See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ restrictive. See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details.
</para>
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml
index 9a0241a8d6..62d9f9eb22 100644
--- a/doc/src/sgml/pgwalinspect.sgml
+++ b/doc/src/sgml/pgwalinspect.sgml
@@ -157,7 +157,7 @@ combined_size_percentage | 2.8634072910530795
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="pgwalinspect-funcs-pg-get-wal-block-info">
<term>
<function>pg_get_wal_block_info(start_lsn pg_lsn, end_lsn pg_lsn) returns setof record</function>
</term>
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e92346edef..f0ab6a918e 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -178,7 +178,7 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
<literal>origin</literal> parameter.
</para>
<para>
- See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details
about copying pre-existing data in binary format.
</para>
diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml
index 9d4b9d4e33..605b11bc67 100644
--- a/doc/src/sgml/ref/create_subscription.sgml
+++ b/doc/src/sgml/ref/create_subscription.sgml
@@ -61,7 +61,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<title>Parameters</title>
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-subscription-name">
<term><replaceable class="parameter">subscription_name</replaceable></term>
<listitem>
<para>
@@ -70,7 +70,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-connection">
<term><literal>CONNECTION '<replaceable class="parameter">conninfo</replaceable>'</literal></term>
<listitem>
<para>
@@ -81,7 +81,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-publication">
<term><literal>PUBLICATION <replaceable class="parameter">publication_name</replaceable> [, ...]</literal></term>
<listitem>
<para>
@@ -90,7 +90,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with">
<term><literal>WITH ( <replaceable class="parameter">subscription_parameter</replaceable> [= <replaceable class="parameter">value</replaceable>] [, ... ] )</literal></term>
<listitem>
<para>
@@ -102,7 +102,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-connect">
<term><literal>connect</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -129,7 +129,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-create-slot">
<term><literal>create_slot</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -145,7 +145,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-enabled">
<term><literal>enabled</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -156,7 +156,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-slot-name">
<term><literal>slot_name</literal> (<type>string</type>)</term>
<listitem>
<para>
@@ -185,7 +185,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
+ <varlistentry id="sql-createsubscription-with-binary" xreflabel="binary">
<term><literal>binary</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -222,7 +222,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-copy-data">
<term><literal>copy_data</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -243,7 +243,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-streaming">
<term><literal>streaming</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -271,7 +271,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-synchronous-commit">
<term><literal>synchronous_commit</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -303,7 +303,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-two-phase">
<term><literal>two_phase</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -334,7 +334,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-disable-on-error">
<term><literal>disable_on_error</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -346,7 +346,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-origin">
<term><literal>origin</literal> (<type>string</type>)</term>
<listitem>
<para>
Attachments:
[text/plain] 001-add-needed-ids_v3.postgresql.patch (7.9K, ../../[email protected]/2-001-add-needed-ids_v3.postgresql.patch)
download | inline diff:
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 71730cc52f..b0546f47b4 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -1132,7 +1132,7 @@ include_dir 'conf.d'
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="guc-scram-iterations">
<term><varname>scram_iterations</varname> (<type>integer</type>)
<indexterm>
<primary><varname>scram_iterations</varname> configuration parameter</primary>
diff --git a/doc/src/sgml/logical-replication.sgml b/doc/src/sgml/logical-replication.sgml
index 3836d13ad3..1432c67c2a 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -252,7 +252,7 @@
additional columns not provided by the published table. Any such columns
will be filled with the default value as specified in the definition of the
target table. However, logical replication in binary format is more
- restrictive. See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ restrictive. See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details.
</para>
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml
index 9a0241a8d6..62d9f9eb22 100644
--- a/doc/src/sgml/pgwalinspect.sgml
+++ b/doc/src/sgml/pgwalinspect.sgml
@@ -157,7 +157,7 @@ combined_size_percentage | 2.8634072910530795
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="pgwalinspect-funcs-pg-get-wal-block-info">
<term>
<function>pg_get_wal_block_info(start_lsn pg_lsn, end_lsn pg_lsn) returns setof record</function>
</term>
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e92346edef..f0ab6a918e 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -178,7 +178,7 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
<literal>origin</literal> parameter.
</para>
<para>
- See the <link linkend="sql-createsubscription-binary"><literal>binary</literal>
+ See the <link linkend="sql-createsubscription-with-binary"><literal>binary</literal>
option</link> of <command>CREATE SUBSCRIPTION</command> for details
about copying pre-existing data in binary format.
</para>
diff --git a/doc/src/sgml/ref/create_subscription.sgml b/doc/src/sgml/ref/create_subscription.sgml
index 9d4b9d4e33..605b11bc67 100644
--- a/doc/src/sgml/ref/create_subscription.sgml
+++ b/doc/src/sgml/ref/create_subscription.sgml
@@ -61,7 +61,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<title>Parameters</title>
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-subscription-name">
<term><replaceable class="parameter">subscription_name</replaceable></term>
<listitem>
<para>
@@ -70,7 +70,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-connection">
<term><literal>CONNECTION '<replaceable class="parameter">conninfo</replaceable>'</literal></term>
<listitem>
<para>
@@ -81,7 +81,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-publication">
<term><literal>PUBLICATION <replaceable class="parameter">publication_name</replaceable> [, ...]</literal></term>
<listitem>
<para>
@@ -90,7 +90,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with">
<term><literal>WITH ( <replaceable class="parameter">subscription_parameter</replaceable> [= <replaceable class="parameter">value</replaceable>] [, ... ] )</literal></term>
<listitem>
<para>
@@ -102,7 +102,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-connect">
<term><literal>connect</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -129,7 +129,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-create-slot">
<term><literal>create_slot</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -145,7 +145,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-enabled">
<term><literal>enabled</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -156,7 +156,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-slot-name">
<term><literal>slot_name</literal> (<type>string</type>)</term>
<listitem>
<para>
@@ -185,7 +185,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
<variablelist>
- <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
+ <varlistentry id="sql-createsubscription-with-binary" xreflabel="binary">
<term><literal>binary</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -222,7 +222,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-copy-data">
<term><literal>copy_data</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -243,7 +243,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-streaming">
<term><literal>streaming</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -271,7 +271,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-synchronous-commit">
<term><literal>synchronous_commit</literal> (<type>enum</type>)</term>
<listitem>
<para>
@@ -303,7 +303,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-two-phase">
<term><literal>two_phase</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -334,7 +334,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-disable-on-error">
<term><literal>disable_on_error</literal> (<type>boolean</type>)</term>
<listitem>
<para>
@@ -346,7 +346,7 @@ CREATE SUBSCRIPTION <replaceable class="parameter">subscription_name</replaceabl
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="sql-createsubscription-with-origin">
<term><literal>origin</literal> (<type>string</type>)</term>
<listitem>
<para>
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-27 22:11 ` Peter Smith <[email protected]>
2023-03-28 10:17 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Peter Smith @ 2023-03-27 22:11 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Tue, Mar 28, 2023 at 4:06 AM Brar Piening <[email protected]> wrote:
>
> On 23.03.2023 at 20:08, Brar Piening wrote:
> > Since the need for ids is starting to grow again (ecb696527c added an
> > id to a varlistentry in doc/src/sgml/ref/create_subscription.sgml)
> > I've also amended the add-needed-ids patch once again so that the
> > build does not fail after applying the make_html_ids_discoverable patch.
>
> New add-needed-ids patch since it was outdated again.
>
FYI, there is a lot of overlap between this last attachment and the
patches of Kuroda-san's current thread here [1] which is also adding
ids to create_subscription.sgml.
(Anyway, I guess you might already be aware of that other thread
because your new ids look like they have the same names as those
chosen by Kuroda-san)
------
[1] https://www.postgresql.org/message-id/flat/CAHut%2BPvzo6%3DKKLqMR6-mAQdM%2Bj_dse0eUreGmrFouL7gbLbv2w...
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 22:11 ` Re: doc: add missing "id" attributes to extension packaging page Peter Smith <[email protected]>
@ 2023-03-28 10:17 ` Brar Piening <[email protected]>
2023-03-29 04:52 ` RE: doc: add missing "id" attributes to extension packaging page Hayato Kuroda (Fujitsu) <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Brar Piening @ 2023-03-28 10:17 UTC (permalink / raw)
To: Peter Smith <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 28.03.2023 at 00:11, Peter Smith wrote:
> FYI, there is a lot of overlap between this last attachment and the
> patches of Kuroda-san's current thread here [1] which is also adding
> ids to create_subscription.sgml.
>
> (Anyway, I guess you might already be aware of that other thread
> because your new ids look like they have the same names as those
> chosen by Kuroda-san)
>
> ------
> [1] https://www.postgresql.org/message-id/flat/CAHut%2BPvzo6%3DKKLqMR6-mAQdM%2Bj_dse0eUreGmrFouL7gbLbv2w...
Thanks, I actually was not aware of this.
Also, kudos for capturing the missing id and advocating for consistency
regarding ids even before this is actively enforced. This nurtures my
optimism that consistency might actually be achieveable without
everybody getting angry at me because my patch will enforce it.
Regarding the overlap, I currently try to make it as easy as possible
for a potential committer and I'm happy to rebase my patch upon request
or if Kuroda-san's patch gets applied first.
Regards,
Brar
^ permalink raw reply [nested|flat] 35+ messages in thread
* RE: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 22:11 ` Re: doc: add missing "id" attributes to extension packaging page Peter Smith <[email protected]>
2023-03-28 10:17 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-29 04:52 ` Hayato Kuroda (Fujitsu) <[email protected]>
2023-03-29 16:03 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Hayato Kuroda (Fujitsu) @ 2023-03-29 04:52 UTC (permalink / raw)
To: 'Brar Piening' <[email protected]>; Peter Smith <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
Dear my comrade Brar,
> Thanks, I actually was not aware of this.
>
> Also, kudos for capturing the missing id and advocating for consistency
> regarding ids even before this is actively enforced. This nurtures my
> optimism that consistency might actually be achieveable without
> everybody getting angry at me because my patch will enforce it.
>
> Regarding the overlap, I currently try to make it as easy as possible
> for a potential committer and I'm happy to rebase my patch upon request
> or if Kuroda-san's patch gets applied first.
FYI - my patch is pushed [1]. Could you please rebase your patch?
I think it's ok to just remove changes from logical-replication.sgml, ref/alter_subscription.sgml,
and ref/create_subscription.sgml.
[1]: https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=de5a47af2d8003dee123815bb7e58913be9a0...
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 22:11 ` Re: doc: add missing "id" attributes to extension packaging page Peter Smith <[email protected]>
2023-03-28 10:17 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-29 04:52 ` RE: doc: add missing "id" attributes to extension packaging page Hayato Kuroda (Fujitsu) <[email protected]>
@ 2023-03-29 16:03 ` Brar Piening <[email protected]>
2023-03-30 08:11 ` RE: doc: add missing "id" attributes to extension packaging page Hayato Kuroda (Fujitsu) <[email protected]>
2023-04-04 14:22 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
0 siblings, 2 replies; 35+ messages in thread
From: Brar Piening @ 2023-03-29 16:03 UTC (permalink / raw)
To: Hayato Kuroda (Fujitsu) <[email protected]>; Peter Smith <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 29.03.2023 at 06:52, Hayato Kuroda (Fujitsu) wrote:
> FYI - my patch is pushed
Thanks!
> Could you please rebase your patch?
Done and tested. Patch is attached.
Regards,
Brar
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fcb53c6997..5c50347c58 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -1132,7 +1132,7 @@ include_dir 'conf.d'
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="guc-scram-iterations">
<term><varname>scram_iterations</varname> (<type>integer</type>)
<indexterm>
<primary><varname>scram_iterations</varname> configuration parameter</primary>
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml
index 9a0241a8d6..62d9f9eb22 100644
--- a/doc/src/sgml/pgwalinspect.sgml
+++ b/doc/src/sgml/pgwalinspect.sgml
@@ -157,7 +157,7 @@ combined_size_percentage | 2.8634072910530795
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="pgwalinspect-funcs-pg-get-wal-block-info">
<term>
<function>pg_get_wal_block_info(start_lsn pg_lsn, end_lsn pg_lsn) returns setof record</function>
</term>
Attachments:
[text/plain] 001-add-needed-ids_v4.postgresql.patch (1004B, ../../[email protected]/2-001-add-needed-ids_v4.postgresql.patch)
download | inline diff:
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index fcb53c6997..5c50347c58 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
@@ -1132,7 +1132,7 @@ include_dir 'conf.d'
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="guc-scram-iterations">
<term><varname>scram_iterations</varname> (<type>integer</type>)
<indexterm>
<primary><varname>scram_iterations</varname> configuration parameter</primary>
diff --git a/doc/src/sgml/pgwalinspect.sgml b/doc/src/sgml/pgwalinspect.sgml
index 9a0241a8d6..62d9f9eb22 100644
--- a/doc/src/sgml/pgwalinspect.sgml
+++ b/doc/src/sgml/pgwalinspect.sgml
@@ -157,7 +157,7 @@ combined_size_percentage | 2.8634072910530795
</listitem>
</varlistentry>
- <varlistentry>
+ <varlistentry id="pgwalinspect-funcs-pg-get-wal-block-info">
<term>
<function>pg_get_wal_block_info(start_lsn pg_lsn, end_lsn pg_lsn) returns setof record</function>
</term>
^ permalink raw reply [nested|flat] 35+ messages in thread
* RE: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 22:11 ` Re: doc: add missing "id" attributes to extension packaging page Peter Smith <[email protected]>
2023-03-28 10:17 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-29 04:52 ` RE: doc: add missing "id" attributes to extension packaging page Hayato Kuroda (Fujitsu) <[email protected]>
2023-03-29 16:03 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-03-30 08:11 ` Hayato Kuroda (Fujitsu) <[email protected]>
1 sibling, 0 replies; 35+ messages in thread
From: Hayato Kuroda (Fujitsu) @ 2023-03-30 08:11 UTC (permalink / raw)
To: 'Brar Piening' <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Peter Smith <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
Dear Brar,
Thank you for updating the patch. The patch looks good to me.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 17:05 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-27 22:11 ` Re: doc: add missing "id" attributes to extension packaging page Peter Smith <[email protected]>
2023-03-28 10:17 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-03-29 04:52 ` RE: doc: add missing "id" attributes to extension packaging page Hayato Kuroda (Fujitsu) <[email protected]>
2023-03-29 16:03 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-04 14:22 ` Peter Eisentraut <[email protected]>
1 sibling, 0 replies; 35+ messages in thread
From: Peter Eisentraut @ 2023-04-04 14:22 UTC (permalink / raw)
To: Brar Piening <[email protected]>; Hayato Kuroda (Fujitsu) <[email protected]>; Peter Smith <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 29.03.23 18:03, Brar Piening wrote:
> On 29.03.2023 at 06:52, Hayato Kuroda (Fujitsu) wrote:
>> FYI - my patch is pushed
>
> Thanks!
>
>
>> Could you please rebase your patch?
>
> Done and tested. Patch is attached.
I have committed the most recent patch that added some missing IDs. (I
also added a missing xreflabel in passing.)
I'll look at the XSLT patch next.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-04 14:54 ` Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2 siblings, 1 reply; 35+ messages in thread
From: Peter Eisentraut @ 2023-04-04 14:54 UTC (permalink / raw)
To: Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 23.03.23 20:08, Brar Piening wrote:
> I've also attached the (unchanged) make_html_ids_discoverable patch for
> convenience so this email now contains two patches for postgresql
> (ending with .postgresql.patch) and one patch for pgweb (ending with
> .pgweb.patch).
Here is my view on this:
First of all, it works very nicely and is very useful. Very welcome.
The XSLT implementation looks sound to me. It would be a touch better
if it had some comments about which parts of the templates were copied
from upstream stylesheets and which were changed. There are examples of
such commenting in the existing customization layer. Also, avoid
introducing whitespace differences during said copying.
However, I wonder if this is the right way to approach this. I don't
think we should put these link markers directly into the HTML. It feels
like this is the wrong layer. For example, if you have CSS turned off,
then all these # marks show up by default.
It seems to me that the correct way to do this is to hook in some
JavaScript that does this transformation directly on the DOM. Then we
don't need to carry this presentation detail in the HTML. Moreover, it
would avoid tight coupling between the website and the documentation
sources. You can produce the exact same DOM, that part seems okay, just
do it elsewhere. Was this approach considered? I didn't see it in the
thread.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
@ 2023-04-04 19:52 ` Brar Piening <[email protected]>
2023-04-04 21:21 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
0 siblings, 2 replies; 35+ messages in thread
From: Brar Piening @ 2023-04-04 19:52 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 04.04.2023 at 16:54, Peter Eisentraut wrote:
>
> First of all, it works very nicely and is very useful. Very welcome.
Thank you!
> The XSLT implementation looks sound to me. It would be a touch better
> if it had some comments about which parts of the templates were copied
> from upstream stylesheets and which were changed. There are examples
> of such commenting in the existing customization layer. Also, avoid
> introducing whitespace differences during said copying.
I will amend the patch if we agree that this is the way forward.
> However, I wonder if this is the right way to approach this. I don't
> think we should put these link markers directly into the HTML. It
> feels like this is the wrong layer. For example, if you have CSS
> turned off, then all these # marks show up by default.
I'd consider this a feature rather than a problem but this is certainly
debatable. I cannot reliably predict what expectations a user who is
browsing the docs with CSS disabled might have. The opposite is true
too. If we'd move the id links feature to javascript, a user who has
javascript disabled will not see them. Is this what they'd want? I don't
know.
Also, while about 1-2% of users have Javascript disabled, I haven't
heard of disabling CSS except for debugging purposes.
In general I'd consider the fact that CSS or Javascript might be
disabled a niche problem that isn't really worth much debating but there
is definitely something to consider regarding people using screen
readers who might suffer from one or the other behavior and I'd
definitely be interested what behavior these users would expect. Would
they want to use the id link feature or would the links rather disrupt
their reading experience - I have no idea TBH and I hate speculating
about other people's preferences.
> It seems to me that the correct way to do this is to hook in some
> JavaScript that does this transformation directly on the DOM. Then we
> don't need to carry this presentation detail in the HTML. Moreover, it
> would avoid tight coupling between the website and the documentation
> sources. You can produce the exact same DOM, that part seems okay,
> just do it elsewhere. Was this approach considered? I didn't see it
> in the thread.
I briefly touched the topic in [1] and [2] but we didin't really follow
up on the best approach.
Regards,
Brar
[1]
https://www.postgresql.org/message-id/68b9c435-d017-93cc-775a-c604db9ec683%40gmx.de
[2]
https://www.postgresql.org/message-id/a75b6d7c-3fa4-d6a8-cf23-6b5180237392%40gmx.de
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-04 21:21 ` Karl O. Pinc <[email protected]>
2023-04-05 22:00 ` Re: doc: add missing "id" attributes to extension packaging page Maciek Sakrejda <[email protected]>
1 sibling, 1 reply; 35+ messages in thread
From: Karl O. Pinc @ 2023-04-04 21:21 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Tue, 4 Apr 2023 21:52:31 +0200
Brar Piening <[email protected]> wrote:
> On 04.04.2023 at 16:54, Peter Eisentraut wrote:
> > The XSLT implementation looks sound to me. It would be a touch
> > better if it had some comments about which parts of the templates
> > were copied from upstream stylesheets and which were changed.
I like this idea. A lot. (Including which stylesheets were copied
from.)
> > However, I wonder if this is the right way to approach this. I
> > don't think we should put these link markers directly into the
> > HTML. It feels like this is the wrong layer. For example, if you
> > have CSS turned off, then all these # marks show up by default.
>
> I'd consider this a feature rather than a problem but this is
> certainly debatable.
I too would consider this a feature. If you don't style your
html presentation, you see everything. The "#" links to content
are, well, content.
> > It seems to me that the correct way to do this is to hook in some
> > JavaScript that does this transformation directly on the DOM. Then
> > we don't need to carry this presentation detail in the HTML.
I would argue the opposite. The HTML/CSS is delivered to the browser
which is then free to present the content to the user in the
form preferred by the user. This puts control of presentation
in the hands of the end-user, where, IMO, it belongs.
Using JavaScript to manipulate the DOM is all well and good when
using AJAX to interact with the server to produce dynamic content.
But otherwise manipulating the DOM with JavaScript seems overly
heavy-handed, even though popular. It seems like JavaScript is
used more because CSS is difficult and an "extra technology" when
instead JavaScript can "do everything". So CSS is put aside.
I may be biased, not being a JavaScript fan. (I tend to be one
of those cranky individuals who keep JavaScript turned off.)
I'd rather not have code executing when such overhead/complication
can be avoided. (Insert here exciting argument about "what is code
and what is data".)
Glancing at the documentation source, I don't see JavaScript used
at all. Introducing it would be adding something else to the mix.
Not that this would be bad if it provides value.
In the end, I don't _really_ care. And don't do web development
all day either so my fundamentals could be just wrong. But
this is my take.
> > Moreover, it would avoid tight coupling between the website and the
> > documentation sources.
I don't really understand this statement. Are you saying that
the documentation's source CSS needn't/shouldn't be the CSS used
on the website? That seems counter-intuitive. But then I don't
understand why the default CSS used when developing the documentation
is not the CSS used on the website.
I can imagine administrative arguments around server maintenance for
wanting to keep the website decoupled from the PG source code.
(I think.) But I can't speak to any of that.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 21:21 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2023-04-05 22:00 ` Maciek Sakrejda <[email protected]>
0 siblings, 0 replies; 35+ messages in thread
From: Maciek Sakrejda @ 2023-04-05 22:00 UTC (permalink / raw)
To: Karl O. Pinc <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
For what it's worth, I think having the anchors be always-visible when
CSS disabled is a feature. The content is still perfectly readable,
and the core feature from this patch is available. Introducing
JavaScript to lose that functionality seems like a step backwards.
By the way, the latest patch attachment was not the full patch series,
which I think confused cfbot: [1] (unless I'm misunderstanding the
state of the patch series).
And thanks for working on this. I've hunted in the page source for ids
to link to a number of times. I look forward to not doing that
anymore.
Thanks,
Maciek
[1]: https://commitfest.postgresql.org/42/4042/
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-06 09:06 ` Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
1 sibling, 1 reply; 35+ messages in thread
From: Peter Eisentraut @ 2023-04-06 09:06 UTC (permalink / raw)
To: Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 04.04.23 21:52, Brar Piening wrote:
>> The XSLT implementation looks sound to me. It would be a touch better
>> if it had some comments about which parts of the templates were copied
>> from upstream stylesheets and which were changed. There are examples
>> of such commenting in the existing customization layer. Also, avoid
>> introducing whitespace differences during said copying.
>
> I will amend the patch if we agree that this is the way forward.
Ok, it appears everyone agrees that this is the correct approach.
Please post an updated patch. There have been so many partial patches
posted recently, I'm not sure which one is the most current one and who
is really the author.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
@ 2023-04-06 14:19 ` Brar Piening <[email protected]>
2023-04-06 15:05 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
0 siblings, 2 replies; 35+ messages in thread
From: Brar Piening @ 2023-04-06 14:19 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 06.04.2023 at 11:06, Peter Eisentraut wrote:
> On 04.04.23 21:52, Brar Piening wrote:
>>> The XSLT implementation looks sound to me. It would be a touch better
>>> if it had some comments about which parts of the templates were copied
>>> from upstream stylesheets and which were changed. There are examples
>>> of such commenting in the existing customization layer. Also, avoid
>>> introducing whitespace differences during said copying.
>>
>> I will amend the patch if we agree that this is the way forward.
>
> Ok, it appears everyone agrees that this is the correct approach.
> Please post an updated patch. There have been so many partial patches
> posted recently, I'm not sure which one is the most current one and
> who is really the author.
>
Attached are two patches:
001-make_html_ids_discoverable_v5.postgresql.patch which needs to be
applied to the postgresql repository. It adds the XSLT to generate the
id links and the CSS to hide/display them. I've added comments as
suggested above.
002-add-discoverable-id-style_v1.pgweb.patch which needs to be applied
to the pgweb repository. It adds the CSS to the offical documentation site.
At the moment (commit 983ec23007) there are no missing ids, so the build
should just work after applying the patch but, as we already know, this
may change with every commit that gets added.
Reviewer is Karl O. Pink
Author is Brar Piening (with some additions from Karl O. Pink)
Best regards,
Brar
diff --git a/media/css/main.css b/media/css/main.css
index 5f8bfdd5..c3464cd0 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -1175,6 +1175,16 @@ code,
padding-right: 2em;
}
+/** Links to ids of headers and definition terms */
+#docContent a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+#docContent *:hover > a.id_link {
+ visibility: visible;
+}
+
/**
* Various callout boxes for docs, including warning, caution, note, tip
*/
diff --git a/doc/src/sgml/stylesheet-html-common.xsl b/doc/src/sgml/stylesheet-html-common.xsl
index bb6429ef7c..8e5d9912d5 100644
--- a/doc/src/sgml/stylesheet-html-common.xsl
+++ b/doc/src/sgml/stylesheet-html-common.xsl
@@ -309,4 +309,137 @@ set toc,title
</xsl:choose>
</xsl:template>
+
+<!-- Override the standard section heading generation in /xhtml/sections.xsl
+ to add an id link to each section heading. -->
+<xsl:template name="section.heading">
+ <xsl:param name="section" select="."/>
+ <xsl:param name="level" select="1"/>
+ <xsl:param name="allow-anchors" select="1"/>
+ <xsl:param name="title"/>
+ <xsl:param name="class" select="'title'"/>
+
+ <xsl:variable name="id">
+ <xsl:choose>
+ <!-- Make sure the subtitle doesn't get the same id as the title -->
+ <xsl:when test="self::subtitle">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="."/>
+ </xsl:call-template>
+ </xsl:when>
+ <!-- if title is in an *info wrapper, get the grandparent -->
+ <xsl:when test="contains(local-name(..), 'info')">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="../.."/>
+ </xsl:call-template>
+ </xsl:when>
+ <xsl:otherwise>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select=".."/>
+ </xsl:call-template>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+
+ <!-- HTML H level is one higher than section level -->
+ <xsl:variable name="hlevel">
+ <xsl:choose>
+ <!-- highest valid HTML H level is H6; so anything nested deeper
+ than 5 levels down just becomes H6 -->
+ <xsl:when test="$level > 5">6</xsl:when>
+ <xsl:otherwise>
+ <xsl:value-of select="$level + 1"/>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+ <xsl:element name="h{$hlevel}" namespace="http://www.w3.org/1999/xhtml";
+ <xsl:attribute name="class"><xsl:value-of select="$class"/></xsl:attribute>
+ <xsl:if test="$css.decoration != '0'">
+ <xsl:if test="$hlevel<3">
+ <xsl:attribute name="style">clear: both</xsl:attribute>
+ </xsl:if>
+ </xsl:if>
+ <xsl:if test="$allow-anchors != 0">
+ <xsl:call-template name="anchor">
+ <xsl:with-param name="node" select="$section"/>
+ <xsl:with-param name="conditional" select="0"/>
+ </xsl:call-template>
+ </xsl:if>
+ <xsl:copy-of select="$title"/>
+
+ <!--
+ The following code calls the template adding the links.
+ Everything else is copied from the original template.
+ -->
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="$section"/>
+ </xsl:call-template>
+
+ </xsl:element>
+</xsl:template>
+
+
+<!-- Override the standard template for varlistentry/term in /xhtml/lists.xsl
+ to add an id link after the last term. -->
+<xsl:template match="varlistentry/term">
+ <!-- Apply the original template -->
+ <xsl:apply-imports/>
+
+ <!-- Add the link after the last term -->
+ <xsl:if test="position() = last()">
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="parent::varlistentry"/>
+ </xsl:call-template>
+ </xsl:if>
+</xsl:template>
+
+
+<!-- Create a link pointing to an id within the document -->
+<xsl:template name="pg.id.link">
+ <xsl:param name="object" select="."/>
+ <xsl:choose>
+ <xsl:when test="$object/@id or $object/@xml:id">
+ <xsl:text> </xsl:text>
+ <a>
+ <xsl:attribute name="href">
+ <xsl:text>#</xsl:text>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="$object"/>
+ </xsl:call-template>
+ </xsl:attribute>
+ <xsl:attribute name="class">
+ <xsl:text>id_link</xsl:text>
+ </xsl:attribute>
+ <xsl:text>#</xsl:text>
+ </a>
+ </xsl:when>
+ <xsl:otherwise>
+ <!-- Only complain about varlistentries if at least one entry in
+ the list has an id -->
+ <xsl:if test="name($object) != 'varlistentry'
+ or $object/parent::variablelist/varlistentry[@id]">
+ <xsl:message terminate="yes">
+ <xsl:text> </xsl:text> <!-- leading newline -->
+ <xsl:text>Ids are required in order to provide the public</xsl:text>
+ <xsl:text> HTML documentation with stable URLs for <</xsl:text>
+ <xsl:value-of select ="name($object)"/>
+ <xsl:text>> element content; id missing at: </xsl:text>
+ <xsl:for-each select="$object/ancestor::*">
+ <xsl:text>/</xsl:text>
+ <xsl:value-of select ="name(.)"/>
+ <xsl:if test="@id|@xml:id">
+ <xsl:text>[@</xsl:text>
+ <xsl:value-of select ="name(@id|@xml:id)"/>
+ <xsl:text> = '</xsl:text>
+ <xsl:value-of select ="@id"/>
+ <xsl:text>']</xsl:text>
+ </xsl:if>
+ </xsl:for-each>
+ <xsl:text> </xsl:text> <!-- trailing newline -->
+ </xsl:message>
+ </xsl:if>
+ </xsl:otherwise>
+ </xsl:choose>
+</xsl:template>
+
</xsl:stylesheet>
diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
index cc14efa1ca..15bcc95d41 100644
--- a/doc/src/sgml/stylesheet.css
+++ b/doc/src/sgml/stylesheet.css
@@ -169,3 +169,13 @@ acronym { font-style: inherit; }
width: 75%;
}
}
+
+/* Links to ids of headers and definition terms */
+a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+*:hover > a.id_link {
+ visibility: visible;
+}
Attachments:
[text/plain] 002-add-discoverable-id-style_v1.pgweb.patch (467B, ../../[email protected]/2-002-add-discoverable-id-style_v1.pgweb.patch)
download | inline diff:
diff --git a/media/css/main.css b/media/css/main.css
index 5f8bfdd5..c3464cd0 100644
--- a/media/css/main.css
+++ b/media/css/main.css
@@ -1175,6 +1175,16 @@ code,
padding-right: 2em;
}
+/** Links to ids of headers and definition terms */
+#docContent a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+#docContent *:hover > a.id_link {
+ visibility: visible;
+}
+
/**
* Various callout boxes for docs, including warning, caution, note, tip
*/
[text/plain] 001-make_html_ids_discoverable_v5.postgresql.patch (5.5K, ../../[email protected]/3-001-make_html_ids_discoverable_v5.postgresql.patch)
download | inline diff:
diff --git a/doc/src/sgml/stylesheet-html-common.xsl b/doc/src/sgml/stylesheet-html-common.xsl
index bb6429ef7c..8e5d9912d5 100644
--- a/doc/src/sgml/stylesheet-html-common.xsl
+++ b/doc/src/sgml/stylesheet-html-common.xsl
@@ -309,4 +309,137 @@ set toc,title
</xsl:choose>
</xsl:template>
+
+<!-- Override the standard section heading generation in /xhtml/sections.xsl
+ to add an id link to each section heading. -->
+<xsl:template name="section.heading">
+ <xsl:param name="section" select="."/>
+ <xsl:param name="level" select="1"/>
+ <xsl:param name="allow-anchors" select="1"/>
+ <xsl:param name="title"/>
+ <xsl:param name="class" select="'title'"/>
+
+ <xsl:variable name="id">
+ <xsl:choose>
+ <!-- Make sure the subtitle doesn't get the same id as the title -->
+ <xsl:when test="self::subtitle">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="."/>
+ </xsl:call-template>
+ </xsl:when>
+ <!-- if title is in an *info wrapper, get the grandparent -->
+ <xsl:when test="contains(local-name(..), 'info')">
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="../.."/>
+ </xsl:call-template>
+ </xsl:when>
+ <xsl:otherwise>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select=".."/>
+ </xsl:call-template>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+
+ <!-- HTML H level is one higher than section level -->
+ <xsl:variable name="hlevel">
+ <xsl:choose>
+ <!-- highest valid HTML H level is H6; so anything nested deeper
+ than 5 levels down just becomes H6 -->
+ <xsl:when test="$level > 5">6</xsl:when>
+ <xsl:otherwise>
+ <xsl:value-of select="$level + 1"/>
+ </xsl:otherwise>
+ </xsl:choose>
+ </xsl:variable>
+ <xsl:element name="h{$hlevel}" namespace="http://www.w3.org/1999/xhtml">
+ <xsl:attribute name="class"><xsl:value-of select="$class"/></xsl:attribute>
+ <xsl:if test="$css.decoration != '0'">
+ <xsl:if test="$hlevel<3">
+ <xsl:attribute name="style">clear: both</xsl:attribute>
+ </xsl:if>
+ </xsl:if>
+ <xsl:if test="$allow-anchors != 0">
+ <xsl:call-template name="anchor">
+ <xsl:with-param name="node" select="$section"/>
+ <xsl:with-param name="conditional" select="0"/>
+ </xsl:call-template>
+ </xsl:if>
+ <xsl:copy-of select="$title"/>
+
+ <!--
+ The following code calls the template adding the links.
+ Everything else is copied from the original template.
+ -->
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="$section"/>
+ </xsl:call-template>
+
+ </xsl:element>
+</xsl:template>
+
+
+<!-- Override the standard template for varlistentry/term in /xhtml/lists.xsl
+ to add an id link after the last term. -->
+<xsl:template match="varlistentry/term">
+ <!-- Apply the original template -->
+ <xsl:apply-imports/>
+
+ <!-- Add the link after the last term -->
+ <xsl:if test="position() = last()">
+ <xsl:call-template name="pg.id.link">
+ <xsl:with-param name="object" select="parent::varlistentry"/>
+ </xsl:call-template>
+ </xsl:if>
+</xsl:template>
+
+
+<!-- Create a link pointing to an id within the document -->
+<xsl:template name="pg.id.link">
+ <xsl:param name="object" select="."/>
+ <xsl:choose>
+ <xsl:when test="$object/@id or $object/@xml:id">
+ <xsl:text> </xsl:text>
+ <a>
+ <xsl:attribute name="href">
+ <xsl:text>#</xsl:text>
+ <xsl:call-template name="object.id">
+ <xsl:with-param name="object" select="$object"/>
+ </xsl:call-template>
+ </xsl:attribute>
+ <xsl:attribute name="class">
+ <xsl:text>id_link</xsl:text>
+ </xsl:attribute>
+ <xsl:text>#</xsl:text>
+ </a>
+ </xsl:when>
+ <xsl:otherwise>
+ <!-- Only complain about varlistentries if at least one entry in
+ the list has an id -->
+ <xsl:if test="name($object) != 'varlistentry'
+ or $object/parent::variablelist/varlistentry[@id]">
+ <xsl:message terminate="yes">
+ <xsl:text> </xsl:text> <!-- leading newline -->
+ <xsl:text>Ids are required in order to provide the public</xsl:text>
+ <xsl:text> HTML documentation with stable URLs for <</xsl:text>
+ <xsl:value-of select ="name($object)"/>
+ <xsl:text>> element content; id missing at: </xsl:text>
+ <xsl:for-each select="$object/ancestor::*">
+ <xsl:text>/</xsl:text>
+ <xsl:value-of select ="name(.)"/>
+ <xsl:if test="@id|@xml:id">
+ <xsl:text>[@</xsl:text>
+ <xsl:value-of select ="name(@id|@xml:id)"/>
+ <xsl:text> = '</xsl:text>
+ <xsl:value-of select ="@id"/>
+ <xsl:text>']</xsl:text>
+ </xsl:if>
+ </xsl:for-each>
+ <xsl:text> </xsl:text> <!-- trailing newline -->
+ </xsl:message>
+ </xsl:if>
+ </xsl:otherwise>
+ </xsl:choose>
+</xsl:template>
+
</xsl:stylesheet>
diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
index cc14efa1ca..15bcc95d41 100644
--- a/doc/src/sgml/stylesheet.css
+++ b/doc/src/sgml/stylesheet.css
@@ -169,3 +169,13 @@ acronym { font-style: inherit; }
width: 75%;
}
}
+
+/* Links to ids of headers and definition terms */
+a.id_link {
+ color: inherit;
+ visibility: hidden;
+}
+
+*:hover > a.id_link {
+ visibility: visible;
+}
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-06 15:05 ` Karl O. Pinc <[email protected]>
1 sibling, 0 replies; 35+ messages in thread
From: Karl O. Pinc @ 2023-04-06 15:05 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Thu, 6 Apr 2023 16:19:30 +0200
Brar Piening <[email protected]> wrote:
> Reviewer is Karl O. Pink
"Karl O. Pinc" actually, with a "c".
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-13 08:31 ` Peter Eisentraut <[email protected]>
2023-04-13 14:01 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 14:58 ` Re: doc: add missing "id" attributes to extension packaging page Dagfinn Ilmari Mannsåker <[email protected]>
1 sibling, 2 replies; 35+ messages in thread
From: Peter Eisentraut @ 2023-04-13 08:31 UTC (permalink / raw)
To: Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 06.04.23 16:19, Brar Piening wrote:
> 001-make_html_ids_discoverable_v5.postgresql.patch which needs to be
> applied to the postgresql repository. It adds the XSLT to generate the
> id links and the CSS to hide/display them. I've added comments as
> suggested above.
>
> 002-add-discoverable-id-style_v1.pgweb.patch which needs to be applied
> to the pgweb repository. It adds the CSS to the offical documentation site.
The first patch has been committed.
The second patch should be sent to pgsql-www for integrating into the
web site.
Side project: I noticed that these new hover links don't appear in the
single-page HTML output (make postgres.html), even though the generated
HTML source code looks correct. Maybe someone has an idea there.
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
@ 2023-04-13 14:01 ` Brar Piening <[email protected]>
2023-04-13 15:53 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
1 sibling, 1 reply; 35+ messages in thread
From: Brar Piening @ 2023-04-13 14:01 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On 13.04.2023 at 10:31, Peter Eisentraut wrote:
> The first patch has been committed.
Yay - thank you!
> The second patch should be sent to pgsql-www for integrating into the
> web site.
Done via [1]. Thanks for the hint.
> Side project: I noticed that these new hover links don't appear in the
> single-page HTML output (make postgres.html), even though the
> generated HTML source code looks correct. Maybe someone has an idea
> there.
I feel responsible for the feature to work for all use cases where it
makes sense. I'll investigate this and post back.
Regards,
Brar
[1]
https://www.postgresql.org/message-id/d987a4a7-62c3-7e0c-860f-1c96fc2117d9%40gmx.de
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-13 14:01 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
@ 2023-04-13 15:53 ` Karl O. Pinc <[email protected]>
2023-04-14 17:41 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Karl O. Pinc @ 2023-04-13 15:53 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Thu, 13 Apr 2023 16:01:35 +0200
Brar Piening <[email protected]> wrote:
> On 13.04.2023 at 10:31, Peter Eisentraut wrote:
> > The first patch has been committed.
>
> Yay - thank you!
>
> > The second patch should be sent to pgsql-www for integrating into
> > the web site.
> Done via [1]. Thanks for the hint.
>
> > Side project: I noticed that these new hover links don't appear in
> > the single-page HTML output (make postgres.html), even though the
> > generated HTML source code looks correct. Maybe someone has an idea
> > there.
> I feel responsible for the feature to work for all use cases where it
> makes sense. I'll investigate this and post back.
Looks to me like the ">" in the CSS was transformed into the >
HTML entity when the stylesheet was included into the single-file
HTML.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-13 14:01 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 15:53 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2023-04-14 17:41 ` Karl O. Pinc <[email protected]>
0 siblings, 0 replies; 35+ messages in thread
From: Karl O. Pinc @ 2023-04-14 17:41 UTC (permalink / raw)
To: Brar Piening <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Thu, 13 Apr 2023 10:53:31 -0500
"Karl O. Pinc" <[email protected]> wrote:
> On Thu, 13 Apr 2023 16:01:35 +0200
> Brar Piening <[email protected]> wrote:
>
> > On 13.04.2023 at 10:31, Peter Eisentraut wrote:
> > > Side project: I noticed that these new hover links don't appear in
> > > the single-page HTML output (make postgres.html), even though the
> > > generated HTML source code looks correct. Maybe someone has an
> > > idea there.
> > I feel responsible for the feature to work for all use cases where
> > it makes sense. I'll investigate this and post back.
>
> Looks to me like the ">" in the CSS was transformed into the >
> HTML entity when the stylesheet was included into the single-file
> HTML.
The XSLT 1.0 spec says that characters in <style> elements should
not be escaped when outputting HTML. [4] But (I think) the
generate.css.header parameter method [1][2] of
inserting the CSS into the HTML expands the CSS content
in an XML context, not a HTML context.
I've played around with it, going so far as to make stylesheet.css
look like:
--------------<snip>--------
<!DOCTYPE xsl:stylesheet [
<!ENTITY css SYSTEM "stylesheet.css">
]>
<xsl:stylesheet
xmlns:xsl="http://www.w3.org/1999/XSL/Transform";
&css;
</xsl:stylesheet>
--------------<snip>--------
and even substituted the actual text of stylesheet.css in
place of the &css; entity reference. In these cases the
"<" character is still entity expanded, resulting in broken CSS.
My conclusion is that this method is broken.
(The other possibility, I suppose, is that xsltproc is broken.)
I think the thing to try is the sagehill.net approach [4].
This overrides the user.head.content template. My hope is
that because the &css; entity is seen in a <style> element
in the template, that xsltproc then recognizances style element
content in a HTML output context.
(I don't know how xsltproc is supposed to know that it is
in a HTML output context. I suppose exploring this would
be another avenue should the above fail.)
1
https://docbook.sourceforge.net/release/xsl/current/doc/html/custom.css.source.html
2
https://docbook.sourceforge.net/release/xsl/current/doc/html/generate.css.header.html
3 http://sagehill.net/docbookxsl/HtmlHead.html#EmbedCSS
4 https://www.w3.org/TR/xslt-10/#section-HTML-Output-Method
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
@ 2023-04-13 14:58 ` Dagfinn Ilmari Mannsåker <[email protected]>
2023-04-13 15:40 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
1 sibling, 1 reply; 35+ messages in thread
From: Dagfinn Ilmari Mannsåker @ 2023-04-13 14:58 UTC (permalink / raw)
To: Peter Eisentraut <[email protected]>; +Cc: Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
Peter Eisentraut <[email protected]> writes:
> On 06.04.23 16:19, Brar Piening wrote:
>> 001-make_html_ids_discoverable_v5.postgresql.patch which needs to be
>> applied to the postgresql repository. It adds the XSLT to generate the
>> id links and the CSS to hide/display them. I've added comments as
>> suggested above.
>> 002-add-discoverable-id-style_v1.pgweb.patch which needs to be applied
>> to the pgweb repository. It adds the CSS to the offical documentation site.
>
> The first patch has been committed.
>
> The second patch should be sent to pgsql-www for integrating into the
> web site.
>
> Side project: I noticed that these new hover links don't appear in the
> single-page HTML output (make postgres.html), even though the generated
> HTML source code looks correct. Maybe someone has an idea there.
Another side note: I notice the links don't appear on <refsectN> elements
(e.g. https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH),
only <sectN>.
- ilmari
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-13 14:58 ` Re: doc: add missing "id" attributes to extension packaging page Dagfinn Ilmari Mannsåker <[email protected]>
@ 2023-04-13 15:40 ` Karl O. Pinc <[email protected]>
2025-11-14 10:59 ` Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Karl O. Pinc @ 2023-04-13 15:40 UTC (permalink / raw)
To: Dagfinn Ilmari Mannsåker <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Brar Piening <[email protected]>; Alvaro Herrera <[email protected]>; Tom Lane <[email protected]>; vignesh C <[email protected]>; Ian Lawrence Barwick <[email protected]>; pgsql-hackers
On Thu, 13 Apr 2023 15:58:03 +0100
Dagfinn Ilmari Mannsåker <[email protected]> wrote:
> Peter Eisentraut <[email protected]> writes:
> > The first patch has been committed.
> Another side note: I notice the links don't appear on <refsectN>
> elements (e.g.
> https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH), only
> <sectN>.
This we know. Working with <refsectN> elements is a different
dive into the XSLT which was deliberately put off for future
work.
Regards,
Karl <[email protected]>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-13 14:58 ` Re: doc: add missing "id" attributes to extension packaging page Dagfinn Ilmari Mannsåker <[email protected]>
2023-04-13 15:40 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
@ 2025-11-14 10:59 ` Alvaro Herrera <[email protected]>
2025-11-15 10:53 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
0 siblings, 1 reply; 35+ messages in thread
From: Alvaro Herrera @ 2025-11-14 10:59 UTC (permalink / raw)
To: Karl O. Pinc <[email protected]>; +Cc: Dagfinn Ilmari Mannsåker <[email protected]>; Peter Eisentraut <[email protected]>; Brar Piening <[email protected]>; Tom Lane <[email protected]>; pgsql-hackers
On 2023-Apr-13, Karl O. Pinc wrote:
> Dagfinn Ilmari Mannsåker <[email protected]> wrote:
> > Another side note: I notice the links don't appear on <refsectN>
> > elements (e.g.
> > https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH),
> > only <sectN>.
>
> This we know. Working with <refsectN> elements is a different
> dive into the XSLT which was deliberately put off for future
> work.
Hi, has anybody been able to spend some time on the <refsectN> aspect of
these link things?
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"No hay ausente sin culpa ni presente sin disculpa" (Prov. francés)
^ permalink raw reply [nested|flat] 35+ messages in thread
* Re: doc: add missing "id" attributes to extension packaging page
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 19:08 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-04 14:54 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-06 09:06 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Re: doc: add missing "id" attributes to extension packaging page Brar Piening <[email protected]>
2023-04-13 08:31 ` Re: doc: add missing "id" attributes to extension packaging page Peter Eisentraut <[email protected]>
2023-04-13 14:58 ` Re: doc: add missing "id" attributes to extension packaging page Dagfinn Ilmari Mannsåker <[email protected]>
2023-04-13 15:40 ` Re: doc: add missing "id" attributes to extension packaging page Karl O. Pinc <[email protected]>
2025-11-14 10:59 ` Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
@ 2025-11-15 10:53 ` Brar Piening <[email protected]>
0 siblings, 0 replies; 35+ messages in thread
From: Brar Piening @ 2025-11-15 10:53 UTC (permalink / raw)
To: Alvaro Herrera <[email protected]>; Karl O. Pinc <[email protected]>; +Cc: Dagfinn Ilmari Mannsåker <[email protected]>; Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; pgsql-hackers
On 2025-11-14 at 11:59 Alvaro Herrera wrote:
> On 2023-Apr-13, Karl O. Pinc wrote:
>
>> Dagfinn Ilmari Mannsåker <[email protected]> wrote:
>>> Another side note: I notice the links don't appear on <refsectN>
>>> elements (e.g.
>>> https://www.postgresql.org/docs/devel/sql-select.html#SQL-WITH),
>>> only <sectN>.
>> This we know. Working with <refsectN> elements is a different
>> dive into the XSLT which was deliberately put off for future
>> work.
> Hi, has anybody been able to spend some time on the <refsectN> aspect of
> these link things?
Hi,
tbh, this has been in my backlog since I did the initial thing.
I haven't prioritized it since it is really a completely different area
XSLT-wise that cannot build on the changes I have made and I wanted to
see how well my initial work will prove its value and be accepted by the
maintainers and the community before starting to work on this and
introducing even more changes in this kind of ugly XSLT area that nobody
really likes to touch.
I think, now that some time has passed, everybody working on patches in
the docs area should have some opinion on how annoying it is to be
forced to provide ids for various elements and if the advantage of being
able to refer to specific items in the HTML docs is really worth it.
Also, as we've learnt the last time, a patch that enforces the presence
of ids in refsections would need to be applied in a quick and
cooperative way once we agree on the general structure, since it needs
to be rebased and enhanced whenever a new refsection without ids (or
other element where it enforces ids) is added by some patch and will
break all subsequent patches that try to add refsections without ids
(forcing their developers/reviewers to rebase and add ids accordingly).
If we can build some consensus that we want this for the refsections as
well, I'm willing to put some time aside and work on this (probably at
some point next year since I'm currently drowning in work).
Regards,
Barr
^ permalink raw reply [nested|flat] 35+ messages in thread
* [PATCH v9 10/17] table_scan_bitmap_next_block counts lossy and exact pages
@ 2024-03-22 21:09 Melanie Plageman <[email protected]>
0 siblings, 0 replies; 35+ messages in thread
From: Melanie Plageman @ 2024-03-22 21:09 UTC (permalink / raw)
Now that the table_scan_bitmap_next_block() callback only returns false
when the bitmap is exhausted, it is simpler to move the management of
the lossy and exact page counters into it. We will eventually remove
this callback and table_scan_bitmap_next_tuple() will update those
counters when a new block is read in.
---
src/backend/access/heap/heapam_handler.c | 8 ++++++--
src/backend/executor/nodeBitmapHeapscan.c | 9 ++-------
src/include/access/tableam.h | 21 +++++++++++++--------
3 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 2ad785e511..266b34fe6b 100644
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -2114,7 +2114,8 @@ heapam_estimate_rel_size(Relation rel, int32 *attr_widths,
static bool
heapam_scan_bitmap_next_block(TableScanDesc scan,
- bool *recheck, bool *lossy, BlockNumber *blockno)
+ bool *recheck, BlockNumber *blockno,
+ long *lossy_pages, long *exact_pages)
{
HeapScanDesc hscan = (HeapScanDesc) scan;
BlockNumber block;
@@ -2267,7 +2268,10 @@ heapam_scan_bitmap_next_block(TableScanDesc scan,
Assert(ntup <= MaxHeapTuplesPerPage);
hscan->rs_ntuples = ntup;
- *lossy = tbmres->ntuples < 0;
+ if (tbmres->ntuples < 0)
+ (*lossy_pages)++;
+ else
+ (*exact_pages)++;
/*
* Return true to indicate that a valid block was found and the bitmap is
diff --git a/src/backend/executor/nodeBitmapHeapscan.c b/src/backend/executor/nodeBitmapHeapscan.c
index 7e73583fe5..96b55507a3 100644
--- a/src/backend/executor/nodeBitmapHeapscan.c
+++ b/src/backend/executor/nodeBitmapHeapscan.c
@@ -69,7 +69,6 @@ BitmapHeapNext(BitmapHeapScanState *node)
{
ExprContext *econtext;
TableScanDesc scan;
- bool lossy;
TIDBitmap *tbm;
TupleTableSlot *slot;
ParallelBitmapHeapState *pstate = node->pstate;
@@ -267,14 +266,10 @@ new_page:
BitmapAdjustPrefetchIterator(node);
- if (!table_scan_bitmap_next_block(scan, &node->recheck, &lossy, &node->blockno))
+ if (!table_scan_bitmap_next_block(scan, &node->recheck, &node->blockno,
+ &node->lossy_pages, &node->exact_pages))
break;
- if (lossy)
- node->lossy_pages++;
- else
- node->exact_pages++;
-
/*
* If serial, we can error out if the the prefetch block doesn't stay
* ahead of the current block.
diff --git a/src/include/access/tableam.h b/src/include/access/tableam.h
index a820cc8c99..1d4b79a73f 100644
--- a/src/include/access/tableam.h
+++ b/src/include/access/tableam.h
@@ -797,8 +797,8 @@ typedef struct TableAmRoutine
* work to allow scan_bitmap_next_tuple() to return tuples (e.g. it might
* make sense to perform tuple visibility checks at this time).
*
- * lossy indicates whether or not the block's representation in the bitmap
- * is lossy or exact.
+ * lossy_pages is incremented if the block's representation in the bitmap
+ * is lossy, otherwise, exact_pages is incremented.
*
* XXX: Currently this may only be implemented if the AM uses md.c as its
* storage manager, and uses ItemPointer->ip_blkid in a manner that maps
@@ -815,8 +815,10 @@ typedef struct TableAmRoutine
* scan_bitmap_next_tuple need to exist, or neither.
*/
bool (*scan_bitmap_next_block) (TableScanDesc scan,
- bool *recheck, bool *lossy,
- BlockNumber *blockno);
+ bool *recheck,
+ BlockNumber *blockno,
+ long *lossy_pages,
+ long *exact_pages);
/*
* Fetch the next tuple of a bitmap table scan into `slot` and return true
@@ -2013,15 +2015,17 @@ table_relation_estimate_size(Relation rel, int32 *attr_widths,
/*
* Prepare to fetch / check / return tuples as part of a bitmap table scan.
* `scan` needs to have been started via table_beginscan_bm(). Returns false if
- * there are no more blocks in the bitmap, true otherwise. lossy is set to true
- * if bitmap is lossy for the selected block and false otherwise.
+ * there are no more blocks in the bitmap, true otherwise. lossy_pages is
+ * incremented if bitmap is lossy for the selected block and exact_pages is
+ * incremented otherwise.
*
* Note, this is an optionally implemented function, therefore should only be
* used after verifying the presence (at plan time or such).
*/
static inline bool
table_scan_bitmap_next_block(TableScanDesc scan,
- bool *recheck, bool *lossy, BlockNumber *blockno)
+ bool *recheck, BlockNumber *blockno,
+ long *lossy_pages, long *exact_pages)
{
/*
* We don't expect direct calls to table_scan_bitmap_next_block with valid
@@ -2032,7 +2036,8 @@ table_scan_bitmap_next_block(TableScanDesc scan,
elog(ERROR, "unexpected table_scan_bitmap_next_block call during logical decoding");
return scan->rs_rd->rd_tableam->scan_bitmap_next_block(scan, recheck,
- lossy, blockno);
+ blockno, lossy_pages,
+ exact_pages);
}
/*
--
2.40.1
--7mdtsjmrzitrgzgx
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
filename="v9-0011-Hard-code-TBMIterateResult-offsets-array-size.patch"
^ permalink raw reply [nested|flat] 35+ messages in thread
end of thread, other threads:[~2025-11-15 10:53 UTC | newest]
Thread overview: 35+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-03-23 09:35 Re: doc: add missing "id" attributes to extension packaging page Alvaro Herrera <[email protected]>
2023-03-23 10:13 ` Brar Piening <[email protected]>
2023-03-23 13:02 ` Karl O. Pinc <[email protected]>
2023-03-23 19:08 ` Brar Piening <[email protected]>
2023-03-23 19:40 ` Corey Huinker <[email protected]>
2023-03-23 22:31 ` Karl O. Pinc <[email protected]>
2023-03-23 22:55 ` Karl O. Pinc <[email protected]>
2023-03-24 04:09 ` Karl O. Pinc <[email protected]>
2023-03-24 05:48 ` Brar Piening <[email protected]>
2023-03-24 05:59 ` Brar Piening <[email protected]>
2023-03-24 05:05 ` Brar Piening <[email protected]>
2023-03-24 09:45 ` Alvaro Herrera <[email protected]>
2023-03-27 17:05 ` Brar Piening <[email protected]>
2023-03-27 22:11 ` Peter Smith <[email protected]>
2023-03-28 10:17 ` Brar Piening <[email protected]>
2023-03-29 04:52 ` Hayato Kuroda (Fujitsu) <[email protected]>
2023-03-29 16:03 ` Brar Piening <[email protected]>
2023-03-30 08:11 ` Hayato Kuroda (Fujitsu) <[email protected]>
2023-04-04 14:22 ` Peter Eisentraut <[email protected]>
2023-04-04 14:54 ` Peter Eisentraut <[email protected]>
2023-04-04 19:52 ` Brar Piening <[email protected]>
2023-04-04 21:21 ` Karl O. Pinc <[email protected]>
2023-04-05 22:00 ` Maciek Sakrejda <[email protected]>
2023-04-06 09:06 ` Peter Eisentraut <[email protected]>
2023-04-06 14:19 ` Brar Piening <[email protected]>
2023-04-06 15:05 ` Karl O. Pinc <[email protected]>
2023-04-13 08:31 ` Peter Eisentraut <[email protected]>
2023-04-13 14:01 ` Brar Piening <[email protected]>
2023-04-13 15:53 ` Karl O. Pinc <[email protected]>
2023-04-14 17:41 ` Karl O. Pinc <[email protected]>
2023-04-13 14:58 ` Dagfinn Ilmari Mannsåker <[email protected]>
2023-04-13 15:40 ` Karl O. Pinc <[email protected]>
2025-11-14 10:59 ` Alvaro Herrera <[email protected]>
2025-11-15 10:53 ` Brar Piening <[email protected]>
2024-03-22 21:09 [PATCH v9 10/17] table_scan_bitmap_next_block counts lossy and exact pages Melanie Plageman <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox