public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][RM#3073] Allow user to schedule without End date from UI
14+ messages / 3 participants
[nested] [flat]
* [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
@ 2018-02-26 14:46 Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-02-26 14:46 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
PFA patch to fix the issue where user was not able to create pgAgent job
from UI without entering End date in schedule section.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
index 6972dca..a88f9d0 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
@@ -464,18 +464,16 @@ define('pgadmin.node.pga_schedule', [
this.errorModel.unset('jscstart');
}
- val = this.get('jscend');
- if (_.isUndefined(val) || _.isNull(val) ||
- String(val).replace(/^\s+|\s+$/g, '') == '') {
- msg = gettext('Please enter the end time.');
- this.errorModel.set('jscend', msg);
- errMsg = errMsg || msg;
- } else {
- this.errorModel.unset('jscend');
- }
-
// End time must be greater than Start time
if(!errMsg) {
+ val = this.get('jscend');
+ // No further validation required if end date is not provided by
+ // the user
+ if (_.isUndefined(val) || _.isNull(val) ||
+ String(val).replace(/^\s+|\s+$/g, '') == '') {
+ return;
+ }
+
var start_time = this.get('jscstart'),
end_time = this.get('jscend'),
start_time_js = start_time.split(' '),
Attachments:
[text/plain] RM_3073.diff (1.4K, 3-RM_3073.diff)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
index 6972dca..a88f9d0 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
@@ -464,18 +464,16 @@ define('pgadmin.node.pga_schedule', [
this.errorModel.unset('jscstart');
}
- val = this.get('jscend');
- if (_.isUndefined(val) || _.isNull(val) ||
- String(val).replace(/^\s+|\s+$/g, '') == '') {
- msg = gettext('Please enter the end time.');
- this.errorModel.set('jscend', msg);
- errMsg = errMsg || msg;
- } else {
- this.errorModel.unset('jscend');
- }
-
// End time must be greater than Start time
if(!errMsg) {
+ val = this.get('jscend');
+ // No further validation required if end date is not provided by
+ // the user
+ if (_.isUndefined(val) || _.isNull(val) ||
+ String(val).replace(/^\s+|\s+$/g, '') == '') {
+ return;
+ }
+
var start_time = this.get('jscstart'),
end_time = this.get('jscend'),
start_time_js = start_time.split(' '),
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-02-26 16:44 ` Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Dave Page @ 2018-02-26 16:44 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi,
>
> PFA patch to fix the issue where user was not able to create pgAgent job
> from UI without entering End date in schedule section.
>
Whilst this does resolve the validation issue, there are still a couple of
other related problems, as can be seen in the attached screenshots:
- The Start date/time in the subnode control doesn't seem to be properly
synchronised with the value in the grid.
- If you leave the End date/time blank (but maybe click into it first), the
grid will show "Invalid date".
It's possible there are other oddities as well - please check carefully for
anything else.
Thanks.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] Screen Shot 2018-02-26 at 16.41.22.png (192.9K, 3-Screen%20Shot%202018-02-26%20at%2016.41.22.png)
download | view image
[image/png] Screen Shot 2018-02-26 at 16.42.04.png (209.1K, 4-Screen%20Shot%202018-02-26%20at%2016.42.04.png)
download | view image
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
@ 2018-02-27 08:26 ` Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-02-27 08:26 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
As validation related patch was committed with RM#3148 [ Sorry about that I
forgot to checkout :) ]
PFA patch to fix the issues you mentioned, I have also removed extra error
message from sub node collection control and made it optional via flag.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch to fix the issue where user was not able to create pgAgent job
>> from UI without entering End date in schedule section.
>>
>
> Whilst this does resolve the validation issue, there are still a couple
> of other related problems, as can be seen in the attached screenshots:
>
> - The Start date/time in the subnode control doesn't seem to be properly
> synchronised with the value in the grid.
>
> - If you leave the End date/time blank (but maybe click into it first),
> the grid will show "Invalid date".
>
> It's possible there are other oddities as well - please check carefully
> for anything else.
>
> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
index a88f9d0..1cfa38c 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
@@ -279,7 +279,7 @@ define('pgadmin.node.pga_schedule', [
control: 'datetimepicker', cell: DatetimeCell,
disabled: function() { return false; }, displayInUTC: false,
displayFormat: 'YYYY-MM-DD HH:mm:ss Z', options: {
- format: 'YYYY-MM-DD HH:mm:ss Z', useCurrent: false,
+ format: 'YYYY-MM-DD HH:mm:ss Z',
minDate: moment().add(0, 'm'),
}, cellHeaderClasses: 'width_percent_25',
modelFormat: 'YYYY-MM-DD HH:mm:ss Z',
@@ -458,6 +458,9 @@ define('pgadmin.node.pga_schedule', [
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
msg = gettext('Please enter the start time.');
+ if (val == '') {
+ this.set('jscstart', undefined);
+ }
this.errorModel.set('jscstart', msg);
errMsg = errMsg || msg;
} else {
@@ -471,6 +474,9 @@ define('pgadmin.node.pga_schedule', [
// the user
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
+ if (val == '') {
+ this.set('jscend', undefined);
+ }
return;
}
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
index 1a1cfb1..72fd1be 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
@@ -133,6 +133,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
model: pgBrowser.Nodes['pga_jobstep'].model, canEdit: true,
control: 'sub-node-collection', canAdd: true, canDelete: true,
+ showError: false,
columns: [
'jstname', 'jstenabled', 'jstkind', 'jstconntype', 'jstonerror',
],
@@ -141,6 +142,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
control: 'sub-node-collection', canAdd: true, canDelete: true,
canEdit: true, model: pgBrowser.Nodes['pga_schedule'].model,
+ showError: false,
columns: ['jscname', 'jscenabled', 'jscstart', 'jscend'],
}],
validate: function() {
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
index 0dd3f60..971c2d6 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
@@ -300,6 +300,17 @@ define('pgadmin.node.pga_jobstep', [
this.errorModel.unset('jstcode');
}
+ val = this.get('jstonerror');
+ if (
+ !_.isUndefined(val) && !_.isNull(val) &&
+ String(val).replace(/^\s+|\s+$/g, '') == ''
+ ) {
+ msg = gettext('Please select valid on error option .');
+ this.errorModel.set('jstonerror', msg);
+ } else {
+ this.errorModel.unset('jstonerror');
+ }
+
return errMsg;
},
}),
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 2bbaa17..9f1f3db 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1196,6 +1196,7 @@ define([
canAddRow: data.canAddRow,
canEdit: evalF(data.canEdit, data, this.model),
canDelete: evalF(data.canDelete, data, this.model),
+ showError: data.showError || true,
});
// Show Backgrid Control
var grid = (data.subnode == undefined) ? '' : this.showGridControl(data);
@@ -1224,9 +1225,11 @@ define([
if (_.isEmpty(error)) return;
- self.$el.addClass('subnode-error').append(
- $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
- );
+ if (self.field.get('showError')) {
+ self.$el.addClass('subnode-error').append(
+ $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
+ );
+ }
},
cleanup: function() {
// Clean up existing grid if any (in case of re-render)
@@ -1238,8 +1241,10 @@ define([
}
},
clearInvalid: function() {
- this.$el.removeClass('subnode-error');
- this.$el.find('.pgadmin-control-error-message').remove();
+ if (this.field.get('showError')) {
+ this.$el.removeClass('subnode-error');
+ this.$el.find('.pgadmin-control-error-message').remove();
+ }
return this;
},
showGridControl: function(data) {
Attachments:
[text/plain] RM_3073_v1.diff (5.2K, 3-RM_3073_v1.diff)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
index a88f9d0..1cfa38c 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
@@ -279,7 +279,7 @@ define('pgadmin.node.pga_schedule', [
control: 'datetimepicker', cell: DatetimeCell,
disabled: function() { return false; }, displayInUTC: false,
displayFormat: 'YYYY-MM-DD HH:mm:ss Z', options: {
- format: 'YYYY-MM-DD HH:mm:ss Z', useCurrent: false,
+ format: 'YYYY-MM-DD HH:mm:ss Z',
minDate: moment().add(0, 'm'),
}, cellHeaderClasses: 'width_percent_25',
modelFormat: 'YYYY-MM-DD HH:mm:ss Z',
@@ -458,6 +458,9 @@ define('pgadmin.node.pga_schedule', [
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
msg = gettext('Please enter the start time.');
+ if (val == '') {
+ this.set('jscstart', undefined);
+ }
this.errorModel.set('jscstart', msg);
errMsg = errMsg || msg;
} else {
@@ -471,6 +474,9 @@ define('pgadmin.node.pga_schedule', [
// the user
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
+ if (val == '') {
+ this.set('jscend', undefined);
+ }
return;
}
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
index 1a1cfb1..72fd1be 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
@@ -133,6 +133,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
model: pgBrowser.Nodes['pga_jobstep'].model, canEdit: true,
control: 'sub-node-collection', canAdd: true, canDelete: true,
+ showError: false,
columns: [
'jstname', 'jstenabled', 'jstkind', 'jstconntype', 'jstonerror',
],
@@ -141,6 +142,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
control: 'sub-node-collection', canAdd: true, canDelete: true,
canEdit: true, model: pgBrowser.Nodes['pga_schedule'].model,
+ showError: false,
columns: ['jscname', 'jscenabled', 'jscstart', 'jscend'],
}],
validate: function() {
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
index 0dd3f60..971c2d6 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
@@ -300,6 +300,17 @@ define('pgadmin.node.pga_jobstep', [
this.errorModel.unset('jstcode');
}
+ val = this.get('jstonerror');
+ if (
+ !_.isUndefined(val) && !_.isNull(val) &&
+ String(val).replace(/^\s+|\s+$/g, '') == ''
+ ) {
+ msg = gettext('Please select valid on error option .');
+ this.errorModel.set('jstonerror', msg);
+ } else {
+ this.errorModel.unset('jstonerror');
+ }
+
return errMsg;
},
}),
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 2bbaa17..9f1f3db 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1196,6 +1196,7 @@ define([
canAddRow: data.canAddRow,
canEdit: evalF(data.canEdit, data, this.model),
canDelete: evalF(data.canDelete, data, this.model),
+ showError: data.showError || true,
});
// Show Backgrid Control
var grid = (data.subnode == undefined) ? '' : this.showGridControl(data);
@@ -1224,9 +1225,11 @@ define([
if (_.isEmpty(error)) return;
- self.$el.addClass('subnode-error').append(
- $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
- );
+ if (self.field.get('showError')) {
+ self.$el.addClass('subnode-error').append(
+ $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
+ );
+ }
},
cleanup: function() {
// Clean up existing grid if any (in case of re-render)
@@ -1238,8 +1241,10 @@ define([
}
},
clearInvalid: function() {
- this.$el.removeClass('subnode-error');
- this.$el.find('.pgadmin-control-error-message').remove();
+ if (this.field.get('showError')) {
+ this.$el.removeClass('subnode-error');
+ this.$el.find('.pgadmin-control-error-message').remove();
+ }
return this;
},
showGridControl: function(data) {
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-02-27 11:54 ` Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Dave Page @ 2018-02-27 11:54 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
Still not quite right - see the attached screenshot which is the result of
simply viewing the properties of an existing job. Note that the start time
is shown in the grid but not the subnode control.
Thanks.
On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> As validation related patch was committed with RM#3148 [ Sorry about that
> I forgot to checkout :) ]
> PFA patch to fix the issues you mentioned, I have also removed extra error
> message from sub node collection control and made it optional via flag.
>
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> PFA patch to fix the issue where user was not able to create pgAgent job
>>> from UI without entering End date in schedule section.
>>>
>>
>> Whilst this does resolve the validation issue, there are still a couple
>> of other related problems, as can be seen in the attached screenshots:
>>
>> - The Start date/time in the subnode control doesn't seem to be properly
>> synchronised with the value in the grid.
>>
>> - If you leave the End date/time blank (but maybe click into it first),
>> the grid will show "Invalid date".
>>
>> It's possible there are other oddities as well - please check carefully
>> for anything else.
>>
>> Thanks.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
@ 2018-02-27 11:59 ` Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-02-27 11:59 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
Could you please send screenshot?
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
> Hi
>
> Still not quite right - see the attached screenshot which is the result of
> simply viewing the properties of an existing job. Note that the start time
> is shown in the grid but not the subnode control.
>
> Thanks.
>
> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> As validation related patch was committed with RM#3148 [ Sorry about that
>> I forgot to checkout :) ]
>> PFA patch to fix the issues you mentioned, I have also removed extra
>> error message from sub node collection control and made it optional via
>> flag.
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA patch to fix the issue where user was not able to create pgAgent
>>>> job from UI without entering End date in schedule section.
>>>>
>>>
>>> Whilst this does resolve the validation issue, there are still a couple
>>> of other related problems, as can be seen in the attached screenshots:
>>>
>>> - The Start date/time in the subnode control doesn't seem to be properly
>>> synchronised with the value in the grid.
>>>
>>> - If you leave the End date/time blank (but maybe click into it first),
>>> the grid will show "Invalid date".
>>>
>>> It's possible there are other oddities as well - please check carefully
>>> for anything else.
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-02-27 12:00 ` Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Dave Page @ 2018-02-27 12:00 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Sorry - here it is.
On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> Could you please send screenshot?
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Still not quite right - see the attached screenshot which is the result
>> of simply viewing the properties of an existing job. Note that the start
>> time is shown in the grid but not the subnode control.
>>
>> Thanks.
>>
>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> As validation related patch was committed with RM#3148 [ Sorry about
>>> that I forgot to checkout :) ]
>>> PFA patch to fix the issues you mentioned, I have also removed extra
>>> error message from sub node collection control and made it optional via
>>> flag.
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> PFA patch to fix the issue where user was not able to create pgAgent
>>>>> job from UI without entering End date in schedule section.
>>>>>
>>>>
>>>> Whilst this does resolve the validation issue, there are still a
>>>> couple of other related problems, as can be seen in the attached
>>>> screenshots:
>>>>
>>>> - The Start date/time in the subnode control doesn't seem to be
>>>> properly synchronised with the value in the grid.
>>>>
>>>> - If you leave the End date/time blank (but maybe click into it first),
>>>> the grid will show "Invalid date".
>>>>
>>>> It's possible there are other oddities as well - please check carefully
>>>> for anything else.
>>>>
>>>> Thanks.
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[image/png] Screen Shot 2018-02-27 at 11.53.58.png (187.5K, 3-Screen%20Shot%202018-02-27%20at%2011.53.58.png)
download | view image
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
@ 2018-02-27 12:03 ` Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-02-27 12:03 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
I'm not able to re-produce the issue, Could you hard refresh and try again?
If possible could you please provide exact steps?
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
> Sorry - here it is.
>
> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Could you please send screenshot?
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Still not quite right - see the attached screenshot which is the result
>>> of simply viewing the properties of an existing job. Note that the start
>>> time is shown in the grid but not the subnode control.
>>>
>>> Thanks.
>>>
>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> As validation related patch was committed with RM#3148 [ Sorry about
>>>> that I forgot to checkout :) ]
>>>> PFA patch to fix the issues you mentioned, I have also removed extra
>>>> error message from sub node collection control and made it optional via
>>>> flag.
>>>>
>>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> PFA patch to fix the issue where user was not able to create pgAgent
>>>>>> job from UI without entering End date in schedule section.
>>>>>>
>>>>>
>>>>> Whilst this does resolve the validation issue, there are still a
>>>>> couple of other related problems, as can be seen in the attached
>>>>> screenshots:
>>>>>
>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>> properly synchronised with the value in the grid.
>>>>>
>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>> first), the grid will show "Invalid date".
>>>>>
>>>>> It's possible there are other oddities as well - please check
>>>>> carefully for anything else.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-02-27 15:07 ` Dave Page <[email protected]>
2018-02-27 15:09 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Dave Page @ 2018-02-27 15:07 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Hi
On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <
[email protected]> wrote:
> I'm not able to re-produce the issue, Could you hard refresh and try again?
>
I still see it.
>
> If possible could you please provide exact steps?
>
Attached is a dump of my test pgagent schema.
1) Load the schema dump into the maintenance database
2) Connect pgAdmin
3) Browse to pgAgent Jobs
4) Right-click Properties, and select the Schedules tab
5) Open the subnode for sched1
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>
>> Sorry - here it is.
>>
>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> Hi Dave,
>>>
>>> Could you please send screenshot?
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> Still not quite right - see the attached screenshot which is the result
>>>> of simply viewing the properties of an existing job. Note that the start
>>>> time is shown in the grid but not the subnode control.
>>>>
>>>> Thanks.
>>>>
>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> As validation related patch was committed with RM#3148 [ Sorry about
>>>>> that I forgot to checkout :) ]
>>>>> PFA patch to fix the issues you mentioned, I have also removed extra
>>>>> error message from sub node collection control and made it optional via
>>>>> flag.
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> PFA patch to fix the issue where user was not able to create pgAgent
>>>>>>> job from UI without entering End date in schedule section.
>>>>>>>
>>>>>>
>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>> couple of other related problems, as can be seen in the attached
>>>>>> screenshots:
>>>>>>
>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>> properly synchronised with the value in the grid.
>>>>>>
>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>> first), the grid will show "Invalid date".
>>>>>>
>>>>>> It's possible there are other oddities as well - please check
>>>>>> carefully for anything else.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] pgagent.sql (40.4K, 3-pgagent.sql)
download
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
@ 2018-02-27 15:09 ` Murtuza Zabuawala <[email protected]>
2018-02-28 10:35 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-02-27 15:09 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Thanks Dave, I'll look into it.
On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> I'm not able to re-produce the issue, Could you hard refresh and try
>> again?
>>
>
> I still see it.
>
>
>>
>> If possible could you please provide exact steps?
>>
>
> Attached is a dump of my test pgagent schema.
>
> 1) Load the schema dump into the maintenance database
> 2) Connect pgAdmin
> 3) Browse to pgAgent Jobs
> 4) Right-click Properties, and select the Schedules tab
> 5) Open the subnode for sched1
>
>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>
>>> Sorry - here it is.
>>>
>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> Could you please send screenshot?
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> Still not quite right - see the attached screenshot which is the
>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>> start time is shown in the grid but not the subnode control.
>>>>>
>>>>> Thanks.
>>>>>
>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> As validation related patch was committed with RM#3148 [ Sorry about
>>>>>> that I forgot to checkout :) ]
>>>>>> PFA patch to fix the issues you mentioned, I have also removed extra
>>>>>> error message from sub node collection control and made it optional via
>>>>>> flag.
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>
>>>>>>>
>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>> screenshots:
>>>>>>>
>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>> properly synchronised with the value in the grid.
>>>>>>>
>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>> first), the grid will show "Invalid date".
>>>>>>>
>>>>>>> It's possible there are other oddities as well - please check
>>>>>>> carefully for anything else.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 15:09 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-02-28 10:35 ` Murtuza Zabuawala <[email protected]>
2018-02-28 15:10 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Joao De Almeida Pereira <[email protected]>
2018-03-02 11:12 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
0 siblings, 2 replies; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-02-28 10:35 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I have found the issue, it was in Backform control itself :)
Issue: We were passing today's date value as minDate option in pgAgent
schedule schema while rendering the control, So when server was sending
previous datetime value it was not displaying it causing sync problem.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Thanks Dave, I'll look into it.
>
>
>
> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> I'm not able to re-produce the issue, Could you hard refresh and try
>>> again?
>>>
>>
>> I still see it.
>>
>>
>>>
>>> If possible could you please provide exact steps?
>>>
>>
>> Attached is a dump of my test pgagent schema.
>>
>> 1) Load the schema dump into the maintenance database
>> 2) Connect pgAdmin
>> 3) Browse to pgAgent Jobs
>> 4) Right-click Properties, and select the Schedules tab
>> 5) Open the subnode for sched1
>>
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>>
>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Sorry - here it is.
>>>>
>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Could you please send screenshot?
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> Still not quite right - see the attached screenshot which is the
>>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>>> start time is shown in the grid but not the subnode control.
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> As validation related patch was committed with RM#3148 [ Sorry about
>>>>>>> that I forgot to checkout :) ]
>>>>>>> PFA patch to fix the issues you mentioned, I have also removed extra
>>>>>>> error message from sub node collection control and made it optional via
>>>>>>> flag.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Murtuza Zabuawala
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>>> screenshots:
>>>>>>>>
>>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>>> properly synchronised with the value in the grid.
>>>>>>>>
>>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>>> first), the grid will show "Invalid date".
>>>>>>>>
>>>>>>>> It's possible there are other oddities as well - please check
>>>>>>>> carefully for anything else.
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
index a88f9d0..1cfa38c 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
@@ -279,7 +279,7 @@ define('pgadmin.node.pga_schedule', [
control: 'datetimepicker', cell: DatetimeCell,
disabled: function() { return false; }, displayInUTC: false,
displayFormat: 'YYYY-MM-DD HH:mm:ss Z', options: {
- format: 'YYYY-MM-DD HH:mm:ss Z', useCurrent: false,
+ format: 'YYYY-MM-DD HH:mm:ss Z',
minDate: moment().add(0, 'm'),
}, cellHeaderClasses: 'width_percent_25',
modelFormat: 'YYYY-MM-DD HH:mm:ss Z',
@@ -458,6 +458,9 @@ define('pgadmin.node.pga_schedule', [
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
msg = gettext('Please enter the start time.');
+ if (val == '') {
+ this.set('jscstart', undefined);
+ }
this.errorModel.set('jscstart', msg);
errMsg = errMsg || msg;
} else {
@@ -471,6 +474,9 @@ define('pgadmin.node.pga_schedule', [
// the user
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
+ if (val == '') {
+ this.set('jscend', undefined);
+ }
return;
}
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
index 1a1cfb1..72fd1be 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
@@ -133,6 +133,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
model: pgBrowser.Nodes['pga_jobstep'].model, canEdit: true,
control: 'sub-node-collection', canAdd: true, canDelete: true,
+ showError: false,
columns: [
'jstname', 'jstenabled', 'jstkind', 'jstconntype', 'jstonerror',
],
@@ -141,6 +142,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
control: 'sub-node-collection', canAdd: true, canDelete: true,
canEdit: true, model: pgBrowser.Nodes['pga_schedule'].model,
+ showError: false,
columns: ['jscname', 'jscenabled', 'jscstart', 'jscend'],
}],
validate: function() {
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
index 0dd3f60..971c2d6 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
@@ -300,6 +300,17 @@ define('pgadmin.node.pga_jobstep', [
this.errorModel.unset('jstcode');
}
+ val = this.get('jstonerror');
+ if (
+ !_.isUndefined(val) && !_.isNull(val) &&
+ String(val).replace(/^\s+|\s+$/g, '') == ''
+ ) {
+ msg = gettext('Please select valid on error option .');
+ this.errorModel.set('jstonerror', msg);
+ } else {
+ this.errorModel.unset('jstonerror');
+ }
+
return errMsg;
},
}),
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 5bbbf9f..ac6d5aa 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1196,6 +1196,7 @@ define([
canAddRow: data.canAddRow,
canEdit: evalF(data.canEdit, data, this.model),
canDelete: evalF(data.canDelete, data, this.model),
+ showError: data.showError || true,
});
// Show Backgrid Control
var grid = (data.subnode == undefined) ? '' : this.showGridControl(data);
@@ -1224,9 +1225,11 @@ define([
if (_.isEmpty(error)) return;
- self.$el.addClass('subnode-error').append(
- $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
- );
+ if (self.field.get('showError')) {
+ self.$el.addClass('subnode-error').append(
+ $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
+ );
+ }
},
cleanup: function() {
// Clean up existing grid if any (in case of re-render)
@@ -1238,8 +1241,10 @@ define([
}
},
clearInvalid: function() {
- this.$el.removeClass('subnode-error');
- this.$el.find('.pgadmin-control-error-message').remove();
+ if (this.field.get('showError')) {
+ this.$el.removeClass('subnode-error');
+ this.$el.find('.pgadmin-control-error-message').remove();
+ }
return this;
},
showGridControl: function(data) {
@@ -2391,6 +2396,7 @@ define([
},
}, this.defaults.options, this.field.get('options'), {
'date': data.value,
+ 'minDate': data.value,
})
);
}
Attachments:
[text/plain] RM_3073_v2.diff (5.5K, 3-RM_3073_v2.diff)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
index a88f9d0..1cfa38c 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/static/js/pga_schedule.js
@@ -279,7 +279,7 @@ define('pgadmin.node.pga_schedule', [
control: 'datetimepicker', cell: DatetimeCell,
disabled: function() { return false; }, displayInUTC: false,
displayFormat: 'YYYY-MM-DD HH:mm:ss Z', options: {
- format: 'YYYY-MM-DD HH:mm:ss Z', useCurrent: false,
+ format: 'YYYY-MM-DD HH:mm:ss Z',
minDate: moment().add(0, 'm'),
}, cellHeaderClasses: 'width_percent_25',
modelFormat: 'YYYY-MM-DD HH:mm:ss Z',
@@ -458,6 +458,9 @@ define('pgadmin.node.pga_schedule', [
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
msg = gettext('Please enter the start time.');
+ if (val == '') {
+ this.set('jscstart', undefined);
+ }
this.errorModel.set('jscstart', msg);
errMsg = errMsg || msg;
} else {
@@ -471,6 +474,9 @@ define('pgadmin.node.pga_schedule', [
// the user
if (_.isUndefined(val) || _.isNull(val) ||
String(val).replace(/^\s+|\s+$/g, '') == '') {
+ if (val == '') {
+ this.set('jscend', undefined);
+ }
return;
}
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
index 1a1cfb1..72fd1be 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/static/js/pga_job.js
@@ -133,6 +133,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
model: pgBrowser.Nodes['pga_jobstep'].model, canEdit: true,
control: 'sub-node-collection', canAdd: true, canDelete: true,
+ showError: false,
columns: [
'jstname', 'jstenabled', 'jstkind', 'jstconntype', 'jstonerror',
],
@@ -141,6 +142,7 @@ define('pgadmin.node.pga_job', [
type: 'collection', mode: ['edit', 'create'],
control: 'sub-node-collection', canAdd: true, canDelete: true,
canEdit: true, model: pgBrowser.Nodes['pga_schedule'].model,
+ showError: false,
columns: ['jscname', 'jscenabled', 'jscstart', 'jscend'],
}],
validate: function() {
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
index 0dd3f60..971c2d6 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/steps/static/js/pga_jobstep.js
@@ -300,6 +300,17 @@ define('pgadmin.node.pga_jobstep', [
this.errorModel.unset('jstcode');
}
+ val = this.get('jstonerror');
+ if (
+ !_.isUndefined(val) && !_.isNull(val) &&
+ String(val).replace(/^\s+|\s+$/g, '') == ''
+ ) {
+ msg = gettext('Please select valid on error option .');
+ this.errorModel.set('jstonerror', msg);
+ } else {
+ this.errorModel.unset('jstonerror');
+ }
+
return errMsg;
},
}),
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 5bbbf9f..ac6d5aa 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1196,6 +1196,7 @@ define([
canAddRow: data.canAddRow,
canEdit: evalF(data.canEdit, data, this.model),
canDelete: evalF(data.canDelete, data, this.model),
+ showError: data.showError || true,
});
// Show Backgrid Control
var grid = (data.subnode == undefined) ? '' : this.showGridControl(data);
@@ -1224,9 +1225,11 @@ define([
if (_.isEmpty(error)) return;
- self.$el.addClass('subnode-error').append(
- $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
- );
+ if (self.field.get('showError')) {
+ self.$el.addClass('subnode-error').append(
+ $('<div></div>').addClass('pgadmin-control-error-message pg-el-xs-offset-4 pg-el-xs-8 help-block').text(error)
+ );
+ }
},
cleanup: function() {
// Clean up existing grid if any (in case of re-render)
@@ -1238,8 +1241,10 @@ define([
}
},
clearInvalid: function() {
- this.$el.removeClass('subnode-error');
- this.$el.find('.pgadmin-control-error-message').remove();
+ if (this.field.get('showError')) {
+ this.$el.removeClass('subnode-error');
+ this.$el.find('.pgadmin-control-error-message').remove();
+ }
return this;
},
showGridControl: function(data) {
@@ -2391,6 +2396,7 @@ define([
},
}, this.defaults.options, this.field.get('options'), {
'date': data.value,
+ 'minDate': data.value,
})
);
}
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 15:09 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-28 10:35 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-02-28 15:10 ` Joao De Almeida Pereira <[email protected]>
2018-03-01 06:01 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-03-01 09:23 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
1 sibling, 2 replies; 14+ messages in thread
From: Joao De Almeida Pereira @ 2018-02-28 15:10 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hello Murtuza,
I do not have the pgAgent installed so it was a little it hard to test this.
After looking into the code I think we are missing some testing coverage
around the pga_job Javascript part so that we can catch these problems.
Even some code extraction can be done around the pg_jobset change
Nevertheless I passed the patch through our CI and it is all green
Thanks
Joao
On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> I have found the issue, it was in Backform control itself :)
> Issue: We were passing today's date value as minDate option in pgAgent
> schedule schema while rendering the control, So when server was sending
> previous datetime value it was not displaying it causing sync problem.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Thanks Dave, I'll look into it.
>>
>>
>>
>> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> I'm not able to re-produce the issue, Could you hard refresh and try
>>>> again?
>>>>
>>>
>>> I still see it.
>>>
>>>
>>>>
>>>> If possible could you please provide exact steps?
>>>>
>>>
>>> Attached is a dump of my test pgagent schema.
>>>
>>> 1) Load the schema dump into the maintenance database
>>> 2) Connect pgAdmin
>>> 3) Browse to pgAgent Jobs
>>> 4) Right-click Properties, and select the Schedules tab
>>> 5) Open the subnode for sched1
>>>
>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Sorry - here it is.
>>>>>
>>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Could you please send screenshot?
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> Still not quite right - see the attached screenshot which is the
>>>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>>>> start time is shown in the grid but not the subnode control.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> As validation related patch was committed with RM#3148 [ Sorry
>>>>>>>> about that I forgot to checkout :) ]
>>>>>>>> PFA patch to fix the issues you mentioned, I have also removed
>>>>>>>> extra error message from sub node collection control and made it optional
>>>>>>>> via flag.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Murtuza Zabuawala
>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>>>> screenshots:
>>>>>>>>>
>>>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>>>> properly synchronised with the value in the grid.
>>>>>>>>>
>>>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>>>> first), the grid will show "Invalid date".
>>>>>>>>>
>>>>>>>>> It's possible there are other oddities as well - please check
>>>>>>>>> carefully for anything else.
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 15:09 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-28 10:35 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-28 15:10 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Joao De Almeida Pereira <[email protected]>
@ 2018-03-01 06:01 ` Murtuza Zabuawala <[email protected]>
1 sibling, 0 replies; 14+ messages in thread
From: Murtuza Zabuawala @ 2018-03-01 06:01 UTC (permalink / raw)
To: Joao De Almeida Pereira <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Joao,
It is difficult to test scenario with unit test as html input source has
proper date value in both the cases but bootstrap datetime picker itself
was not displaying the value on the UI.
I'm attaching the screenshot for Start field (Both the scenario when it
displays with Valid date and with invalid date when it doesn't).
Let me know if you have anything in mind.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Feb 28, 2018 at 8:40 PM, Joao De Almeida Pereira <
[email protected]> wrote:
> Hello Murtuza,
> I do not have the pgAgent installed so it was a little it hard to test
> this.
> After looking into the code I think we are missing some testing coverage
> around the pga_job Javascript part so that we can catch these problems.
> Even some code extraction can be done around the pg_jobset change
>
> Nevertheless I passed the patch through our CI and it is all green
>
> Thanks
> Joao
>
> On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> I have found the issue, it was in Backform control itself :)
>> Issue: We were passing today's date value as minDate option in pgAgent
>> schedule schema while rendering the control, So when server was sending
>> previous datetime value it was not displaying it causing sync problem.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala <murtuza.zabuawala@
>> enterprisedb.com> wrote:
>>
>>> Thanks Dave, I'll look into it.
>>>
>>>
>>>
>>> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@
>>>> enterprisedb.com> wrote:
>>>>
>>>>> I'm not able to re-produce the issue, Could you hard refresh and try
>>>>> again?
>>>>>
>>>>
>>>> I still see it.
>>>>
>>>>
>>>>>
>>>>> If possible could you please provide exact steps?
>>>>>
>>>>
>>>> Attached is a dump of my test pgagent schema.
>>>>
>>>> 1) Load the schema dump into the maintenance database
>>>> 2) Connect pgAdmin
>>>> 3) Browse to pgAgent Jobs
>>>> 4) Right-click Properties, and select the Schedules tab
>>>> 5) Open the subnode for sched1
>>>>
>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Sorry - here it is.
>>>>>>
>>>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Could you please send screenshot?
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Murtuza Zabuawala
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> Still not quite right - see the attached screenshot which is the
>>>>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>>>>> start time is shown in the grid but not the subnode control.
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> As validation related patch was committed with RM#3148 [ Sorry
>>>>>>>>> about that I forgot to checkout :) ]
>>>>>>>>> PFA patch to fix the issues you mentioned, I have also removed
>>>>>>>>> extra error message from sub node collection control and made it optional
>>>>>>>>> via flag.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Regards,
>>>>>>>>> Murtuza Zabuawala
>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>>>>> screenshots:
>>>>>>>>>>
>>>>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>>>>> properly synchronised with the value in the grid.
>>>>>>>>>>
>>>>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>>>>> first), the grid will show "Invalid date".
>>>>>>>>>>
>>>>>>>>>> It's possible there are other oddities as well - please check
>>>>>>>>>> carefully for anything else.
>>>>>>>>>>
>>>>>>>>>> Thanks.
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>>
>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
Attachments:
[image/png] With Invalid Date.png (152.4K, 3-With%20Invalid%20Date.png)
download | view image
[image/png] With Valid Date.png (209.5K, 4-With%20Valid%20Date.png)
download | view image
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 15:09 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-28 10:35 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-28 15:10 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Joao De Almeida Pereira <[email protected]>
@ 2018-03-01 09:23 ` Dave Page <[email protected]>
1 sibling, 0 replies; 14+ messages in thread
From: Dave Page @ 2018-03-01 09:23 UTC (permalink / raw)
To: Joao De Almeida Pereira <[email protected]>; +Cc: Murtuza Zabuawala <[email protected]>; pgadmin-hackers
On Wed, Feb 28, 2018 at 3:10 PM, Joao De Almeida Pereira <
[email protected]> wrote:
> Hello Murtuza,
> I do not have the pgAgent installed so it was a little it hard to test
> this.
>
FWIW, you don't need to install pgAgent to test this - you can just load
the SQL file I sent into your maintenance database, and that should enable
all the pgAgent features in pgAdmin. Obviously jobs won't get run, but
you'll be able to create them and edit them.
> After looking into the code I think we are missing some testing coverage
> around the pga_job Javascript part so that we can catch these problems.
> Even some code extraction can be done around the pg_jobset change
>
+1
>
> Nevertheless I passed the patch through our CI and it is all green
>
> Thanks
> Joao
>
> On Wed, Feb 28, 2018 at 5:36 AM Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> I have found the issue, it was in Backform control itself :)
>> Issue: We were passing today's date value as minDate option in pgAgent
>> schedule schema while rendering the control, So when server was sending
>> previous datetime value it was not displaying it causing sync problem.
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala <murtuza.zabuawala@
>> enterprisedb.com> wrote:
>>
>>> Thanks Dave, I'll look into it.
>>>
>>>
>>>
>>> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <murtuza.zabuawala@
>>>> enterprisedb.com> wrote:
>>>>
>>>>> I'm not able to re-produce the issue, Could you hard refresh and try
>>>>> again?
>>>>>
>>>>
>>>> I still see it.
>>>>
>>>>
>>>>>
>>>>> If possible could you please provide exact steps?
>>>>>
>>>>
>>>> Attached is a dump of my test pgagent schema.
>>>>
>>>> 1) Load the schema dump into the maintenance database
>>>> 2) Connect pgAdmin
>>>> 3) Browse to pgAgent Jobs
>>>> 4) Right-click Properties, and select the Schedules tab
>>>> 5) Open the subnode for sched1
>>>>
>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Sorry - here it is.
>>>>>>
>>>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> Could you please send screenshot?
>>>>>>>
>>>>>>> --
>>>>>>> Regards,
>>>>>>> Murtuza Zabuawala
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> Still not quite right - see the attached screenshot which is the
>>>>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>>>>> start time is shown in the grid but not the subnode control.
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> As validation related patch was committed with RM#3148 [ Sorry
>>>>>>>>> about that I forgot to checkout :) ]
>>>>>>>>> PFA patch to fix the issues you mentioned, I have also removed
>>>>>>>>> extra error message from sub node collection control and made it optional
>>>>>>>>> via flag.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Regards,
>>>>>>>>> Murtuza Zabuawala
>>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>>>>> screenshots:
>>>>>>>>>>
>>>>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>>>>> properly synchronised with the value in the grid.
>>>>>>>>>>
>>>>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>>>>> first), the grid will show "Invalid date".
>>>>>>>>>>
>>>>>>>>>> It's possible there are other oddities as well - please check
>>>>>>>>>> carefully for anything else.
>>>>>>>>>>
>>>>>>>>>> Thanks.
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>>
>>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>> Twitter: @pgsnake
>>>>>>>>
>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 08:26 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 11:59 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 12:03 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Dave Page <[email protected]>
2018-02-27 15:09 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-28 10:35 ` Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
@ 2018-03-02 11:12 ` Dave Page <[email protected]>
1 sibling, 0 replies; 14+ messages in thread
From: Dave Page @ 2018-03-02 11:12 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: pgadmin-hackers
Thanks, applied.
On Wed, Feb 28, 2018 at 10:35 AM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> I have found the issue, it was in Backform control itself :)
> Issue: We were passing today's date value as minDate option in pgAgent
> schedule schema while rendering the control, So when server was sending
> previous datetime value it was not displaying it causing sync problem.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Tue, Feb 27, 2018 at 8:39 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Thanks Dave, I'll look into it.
>>
>>
>>
>> On Tue, Feb 27, 2018 at 8:37 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Tue, Feb 27, 2018 at 12:03 PM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> I'm not able to re-produce the issue, Could you hard refresh and try
>>>> again?
>>>>
>>>
>>> I still see it.
>>>
>>>
>>>>
>>>> If possible could you please provide exact steps?
>>>>
>>>
>>> Attached is a dump of my test pgagent schema.
>>>
>>> 1) Load the schema dump into the maintenance database
>>> 2) Connect pgAdmin
>>> 3) Browse to pgAgent Jobs
>>> 4) Right-click Properties, and select the Schedules tab
>>> 5) Open the subnode for sched1
>>>
>>>
>>>>
>>>> --
>>>> Regards,
>>>> Murtuza Zabuawala
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>>
>>>> On Tue, Feb 27, 2018 at 5:30 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Sorry - here it is.
>>>>>
>>>>> On Tue, Feb 27, 2018 at 11:59 AM, Murtuza Zabuawala <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Could you please send screenshot?
>>>>>>
>>>>>> --
>>>>>> Regards,
>>>>>> Murtuza Zabuawala
>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>>
>>>>>> On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> Still not quite right - see the attached screenshot which is the
>>>>>>> result of simply viewing the properties of an existing job. Note that the
>>>>>>> start time is shown in the grid but not the subnode control.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> As validation related patch was committed with RM#3148 [ Sorry
>>>>>>>> about that I forgot to checkout :) ]
>>>>>>>> PFA patch to fix the issues you mentioned, I have also removed
>>>>>>>> extra error message from sub node collection control and made it optional
>>>>>>>> via flag.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Regards,
>>>>>>>> Murtuza Zabuawala
>>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> PFA patch to fix the issue where user was not able to create
>>>>>>>>>> pgAgent job from UI without entering End date in schedule section.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Whilst this does resolve the validation issue, there are still a
>>>>>>>>> couple of other related problems, as can be seen in the attached
>>>>>>>>> screenshots:
>>>>>>>>>
>>>>>>>>> - The Start date/time in the subnode control doesn't seem to be
>>>>>>>>> properly synchronised with the value in the grid.
>>>>>>>>>
>>>>>>>>> - If you leave the End date/time blank (but maybe click into it
>>>>>>>>> first), the grid will show "Invalid date".
>>>>>>>>>
>>>>>>>>> It's possible there are other oddities as well - please check
>>>>>>>>> carefully for anything else.
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
end of thread, other threads:[~2018-03-02 11:12 UTC | newest]
Thread overview: 14+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-02-26 14:46 [pgAdmin4][RM#3073] Allow user to schedule without End date from UI Murtuza Zabuawala <[email protected]>
2018-02-26 16:44 ` Dave Page <[email protected]>
2018-02-27 08:26 ` Murtuza Zabuawala <[email protected]>
2018-02-27 11:54 ` Dave Page <[email protected]>
2018-02-27 11:59 ` Murtuza Zabuawala <[email protected]>
2018-02-27 12:00 ` Dave Page <[email protected]>
2018-02-27 12:03 ` Murtuza Zabuawala <[email protected]>
2018-02-27 15:07 ` Dave Page <[email protected]>
2018-02-27 15:09 ` Murtuza Zabuawala <[email protected]>
2018-02-28 10:35 ` Murtuza Zabuawala <[email protected]>
2018-02-28 15:10 ` Joao De Almeida Pereira <[email protected]>
2018-03-01 06:01 ` Murtuza Zabuawala <[email protected]>
2018-03-01 09:23 ` Dave Page <[email protected]>
2018-03-02 11:12 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox