public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
9+ messages / 4 participants
[nested] [flat]
* pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
@ 2018-03-15 11:10 Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2018-03-15 11:10 UTC (permalink / raw)
To: pgadmin-hackers
Ignore config_local.py and config_distro.py when running PEP-8 checks.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b0...
Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
@ 2018-03-15 11:14 ` Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Ashesh Vashi @ 2018-03-15 11:14 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi,
I have just noticed, we're ignoring migrations directory too.
Should we not also check code styling for migrations directory?
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
> 53ae960aeba0dde6109b91c171f22758b1b04ebe
>
> Modified Files
> --------------
> web/.pycodestyle | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
@ 2018-03-15 11:23 ` Dave Page <[email protected]>
2018-03-15 12:30 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2018-03-15 11:23 UTC (permalink / raw)
To: Ashesh Vashi <[email protected]>; +Cc: pgadmin-hackers; Murtuza Zabuawala <[email protected]>
Hi
On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <[email protected]
> wrote:
> Hi,
>
> I have just noticed, we're ignoring migrations directory too.
> Should we not also check code styling for migrations directory?
>
Yeah, I was going to ask about that :-). Is there a specific reason why
we're ignoring the migrations Murtuza?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com;
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi;
>
> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>
>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>
>> Branch
>> ------
>> master
>>
>> Details
>> -------
>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>
>> Modified Files
>> --------------
>> web/.pycodestyle | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
@ 2018-03-15 12:30 ` Murtuza Zabuawala <[email protected]>
2018-03-15 16:12 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Murtuza Zabuawala @ 2018-03-15 12:30 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
> [email protected]> wrote:
>
>> Hi,
>>
>> I have just noticed, we're ignoring migrations directory too.
>> Should we not also check code styling for migrations directory?
>>
>
> Yeah, I was going to ask about that :-). Is there a specific reason why
> we're ignoring the migrations Murtuza?
>
To ease writing long SQL's.
>
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com;
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi;
>>
>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>>
>>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>>
>>> Branch
>>> ------
>>> master
>>>
>>> Details
>>> -------
>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>
>>> Modified Files
>>> --------------
>>> web/.pycodestyle | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 12:30 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
@ 2018-03-15 16:12 ` Dave Page <[email protected]>
2018-03-15 16:25 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2018-03-15 16:12 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers
On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <
[email protected]> wrote:
> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> I have just noticed, we're ignoring migrations directory too.
>>> Should we not also check code styling for migrations directory?
>>>
>>
>> Yeah, I was going to ask about that :-). Is there a specific reason why
>> we're ignoring the migrations Murtuza?
>>
> To ease writing long SQL's.
>
>
Perhaps we could just skip the long line check for those files?
>
>>
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.com;
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>> <http://www.linkedin.com/in/asheshvashi;
>>>
>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>>>
>>>> Branch
>>>> ------
>>>> master
>>>>
>>>> Details
>>>> -------
>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>>
>>>> Modified Files
>>>> --------------
>>>> web/.pycodestyle | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 12:30 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
2018-03-15 16:12 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
@ 2018-03-15 16:25 ` Murtuza Zabuawala <[email protected]>
2018-03-15 19:31 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Murtuza Zabuawala @ 2018-03-15 16:25 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers
Hi Dave,
On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <[email protected]> wrote:
>
>
> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have just noticed, we're ignoring migrations directory too.
>>>> Should we not also check code styling for migrations directory?
>>>>
>>>
>>> Yeah, I was going to ask about that :-). Is there a specific reason why
>>> we're ignoring the migrations Murtuza?
>>>
>> To ease writing long SQL's.
>>
>>
>
> Perhaps we could just skip the long line check for those files?
>
We have to create separate config for that and then run pycodestyle using
that config for migration.
1) pycodestyle --config=.pycodestyle
2) pycodestyle --config=.pycodestyle_migration
something like that, Because I checked the documentation and I didn't find
any option to have single config file for individual directories.
>
>>
>>>
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com;
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>
>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>>>>
>>>>> Branch
>>>>> ------
>>>>> master
>>>>>
>>>>> Details
>>>>> -------
>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>>>
>>>>> Modified Files
>>>>> --------------
>>>>> web/.pycodestyle | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 12:30 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
2018-03-15 16:12 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 16:25 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
@ 2018-03-15 19:31 ` Dave Page <[email protected]>
2018-03-16 11:40 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Joao De Almeida Pereira <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2018-03-15 19:31 UTC (permalink / raw)
To: Murtuza Zabuawala <[email protected]>; +Cc: Ashesh Vashi <[email protected]>; pgadmin-hackers
On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <
[email protected]> wrote:
> Hi Dave,
>
> On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <[email protected]> wrote:
>
>>
>>
>> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <
>> [email protected]> wrote:
>>
>>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have just noticed, we're ignoring migrations directory too.
>>>>> Should we not also check code styling for migrations directory?
>>>>>
>>>>
>>>> Yeah, I was going to ask about that :-). Is there a specific reason why
>>>> we're ignoring the migrations Murtuza?
>>>>
>>> To ease writing long SQL's.
>>>
>>>
>>
>> Perhaps we could just skip the long line check for those files?
>>
> We have to create separate config for that and then run pycodestyle using
> that config for migration.
>
> 1) pycodestyle --config=.pycodestyle
> 2) pycodestyle --config=.pycodestyle_migration
>
> something like that, Because I checked the documentation and I didn't find
> any option to have single config file for individual directories.
>
Urgh. I suppose we could keep a config file in the migration directory, but
even then, we'll get two sets of stats out for running two tests.
>
>
>>
>>>
>>>>
>>>>>
>>>>> --
>>>>>
>>>>> Thanks & Regards,
>>>>>
>>>>> Ashesh Vashi
>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>> <http://www.enterprisedb.com;
>>>>>
>>>>>
>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>
>>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Ignore config_local.py and config_distro.py when running PEP-8 checks.
>>>>>>
>>>>>> Branch
>>>>>> ------
>>>>>> master
>>>>>>
>>>>>> Details
>>>>>> -------
>>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdif
>>>>>> f;h=53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>>>>
>>>>>> Modified Files
>>>>>> --------------
>>>>>> web/.pycodestyle | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 12:30 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
2018-03-15 16:12 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 16:25 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
2018-03-15 19:31 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
@ 2018-03-16 11:40 ` Joao De Almeida Pereira <[email protected]>
2018-03-16 11:59 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Joao De Almeida Pereira @ 2018-03-16 11:40 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Murtuza Zabuawala <[email protected]>; Ashesh Vashi <[email protected]>; pgadmin-hackers
Hello,
Personally I believe we should fix the config_local pep issues and just
ignore the migrations. Specially because the migration file should not have
a lot of python code.
Thanks
On Thu, Mar 15, 2018 at 3:32 PM Dave Page <[email protected]> wrote:
> On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <
> [email protected]> wrote:
>
>> Hi Dave,
>>
>> On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <
>>> [email protected]> wrote:
>>>
>>>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have just noticed, we're ignoring migrations directory too.
>>>>>> Should we not also check code styling for migrations directory?
>>>>>>
>>>>>
>>>>> Yeah, I was going to ask about that :-). Is there a specific reason
>>>>> why we're ignoring the migrations Murtuza?
>>>>>
>>>> To ease writing long SQL's.
>>>>
>>>>
>>>
>>> Perhaps we could just skip the long line check for those files?
>>>
>> We have to create separate config for that and then run pycodestyle
>> using that config for migration.
>>
>> 1) pycodestyle --config=.pycodestyle
>> 2) pycodestyle --config=.pycodestyle_migration
>>
>> something like that, Because I checked the documentation and I didn't
>> find any option to have single config file for individual directories.
>>
>
> Urgh. I suppose we could keep a config file in the migration directory,
> but even then, we'll get two sets of stats out for running two tests.
>
>
>>
>>
>>>
>>>>
>>>>>
>>>>>>
>>>>>> --
>>>>>>
>>>>>> Thanks & Regards,
>>>>>>
>>>>>> Ashesh Vashi
>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>> <http://www.enterprisedb.com;
>>>>>>
>>>>>>
>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>
>>>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Ignore config_local.py and config_distro.py when running PEP-8
>>>>>>> checks.
>>>>>>>
>>>>>>> Branch
>>>>>>> ------
>>>>>>> master
>>>>>>>
>>>>>>> Details
>>>>>>> -------
>>>>>>>
>>>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53ae960aeba0dde6109b91c171f22758b1b0...
>>>>>>>
>>>>>>> Modified Files
>>>>>>> --------------
>>>>>>> web/.pycodestyle | 2 +-
>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 12:30 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
2018-03-15 16:12 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 16:25 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Murtuza Zabuawala <[email protected]>
2018-03-15 19:31 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-16 11:40 ` Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Joao De Almeida Pereira <[email protected]>
@ 2018-03-16 11:59 ` Dave Page <[email protected]>
0 siblings, 0 replies; 9+ messages in thread
From: Dave Page @ 2018-03-16 11:59 UTC (permalink / raw)
To: Joao De Almeida Pereira <[email protected]>; +Cc: Murtuza Zabuawala <[email protected]>; Ashesh Vashi <[email protected]>; pgadmin-hackers
Well config_local isn't part of the source tree, so it's easier to just
ignore that. I'm happy with ignoring the migrations as well.
On Friday, March 16, 2018, Joao De Almeida Pereira <
[email protected]> wrote:
> Hello,
> Personally I believe we should fix the config_local pep issues and just
> ignore the migrations. Specially because the migration file should not have
> a lot of python code.
>
> Thanks
>
> On Thu, Mar 15, 2018 at 3:32 PM Dave Page <[email protected]> wrote:
>
>> On Thu, Mar 15, 2018 at 12:25 PM, Murtuza Zabuawala <murtuza.zabuawala@
>> enterprisedb.com> wrote:
>>
>>> Hi Dave,
>>>
>>> On Thu, Mar 15, 2018 at 9:42 PM, Dave Page <[email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Mar 15, 2018 at 8:30 AM, Murtuza Zabuawala <murtuza.zabuawala@
>>>> enterprisedb.com> wrote:
>>>>
>>>>> On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have just noticed, we're ignoring migrations directory too.
>>>>>>> Should we not also check code styling for migrations directory?
>>>>>>>
>>>>>>
>>>>>> Yeah, I was going to ask about that :-). Is there a specific reason
>>>>>> why we're ignoring the migrations Murtuza?
>>>>>>
>>>>> To ease writing long SQL's.
>>>>>
>>>>>
>>>>
>>>> Perhaps we could just skip the long line check for those files?
>>>>
>>> We have to create separate config for that and then run pycodestyle
>>> using that config for migration.
>>>
>>> 1) pycodestyle --config=.pycodestyle
>>> 2) pycodestyle --config=.pycodestyle_migration
>>>
>>> something like that, Because I checked the documentation and I didn't
>>> find any option to have single config file for individual directories.
>>>
>>
>> Urgh. I suppose we could keep a config file in the migration directory,
>> but even then, we'll get two sets of stats out for running two tests.
>>
>>
>>>
>>>
>>>>
>>>>>
>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> Thanks & Regards,
>>>>>>>
>>>>>>> Ashesh Vashi
>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>> <http://www.enterprisedb.com;
>>>>>>>
>>>>>>>
>>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>>> <http://www.linkedin.com/in/asheshvashi;
>>>>>>>
>>>>>>> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <[email protected]>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Ignore config_local.py and config_distro.py when running PEP-8
>>>>>>>> checks.
>>>>>>>>
>>>>>>>> Branch
>>>>>>>> ------
>>>>>>>> master
>>>>>>>>
>>>>>>>> Details
>>>>>>>> -------
>>>>>>>> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=
>>>>>>>> 53ae960aeba0dde6109b91c171f22758b1b04ebe
>>>>>>>>
>>>>>>>> Modified Files
>>>>>>>> --------------
>>>>>>>> web/.pycodestyle | 2 +-
>>>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2018-03-16 11:59 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 11:10 pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn Dave Page <[email protected]>
2018-03-15 11:14 ` Ashesh Vashi <[email protected]>
2018-03-15 11:23 ` Dave Page <[email protected]>
2018-03-15 12:30 ` Murtuza Zabuawala <[email protected]>
2018-03-15 16:12 ` Dave Page <[email protected]>
2018-03-15 16:25 ` Murtuza Zabuawala <[email protected]>
2018-03-15 19:31 ` Dave Page <[email protected]>
2018-03-16 11:40 ` Joao De Almeida Pereira <[email protected]>
2018-03-16 11:59 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox