pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg_upgrade does not upgrade pg_stat_statements properly
102+ messages / 10 participants
[nested] [flat]
Commits from this thread:
2021-08-03 5e531bb1d3 3d2b6cd6f6 58974a5426 a81c71e3a8 e462856a7a 4051a77757 49e319ceac pg_upgrade: warn about extensions that need updating
2021-08-03 763b95cecc cc7091d91a cebe3ee173 ead4ae00b8 0e6cf3c6f4 5090d709f1 9f6215b4c9 pg_upgrade: improve docs about extension upgrades
* pg_upgrade does not upgrade pg_stat_statements properly
@ 2021-07-14 18:38 Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-14 18:38 UTC (permalink / raw)
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Upgrading from
10.5 to 13.3 using pg_upgrade -k
The following is the result of an upgrade
select * from pg_extension ;
oid | extname | extowner | extnamespace | extrelocatable |
extversion | extconfig | extcondition
-------+--------------------+----------+--------------+----------------+------------+-----------+--------------
12910 | plpgsql | 10 | 11 | f |
1.0 | |
16403 | pg_stat_statements | 10 | 2200 | t |
1.5 | |
(2 rows)
test=# \df+ pg_stat_statements_reset
List of functions
Schema | Name | Result data type | Argument data types
| Type | Volatility | Parallel | Owner | Security | Access privileges
| Language | Source code | Description
--------+--------------------------+------------------+---------------------+------+------------+----------+-------+----------+---------------------------+----------+--------------------------+-------------
public | pg_stat_statements_reset | void |
| func | volatile | safe | davec | invoker | davec=X/davec
+| c | pg_stat_statements_reset |
| | |
| | | | | |
pg_read_all_stats=X/davec | | |
(1 row)
And this is from creating the extension in a new db on the same instance
foo=# select * from pg_extension ;
oid | extname | extowner | extnamespace | extrelocatable |
extversion | extconfig | extcondition
-------+--------------------+----------+--------------+----------------+------------+-----------+--------------
12910 | plpgsql | 10 | 11 | f |
1.0 | |
16393 | pg_stat_statements | 10 | 2200 | t |
1.8 | |
(2 rows)
foo=# \df+ pg_stat_statements_reset
List of functions
Schema | Name | Result data type |
Argument data types | Type | Volatility |
Parallel | Owner | Security | Access privileges | Language | Source
code | Description
--------+--------------------------+------------------+--------------------------------------------------------------------+------+------------+----------+-------+----------+-------------------+----------+------------------------------+-------------
public | pg_stat_statements_reset | void | userid oid DEFAULT
0, dbid oid DEFAULT 0, queryid bigint DEFAULT 0 | func | volatile | safe
| davec | invoker | davec=X/davec | c |
pg_stat_statements_reset_1_7 |
(1 row)
Notice the upgraded version is 1.5 and the new version is 1.8
I would think somewhere in the upgrade of the schema there should have been
a create extension pg_stat_statements ?
Dave
Dave Cramer
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-14 18:47 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-14 18:47 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wednesday, July 14, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
>
> Notice the upgraded version is 1.5 and the new version is 1.8
>
> I would think somewhere in the upgrade of the schema there should have
> been a create extension pg_stat_statements ?
>
That would be a faulty assumption. Modules do not get upgraded during a
server version upgrade. This is a good thing, IMO.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-14 18:58 ` Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-14 18:58 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, 14 Jul 2021 at 14:47, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Wednesday, July 14, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
>>
>>
>> Notice the upgraded version is 1.5 and the new version is 1.8
>>
>> I would think somewhere in the upgrade of the schema there should have
>> been a create extension pg_stat_statements ?
>>
>
> That would be a faulty assumption. Modules do not get upgraded during a
> server version upgrade. This is a good thing, IMO.
>
This is from the documentation of pg_upgrade
Install any custom shared object files (or DLLs) used by the old cluster
into the new cluster, e.g., pgcrypto.so, whether they are from contrib or
some other source. Do not install the schema definitions, e.g., CREATE
EXTENSION pgcrypto, because these will be upgraded from the old cluster.
Also, any custom full text search files (dictionary, synonym, thesaurus,
stop words) must also be copied to the new cluster.
If indeed modules do not get upgraded then the above is confusing at best,
and misleading at worst.
Dave
> David J.
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-14 19:09 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-14 19:09 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, Jul 14, 2021 at 11:59 AM Dave Cramer <davecramer@gmail.com> wrote:
>
>
> On Wed, 14 Jul 2021 at 14:47, David G. Johnston <
> david.g.johnston@gmail.com> wrote:
>
>> On Wednesday, July 14, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>>
>>>
>>>
>>> Notice the upgraded version is 1.5 and the new version is 1.8
>>>
>>> I would think somewhere in the upgrade of the schema there should have
>>> been a create extension pg_stat_statements ?
>>>
>>
>> That would be a faulty assumption. Modules do not get upgraded during a
>> server version upgrade. This is a good thing, IMO.
>>
>
> This is from the documentation of pg_upgrade
>
> Install any custom shared object files (or DLLs) used by the old cluster
> into the new cluster, e.g., pgcrypto.so, whether they are from contrib or
> some other source. Do not install the schema definitions, e.g., CREATE
> EXTENSION pgcrypto, because these will be upgraded from the old cluster.
> Also, any custom full text search files (dictionary, synonym, thesaurus,
> stop words) must also be copied to the new cluster.
>
> If indeed modules do not get upgraded then the above is confusing at best,
> and misleading at worst.
>
>
"Install ... files used by the old cluster" (which must be binary
compatible with the new cluster as noted elsewhere on that page) supports
the claim that it is the old cluster's version that is going to result.
But I agree that saying "because these will be upgraded from the old
cluster" is poorly worded and should be fixed to be more precise here.
Something like, "... because the installed extensions will be copied from
the old cluster during the upgrade."
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-14 19:21 ` Dave Cramer <davecramer@gmail.com>
2021-07-14 19:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-14 19:21 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, 14 Jul 2021 at 15:09, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Wed, Jul 14, 2021 at 11:59 AM Dave Cramer <davecramer@gmail.com> wrote:
>
>>
>>
>> On Wed, 14 Jul 2021 at 14:47, David G. Johnston <
>> david.g.johnston@gmail.com> wrote:
>>
>>> On Wednesday, July 14, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>>>
>>>>
>>>>
>>>> Notice the upgraded version is 1.5 and the new version is 1.8
>>>>
>>>> I would think somewhere in the upgrade of the schema there should have
>>>> been a create extension pg_stat_statements ?
>>>>
>>>
>>> That would be a faulty assumption. Modules do not get upgraded during a
>>> server version upgrade. This is a good thing, IMO.
>>>
>>
>> This is from the documentation of pg_upgrade
>>
>> Install any custom shared object files (or DLLs) used by the old cluster
>> into the new cluster, e.g., pgcrypto.so, whether they are from contrib or
>> some other source. Do not install the schema definitions, e.g., CREATE
>> EXTENSION pgcrypto, because these will be upgraded from the old cluster.
>> Also, any custom full text search files (dictionary, synonym, thesaurus,
>> stop words) must also be copied to the new cluster.
>>
>> If indeed modules do not get upgraded then the above is confusing at
>> best, and misleading at worst.
>>
>>
> "Install ... files used by the old cluster" (which must be binary
> compatible with the new cluster as noted elsewhere on that page) supports
> the claim that it is the old cluster's version that is going to result.
> But I agree that saying "because these will be upgraded from the old
> cluster" is poorly worded and should be fixed to be more precise here.
>
> Something like, "... because the installed extensions will be copied from
> the old cluster during the upgrade."
>
This is still rather opaque. Without intimate knowledge of what changes
have occurred in each extension I have installed; how would I know what I
have to fix after the upgrade.
Seems to me extensions should either store some information in pg_extension
to indicate compatibility, or they should have some sort of upgrade script
which pg_upgrade would call to fix any problems (yes, I realize this is
hand waving at the moment)
In this example the older version of pg_stat_statements works fine, it only
fails when I do a dump restore of the new database and then the error is
rather obtuse. IIRC pg_dump wanted to revoke all from public from the
function pg_stat_statements_reset() and that could not be found, yet the
function is there. I don't believe we should be surprising our users like
this.
Dave
>
> David J.
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-14 19:33 ` David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-14 19:33 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, Jul 14, 2021 at 12:21 PM Dave Cramer <davecramer@gmail.com> wrote:
>
> On Wed, 14 Jul 2021 at 15:09, David G. Johnston <
> david.g.johnston@gmail.com> wrote:
>
>>
>> Something like, "... because the installed extensions will be copied from
>> the old cluster during the upgrade."
>>
>
> This is still rather opaque. Without intimate knowledge of what changes
> have occurred in each extension I have installed; how would I know what I
> have to fix after the upgrade.
>
The point of this behavior is that you don't have to fix anything after an
upgrade - so long as your current extension version works on the new
cluster. If you are upgrading in such a way that the current extension and
new cluster are not compatible you need to not do that. Upgrade instead to
a lesser version where they are compatible. Then upgrade your extension to
its newer version, changing any required user code that such an upgrade
requires, then upgrade the server again.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-14 19:43 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Tom Lane @ 2021-07-14 19:43 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Dave Cramer <davecramer@gmail.com> writes:
> On Wed, 14 Jul 2021 at 15:09, David G. Johnston <david.g.johnston@gmail.com>
> wrote:
>> "Install ... files used by the old cluster" (which must be binary
>> compatible with the new cluster as noted elsewhere on that page) supports
>> the claim that it is the old cluster's version that is going to result.
>> But I agree that saying "because these will be upgraded from the old
>> cluster" is poorly worded and should be fixed to be more precise here.
>>
>> Something like, "... because the installed extensions will be copied from
>> the old cluster during the upgrade."
> This is still rather opaque. Without intimate knowledge of what changes
> have occurred in each extension I have installed; how would I know what I
> have to fix after the upgrade.
That's exactly why we don't force upgrades of extensions. It is on the
user's head to upgrade their extensions from time to time, but we don't
make them do it as part of pg_upgrade. (There are also some
implementation-level reasons to avoid this, IIRC, but the overall
choice is intentional.)
I agree this documentation could be worded better. Another idea
is that possibly pg_upgrade could produce a list of extensions
that are not the latest version, so people know what's left to
be addressed.
regards, tom lane
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-07-15 11:40 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 11:40 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Dave Cramer
On Wed, 14 Jul 2021 at 15:43, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Dave Cramer <davecramer@gmail.com> writes:
> > On Wed, 14 Jul 2021 at 15:09, David G. Johnston <
> david.g.johnston@gmail.com>
> > wrote:
> >> "Install ... files used by the old cluster" (which must be binary
> >> compatible with the new cluster as noted elsewhere on that page)
> supports
> >> the claim that it is the old cluster's version that is going to result.
> >> But I agree that saying "because these will be upgraded from the old
> >> cluster" is poorly worded and should be fixed to be more precise here.
> >>
> >> Something like, "... because the installed extensions will be copied
> from
> >> the old cluster during the upgrade."
>
> > This is still rather opaque. Without intimate knowledge of what changes
> > have occurred in each extension I have installed; how would I know what I
> > have to fix after the upgrade.
>
> That's exactly why we don't force upgrades of extensions. It is on the
> user's head to upgrade their extensions from time to time, but we don't
> make them do it as part of pg_upgrade. (There are also some
> implementation-level reasons to avoid this, IIRC, but the overall
> choice is intentional.)
>
> I agree this documentation could be worded better.
As a first step I propose the following
diff --git a/doc/src/sgml/ref/pgupgrade.sgml
b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..f747a4473a 100644
inline patch 1: doc/src/sgml/ref/pgupgrade.sgml (+0/-0 lines) download inline-1.patch
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -305,9 +305,10 @@ make prefix=/usr/local/pgsql.new install
Install any custom shared object files (or DLLs) used by the old
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-15 15:01 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 15:01 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
> As a first step I propose the following
>
> diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.
> sgml
> index a83c63cd98..f747a4473a 100644
> --- a/doc/src/sgml/ref/pgupgrade.sgml
> +++ b/doc/src/sgml/ref/pgupgrade.sgml
> @@ -305,9 +305,10 @@ make prefix=/usr/local/pgsql.new install
> Install any custom shared object files (or DLLs) used by the old
> cluster
> into the new cluster, e.g., <filename>pgcrypto.so</filename>,
> whether they are from <filename>contrib</filename>
> - or some other source. Do not install the schema definitions, e.g.,
> - <command>CREATE EXTENSION pgcrypto</command>, because these will be
> upgraded
> - from the old cluster.
> + or some other source. Do not execute CREATE EXTENSION on the new
> cluster.
> + The extensions will be upgraded from the old cluster. However it may
> be
> + necessary to recreate the extension on the new server after the
> upgrade
> + to ensure compatibility with the new library.
> Also, any custom full text search files (dictionary, synonym,
> thesaurus, stop words) must also be copied to the new cluster.
> </para>
>
>
I think this needs some work to distinguish between core extensions where
we know the new server already has a library installed and external
extensions where it’s expected that the library that is added to the new
cluster is compatible with the version being migrated (not upgraded). In
short, it should never be necessary to recreate the extension. My
uncertainty revolves around core extensions since it seems odd to tell the
user to overwrite them with versions from an older version of PostgreSQL.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 15:09 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 15:17 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 15:09 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 15 Jul 2021 at 11:01, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
>>
>> As a first step I propose the following
>>
>> diff --git a/doc/src/sgml/ref/pgupgrade.sgml
>> b/doc/src/sgml/ref/pgupgrade.sgml
>> index a83c63cd98..f747a4473a 100644
>> --- a/doc/src/sgml/ref/pgupgrade.sgml
>> +++ b/doc/src/sgml/ref/pgupgrade.sgml
>> @@ -305,9 +305,10 @@ make prefix=/usr/local/pgsql.new install
>> Install any custom shared object files (or DLLs) used by the old
>> cluster
>> into the new cluster, e.g., <filename>pgcrypto.so</filename>,
>> whether they are from <filename>contrib</filename>
>> - or some other source. Do not install the schema definitions, e.g.,
>> - <command>CREATE EXTENSION pgcrypto</command>, because these will be
>> upgraded
>> - from the old cluster.
>> + or some other source. Do not execute CREATE EXTENSION on the new
>> cluster.
>> + The extensions will be upgraded from the old cluster. However it
>> may be
>> + necessary to recreate the extension on the new server after the
>> upgrade
>> + to ensure compatibility with the new library.
>> Also, any custom full text search files (dictionary, synonym,
>> thesaurus, stop words) must also be copied to the new cluster.
>> </para>
>>
>>
>
> I think this needs some work to distinguish between core extensions where
> we know the new server already has a library installed and external
> extensions where it’s expected that the library that is added to the new
> cluster is compatible with the version being migrated (not upgraded). In
> short, it should never be necessary to recreate the extension. My
> uncertainty revolves around core extensions since it seems odd to tell the
> user to overwrite them with versions from an older version of PostgreSQL.
>
Well clearly my suggestion was not clear if you interpreted that as over
writing them with versions from an older version of PostgreSQL.
Dave Cramer
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-15 15:17 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 15:17 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
> Well clearly my suggestion was not clear if you interpreted that as over
> writing them with versions from an older version of PostgreSQL.
>
>>
>>
Ignoring my original interpretation as being moot; the section immediately
preceding your edit says to do exactly that.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 15:15 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 15:15 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thursday, July 15, 2021, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
>>
>> Install any custom shared object files (or DLLs) used by the old
>> cluster
>> into the new cluster, e.g., <filename>pgcrypto.so</filename>,
>> whether they are from <filename>contrib</filename>
>> - or some other source.
>> However it may be
>> + necessary to recreate the extension on the new server after the
>> upgrade
>> + to ensure compatibility with the new library.
>>
>>
>
> My uncertainty revolves around core extensions since it seems odd to tell
> the user to overwrite them with versions from an older version of
> PostgreSQL.
>
Ok. Just re-read the docs a third time…no uncertainty regarding contrib
now…following the first part of the instructions means that before one
could re-run create extension they would need to restore the original
contrib library files to avoid the new extension code using the old
library. So that whole part about recreation is inconsistent with the
existing unchanged text.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 15:21 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 15:21 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 15 Jul 2021 at 11:15, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thursday, July 15, 2021, David G. Johnston <david.g.johnston@gmail.com>
> wrote:
>
>> On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>>
>>>
>>> Install any custom shared object files (or DLLs) used by the old
>>> cluster
>>> into the new cluster, e.g., <filename>pgcrypto.so</filename>,
>>> whether they are from <filename>contrib</filename>
>>> - or some other source.
>>> However it may be
>>> + necessary to recreate the extension on the new server after the
>>> upgrade
>>> + to ensure compatibility with the new library.
>>>
>>>
>>
>> My uncertainty revolves around core extensions since it seems odd to
>> tell the user to overwrite them with versions from an older version of
>> PostgreSQL.
>>
>
> Ok. Just re-read the docs a third time…no uncertainty regarding contrib
> now…following the first part of the instructions means that before one
> could re-run create extension they would need to restore the original
> contrib library files to avoid the new extension code using the old
> library. So that whole part about recreation is inconsistent with the
> existing unchanged text.
>
>
The way I solved the original problem of having old function definitions
for pg_stat_statement functions in the *new* library was by recreating the
extension which presumably redefines the functions correctly.
I'm thinking at this point we need something a bit more sophisticated like
ALTER EXTENSION ... UPGRADE. And the extension knows how to upgrade itself.
Dave
>
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-15 15:29 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 15:29 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
> I'm thinking at this point we need something a bit more sophisticated like
>
> ALTER EXTENSION ... UPGRADE. And the extension knows how to upgrade itself.
>
I’m not familiar with what hoops extensions jump through to facilitate
upgrades but even if it was as simple as “create extension upgrade” I
wouldn’t have pg_upgrade execute that command (or at least not by
default). I would maybe have pg_upgrade help move the libraries over from
the old server (and we must be dealing with different databases having
different extension versions in some manner…).
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 15:43 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 2 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 15:43 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 15 Jul 2021 at 11:29, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thursday, July 15, 2021, Dave Cramer <davecramer@gmail.com> wrote:
>
>>
>> I'm thinking at this point we need something a bit more sophisticated like
>>
>> ALTER EXTENSION ... UPGRADE. And the extension knows how to upgrade
>> itself.
>>
>
> I’m not familiar with what hoops extensions jump through to facilitate
> upgrades but even if it was as simple as “create extension upgrade” I
> wouldn’t have pg_upgrade execute that command (or at least not by
> default). I would maybe have pg_upgrade help move the libraries over from
> the old server (and we must be dealing with different databases having
> different extension versions in some manner…).
>
Well IMHO the status quo is terrible. Perhaps you have a suggestion on how
to make it better ?
Dave
>
> David J.
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-15 16:11 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
1 sibling, 1 reply; 102+ messages in thread
From: Alvaro Herrera @ 2021-07-15 16:11 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Jul-15, Dave Cramer wrote:
> Well IMHO the status quo is terrible. Perhaps you have a suggestion on how
> to make it better ?
I thought the suggestion of having pg_upgrade emit a file with a list of
all extensions needing upgrade in each database was a fairly decent one.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-07-15 16:13 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Alvaro Herrera @ 2021-07-15 16:13 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Jul-15, Alvaro Herrera wrote:
> On 2021-Jul-15, Dave Cramer wrote:
>
> > Well IMHO the status quo is terrible. Perhaps you have a suggestion on how
> > to make it better ?
>
> I thought the suggestion of having pg_upgrade emit a file with a list of
> all extensions needing upgrade in each database was a fairly decent one.
Eh, and
pg_upgrade [other switches] --upgrade-extensions
sounds good too ...
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-07-15 16:16 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 16:16 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 15 Jul 2021 at 12:13, Alvaro Herrera <alvherre@alvh.no-ip.org>
wrote:
> On 2021-Jul-15, Alvaro Herrera wrote:
>
> > On 2021-Jul-15, Dave Cramer wrote:
> >
> > > Well IMHO the status quo is terrible. Perhaps you have a suggestion on
> how
> > > to make it better ?
> >
> > I thought the suggestion of having pg_upgrade emit a file with a list of
> > all extensions needing upgrade in each database was a fairly decent one.
>
> I think this is the minimum we should be doing.
> Eh, and
> pg_upgrade [other switches] --upgrade-extensions
> sounds good too ...
>
Ultimately I believe this is the solution, however we still need to teach
extensions how to upgrade themselves or emit a message saying they can't,
or even ignore if it truly is a NOP.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-15 16:25 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 16:25 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 9:16 AM Dave Cramer <davecramer@gmail.com> wrote:
> Eh, and
>> pg_upgrade [other switches] --upgrade-extensions
>> sounds good too ...
>>
>
> Ultimately I believe this is the solution, however we still need to teach
> extensions how to upgrade themselves or emit a message saying they can't,
> or even ignore if it truly is a NOP.
>
>
If it's opt-in and simple I don't really care but I doubt I would use it as
personally I'd rather the upgrade not touch my application at all (to the
extent possible) and just basically promise that I'll get a reliable
upgrade. Then I'll go ahead and ensure I have the backups of the new
version and that my application works correctly, then just run the "ALTER
EXTENSION" myself. But anything that will solve pain points for
same-PostgreSQL-version extension upgrading is great.
I would say that it probably should be "--upgrade-extension=aaa
--upgrade_extension=bbb" though if we are going to the effort to offer
something.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 16:35 ` Dave Cramer <davecramer@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 16:35 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 15 Jul 2021 at 12:25, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thu, Jul 15, 2021 at 9:16 AM Dave Cramer <davecramer@gmail.com> wrote:
>
>> Eh, and
>>> pg_upgrade [other switches] --upgrade-extensions
>>> sounds good too ...
>>>
>>
>> Ultimately I believe this is the solution, however we still need to teach
>> extensions how to upgrade themselves or emit a message saying they can't,
>> or even ignore if it truly is a NOP.
>>
>>
> If it's opt-in and simple I don't really care but I doubt I would use it
> as personally I'd rather the upgrade not touch my application at all (to
> the extent possible) and just basically promise that I'll get a reliable
> upgrade. Then I'll go ahead and ensure I have the backups of the new
> version and that my application works correctly, then just run the "ALTER
> EXTENSION" myself. But anything that will solve pain points for
> same-PostgreSQL-version extension upgrading is great.
>
I may have not communicated this clearly. In this case the application
worked fine, the extension worked fine. The issue only arose when doing a
dump and restore of the database and then the only reason it failed was due
to trying to revoke permissions from pg_stat_statements_reset.
There may have been other things that were not working correctly but since
it did not cause any errors it was difficult to know.
As Robert points out in the next message this is not a particularly great
user experience
Dave
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 16:35 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-15 16:35 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
On 7/15/21 12:25 PM, David G. Johnston wrote:
> I would say that it probably should be "--upgrade-extension=aaa
> --upgrade_extension=bbb" though if we are going to the effort to offer
> something.
I am a bit confused here. From the previous exchange I get the feeling
that you haven't created and maintained a single extension that survived
a single version upgrade of itself or PostgreSQL (in the latter case
requiring code changes to the extension due to internal API changes
inside the PostgreSQL version).
I have. PL/Profiler to be explicit.
Can you please elaborate what experience your opinion is based on?
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-15 16:46 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 16:46 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 9:36 AM Jan Wieck <jan@wi3ck.info> wrote:
>
> I am a bit confused here. From the previous exchange I get the feeling
> that you haven't created and maintained a single extension that survived
> a single version upgrade of itself or PostgreSQL (in the latter case
> requiring code changes to the extension due to internal API changes
> inside the PostgreSQL version).
>
Correct.
>
> I have. PL/Profiler to be explicit.
>
> Can you please elaborate what experience your opinion is based on?
>
>
I am an application developer who operates on the principle of "change only
one thing at a time".
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 16:58 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-15 16:58 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/15/21 12:46 PM, David G. Johnston wrote:
> I am an application developer who operates on the principle of "change
> only one thing at a time".
Which pg_upgrade by definition isn't. It is bringing ALL the changes
from one major version to the target version, which may be multiple at
once. Including, but not limited to, catalog schema changes, SQL
language changes, extension behavior changes and utility command
behavior changes.
On that principle, you should advocate against using pg_upgrade in the
first place.
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-15 17:10 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 17:10 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 9:58 AM Jan Wieck <jan@wi3ck.info> wrote:
> On 7/15/21 12:46 PM, David G. Johnston wrote:
>
> > I am an application developer who operates on the principle of "change
> > only one thing at a time".
>
> Which pg_upgrade by definition isn't. It is bringing ALL the changes
> from one major version to the target version, which may be multiple at
> once. Including, but not limited to, catalog schema changes, SQL
> language changes, extension behavior changes and utility command
> behavior changes.
>
> On that principle, you should advocate against using pg_upgrade in the
> first place.
>
>
Not that I use extensions a whole lot (yes, my overall experience here is
slim) but I would definitely prefer those that allow me to stay on a single
PostgreSQL major version while migrating between major versions of their
own product. Extensions that don't fit this model (i.e., choose to treat
their major version as being the same as the major version of PostgreSQL
they were developed for) must by necessity be upgraded simultaneously with
the PostgreSQL server. But while PostgreSQL doesn't really have a choice
here - it cannot be expected to subdivide itself - extensions (at least
external ones - PostGIS is one I have in mind presently) - can and often do
attempt to support multiple versions of PostgreSQL for whatever major
versions of their product they are offering. For these it is possible to
adhere to the "change one thing at a time principle" and to treat the
extensions as not being part of "ALL the changes from one major version to
the target version..."
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 18:14 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 18:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-15 18:30 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 2 replies; 102+ messages in thread
From: Jan Wieck @ 2021-07-15 18:14 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/15/21 1:10 PM, David G. Johnston wrote:
> ... But while
> PostgreSQL doesn't really have a choice here - it cannot be expected to
> subdivide itself - extensions (at least external ones - PostGIS is one I
> have in mind presently) - can and often do attempt to support multiple
> versions of PostgreSQL for whatever major versions of their product they
> are offering. For these it is possible to adhere to the "change one
> thing at a time principle" and to treat the extensions as not being part
> of "ALL the changes from one major version to the target version..."
You may make that exception for an external extension like PostGIS. But
I don't think it is valid for one distributed in sync with the core
system in the contrib package, like pg_stat_statements. Which happens to
be the one named in the subject line of this entire discussion.
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-15 18:26 ` Bruce Momjian <bruce@momjian.us>
1 sibling, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-15 18:26 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 02:14:28PM -0400, Jan Wieck wrote:
> On 7/15/21 1:10 PM, David G. Johnston wrote:
> > ... But while PostgreSQL doesn't really have a choice here - it cannot
> > be expected to subdivide itself - extensions (at least external ones -
> > PostGIS is one I have in mind presently) - can and often do attempt to
> > support multiple versions of PostgreSQL for whatever major versions of
> > their product they are offering. For these it is possible to adhere to
> > the "change one thing at a time principle" and to treat the extensions
> > as not being part of "ALL the changes from one major version to the
> > target version..."
>
> You may make that exception for an external extension like PostGIS. But I
> don't think it is valid for one distributed in sync with the core system in
> the contrib package, like pg_stat_statements. Which happens to be the one
> named in the subject line of this entire discussion.
Yes, I think one big issue is that the documentation of the new server
might not match the API of the extension installed on the old server.
There has been a lot of discussion from years ago about why we can't
auto-upgrade extensions, so it might be good to revisit that.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-15 18:30 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:51 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
1 sibling, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 18:30 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 11:14 AM Jan Wieck <jan@wi3ck.info> wrote:
> On 7/15/21 1:10 PM, David G. Johnston wrote:
> > ... But while
> > PostgreSQL doesn't really have a choice here - it cannot be expected to
> > subdivide itself - extensions (at least external ones - PostGIS is one I
> > have in mind presently) - can and often do attempt to support multiple
> > versions of PostgreSQL for whatever major versions of their product they
> > are offering. For these it is possible to adhere to the "change one
> > thing at a time principle" and to treat the extensions as not being part
> > of "ALL the changes from one major version to the target version..."
>
> You may make that exception for an external extension like PostGIS. But
> I don't think it is valid for one distributed in sync with the core
> system in the contrib package, like pg_stat_statements. Which happens to
> be the one named in the subject line of this entire discussion.
>
>
Yep, and IIUC running "CREATE EXTENSION pg_stat_statements VERSION '1.5';"
works correctly in v13 as does executing "ALTER EXTENSION
pg_stat_statements UPDATE;" while version 1.5 is installed. So even
without doing the copying of the old contrib libraries to the new server
such a "one at a time" procedure would work just fine for this particular
contrib extension.
And since the OP was unaware of the presence of the existing ALTER
EXTENSION UPDATE command I'm not sure at what point a "lack of features"
complaint here is due to lack of knowledge or actual problems (yes, I did
forget too but at least this strengthens my position that one-at-a-time
methods are workable, even today).
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 18:30 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 18:51 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-15 20:24 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-15 18:51 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Jan Wieck <jan@wi3ck.info>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 15 Jul 2021 at 14:31, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thu, Jul 15, 2021 at 11:14 AM Jan Wieck <jan@wi3ck.info> wrote:
>
>> On 7/15/21 1:10 PM, David G. Johnston wrote:
>> > ... But while
>> > PostgreSQL doesn't really have a choice here - it cannot be expected to
>> > subdivide itself - extensions (at least external ones - PostGIS is one
>> I
>> > have in mind presently) - can and often do attempt to support multiple
>> > versions of PostgreSQL for whatever major versions of their product
>> they
>> > are offering. For these it is possible to adhere to the "change one
>> > thing at a time principle" and to treat the extensions as not being
>> part
>> > of "ALL the changes from one major version to the target version..."
>>
>> You may make that exception for an external extension like PostGIS. But
>> I don't think it is valid for one distributed in sync with the core
>> system in the contrib package, like pg_stat_statements. Which happens to
>> be the one named in the subject line of this entire discussion.
>>
>>
> Yep, and IIUC running "CREATE EXTENSION pg_stat_statements VERSION '1.5';"
> works correctly in v13 as does executing
>
While it does work there are issues with dumping and restoring a database
with the old version of pg_stat_statements in it that would only be found
by dumping and restoring.
> "ALTER EXTENSION pg_stat_statements UPDATE;" while version 1.5 is
> installed.
>
> So even without doing the copying of the old contrib libraries to the new
> server such a "one at a time" procedure would work just fine for this
> particular contrib extension.
>
You cannot copy the old contrib libraries into the new server. This will
fail due to changes in the API and various exported variables either not
being there or being renamed.
>
> And since the OP was unaware of the presence of the existing ALTER
> EXTENSION UPDATE command I'm not sure at what point a "lack of features"
> complaint here is due to lack of knowledge or actual problems (yes, I did
> forget too but at least this strengthens my position that one-at-a-time
> methods are workable, even today).
>
You are correct I was not aware of the ALTER EXTENSION UPDATE command, but
that doesn't change the issue.
It's not so much the lack of features that I am complaining about; it is
the incompleteness of the upgrade. pg_upgrade does a wonderful job telling
me what extensions are incompatible with the upgrade before it does the
upgrade, but it fails to say that the versions that are installed may need
to be updated.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 18:30 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:51 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
@ 2021-07-15 20:24 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 23:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 20:24 UTC (permalink / raw)
To: Dave Cramer <davecramer@postgres.rocks>; +Cc: Jan Wieck <jan@wi3ck.info>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 11:52 AM Dave Cramer <davecramer@postgres.rocks>
wrote:
>
> On Thu, 15 Jul 2021 at 14:31, David G. Johnston <
> david.g.johnston@gmail.com> wrote:
>
>>
>> Yep, and IIUC running "CREATE EXTENSION pg_stat_statements VERSION
>> '1.5';" works correctly in v13 as does executing
>>
> While it does work there are issues with dumping and restoring a database
> with the old version of pg_stat_statements in it that would only be found
> by dumping and restoring.
>
I'm unsure how this impacts the broader discussion. At worse you'd have a
chance to manually run the update command on the new cluster before using
dump/restore.
>
>> "ALTER EXTENSION pg_stat_statements UPDATE;" while version 1.5 is
>> installed.
>>
>
>
>
>> So even without doing the copying of the old contrib libraries to the new
>> server such a "one at a time" procedure would work just fine for this
>> particular contrib extension.
>>
>
> You cannot copy the old contrib libraries into the new server. This will
> fail due to changes in the API and various exported variables either not
> being there or being renamed.
>
If this is true then the docs have a bug. It sounds more like the
documentation should say "ensure that the new cluster has extension
libraries installed that are compatible with the version of the extension
installed on the old cluster". Whether we want to be even more specific
with regards to contrib I cannot say - it seems like newer versions largely
retain backward compatibility so this is basically a non-issue for contrib
(though maybe individual extensions have their own requirements?)
but it fails to say that the versions that are installed may need to be
> updated.
>
OK, especially as this seems useful outside of pg_upgrade, and if done
separately is something pg_upgrade could just run as part of its new
cluster evaluation scripts. Knowing whether an extension is outdated
doesn't require the old cluster.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 18:30 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:51 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-15 20:24 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 23:18 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 23:31 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-15 23:18 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; Dave Cramer <davecramer@postgres.rocks>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/15/21 4:24 PM, David G. Johnston wrote:
> OK, especially as this seems useful outside of pg_upgrade, and if done
> separately is something pg_upgrade could just run as part of its new
> cluster evaluation scripts. Knowing whether an extension is outdated
> doesn't require the old cluster.
Knowing that (the extension is outdated) exactly how? Can you give us an
example query, maybe a few SQL snippets explaining what exactly you are
talking about? Because at this point you completely lost me.
Sorry, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-15 18:30 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:51 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-15 20:24 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 23:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-15 23:31 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 23:31 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: Dave Cramer <davecramer@postgres.rocks>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thursday, July 15, 2021, Jan Wieck <jan@wi3ck.info> wrote:
> On 7/15/21 4:24 PM, David G. Johnston wrote:
>
> OK, especially as this seems useful outside of pg_upgrade, and if done
>> separately is something pg_upgrade could just run as part of its new
>> cluster evaluation scripts. Knowing whether an extension is outdated
>> doesn't require the old cluster.
>>
>
> Knowing that (the extension is outdated) exactly how? Can you give us an
> example query, maybe a few SQL snippets explaining what exactly you are
> talking about? Because at this point you completely lost me.
>
I was mostly going off other people saying it was possible. In any case,
looking at pg_available_extension_versions, once you figure out how to
order by the version text column, would let you check if any installed
extensions are not their latest version.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-15 16:15 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:31 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Robert Eckhardt <eckhardtr@vmware.com>
1 sibling, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-15 16:15 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 8:43 AM Dave Cramer <davecramer@gmail.com> wrote:
>
> On Thu, 15 Jul 2021 at 11:29, David G. Johnston <
> david.g.johnston@gmail.com> wrote:
>
>>
>> I’m not familiar with what hoops extensions jump through to facilitate
>> upgrades but even if it was as simple as “create extension upgrade” I
>> wouldn’t have pg_upgrade execute that command (or at least not by
>> default). I would maybe have pg_upgrade help move the libraries over from
>> the old server (and we must be dealing with different databases having
>> different extension versions in some manner…).
>>
>
> Well IMHO the status quo is terrible. Perhaps you have a suggestion on how
> to make it better ?
>
To a certain extent it is beyond pg_upgrade's purview to care about
extension explicitly - it considers them "data" on the database side and
copies over the schema and, within reason, punts on the filesystem by
saying "ensure that the existing versions of your extensions in the old
cluster can correctly run in the new cluster" (which basically just takes a
simple file copy/install and the assumption you are upgrading to a server
version that is supported by the extension in question - also a reasonable
requirement). In short, I don't have a suggestion on how to improve that
and don't really consider it a terrible flaw in pg_upgrade.
I'll readily admit that I lack sufficient knowledge here to make such
suggestions as I don't hold any optionions that things are "quite terrible"
and haven't been presented with concrete problems to consider alternatives
for.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-15 16:31 ` Robert Eckhardt <eckhardtr@vmware.com>
2021-07-15 16:38 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: Robert Eckhardt @ 2021-07-15 16:31 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; pvtl-cont-davecramer <davecramer@gmail.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 8:43 AM Dave Cramer <davecramer@gmail.com<mailto:davecramer@gmail.com>> wrote:
On Thu, 15 Jul 2021 at 11:29, David G. Johnston <david.g.johnston@gmail.com<mailto:david.g.johnston@gmail.com>> wrote:
I’m not familiar with what hoops extensions jump through to facilitate upgrades but even if it was as simple as “create extension upgrade” I wouldn’t have pg_upgrade execute that command (or at least not by default). I would maybe have pg_upgrade help move the libraries over from the old server (and we must be dealing with different databases having different extension versions in some manner…).
Well IMHO the status quo is terrible. Perhaps you have a suggestion on how to make it better ?
To a certain extent it is beyond pg_upgrade's purview to care about extension explicitly - it considers them "data" on the database side and copies over the schema and, within reason, punts on the filesystem by saying "ensure that the existing versions of your extensions in the old cluster can correctly run in the new cluster" (which basically just takes a simple file copy/install and the assumption you are upgrading to a server version that is supported by the extension in question - also a reasonable requirement). In short, I don't have a suggestion on how to improve that and don't really consider it a terrible flaw in pg_upgrade.
I don’t know if this is a terrible flaw in pg_upgrade, it is a terrible flaw in the overall Postgres experience.
We are currently working through various upgrade processes and it seems like the status quo is:
Drop the extension, upgrade and reinstall
OR
Upgrade the cluster then upgrade the extension
The issue is that it often isn’t clear which path to choose and choosing the wrong path can lead to data loss.
I don’t think it is ok to expect end users to understand when it is an isn’t ok to just drop and recreate and often it
Isn’t clear in the extension documentation itself. I’m not sure what core can/should do about it but it is a major pain.
-- Rob
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 16:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:31 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Robert Eckhardt <eckhardtr@vmware.com>
@ 2021-07-15 16:38 ` Jan Wieck <jan@wi3ck.info>
0 siblings, 0 replies; 102+ messages in thread
From: Jan Wieck @ 2021-07-15 16:38 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
On 7/15/21 12:31 PM, Robert Eckhardt wrote:
> I don’t know if this is a terrible flaw in pg_upgrade, it is a
> terrible flaw in the overall Postgres experience.
+1 (that is the actual problem here)
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 01:52 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 01:52 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 15, 2021 at 08:15:57AM -0700, David G. Johnston wrote:
> On Thursday, July 15, 2021, David G. Johnston <david.g.johnston@gmail.com>
> My uncertainty revolves around core extensions since it seems odd to tell
> the user to overwrite them with versions from an older version of
> PostgreSQL.
>
> Ok. Just re-read the docs a third time…no uncertainty regarding contrib
> now…following the first part of the instructions means that before one could
> re-run create extension they would need to restore the original contrib library
> files to avoid the new extension code using the old library. So that whole
> part about recreation is inconsistent with the existing unchanged text.
I came up with the attached patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
pg_upgrade.diff (text/x-diff, 920B) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..c042300c8c 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -306,8 +306,9 @@ make prefix=/usr/local/pgsql.new install
into the new cluster, e.g., <filename>pgcrypto.so</filename>,
whether they are from <filename>contrib</filename>
or some other source. Do not install the schema definitions, e.g.,
- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
- from the old cluster.
+ <command>CREATE EXTENSION pgcrypto</command>, because these will be copied
+ from the old cluster. (Consider upgrading the extensions later
+ using <literal>ALTER EXTENSION...UPGRADE</literal>.)
Also, any custom full text search files (dictionary, synonym,
thesaurus, stop words) must also be copied to the new cluster.
</para>
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 04:35 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 11:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
0 siblings, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 04:35 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce@momjian.us> wrote:
> I came up with the attached patch.
>
Thank you. It is an improvement but I think more could be done here (not
exactly sure what - though removing the "copy binaries for contrib modules
from the old server" seems like a decent second step.)
I'm not sure it really needs a parenthetical, and I personally dislike
using "Consider" to start the sentence.
"Bringing extensions up to the newest version available on the new server
can be done later using ALTER EXTENSION UPGRADE (after ensuring the correct
binaries are installed)."
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 11:02 ` Dave Cramer <davecramer@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 11:02 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 29 Jul 2021 at 00:35, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce@momjian.us> wrote:
>
>> I came up with the attached patch.
>>
>
> Thank you. It is an improvement but I think more could be done here (not
> exactly sure what - though removing the "copy binaries for contrib modules
> from the old server" seems like a decent second step.)
>
> I'm not sure it really needs a parenthetical, and I personally dislike
> using "Consider" to start the sentence.
>
> "Bringing extensions up to the newest version available on the new server
> can be done later using ALTER EXTENSION UPGRADE (after ensuring the correct
> binaries are installed)."
>
As for the patch. What exactly is being copied ?
This is all very confusing. Some of the extensions will work perfectly fine
on the new server without an upgrade. At least one of the extensions will
appear to function perfectly fine with new binaries and old function
definitions.
Seems to me we need to do more.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 14:56 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 2 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 14:56 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, Jul 28, 2021 at 09:35:28PM -0700, David G. Johnston wrote:
> On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> I came up with the attached patch.
>
>
> Thank you. It is an improvement but I think more could be done here (not
> exactly sure what - though removing the "copy binaries for contrib modules from
> the old server" seems like a decent second step.)
Uh, I don't see that text.
> I'm not sure it really needs a parenthetical, and I personally dislike using
> "Consider" to start the sentence.
>
> "Bringing extensions up to the newest version available on the new server can
> be done later using ALTER EXTENSION UPGRADE (after ensuring the correct
> binaries are installed)."
OK, I went with this new text. There is confusion over install vs copy,
and whether this is happening at the operating system level or the SQL
level. I tried to clarify that, but I am not sure I was successful. I
also used the word "extension" since this is more common than "custom".
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
pg_upgrade.diff (text/x-diff, 1.8K) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..5ab7c57cd9 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -299,15 +299,17 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster
- into the new cluster, e.g., <filename>pgcrypto.so</filename>,
- whether they are from <filename>contrib</filename>
- or some other source. Do not install the schema definitions, e.g.,
- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
- from the old cluster.
+ If the old cluster used extensions, whether from
+ <filename>contrib</filename> or some other source, install new
+ versions of the extension shared object files (or DLLs) into the
+ new cluster, e.g., <filename>pgcrypto.so</filename>.
+ Do not load the schema definitions, e.g.,
+ <command>CREATE EXTENSION pgcrypto</command>, because these will be
+ recreated from the old cluster. (The extensions may be
+ upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
Also, any custom full text search files (dictionary, synonym,
thesaurus, stop words) must also be copied to the new cluster.
</para>
@@ -494,10 +496,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys
+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 15:01 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 15:01 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
>
> OK, I went with this new text. There is confusion over install vs copy,
> and whether this is happening at the operating system level or the SQL
> level. I tried to clarify that, but I am not sure I was successful. I
> also used the word "extension" since this is more common than "custom".
>
Much better, however I'm unclear on whether CREATE EXTENSION is actually
executed on the upgraded server.
From what I could gather it is not, otherwise the new function definitions
should have been in place.
I think what happens is that the function definitions are copied as part of
the schema and pg_extension is also copied.
Dave
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 15:10 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 15:17 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 2 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 15:10 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 11:01:43AM -0400, Dave Cramer wrote:
>
>
>
>
> OK, I went with this new text. There is confusion over install vs copy,
> and whether this is happening at the operating system level or the SQL
> level. I tried to clarify that, but I am not sure I was successful. I
> also used the word "extension" since this is more common than "custom".
>
>
> Much better, however I'm unclear on whether CREATE EXTENSION is actually
> executed on the upgraded server.
>
> From what I could gather it is not, otherwise the new function definitions
> should have been in place.
> I think what happens is that the function definitions are copied as part of the
> schema and pg_extension is also copied.
Yes, the _effect_ of CREATE EXTENSION in the old cluster is copied to
the new cluster as object definitions. CREATE EXTENSION runs the SQL
files associated with the extension.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 15:17 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 15:24 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 15:17 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 29 Jul 2021 at 11:10, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jul 29, 2021 at 11:01:43AM -0400, Dave Cramer wrote:
> >
> >
> >
> >
> > OK, I went with this new text. There is confusion over install vs
> copy,
> > and whether this is happening at the operating system level or the
> SQL
> > level. I tried to clarify that, but I am not sure I was
> successful. I
> > also used the word "extension" since this is more common than
> "custom".
> >
> >
> > Much better, however I'm unclear on whether CREATE EXTENSION is actually
> > executed on the upgraded server.
> >
> > From what I could gather it is not, otherwise the new function
> definitions
> > should have been in place.
> > I think what happens is that the function definitions are copied as part
> of the
> > schema and pg_extension is also copied.
>
> Yes, the _effect_ of CREATE EXTENSION in the old cluster is copied to
> the new cluster as object definitions. CREATE EXTENSION runs the SQL
> files associated with the extension.
>
OK, I think we should be more clear as to what is happening. Saying they
will be recreated is misleading.
The extension definitions are being copied from the old server to the new
server.
I also think we should have stronger wording in the "The extensions may be
upgraded ..." statement.
I'd suggest "Any new versions of extensions should be upgraded using...."
Dave
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:17 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 15:24 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 15:24 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 11:17:52AM -0400, Dave Cramer wrote:
> On Thu, 29 Jul 2021 at 11:10, Bruce Momjian <bruce@momjian.us> wrote:
> OK, I think we should be more clear as to what is happening. Saying they will
> be recreated is misleading.
> The extension definitions are being copied from the old server to the new
> server.
I think my wording is says exactly that:
Do not load the schema definitions, e.g., <command>CREATE EXTENSION
pgcrypto</command>, because these will be recreated from the old
cluster.
> I also think we should have stronger wording in the "The extensions may be
> upgraded ..." statement.
> I'd suggest "Any new versions of extensions should be upgraded using...."
I can't really comment on that since I see little mention of upgrading
extensions in our docs.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 15:46 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-29 15:46 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org
On 7/29/21 11:10 AM, Bruce Momjian wrote:
> On Thu, Jul 29, 2021 at 11:01:43AM -0400, Dave Cramer wrote:
>> Much better, however I'm unclear on whether CREATE EXTENSION is actually
>> executed on the upgraded server.
>>
>> From what I could gather it is not, otherwise the new function definitions
>> should have been in place.
>> I think what happens is that the function definitions are copied as part of the
>> schema and pg_extension is also copied.
>
> Yes, the _effect_ of CREATE EXTENSION in the old cluster is copied to
> the new cluster as object definitions. CREATE EXTENSION runs the SQL
> files associated with the extension.
>
This assumes that the scripts executed during CREATE EXTENSION have no
conditional code in them that depends on the server version. Running the
same SQL script on different server versions can have different effects.
I don't have a ready example of such an extension, but if we ever would
convert the backend parts of Slony into an extension, it would be one.
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-29 16:14 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 16:14 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: pgsql-hackers@lists.postgresql.org
On Thu, Jul 29, 2021 at 11:46:12AM -0400, Jan Wieck wrote:
> On 7/29/21 11:10 AM, Bruce Momjian wrote:
> > On Thu, Jul 29, 2021 at 11:01:43AM -0400, Dave Cramer wrote:
> > > Much better, however I'm unclear on whether CREATE EXTENSION is actually
> > > executed on the upgraded server.
> > >
> > > From what I could gather it is not, otherwise the new function definitions
> > > should have been in place. I think what happens is that the function
> > > definitions are copied as part of the
> > > schema and pg_extension is also copied.
> >
> > Yes, the _effect_ of CREATE EXTENSION in the old cluster is copied to
> > the new cluster as object definitions. CREATE EXTENSION runs the SQL
> > files associated with the extension.
> >
>
> This assumes that the scripts executed during CREATE EXTENSION have no
> conditional code in them that depends on the server version. Running the
> same SQL script on different server versions can have different effects.
>
> I don't have a ready example of such an extension, but if we ever would
> convert the backend parts of Slony into an extension, it would be one.
The bottom line is that we have _no_ mechanism to handle this except
uninstalling the extension before the upgrade and re-installing it
afterward, which isn't clearly spelled out for each extension, as far as
I know, and would not work for extensions that create data types.
Yes, I do feel this is a big hold in our upgrade instructions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 18:04 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: Julien Rouhaud @ 2021-07-29 18:04 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Jan Wieck <jan@wi3ck.info>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Jul 30, 2021 at 12:14 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Thu, Jul 29, 2021 at 11:46:12AM -0400, Jan Wieck wrote:
> >
> > This assumes that the scripts executed during CREATE EXTENSION have no
> > conditional code in them that depends on the server version. Running the
> > same SQL script on different server versions can have different effects.
> >
> > I don't have a ready example of such an extension, but if we ever would
> > convert the backend parts of Slony into an extension, it would be one.
>
> The bottom line is that we have _no_ mechanism to handle this except
> uninstalling the extension before the upgrade and re-installing it
> afterward, which isn't clearly spelled out for each extension, as far as
> I know, and would not work for extensions that create data types.
>
> Yes, I do feel this is a big hold in our upgrade instructions.
FWIW I have an example of such an extension: powa-archivist extension
script runs an anonymous block code and creates if needed a custom
wrapper to emulate the current_setting(text, boolean) variant that
doesn't exist on pre-pg96 servers.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
@ 2021-07-29 18:14 ` Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-29 18:14 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; Bruce Momjian <bruce@momjian.us>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/29/21 2:04 PM, Julien Rouhaud wrote:
>> On Thu, Jul 29, 2021 at 11:46:12AM -0400, Jan Wieck wrote:
>> > I don't have a ready example of such an extension, but if we ever would
>> > convert the backend parts of Slony into an extension, it would be one.
> FWIW I have an example of such an extension: powa-archivist extension
> script runs an anonymous block code and creates if needed a custom
> wrapper to emulate the current_setting(text, boolean) variant that
> doesn't exist on pre-pg96 servers.
>
Thank you!
I presume that pg_upgrade on a database with that extension installed
would silently succeed and have the pg_catalog as well as public (or
wherever) version of that function present.
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-30 02:02 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
0 siblings, 1 reply; 102+ messages in thread
From: Julien Rouhaud @ 2021-07-30 02:02 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 02:14:56PM -0400, Jan Wieck wrote:
>
> I presume that pg_upgrade on a database with that extension installed would
> silently succeed and have the pg_catalog as well as public (or wherever)
> version of that function present.
I'll have to run a pg_upgrade with it to be 100% sure, but given that this is a
plpgsql function and since the created function is part of the extension
dependencies (and looking at pg_dump source code for binary-upgrade mode), I'm
almost certain that the upgraded cluster would have the pg96- version of the
function even if upgrading to pg9.6+.
Note that in that case the extension would appear to work normally, but the
only way to simulate missing_ok = true is to add a BEGIN/EXCEPTION block.
Since this wrapper function is extensively used, it seems quite possible to
lead to overflowing the snapshot subxip array, as the extension basically runs
every x minutes many functions in a single trannsaction to retrieve many
performance metrics. This can ruin the performance.
This was an acceptable trade off for people still using pg96- in 2021, but
would be silly to have on more recent versions.
Unfortunately I don't see any easy way to avoid that, as there isn't any
guarantee that a new version will be available after the upgrade. AFAICT the
only way to ensure that the correct version of the function is present from an
extension point of view would be to add a dedicated function to overwrite any
object that depends on the servers version and document the need to call that
after a pg_upgrade.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
@ 2021-07-30 10:03 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-30 10:03 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 29 Jul 2021 at 22:03, Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Thu, Jul 29, 2021 at 02:14:56PM -0400, Jan Wieck wrote:
> >
> > I presume that pg_upgrade on a database with that extension installed
> would
> > silently succeed and have the pg_catalog as well as public (or wherever)
> > version of that function present.
>
> I'll have to run a pg_upgrade with it to be 100% sure, but given that this
> is a
> plpgsql function and since the created function is part of the extension
> dependencies (and looking at pg_dump source code for binary-upgrade mode),
> I'm
> almost certain that the upgraded cluster would have the pg96- version of
> the
> function even if upgrading to pg9.6+.
>
> Note that in that case the extension would appear to work normally, but the
> only way to simulate missing_ok = true is to add a BEGIN/EXCEPTION block.
>
> Since this wrapper function is extensively used, it seems quite possible to
> lead to overflowing the snapshot subxip array, as the extension basically
> runs
> every x minutes many functions in a single trannsaction to retrieve many
> performance metrics. This can ruin the performance.
>
> This was an acceptable trade off for people still using pg96- in 2021, but
> would be silly to have on more recent versions.
>
> Unfortunately I don't see any easy way to avoid that, as there isn't any
> guarantee that a new version will be available after the upgrade. AFAICT
> the
> only way to ensure that the correct version of the function is present
> from an
> extension point of view would be to add a dedicated function to overwrite
> any
> object that depends on the servers version and document the need to call
> that
> after a pg_upgrade.
>
What would happen if subsequent to the upgrade "ALTER EXTENSION UPGRADE"
was executed ?
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
@ 2021-07-30 10:39 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
0 siblings, 1 reply; 102+ messages in thread
From: Julien Rouhaud @ 2021-07-30 10:39 UTC (permalink / raw)
To: Dave Cramer <davecramer@postgres.rocks>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Jul 30, 2021 at 06:03:50AM -0400, Dave Cramer wrote:
>
> What would happen if subsequent to the upgrade "ALTER EXTENSION UPGRADE"
> was executed ?
If the extension was already up to date on the source cluster then obviously
nothing.
Otherwise, the extension would be updated. But unless I'm willing (and
remember) to copy/paste until the end of time an anonymous block code that
checks the current server version to see if the wrapper function needs to be
overwritten then nothing will happen either as far as this function is
concerned.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
@ 2021-07-30 10:48 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-30 10:48 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, 30 Jul 2021 at 06:39, Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Fri, Jul 30, 2021 at 06:03:50AM -0400, Dave Cramer wrote:
> >
> > What would happen if subsequent to the upgrade "ALTER EXTENSION UPGRADE"
> > was executed ?
>
> If the extension was already up to date on the source cluster then
> obviously
> nothing.
>
> Otherwise, the extension would be updated. But unless I'm willing (and
> remember) to copy/paste until the end of time an anonymous block code that
> checks the current server version to see if the wrapper function needs to
> be
> overwritten then nothing will happen either as far as this function is
> concerned.
>
Well I think that's on the extension author to fix. There's only so much
pg_upgrade can do here.
It seems reasonable that upgrading the extension should upgrade the
extension to the latest version.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
@ 2021-07-30 11:07 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
0 siblings, 1 reply; 102+ messages in thread
From: Julien Rouhaud @ 2021-07-30 11:07 UTC (permalink / raw)
To: Dave Cramer <davecramer@postgres.rocks>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Jul 30, 2021 at 06:48:34AM -0400, Dave Cramer wrote:
>
> Well I think that's on the extension author to fix. There's only so much
> pg_upgrade can do here.
> It seems reasonable that upgrading the extension should upgrade the
> extension to the latest version.
That would only work iff the extension was *not* up to date on the original
instance. Otherwise I fail to see how any extension script will be called at
all, and therefore the extension was no way to fix anything.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
@ 2021-07-30 11:18 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-30 11:18 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, 30 Jul 2021 at 07:07, Julien Rouhaud <rjuju123@gmail.com> wrote:
> On Fri, Jul 30, 2021 at 06:48:34AM -0400, Dave Cramer wrote:
> >
> > Well I think that's on the extension author to fix. There's only so much
> > pg_upgrade can do here.
> > It seems reasonable that upgrading the extension should upgrade the
> > extension to the latest version.
>
> That would only work iff the extension was *not* up to date on the original
> instance. Otherwise I fail to see how any extension script will be called
> at
> all, and therefore the extension was no way to fix anything.
>
So my understanding is that upgrade is going to run all of the SQL files
from whatever version the original instance was up to the current version.
I'm at a loss as to how this would not work ? How do you upgrade your
extension otherwise ?
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
@ 2021-07-30 11:28 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
0 siblings, 1 reply; 102+ messages in thread
From: Julien Rouhaud @ 2021-07-30 11:28 UTC (permalink / raw)
To: Dave Cramer <davecramer@postgres.rocks>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Jul 30, 2021 at 07:18:56AM -0400, Dave Cramer wrote:
>
> So my understanding is that upgrade is going to run all of the SQL files
> from whatever version the original instance was up to the current version.
>
> I'm at a loss as to how this would not work ? How do you upgrade your
> extension otherwise ?
Yes, but as I said twice only if the currently installed version is different
from the default version. Otherwise ALTER EXTENSION UPGRADE is a no-op.
Just to be clear: I'm not arguing against automatically doing an ALTER
EXTENSION UPGRADE for all extensions in all databases during pg_upgrade (I'm
all for it), just that this specific corner case can't be solved by that
approach.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
@ 2021-07-30 11:33 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 16:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 2 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-30 11:33 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
>
> Yes, but as I said twice only if the currently installed version is
> different
> from the default version. Otherwise ALTER EXTENSION UPGRADE is a no-op.
>
Ah, ok, got it, thanks. Well I'm not sure how to deal with this.
The only thing I can think of is that we add a post_upgrade function to the
API.
All extensions would have to implement this.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
@ 2021-07-30 11:40 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 16:44 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
1 sibling, 1 reply; 102+ messages in thread
From: Julien Rouhaud @ 2021-07-30 11:40 UTC (permalink / raw)
To: Dave Cramer <davecramer@postgres.rocks>; +Cc: Jan Wieck <jan@wi3ck.info>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Jul 30, 2021 at 07:33:55AM -0400, Dave Cramer wrote:
>
> Ah, ok, got it, thanks. Well I'm not sure how to deal with this.
> The only thing I can think of is that we add a post_upgrade function to the
> API.
>
> All extensions would have to implement this.
It seems like a really big hammer for a niche usage. As far as I know I'm the
only one who wrote an extension that can create different objects depending on
the server version, so I'm entirely fine with dealing with that problem in my
extension rather than forcing everyone to implement an otherwise useless API.
Now if that API can be useful for other cases or if there are other extensions
with similar problems that would be different story.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
@ 2021-07-30 16:44 ` Jan Wieck <jan@wi3ck.info>
0 siblings, 0 replies; 102+ messages in thread
From: Jan Wieck @ 2021-07-30 16:44 UTC (permalink / raw)
To: Julien Rouhaud <rjuju123@gmail.com>; Dave Cramer <davecramer@postgres.rocks>; +Cc: Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/30/21 7:40 AM, Julien Rouhaud wrote:
> On Fri, Jul 30, 2021 at 07:33:55AM -0400, Dave Cramer wrote:
>>
>> Ah, ok, got it, thanks. Well I'm not sure how to deal with this.
>> The only thing I can think of is that we add a post_upgrade function to the
>> API.
>>
>> All extensions would have to implement this.
>
> It seems like a really big hammer for a niche usage. As far as I know I'm the
> only one who wrote an extension that can create different objects depending on
> the server version, so I'm entirely fine with dealing with that problem in my
> extension rather than forcing everyone to implement an otherwise useless API.
>
> Now if that API can be useful for other cases or if there are other extensions
> with similar problems that would be different story.
>
I haven't worked on it for a while, but I think pl_profiler does the
same thing, so you are not alone.
Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
@ 2021-07-30 16:43 ` Jan Wieck <jan@wi3ck.info>
2021-07-30 17:05 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-30 16:43 UTC (permalink / raw)
To: Dave Cramer <davecramer@postgres.rocks>; Julien Rouhaud <rjuju123@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/30/21 7:33 AM, Dave Cramer wrote:
>
>
>
>
> Yes, but as I said twice only if the currently installed version is
> different
> from the default version. Otherwise ALTER EXTENSION UPGRADE is a no-op.
>
>
> Ah, ok, got it, thanks. Well I'm not sure how to deal with this.
> The only thing I can think of is that we add a post_upgrade function to
> the API.
>
> All extensions would have to implement this.
An alternative to this would be a recommended version number scheme for
extensions. If extensions were numbered
MAJOR_SERVER.MAJOR_EXTENSION.MINOR_EXTENSION
then pg_upgrade could check the new cluster for the existence of an SQL
script that upgrades the extension from the old cluster's version to the
new current. And since an extension cannot have the same version number
on two major server versions, there is no ambiguity here.
The downside is that all the extensions that don't need anything done
for those upgrades (which I believe is the majority of them) would have
to provide empty SQL files. Not necessarily a bad thing, as it actually
documents "yes, the extension developer checked this and there is
nothing to do here."
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 16:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-30 17:05 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-30 17:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: Tom Lane @ 2021-07-30 17:05 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: Dave Cramer <davecramer@postgres.rocks>; Julien Rouhaud <rjuju123@gmail.com>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Jan Wieck <jan@wi3ck.info> writes:
> An alternative to this would be a recommended version number scheme for
> extensions. If extensions were numbered
> MAJOR_SERVER.MAJOR_EXTENSION.MINOR_EXTENSION
> then pg_upgrade could check the new cluster for the existence of an SQL
> script that upgrades the extension from the old cluster's version to the
> new current. And since an extension cannot have the same version number
> on two major server versions, there is no ambiguity here.
That idea cannot get off the ground. We've spent ten years telling
people they can use whatever version-numbering scheme they like for
their extensions; we can't suddenly go from that to "you must use
exactly this scheme".
I don't see the need for it anyway. What is different from just
putting the update actions into an extension version upgrade
script created according to the current rules, and then setting
that new extension version as the default version in the extension
build you ship for the new server version?
regards, tom lane
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@postgres.rocks>
2021-07-30 16:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-30 17:05 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-07-30 17:28 ` Jan Wieck <jan@wi3ck.info>
0 siblings, 0 replies; 102+ messages in thread
From: Jan Wieck @ 2021-07-30 17:28 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@postgres.rocks>; Julien Rouhaud <rjuju123@gmail.com>; Bruce Momjian <bruce@momjian.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/30/21 1:05 PM, Tom Lane wrote:
> I don't see the need for it anyway. What is different from just
> putting the update actions into an extension version upgrade
> script created according to the current rules, and then setting
> that new extension version as the default version in the extension
> build you ship for the new server version?
You are right. The real fix should actually be that an extension, that
creates different objects depending on the major server version it is
installed on, should not use the same version number for itself on those
two server versions. It is actually wrong to have DO blocks that execute
server version dependent sections in the CREATE EXTENSION scripts.
However similar the code may be, it is intended for different server
versions, so it is not the same version of the extension.
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 15:28 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 15:28 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 7:56 AM Bruce Momjian <bruce@momjian.us> wrote:
> On Wed, Jul 28, 2021 at 09:35:28PM -0700, David G. Johnston wrote:
> > On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce@momjian.us> wrote:
> >
> > I came up with the attached patch.
> >
> >
> > Thank you. It is an improvement but I think more could be done here (not
> > exactly sure what - though removing the "copy binaries for contrib
> modules from
> > the old server" seems like a decent second step.)
>
> Uh, I don't see that text.
>
>
"""
5. Install custom shared object files
Install any custom shared object files (or DLLs) used by the old cluster
into the new cluster, e.g., pgcrypto.so, whether they are from contrib or
some other source. Do not install the schema definitions, e.g., CREATE
EXTENSION pgcrypto, because these will be upgraded from the old cluster.
Also, any custom full text search files (dictionary, synonym, thesaurus,
stop words) must also be copied to the new cluster.
"""
I have an issue with the fragment "whether they are from contrib" - my
understanding at this point is that because of the way we package and
version contrib it should not be necessary to copy those shared object
files from the old to the new server (maybe, just maybe, with a
qualification that you are upgrading between two versions that were in
support during the same time period).
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 15:36 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 15:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 15:36 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
I have an issue with the fragment "whether they are from contrib" - my
> understanding at this point is that because of the way we package and
> version contrib it should not be necessary to copy those shared object
> files from the old to the new server (maybe, just maybe, with a
> qualification that you are upgrading between two versions that were in
> support during the same time period).
>
Just to clarify. In no case are binaries copied from the old server to the
new server. Whether from contrib or otherwise.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 15:39 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:46 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:12 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 15:39 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 8:36 AM Dave Cramer <davecramer@gmail.com> wrote:
>
>
> I have an issue with the fragment "whether they are from contrib" - my
>> understanding at this point is that because of the way we package and
>> version contrib it should not be necessary to copy those shared object
>> files from the old to the new server (maybe, just maybe, with a
>> qualification that you are upgrading between two versions that were in
>> support during the same time period).
>>
>
> Just to clarify. In no case are binaries copied from the old server to the
> new server. Whether from contrib or otherwise.
>
>
I had used "binaries" when I should have written "shared object files". I
just imagine a DLL as being a binary file so it seems accurate but we use
the term differently I suppose?
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 15:46 ` Dave Cramer <davecramer@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 15:46 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 29 Jul 2021 at 11:39, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Thu, Jul 29, 2021 at 8:36 AM Dave Cramer <davecramer@gmail.com> wrote:
>
>>
>>
>> I have an issue with the fragment "whether they are from contrib" - my
>>> understanding at this point is that because of the way we package and
>>> version contrib it should not be necessary to copy those shared object
>>> files from the old to the new server (maybe, just maybe, with a
>>> qualification that you are upgrading between two versions that were in
>>> support during the same time period).
>>>
>>
>> Just to clarify. In no case are binaries copied from the old server to
>> the new server. Whether from contrib or otherwise.
>>
>>
> I had used "binaries" when I should have written "shared object files". I
> just imagine a DLL as being a binary file so it seems accurate but we use
> the term differently I suppose?
>
No, we are using the same term. pg_upgrade does not copy anything that was
compiled, whether it is called a DLL or otherwise.
Dave
>
> David J.
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 16:12 ` Bruce Momjian <bruce@momjian.us>
1 sibling, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 16:12 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 08:39:32AM -0700, David G. Johnston wrote:
> On Thu, Jul 29, 2021 at 8:36 AM Dave Cramer <davecramer@gmail.com> wrote:
>
>
>
>
> I have an issue with the fragment "whether they are from contrib" - my
> understanding at this point is that because of the way we package and
> version contrib it should not be necessary to copy those shared object
> files from the old to the new server (maybe, just maybe, with a
> qualification that you are upgrading between two versions that were in
> support during the same time period).
>
>
> Just to clarify. In no case are binaries copied from the old server to the
> new server. Whether from contrib or otherwise.
>
> I had used "binaries" when I should have written "shared object files". I just
> imagine a DLL as being a binary file so it seems accurate but we use the term
> differently I suppose?
Uh, technically, the _executable_ binary should only use shared object /
loadable libraries that were compiled against that binary's exported
API. Sometimes mismatches work (if the API used by the shared object
has not changed in the binary) so people get used to it working, and
then one day it doesn't, but it is never a safe process.
If two people here are confused about this, obviously others will be as
well. I think we were trying to do too much in that first sentence, so
I split it into two in the attached patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
pg_upgrade.diff (text/x-diff, 2.0K) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..7352936a94 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -299,15 +299,18 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster
- into the new cluster, e.g., <filename>pgcrypto.so</filename>,
- whether they are from <filename>contrib</filename>
- or some other source. Do not install the schema definitions, e.g.,
- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
- from the old cluster.
+ If the old cluster used extensions, whether from
+ <filename>contrib</filename> or some other source, it used
+ shared object files (or DLLs) to implement these extensions, e.g.,
+ <filename>pgcrypto.so</filename>. Now, shared object files matching
+ the new server binary must be installed in the new cluster, usually
+ via operating system commands. Do not load the schema definitions,
+ e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
+ will be recreated from the old cluster. (The extensions may be
+ upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
Also, any custom full text search files (dictionary, synonym,
thesaurus, stop words) must also be copied to the new cluster.
</para>
@@ -494,10 +497,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys
+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 15:42 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 15:42 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 11:36:19AM -0400, Dave Cramer wrote:
>
>
> I have an issue with the fragment "whether they are from contrib" - my
> understanding at this point is that because of the way we package and
> version contrib it should not be necessary to copy those shared object
> files from the old to the new server (maybe, just maybe, with a
> qualification that you are upgrading between two versions that were in
> support during the same time period).
>
>
> Just to clarify. In no case are binaries copied from the old server to the new
> server. Whether from contrib or otherwise.
Right. Those are _binaries_ and therefore made to match a specific
Postgres binary. They might work or might not, but copying them is
never a good idea --- they should be recompiled to match the new server
binary, even if the extension had no version/API changes.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 16:00 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 16:00 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 8:42 AM Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jul 29, 2021 at 11:36:19AM -0400, Dave Cramer wrote:
> >
> >
> > I have an issue with the fragment "whether they are from contrib" -
> my
> > understanding at this point is that because of the way we package and
> > version contrib it should not be necessary to copy those shared
> object
> > files from the old to the new server (maybe, just maybe, with a
> > qualification that you are upgrading between two versions that were
> in
> > support during the same time period).
> >
> >
> > Just to clarify. In no case are binaries copied from the old server to
> the new
> > server. Whether from contrib or otherwise.
>
> Right. Those are _binaries_ and therefore made to match a specific
> Postgres binary. They might work or might not, but copying them is
> never a good idea --- they should be recompiled to match the new server
> binary, even if the extension had no version/API changes.
>
Ok, looking at the flow again, where exactly would the user even be able to
execute "CREATE EXTENSION" meaningfully? The relevant databases do not
exist (not totally sure what happens to the postgres database created
during the initdb step...) so at the point where the user is "installing
the extension" all they can reasonably do is a server-level install (they
could maybe create extension in the postgres database, but does that even
matter?).
So, I'd propose simplifying this all to something like:
Install extensions on the new server
Any extensions that are used by the old cluster need to be installed into
the new cluster. Each database in the old cluster will have its current
version of all extensions migrated to the new cluster as-is. You can use
the ALTER EXTENSION command, on a per-database basis, to update its
extensions post-upgrade.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 16:16 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 16:16 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 09:00:36AM -0700, David G. Johnston wrote:
> On Thu, Jul 29, 2021 at 8:42 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Thu, Jul 29, 2021 at 11:36:19AM -0400, Dave Cramer wrote:
> >
> >
> > I have an issue with the fragment "whether they are from contrib" -
> my
> > understanding at this point is that because of the way we package and
> > version contrib it should not be necessary to copy those shared
> object
> > files from the old to the new server (maybe, just maybe, with a
> > qualification that you are upgrading between two versions that were
> in
> > support during the same time period).
> >
> >
> > Just to clarify. In no case are binaries copied from the old server to
> the new
> > server. Whether from contrib or otherwise.
>
> Right. Those are _binaries_ and therefore made to match a specific
> Postgres binary. They might work or might not, but copying them is
> never a good idea --- they should be recompiled to match the new server
> binary, even if the extension had no version/API changes.
>
>
> Ok, looking at the flow again, where exactly would the user even be able to
> execute "CREATE EXTENSION" meaningfully? The relevant databases do not exist
> (not totally sure what happens to the postgres database created during the
> initdb step...) so at the point where the user is "installing the extension"
> all they can reasonably do is a server-level install (they could maybe create
> extension in the postgres database, but does that even matter?).
They could technically start the new cluster and use "CREATE EXTENSION"
before the upgrade, and then the ugprade would fail since there would be
duplicate object errors.
> So, I'd propose simplifying this all to something like:
>
> Install extensions on the new server
>
> Any extensions that are used by the old cluster need to be installed into the
> new cluster. Each database in the old cluster will have its current version of
> all extensions migrated to the new cluster as-is. You can use the ALTER
> EXTENSION command, on a per-database basis, to update its extensions
> post-upgrade.
Can you review the text I just posted? Thanks. I think we are making
progress. ;-)
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 16:22 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 16:22 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Dave Cramer
On Thu, 29 Jul 2021 at 12:16, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jul 29, 2021 at 09:00:36AM -0700, David G. Johnston wrote:
> > On Thu, Jul 29, 2021 at 8:42 AM Bruce Momjian <bruce@momjian.us> wrote:
> >
> > On Thu, Jul 29, 2021 at 11:36:19AM -0400, Dave Cramer wrote:
> > >
> > >
> > > I have an issue with the fragment "whether they are from
> contrib" -
> > my
> > > understanding at this point is that because of the way we
> package and
> > > version contrib it should not be necessary to copy those shared
> > object
> > > files from the old to the new server (maybe, just maybe, with a
> > > qualification that you are upgrading between two versions that
> were
> > in
> > > support during the same time period).
> > >
> > >
> > > Just to clarify. In no case are binaries copied from the old
> server to
> > the new
> > > server. Whether from contrib or otherwise.
> >
> > Right. Those are _binaries_ and therefore made to match a specific
> > Postgres binary. They might work or might not, but copying them is
> > never a good idea --- they should be recompiled to match the new
> server
> > binary, even if the extension had no version/API changes.
> >
> >
> > Ok, looking at the flow again, where exactly would the user even be able
> to
> > execute "CREATE EXTENSION" meaningfully? The relevant databases do not
> exist
> > (not totally sure what happens to the postgres database created during
> the
> > initdb step...) so at the point where the user is "installing the
> extension"
> > all they can reasonably do is a server-level install (they could maybe
> create
> > extension in the postgres database, but does that even matter?).
>
> They could technically start the new cluster and use "CREATE EXTENSION"
> before the upgrade, and then the ugprade would fail since there would be
> duplicate object errors.
>
> > So, I'd propose simplifying this all to something like:
> >
> > Install extensions on the new server
> >
> > Any extensions that are used by the old cluster need to be installed
> into the
> > new cluster. Each database in the old cluster will have its current
> version of
> > all extensions migrated to the new cluster as-is. You can use the ALTER
> > EXTENSION command, on a per-database basis, to update its extensions
> > post-upgrade.
>
> Can you review the text I just posted? Thanks. I think we are making
> progress. ;-)
>
I am OK with Everything except
Do not load the schema definitions,
e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
will be recreated from the old cluster. (The extensions may be
upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
I take issue with the word "recreated". This implies something new is
created, when in fact the old definitions are simply copied over.
As I said earlier; using the wording "may be upgraded" is not nearly
cautionary enough.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 16:34 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 2 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 16:34 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 12:22:59PM -0400, Dave Cramer wrote:
> On Thu, 29 Jul 2021 at 12:16, Bruce Momjian <bruce@momjian.us> wrote:
> Can you review the text I just posted? Thanks. I think we are making
> progress. ;-)
>
>
> I am OK with Everything except
>
> Do not load the schema definitions,
> e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> will be recreated from the old cluster. (The extensions may be
> upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
>
> I take issue with the word "recreated". This implies something new is created,
> when in fact the old definitions are simply copied over.
>
> As I said earlier; using the wording "may be upgraded" is not nearly cautionary
> enough.
OK, I changed it to "copy" though I used "recreated" earlier since I was
worried "copy" would be confused with file copy. I changed the
recommendation to "should be".
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
pg_upgrade.diff (text/x-diff, 2.0K) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..0e69f26628 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -299,15 +299,18 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster
- into the new cluster, e.g., <filename>pgcrypto.so</filename>,
- whether they are from <filename>contrib</filename>
- or some other source. Do not install the schema definitions, e.g.,
- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
- from the old cluster.
+ If the old cluster used extensions, whether from
+ <filename>contrib</filename> or some other source, it used
+ shared object files (or DLLs) to implement these extensions, e.g.,
+ <filename>pgcrypto.so</filename>. Now, shared object files matching
+ the new server binary must be installed in the new cluster, usually
+ via operating system commands. Do not load the schema definitions,
+ e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
+ will be copied from the old cluster. (Extensions should be upgraded
+ later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
Also, any custom full text search files (dictionary, synonym,
thesaurus, stop words) must also be copied to the new cluster.
</para>
@@ -494,10 +497,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys
+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 17:00 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 18:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 17:00 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 9:34 AM Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jul 29, 2021 at 12:22:59PM -0400, Dave Cramer wrote:
> > On Thu, 29 Jul 2021 at 12:16, Bruce Momjian <bruce@momjian.us> wrote:
> > Can you review the text I just posted? Thanks. I think we are
> making
> > progress. ;-)
> >
> >
> > I am OK with Everything except
> >
> > Do not load the schema definitions,
> > e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> > will be recreated from the old cluster. (The extensions may be
> > upgraded later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
> >
> > I take issue with the word "recreated". This implies something new is
> created,
> > when in fact the old definitions are simply copied over.
> >
> > As I said earlier; using the wording "may be upgraded" is not nearly
> cautionary
> > enough.
>
> OK, I changed it to "copy" though I used "recreated" earlier since I was
> worried "copy" would be confused with file copy. I changed the
> recommendation to "should be".
>
>
I'm warming up to "should" but maybe add a "why" such as "the old versions
are considered unsupported on the newer server".
I dislike "usually via operating system commands", just offload this to the
extension, i.e., "must be installed in the new cluster via installation
procedures specific to, and documented by, each extension (for contrib it
is usually enough to ensure the -contrib package was chosen to be installed
along with the -server package for your operating system.)"
I would simplify the first two sentences to just:
If the old cluster used extensions those same extensions must be installed
in the new cluster via installation procedures specific to, and documented
by, each extension. For contrib extensions it is usually enough to install
the -contrib package via the same method you used to install the PostgreSQL
server.
I would consider my suggestion for "copy as-is/alter extension" wording in
my previous email in lieu of the existing third and fourth sentences, with
the "should" and "why" wording possibly worked in. But the existing works
ok.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 17:10 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 17:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
1 sibling, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 17:10 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
>
>
>
> I would simplify the first two sentences to just:
>
> If the old cluster used extensions those same extensions must be installed
> in the new cluster via installation procedures specific to, and documented
> by, each extension. For contrib extensions it is usually enough to install
> the -contrib package via the same method you used to install the PostgreSQL
> server.
>
Well this is not strictly true. There are many extensions that would work
just fine with the current pg_upgrade. It may not even be necessary to
recompile them.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 17:13 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 17:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Alvaro Herrera @ 2021-07-29 17:13 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Jul-29, Dave Cramer wrote:
> > If the old cluster used extensions those same extensions must be
> > installed in the new cluster via installation procedures specific
> > to, and documented by, each extension. For contrib extensions it is
> > usually enough to install the -contrib package via the same method
> > you used to install the PostgreSQL server.
>
> Well this is not strictly true. There are many extensions that would
> work just fine with the current pg_upgrade. It may not even be
> necessary to recompile them.
It is always necessary to recompile because of the PG_MODULE_MAGIC
declaration, which is mandatory and contains a check that the major
version matches. Copying the original shared object never works.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
"But static content is just dynamic content that isn't moving!"
http://smylers.hates-software.com/2007/08/15/fe244d0c.html
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 17:10 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 17:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-07-29 17:15 ` Dave Cramer <davecramer@gmail.com>
0 siblings, 0 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 17:15 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: David G. Johnston <david.g.johnston@gmail.com>; Bruce Momjian <bruce@momjian.us>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 29 Jul 2021 at 13:13, Alvaro Herrera <alvherre@alvh.no-ip.org>
wrote:
> On 2021-Jul-29, Dave Cramer wrote:
>
> > > If the old cluster used extensions those same extensions must be
> > > installed in the new cluster via installation procedures specific
> > > to, and documented by, each extension. For contrib extensions it is
> > > usually enough to install the -contrib package via the same method
> > > you used to install the PostgreSQL server.
> >
> > Well this is not strictly true. There are many extensions that would
> > work just fine with the current pg_upgrade. It may not even be
> > necessary to recompile them.
>
> It is always necessary to recompile because of the PG_MODULE_MAGIC
> declaration, which is mandatory and contains a check that the major
> version matches. Copying the original shared object never works.
>
Thx, I knew I was on shaky ground with that last statement :)
Dave
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 18:28 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 18:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 2 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 18:28 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 10:00:12AM -0700, David G. Johnston wrote:
> I'm warming up to "should" but maybe add a "why" such as "the old versions are
> considered unsupported on the newer server".
>
> I dislike "usually via operating system commands", just offload this to the
> extension, i.e., "must be installed in the new cluster via installation
> procedures specific to, and documented by, each extension (for contrib it is
> usually enough to ensure the -contrib package was chosen to be installed along
> with the -server package for your operating system.)"
>
> I would simplify the first two sentences to just:
>
> If the old cluster used extensions those same extensions must be installed in
> the new cluster via installation procedures specific to, and documented by,
> each extension. For contrib extensions it is usually enough to install the
> -contrib package via the same method you used to install the PostgreSQL server.
>
> I would consider my suggestion for "copy as-is/alter extension" wording in my
> previous email in lieu of the existing third and fourth sentences, with the
> "should" and "why" wording possibly worked in. But the existing works ok.
I am sorry but none of your suggestions are exciting me --- they seem to
get into too much detail for the context.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 18:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 18:35 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 18:38 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 18:35 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 02:28:55PM -0400, Bruce Momjian wrote:
> On Thu, Jul 29, 2021 at 10:00:12AM -0700, David G. Johnston wrote:
> > I'm warming up to "should" but maybe add a "why" such as "the old versions are
> > considered unsupported on the newer server".
> >
> > I dislike "usually via operating system commands", just offload this to the
> > extension, i.e., "must be installed in the new cluster via installation
> > procedures specific to, and documented by, each extension (for contrib it is
> > usually enough to ensure the -contrib package was chosen to be installed along
> > with the -server package for your operating system.)"
> >
> > I would simplify the first two sentences to just:
> >
> > If the old cluster used extensions those same extensions must be installed in
> > the new cluster via installation procedures specific to, and documented by,
> > each extension. For contrib extensions it is usually enough to install the
> > -contrib package via the same method you used to install the PostgreSQL server.
Oh, and you can't use the same installation procedures as when you
installed the extension because that probably included CREATE EXTENSION.
This really highlights why this is tricky to explain --- we need the
binaries, but not the SQL that goes with it.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 18:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 18:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 18:38 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 18:38 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 11:35 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> Oh, and you can't use the same installation procedures as when you
> installed the extension because that probably included CREATE EXTENSION.
> This really highlights why this is tricky to explain --- we need the
> binaries, but not the SQL that goes with it.
>
Maybe...but the fact that "installation to the O/S" is cluster-wide and
"CREATE EXTENSION" is database-specific I believe this will generally take
care of itself in practice, especially if we leave the part (but ignore any
installation instructions that advise executing create extension).
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 18:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 18:36 ` David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 18:36 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 11:28 AM Bruce Momjian <bruce@momjian.us> wrote:
> I am sorry but none of your suggestions are exciting me --- they seem to
> get into too much detail for the context.
>
Fair, I still need to consider Alvaro's anyway, but given the amount of
general angst surrounding performing a pg_upgrade I do not feel that being
detailed is necessarily a bad thing, so long as the detail is relevant.
But I'll keep this in mind for my next reply.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 17:43 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 18:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: Alvaro Herrera @ 2021-07-29 17:43 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Jul-29, Bruce Momjian wrote:
> + If the old cluster used extensions, whether from
> + <filename>contrib</filename> or some other source, it used
> + shared object files (or DLLs) to implement these extensions, e.g.,
> + <filename>pgcrypto.so</filename>. Now, shared object files matching
> + the new server binary must be installed in the new cluster, usually
> + via operating system commands. Do not load the schema definitions,
> + e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> + will be copied from the old cluster. (Extensions should be upgraded
> + later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
I propose this:
<para>
If the old cluster used shared-object files (or DLLs) for extensions
or other loadable modules, install recompiled versions of those files
onto the new cluster.
Do not install the extension themselves (i.e., do not run
<command>CREATE EXTENSION</command>), because extension definitions
will be carried forward from the old cluster.
</para>
<para>
Extensions can be upgraded after pg_upgrade completes using
<command>ALTER EXTENSION ... UPGRADE</command>, on a per-database
basis.
</para>
I suggest " ... for extensions or other loadable modules" because
loadable modules aren't necessarily for extensions. Also, it's
perfectly possible to have extension that don't have a loadable module.
I suggest "extension definitions ... carried forward" instead of
"extensions ... copied" (your proposed text) to avoid the idea that
files are copied; use it instead of "schema definitions ... upgraded"
(the current docs) to avoid the idea that they are actually upgraded;
also, "schema definition" seems a misleading term to use here.
I suggest "can be upgraded" rather than "should be upgraded" because
we're not making a recommendation, merely stating the fact that it is
possible to do so.
I suggest using the imperative mood, to be consistent with the
surrounding text. (Applies to the first para; the second para is
informative.)
I haven't seen it mentioned in the thread, but I think the final phrase
of this <step> should be a separate step,
<step>
<title>Copy custom full-text search files</title>
<para>
Copy any custom full text search file (dictionary, synonym, thesaurus,
stop word list) to the new server.
</para>
</step>
While this is closely related to extensions, it's completely different.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Sallah, I said NO camels! That's FIVE camels; can't you count?"
(Indiana Jones)
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-07-29 18:06 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 18:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
1 sibling, 1 reply; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 18:06 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Bruce Momjian <bruce@momjian.us>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Dave Cramer
On Thu, 29 Jul 2021 at 13:43, Alvaro Herrera <alvherre@alvh.no-ip.org>
wrote:
> On 2021-Jul-29, Bruce Momjian wrote:
>
> > + If the old cluster used extensions, whether from
> > + <filename>contrib</filename> or some other source, it used
> > + shared object files (or DLLs) to implement these extensions, e.g.,
> > + <filename>pgcrypto.so</filename>. Now, shared object files
> matching
> > + the new server binary must be installed in the new cluster, usually
> > + via operating system commands. Do not load the schema definitions,
> > + e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> > + will be copied from the old cluster. (Extensions should be
> upgraded
> > + later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
>
> I propose this:
>
> <para>
> If the old cluster used shared-object files (or DLLs) for extensions
> or other loadable modules, install recompiled versions of those files
> onto the new cluster.
> Do not install the extension themselves (i.e., do not run
> <command>CREATE EXTENSION</command>), because extension definitions
> will be carried forward from the old cluster.
> </para>
>
> <para>
> Extensions can be upgraded after pg_upgrade completes using
> <command>ALTER EXTENSION ... UPGRADE</command>, on a per-database
> basis.
> </para>
>
> I suggest " ... for extensions or other loadable modules" because
> loadable modules aren't necessarily for extensions. Also, it's
> perfectly possible to have extension that don't have a loadable module.
>
> I suggest "extension definitions ... carried forward" instead of
> "extensions ... copied" (your proposed text) to avoid the idea that
> files are copied; use it instead of "schema definitions ... upgraded"
> (the current docs) to avoid the idea that they are actually upgraded;
> also, "schema definition" seems a misleading term to use here.
>
I like "carried forward", however it presumes quite a bit of knowledge of
what is going on inside pg_upgrade.
That said I don't have a better option short of explaining the whole thing
which is clearly out of scope.
>
> I suggest "can be upgraded" rather than "should be upgraded" because
> we're not making a recommendation, merely stating the fact that it is
> possible to do so.
>
> Why not recommend it? I was going to suggest that we actually run alter
extension upgrade ... on all of them as a solution.
What are the downsides to upgrading them all by default ? AFAIK if they
need upgrading this should run all of the SQL scripts, if they don't then
this should be a NO-OP.
Dave
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 18:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 18:19 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:08 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 102+ messages in thread
From: Alvaro Herrera @ 2021-07-29 18:19 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Jul-29, Dave Cramer wrote:
> > I suggest "can be upgraded" rather than "should be upgraded" because
> > we're not making a recommendation, merely stating the fact that it is
> > possible to do so.
>
> Why not recommend it? I was going to suggest that we actually run alter
> extension upgrade ... on all of them as a solution.
>
> What are the downsides to upgrading them all by default ? AFAIK if they
> need upgrading this should run all of the SQL scripts, if they don't then
> this should be a NO-OP.
I'm not aware of any downsides, and I think it would be a good idea to
do so, but I also think that it would be good to sort out the docs
precisely (a backpatchable doc change, IMV) and once that is done we can
discuss how to improve pg_upgrade so that users no longer need to do
that (a non-backpatchable code change). Incremental improvements and
all that ...
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"La libertad es como el dinero; el que no la sabe emplear la pierde" (Alvarez)
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 18:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 18:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-07-29 19:08 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 19:08 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Dave Cramer <davecramer@gmail.com>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 02:19:17PM -0400, Álvaro Herrera wrote:
> On 2021-Jul-29, Dave Cramer wrote:
>
> > > I suggest "can be upgraded" rather than "should be upgraded" because
> > > we're not making a recommendation, merely stating the fact that it is
> > > possible to do so.
> >
> > Why not recommend it? I was going to suggest that we actually run alter
> > extension upgrade ... on all of them as a solution.
> >
> > What are the downsides to upgrading them all by default ? AFAIK if they
> > need upgrading this should run all of the SQL scripts, if they don't then
> > this should be a NO-OP.
>
> I'm not aware of any downsides, and I think it would be a good idea to
> do so, but I also think that it would be good to sort out the docs
> precisely (a backpatchable doc change, IMV) and once that is done we can
> discuss how to improve pg_upgrade so that users no longer need to do
> that (a non-backpatchable code change). Incremental improvements and
> all that ...
Agreed. I don't think we have any consistent set of steps for detecting
and upgrading extensions --- that needs a lot more research.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2021-07-29 19:06 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-08-03 15:39 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 2 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 19:06 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Dave Cramer <davecramer@gmail.com>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 01:43:09PM -0400, Álvaro Herrera wrote:
> On 2021-Jul-29, Bruce Momjian wrote:
>
> > + If the old cluster used extensions, whether from
> > + <filename>contrib</filename> or some other source, it used
> > + shared object files (or DLLs) to implement these extensions, e.g.,
> > + <filename>pgcrypto.so</filename>. Now, shared object files matching
> > + the new server binary must be installed in the new cluster, usually
> > + via operating system commands. Do not load the schema definitions,
> > + e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> > + will be copied from the old cluster. (Extensions should be upgraded
> > + later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
>
> I propose this:
>
> <para>
> If the old cluster used shared-object files (or DLLs) for extensions
> or other loadable modules, install recompiled versions of those files
> onto the new cluster.
> Do not install the extension themselves (i.e., do not run
> <command>CREATE EXTENSION</command>), because extension definitions
> will be carried forward from the old cluster.
> </para>
>
> <para>
> Extensions can be upgraded after pg_upgrade completes using
> <command>ALTER EXTENSION ... UPGRADE</command>, on a per-database
> basis.
> </para>
>
> I suggest " ... for extensions or other loadable modules" because
> loadable modules aren't necessarily for extensions. Also, it's
> perfectly possible to have extension that don't have a loadable module.
Yes, good point.
> I suggest "extension definitions ... carried forward" instead of
> "extensions ... copied" (your proposed text) to avoid the idea that
> files are copied; use it instead of "schema definitions ... upgraded"
> (the current docs) to avoid the idea that they are actually upgraded;
> also, "schema definition" seems a misleading term to use here.
I used the term "duplicated".
> I suggest "can be upgraded" rather than "should be upgraded" because
> we're not making a recommendation, merely stating the fact that it is
> possible to do so.
Agreed. Most extensions don't have updates between major versions.
> I suggest using the imperative mood, to be consistent with the
> surrounding text. (Applies to the first para; the second para is
> informative.)
OK.
> I haven't seen it mentioned in the thread, but I think the final phrase
> of this <step> should be a separate step,
>
> <step>
> <title>Copy custom full-text search files</title>
> <para>
> Copy any custom full text search file (dictionary, synonym, thesaurus,
> stop word list) to the new server.
> </para>
> </step>
>
> While this is closely related to extensions, it's completely different.
Agreed. See attached patch.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
pg_upgrade.diff (text/x-diff, 2.2K) download
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..0a71465805 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -299,17 +299,27 @@ make prefix=/usr/local/pgsql.new install
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install any custom shared object files (or DLLs) used by the old cluster
- into the new cluster, e.g., <filename>pgcrypto.so</filename>,
- whether they are from <filename>contrib</filename>
- or some other source. Do not install the schema definitions, e.g.,
- <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
- from the old cluster.
- Also, any custom full text search files (dictionary, synonym,
- thesaurus, stop words) must also be copied to the new cluster.
+ Many extensions and custom modules, whether from
+ <filename>contrib</filename> or another source, use shared object
+ files (or DLLs), e.g., <filename>pgcrypto.so</filename>. If the old
+ cluster used these, shared object files matching the new server binary
+ must be installed in the new cluster, usually via operating system
+ commands. Do not load the schema definitions, e.g., <command>CREATE
+ EXTENSION pgcrypto</command>, because these will be duplicated from
+ the old cluster. (Extensions with available updates can be processed
+ later using <literal>ALTER EXTENSION ... UPDATE</literal>.)
+ </para>
+ </step>
+
+ <step>
+ <title>Copy custom full-text search files</title>
+
+ <para>
+ Copy any custom full text search files (dictionary, synonym,
+ thesaurus, stop words) from the old to the new cluster.
</para>
</step>
@@ -494,10 +504,10 @@ pg_upgrade.exe
</step>
<step>
- <title>Install custom shared object files</title>
+ <title>Install extension shared object files</title>
<para>
- Install the same custom shared object files on the new standbys
+ Install the same extension shared object files on the new standbys
that you installed in the new primary cluster.
</para>
</step>
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 19:27 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 19:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 2 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 19:27 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Dave Cramer
On Thu, 29 Jul 2021 at 15:06, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jul 29, 2021 at 01:43:09PM -0400, Álvaro Herrera wrote:
> > On 2021-Jul-29, Bruce Momjian wrote:
> >
> > > + If the old cluster used extensions, whether from
> > > + <filename>contrib</filename> or some other source, it used
> > > + shared object files (or DLLs) to implement these extensions,
> e.g.,
> > > + <filename>pgcrypto.so</filename>. Now, shared object files
> matching
> > > + the new server binary must be installed in the new cluster,
> usually
> > > + via operating system commands. Do not load the schema
> definitions,
> > > + e.g., <command>CREATE EXTENSION pgcrypto</command>, because these
> > > + will be copied from the old cluster. (Extensions should be
> upgraded
> > > + later using <literal>ALTER EXTENSION ... UPGRADE</literal>.)
> >
> > I propose this:
> >
> > <para>
> > If the old cluster used shared-object files (or DLLs) for extensions
> > or other loadable modules, install recompiled versions of those files
> > onto the new cluster.
> > Do not install the extension themselves (i.e., do not run
> > <command>CREATE EXTENSION</command>), because extension definitions
> > will be carried forward from the old cluster.
> > </para>
> >
> > <para>
> > Extensions can be upgraded after pg_upgrade completes using
> > <command>ALTER EXTENSION ... UPGRADE</command>, on a per-database
> > basis.
> > </para>
> >
> > I suggest " ... for extensions or other loadable modules" because
> > loadable modules aren't necessarily for extensions. Also, it's
> > perfectly possible to have extension that don't have a loadable module.
>
> Yes, good point.
>
> > I suggest "extension definitions ... carried forward" instead of
> > "extensions ... copied" (your proposed text) to avoid the idea that
> > files are copied; use it instead of "schema definitions ... upgraded"
> > (the current docs) to avoid the idea that they are actually upgraded;
> > also, "schema definition" seems a misleading term to use here.
>
> I used the term "duplicated".
>
> > I suggest "can be upgraded" rather than "should be upgraded" because
> > we're not making a recommendation, merely stating the fact that it is
> > possible to do so.
>
> Agreed. Most extensions don't have updates between major versions.
>
> > I suggest using the imperative mood, to be consistent with the
> > surrounding text. (Applies to the first para; the second para is
> > informative.)
>
> OK.
>
> > I haven't seen it mentioned in the thread, but I think the final phrase
> > of this <step> should be a separate step,
> >
> > <step>
> > <title>Copy custom full-text search files</title>
> > <para>
> > Copy any custom full text search file (dictionary, synonym, thesaurus,
> > stop word list) to the new server.
> > </para>
> > </step>
> >
> > While this is closely related to extensions, it's completely different.
>
> Agreed. See attached patch.
>
So back to the original motivation for bringing this up. Recall that a
cluster was upgraded. Everything appeared to work fine, except that the
definitions of the functions were slightly different enough to cause a
fatal issue on restoring a dump from pg_dump.
Since pg_upgrade is now part of the core project, we need to make sure this
is not possible or be much more insistent that the user needs to upgrade
any extensions that require it.
I believe we should be doing more than making a recommendation.
Dave
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 19:56 ` David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 19:56 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Alvaro Herrera <alvherre@alvh.no-ip.org>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 12:28 PM Dave Cramer <davecramer@gmail.com> wrote:
> So back to the original motivation for bringing this up. Recall that a
> cluster was upgraded. Everything appeared to work fine, except that the
> definitions of the functions were slightly different enough to cause a
> fatal issue on restoring a dump from pg_dump.
> Since pg_upgrade is now part of the core project, we need to make sure
> this is not possible or be much more insistent that the user needs to
> upgrade any extensions that require it.
>
I'm missing something here because I do not recall that level of detail
being provided. The first email was simply an observation that the
pg_upgraded version and the create extension version were different in the
new cluster - which is working as designed (opinions of said design, at
least right here and now, are immaterial).
From your piecemeal follow-on descriptions I do see that pg_dump seems to
be involved - though a self-contained demonstration is not available that I
can find. But so far as pg_dump is concerned it just needs to export the
current version each database is running for a given extension, and
pg_restore issue a CREATE EXTENSION for the same version when prompted. I
presume it does this correctly but admittedly haven't checked. IOW, if
pg_dump is failing here it is more likely its own bug and should be fixed
rather than blame pg_upgrade. Or its pg_stat_statement's bug and it should
be fixed.
In theory the procedure and requirements imposed by pg_upgrade here seem
reasonable. Fewer moving parts during the upgrade is strictly better. The
documentation was not clear on how things worked, and so its being cleaned
up, but the how hasn't been shown yet to be a problem nor that simply
running alter extension would be an appropriate solution for this single
case let alone in general. Since running alter extension manually is
simple constructing such a test case and proving that the alter extension
at least works for it should be straight-forward.
Without that I cannot support changing the behavior or even saying that
users must run alter extension manually to overcome a limitation in
pg_upgrade. They should do so in order to keep their code base current and
running supported code - but that is a judgement we've always left to the
DBA, with the exception of strongly discouraging not updating to the newest
point release and getting off unsupported major releases.
David J.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
@ 2021-07-29 21:01 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 1 reply; 102+ messages in thread
From: Tom Lane @ 2021-07-29 21:01 UTC (permalink / raw)
To: Dave Cramer <davecramer@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Dave Cramer <davecramer@gmail.com> writes:
> So back to the original motivation for bringing this up. Recall that a
> cluster was upgraded. Everything appeared to work fine, except that the
> definitions of the functions were slightly different enough to cause a
> fatal issue on restoring a dump from pg_dump.
> Since pg_upgrade is now part of the core project, we need to make sure this
> is not possible or be much more insistent that the user needs to upgrade
> any extensions that require it.
TBH, this seems like mostly the fault of the extension author.
The established design is that the SQL-level objects will be
carried forward verbatim by pg_upgrade. Therefore, any newer-version
shared library MUST be able to cope sanely with SQL objects from
some previous revision. The contrib modules provide multiple
examples of ways to do this.
If particular extension authors don't care to go to that much
trouble, it's on their heads to document that their extensions
are unsafe to pg_upgrade.
regards, tom lane
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-07-29 22:11 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 22:11 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 05:01:24PM -0400, Tom Lane wrote:
> Dave Cramer <davecramer@gmail.com> writes:
> > So back to the original motivation for bringing this up. Recall that a
> > cluster was upgraded. Everything appeared to work fine, except that the
> > definitions of the functions were slightly different enough to cause a
> > fatal issue on restoring a dump from pg_dump.
> > Since pg_upgrade is now part of the core project, we need to make sure this
> > is not possible or be much more insistent that the user needs to upgrade
> > any extensions that require it.
>
> TBH, this seems like mostly the fault of the extension author.
> The established design is that the SQL-level objects will be
> carried forward verbatim by pg_upgrade. Therefore, any newer-version
> shared library MUST be able to cope sanely with SQL objects from
> some previous revision. The contrib modules provide multiple
> examples of ways to do this.
>
> If particular extension authors don't care to go to that much
> trouble, it's on their heads to document that their extensions
> are unsafe to pg_upgrade.
I think we need to first give clear instructions on how to find out if
an extension update is available, and then how to update it. I am
thinking we should supply a query which reports all extensions that can
be upgraded, at least for contrib.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 22:19 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-30 16:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
0 siblings, 2 replies; 102+ messages in thread
From: Tom Lane @ 2021-07-29 22:19 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Bruce Momjian <bruce@momjian.us> writes:
> I think we need to first give clear instructions on how to find out if
> an extension update is available, and then how to update it. I am
> thinking we should supply a query which reports all extensions that can
> be upgraded, at least for contrib.
I suggested awhile ago that pg_upgrade should look into
pg_available_extensions in the new cluster, and prepare
a script with ALTER EXTENSION UPDATE commands for
anything that's installed but is not the (new cluster's)
default version.
regards, tom lane
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-07-29 22:26 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 22:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 22:26 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I think we need to first give clear instructions on how to find out if
> > an extension update is available, and then how to update it. I am
> > thinking we should supply a query which reports all extensions that can
> > be upgraded, at least for contrib.
>
> I suggested awhile ago that pg_upgrade should look into
> pg_available_extensions in the new cluster, and prepare
> a script with ALTER EXTENSION UPDATE commands for
> anything that's installed but is not the (new cluster's)
> default version.
I can do that, but I would think a pg_dump/restore would also have this
issue, so should this be more generic? If we had a doc section about
that, we could add it a step to run in the pg_upgrade instructions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 22:29 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:38 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 102+ messages in thread
From: Tom Lane @ 2021-07-29 22:29 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Bruce Momjian <bruce@momjian.us> writes:
> On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
>> I suggested awhile ago that pg_upgrade should look into
>> pg_available_extensions in the new cluster, and prepare
>> a script with ALTER EXTENSION UPDATE commands for
>> anything that's installed but is not the (new cluster's)
>> default version.
> I can do that, but I would think a pg_dump/restore would also have this
> issue, so should this be more generic?
No, because dump/restore does not have this issue. Regular pg_dump just
issues "CREATE EXTENSION" commands, so you automatically get the target
server's default version.
regards, tom lane
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-07-29 22:38 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 23:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 23:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 2 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 22:38 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 06:29:11PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
> >> I suggested awhile ago that pg_upgrade should look into
> >> pg_available_extensions in the new cluster, and prepare
> >> a script with ALTER EXTENSION UPDATE commands for
> >> anything that's installed but is not the (new cluster's)
> >> default version.
>
> > I can do that, but I would think a pg_dump/restore would also have this
> > issue, so should this be more generic?
>
> No, because dump/restore does not have this issue. Regular pg_dump just
> issues "CREATE EXTENSION" commands, so you automatically get the target
> server's default version.
Oh, so pg_upgrade does it differently so the oids are preserved?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:38 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 23:06 ` Dave Cramer <davecramer@gmail.com>
1 sibling, 0 replies; 102+ messages in thread
From: Dave Cramer @ 2021-07-29 23:06 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 29 Jul 2021 at 18:39, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Jul 29, 2021 at 06:29:11PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
> > >> I suggested awhile ago that pg_upgrade should look into
> > >> pg_available_extensions in the new cluster, and prepare
> > >> a script with ALTER EXTENSION UPDATE commands for
> > >> anything that's installed but is not the (new cluster's)
> > >> default version.
> >
> > > I can do that, but I would think a pg_dump/restore would also have this
> > > issue, so should this be more generic?
> >
> > No, because dump/restore does not have this issue. Regular pg_dump just
> > issues "CREATE EXTENSION" commands, so you automatically get the target
> > server's default version.
>
> Oh, so pg_upgrade does it differently so the oids are preserved?
>
>
I suspect this is part of --binary_upgrade mode
Dave
> --
> Bruce Momjian <bruce@momjian.us> https://momjian.us
> EDB https://enterprisedb.com
>
> If only the physical world exists, free will is an illusion.
>
>
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:29 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:38 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-07-29 23:26 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
1 sibling, 0 replies; 102+ messages in thread
From: Alvaro Herrera @ 2021-07-29 23:26 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Dave Cramer <davecramer@gmail.com>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2021-Jul-29, Bruce Momjian wrote:
> On Thu, Jul 29, 2021 at 06:29:11PM -0400, Tom Lane wrote:
> > No, because dump/restore does not have this issue. Regular pg_dump just
> > issues "CREATE EXTENSION" commands, so you automatically get the target
> > server's default version.
>
> Oh, so pg_upgrade does it differently so the oids are preserved?
Have a look at pg_dump --binary-upgrade output :-)
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
"Ellos andaban todos desnudos como su madre los parió, y también las mujeres,
aunque no vi más que una, harto moza, y todos los que yo vi eran todos
mancebos, que ninguno vi de edad de más de XXX años" (Cristóbal Colón)
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
@ 2021-07-30 16:40 ` Bruce Momjian <bruce@momjian.us>
2021-08-03 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
1 sibling, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-07-30 16:40 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > I think we need to first give clear instructions on how to find out if
> > an extension update is available, and then how to update it. I am
> > thinking we should supply a query which reports all extensions that can
> > be upgraded, at least for contrib.
>
> I suggested awhile ago that pg_upgrade should look into
> pg_available_extensions in the new cluster, and prepare
> a script with ALTER EXTENSION UPDATE commands for
> anything that's installed but is not the (new cluster's)
> default version.
OK, done in this patch. I am assuming that everything that shows an
update in pg_available_extensions can use ALTER EXTENSION UPDATE. I
assume this would be backpatched to 9.6.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachments:
extension.diff (text/x-diff, 3.1K) download
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
index 0c47a6b8cc..ad5f391995 100644
--- a/src/bin/pg_upgrade/check.c
+++ b/src/bin/pg_upgrade/check.c
@@ -241,6 +241,8 @@ issue_warnings_and_set_wal_level(void)
if (GET_MAJOR_VERSION(old_cluster.major_version) <= 906)
old_9_6_invalidate_hash_indexes(&new_cluster, false);
+ report_extension_updates(&new_cluster);
+
stop_postmaster(false);
}
diff --git a/src/bin/pg_upgrade/pg_upgrade.h b/src/bin/pg_upgrade/pg_upgrade.h
index 7038ac12bf..ca0795f68f 100644
--- a/src/bin/pg_upgrade/pg_upgrade.h
+++ b/src/bin/pg_upgrade/pg_upgrade.h
@@ -455,6 +455,7 @@ void old_9_6_invalidate_hash_indexes(ClusterInfo *cluster,
bool check_mode);
void old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster);
+void report_extension_updates(ClusterInfo *cluster);
/* parallel.c */
void parallel_exec_prog(const char *log_file, const char *opt_log_file,
diff --git a/src/bin/pg_upgrade/version.c b/src/bin/pg_upgrade/version.c
index a3c193316d..b82afafd22 100644
--- a/src/bin/pg_upgrade/version.c
+++ b/src/bin/pg_upgrade/version.c
@@ -468,3 +468,81 @@ old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster)
else
check_ok();
}
+
+
+/*
+ * report_extension_updates()
+ * Report extensions that should be updated.
+ */
+void
+report_extension_updates(ClusterInfo *cluster)
+{
+ int dbnum;
+ FILE *script = NULL;
+ bool found = false;
+ char *output_path = "update_extensions.sql";
+
+ prep_status("Checking for extension updates");
+
+ for (dbnum = 0; dbnum < cluster->dbarr.ndbs; dbnum++)
+ {
+ PGresult *res;
+ bool db_used = false;
+ int ntups;
+ int rowno;
+ int i_name;
+ DbInfo *active_db = &cluster->dbarr.dbs[dbnum];
+ PGconn *conn = connectToServer(cluster, active_db->db_name);
+
+ /* find hash indexes */
+ res = executeQueryOrDie(conn,
+ "SELECT name "
+ "FROM pg_available_extensions "
+ "WHERE installed_version != default_version"
+ );
+
+ ntups = PQntuples(res);
+ i_name = PQfnumber(res, "name");
+ for (rowno = 0; rowno < ntups; rowno++)
+ {
+ found = true;
+
+ if (script == NULL && (script = fopen_priv(output_path, "w")) == NULL)
+ pg_fatal("could not open file \"%s\": %s\n", output_path,
+ strerror(errno));
+ if (!db_used)
+ {
+ PQExpBufferData connectbuf;
+
+ initPQExpBuffer(&connectbuf);
+ appendPsqlMetaConnect(&connectbuf, active_db->db_name);
+ fputs(connectbuf.data, script);
+ termPQExpBuffer(&connectbuf);
+ db_used = true;
+ }
+ fprintf(script, "ALTER EXTENSION %s UPDATE;\n",
+ quote_identifier(PQgetvalue(res, rowno, i_name)));
+ }
+
+ PQclear(res);
+
+ PQfinish(conn);
+ }
+
+ if (script)
+ fclose(script);
+
+ if (found)
+ {
+ report_status(PG_REPORT, "notice");
+ pg_log(PG_REPORT, "\n"
+ "Your installation contains extensions that should be updated\n"
+ "with the ALTER EXTENSION command. The file\n"
+ " %s\n"
+ "when executed by psql by the database superuser will update\n"
+ "these extensions.\n\n",
+ output_path);
+ }
+ else
+ check_ok();
+}
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-30 16:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-08-03 16:00 ` Bruce Momjian <bruce@momjian.us>
2021-08-03 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Justin Pryzby <pryzby@telsasoft.com>
0 siblings, 1 reply; 102+ messages in thread
From: Bruce Momjian @ 2021-08-03 16:00 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Jul 30, 2021 at 12:40:06PM -0400, Bruce Momjian wrote:
> On Thu, Jul 29, 2021 at 06:19:56PM -0400, Tom Lane wrote:
> > Bruce Momjian <bruce@momjian.us> writes:
> > > I think we need to first give clear instructions on how to find out if
> > > an extension update is available, and then how to update it. I am
> > > thinking we should supply a query which reports all extensions that can
> > > be upgraded, at least for contrib.
> >
> > I suggested awhile ago that pg_upgrade should look into
> > pg_available_extensions in the new cluster, and prepare
> > a script with ALTER EXTENSION UPDATE commands for
> > anything that's installed but is not the (new cluster's)
> > default version.
>
> OK, done in this patch. I am assuming that everything that shows an
> update in pg_available_extensions can use ALTER EXTENSION UPDATE. I
> assume this would be backpatched to 9.6.
Patch applied through 9.6.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-30 16:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-08-03 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-08-03 16:13 ` Justin Pryzby <pryzby@telsasoft.com>
2021-08-03 16:26 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
0 siblings, 1 reply; 102+ messages in thread
From: Justin Pryzby @ 2021-08-03 16:13 UTC (permalink / raw)
To: Bruce Momjian <bruce@momjian.us>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; pgsql-hackers@lists.postgresql.org
On Tue, Aug 03, 2021 at 12:00:47PM -0400, Bruce Momjian wrote:
> Patch applied through 9.6.
The comment seems to be a leftover from a copy pasto.
+ /* find hash indexes */
+ res = executeQueryOrDie(conn,
+ "SELECT name "
+ "FROM pg_available_extensions "
+ "WHERE installed_version != default_version"
+ );
--
Justin
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 21:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-30 16:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-08-03 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-08-03 16:13 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Justin Pryzby <pryzby@telsasoft.com>
@ 2021-08-03 16:26 ` Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-08-03 16:26 UTC (permalink / raw)
To: Justin Pryzby <pryzby@telsasoft.com>; +Cc: Tom Lane <tgl@sss.pgh.pa.us>; Dave Cramer <davecramer@gmail.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; David G. Johnston <david.g.johnston@gmail.com>; pgsql-hackers@lists.postgresql.org
On Tue, Aug 3, 2021 at 11:13:45AM -0500, Justin Pryzby wrote:
> On Tue, Aug 03, 2021 at 12:00:47PM -0400, Bruce Momjian wrote:
> > Patch applied through 9.6.
>
> The comment seems to be a leftover from a copy pasto.
>
> + /* find hash indexes */
> + res = executeQueryOrDie(conn,
> + "SELECT name "
> + "FROM pg_available_extensions "
> + "WHERE installed_version != default_version"
> + );
Thanks much, fixed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 17:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:06 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
@ 2021-08-03 15:39 ` Bruce Momjian <bruce@momjian.us>
1 sibling, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-08-03 15:39 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Dave Cramer <davecramer@gmail.com>; David G. Johnston <david.g.johnston@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 03:06:45PM -0400, Bruce Momjian wrote:
> > I haven't seen it mentioned in the thread, but I think the final phrase
> > of this <step> should be a separate step,
> >
> > <step>
> > <title>Copy custom full-text search files</title>
> > <para>
> > Copy any custom full text search file (dictionary, synonym, thesaurus,
> > stop word list) to the new server.
> > </para>
> > </step>
> >
> > While this is closely related to extensions, it's completely different.
>
> Agreed. See attached patch.
Doc patch applied to all supported versions.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 16:28 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 16:44 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-29 16:28 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; Bruce Momjian <bruce@momjian.us>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/29/21 12:00 PM, David G. Johnston wrote:
> Ok, looking at the flow again, where exactly would the user even be able
> to execute "CREATE EXTENSION" meaningfully? The relevant databases do
> not exist (not totally sure what happens to the postgres database
> created during the initdb step...) so at the point where the user is
> "installing the extension" all they can reasonably do is a server-level
> install (they could maybe create extension in the postgres database, but
> does that even matter?).
>
> So, I'd propose simplifying this all to something like:
>
> Install extensions on the new server
Extensions are not installed on the server level. Their binary
components (shared objects) are, but the actual catalog modifications
that make them accessible are performed per database by CREATE
EXTENSION, which executes the SQL files associated with the extension.
And they can be performed differently per database, like for example
placing one and the same extension into different schemas in different
databases.
pg_upgrade is not (and should not be) concerned with placing the
extension's installation components into the new version's lib and share
directories. But it is pg_upgrade's job to perform the correct catalog
modification per database during the upgrade.
> Any extensions that are used by the old cluster need to be installed
> into the new cluster. Each database in the old cluster will have its
> current version of all extensions migrated to the new cluster as-is.
> You can use the ALTER EXTENSION command, on a per-database basis, to
> update its extensions post-upgrade.
That assumes that the extension SQL files are capable of detecting a
server version change and perform the necessary (if any) steps to alter
the extension's objects accordingly.
Off the top of my head I don't remember what happens when one executes
ALTER EXTENSION ... UPGRADE ... when it is already on the latest version
*of the extension*. Might be an error or a no-op.
And to make matters worse, it is not possible to work around this with a
DROP EXTENSION ... CREATE EXTENSION. There are extensions that create
objects, like user defined data types and functions, that will be
referenced by end user objects like tables and views.
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-29 16:44 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:55 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
0 siblings, 1 reply; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 16:44 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: Bruce Momjian <bruce@momjian.us>; Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 9:28 AM Jan Wieck <jan@wi3ck.info> wrote:
> On 7/29/21 12:00 PM, David G. Johnston wrote:
> > Ok, looking at the flow again, where exactly would the user even be able
> > to execute "CREATE EXTENSION" meaningfully? The relevant databases do
> > not exist (not totally sure what happens to the postgres database
> > created during the initdb step...) so at the point where the user is
> > "installing the extension" all they can reasonably do is a server-level
> > install (they could maybe create extension in the postgres database, but
> > does that even matter?).
> >
> > So, I'd propose simplifying this all to something like:
> >
> > Install extensions on the new server
>
> Extensions are not installed on the server level. Their binary
> components (shared objects) are, but the actual catalog modifications
> that make them accessible are performed per database by CREATE
> EXTENSION, which executes the SQL files associated with the extension.
> And they can be performed differently per database, like for example
> placing one and the same extension into different schemas in different
> databases.
>
> pg_upgrade is not (and should not be) concerned with placing the
> extension's installation components into the new version's lib and share
> directories. But it is pg_upgrade's job to perform the correct catalog
> modification per database during the upgrade.
>
That is exactly the point I am making. The section is informing the user
of things to do that the server will not do. Which is "install extension
code into the O/S" and that mentioning CREATE EXTENSION at this point in
the process is talking about something that is simply out-of-scope.
> > Any extensions that are used by the old cluster need to be installed
> > into the new cluster. Each database in the old cluster will have its
> > current version of all extensions migrated to the new cluster as-is.
> > You can use the ALTER EXTENSION command, on a per-database basis, to
> > update its extensions post-upgrade.
>
> That assumes that the extension SQL files are capable of detecting a
> server version change and perform the necessary (if any) steps to alter
> the extension's objects accordingly.
>
> Off the top of my head I don't remember what happens when one executes
> ALTER EXTENSION ... UPGRADE ... when it is already on the latest version
> *of the extension*. Might be an error or a no-op.
>
> And to make matters worse, it is not possible to work around this with a
> DROP EXTENSION ... CREATE EXTENSION. There are extensions that create
> objects, like user defined data types and functions, that will be
> referenced by end user objects like tables and views.
>
>
These are all excellent points - but at present pg_upgrade simply doesn't
care and hopes that the extension author's documentation deals with these
possibilities in a sane manner.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:44 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 16:55 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 17:05 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 102+ messages in thread
From: Jan Wieck @ 2021-07-29 16:55 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 7/29/21 12:44 PM, David G. Johnston wrote:
> ... - but at present pg_upgrade simply
> doesn't care and hopes that the extension author's documentation deals
> with these possibilities in a sane manner.
pg_upgrade is not able to address this in a guaranteed, consistent
fashion. At this point there is no way to even make sure that a 3rd
party extension provides the scripts needed to upgrade from one
extension version to the next. We don't have the mechanism to upgrade
the same extension version from one server version to the next, in case
there are any modifications in place necessary.
How exactly do you envision that we, the PostgreSQL project, make sure
that extension developers provide those mechanisms in the future?
Regards, Jan
--
Jan Wieck
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-29 15:42 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
2021-07-29 16:44 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:55 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Jan Wieck <jan@wi3ck.info>
@ 2021-07-29 17:05 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 102+ messages in thread
From: David G. Johnston @ 2021-07-29 17:05 UTC (permalink / raw)
To: Jan Wieck <jan@wi3ck.info>; +Cc: Bruce Momjian <bruce@momjian.us>; Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 9:55 AM Jan Wieck <jan@wi3ck.info> wrote:
> How exactly do you envision that we, the PostgreSQL project, make sure
> that extension developers provide those mechanisms in the future?
>
>
I have no suggestions here, and don't really plan to get deeply involved in
this area of the project anytime soon. But it is definitely a topic worthy
of discussion on a new thread.
David J.
^ permalink raw reply [nested|flat] 102+ messages in thread
* Re: pg_upgrade does not upgrade pg_stat_statements properly
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 19:43 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 01:52 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 14:56 ` Re: pg_upgrade does not upgrade pg_stat_statements properly Bruce Momjian <bruce@momjian.us>
2021-07-29 15:28 ` Re: pg_upgrade does not upgrade pg_stat_statements properly David G. Johnston <david.g.johnston@gmail.com>
@ 2021-07-29 15:40 ` Bruce Momjian <bruce@momjian.us>
1 sibling, 0 replies; 102+ messages in thread
From: Bruce Momjian @ 2021-07-29 15:40 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Dave Cramer <davecramer@gmail.com>; Tom Lane <tgl@sss.pgh.pa.us>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, Jul 29, 2021 at 08:28:12AM -0700, David G. Johnston wrote:
> On Thu, Jul 29, 2021 at 7:56 AM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Wed, Jul 28, 2021 at 09:35:28PM -0700, David G. Johnston wrote:
> > On Wed, Jul 28, 2021 at 6:52 PM Bruce Momjian <bruce@momjian.us> wrote:
> >
> > I came up with the attached patch.
> >
> >
> > Thank you. It is an improvement but I think more could be done here (not
> > exactly sure what - though removing the "copy binaries for contrib
> modules from
> > the old server" seems like a decent second step.)
>
> Uh, I don't see that text.
> """
> 5. Install custom shared object files
>
> Install any custom shared object files (or DLLs) used by the old cluster into
> the new cluster, e.g., pgcrypto.so, whether they are from contrib or some other
> source. Do not install the schema definitions, e.g., CREATE EXTENSION pgcrypto,
> because these will be upgraded from the old cluster. Also, any custom full text
> search files (dictionary, synonym, thesaurus, stop words) must also be copied
> to the new cluster.
> """
> I have an issue with the fragment "whether they are from contrib" - my
> understanding at this point is that because of the way we package and version
> contrib it should not be necessary to copy those shared object files from the
> old to the new server (maybe, just maybe, with a qualification that you are
> upgrading between two versions that were in support during the same time
> period).
OK, so this is the confusion I was talking about. You are supposed to
install _new_ _versions_ of the extensions that are in the old cluster
to the new cluster. You are not supposed to _copy_ the files from the
old to new cluster. I think my new patch makes that clearer, but can it
be improved?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
^ permalink raw reply [nested|flat] 102+ messages in thread
end of thread, other threads:[~2021-08-03 16:26 UTC | newest]
Thread overview: 102+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-07-14 18:38 pg_upgrade does not upgrade pg_stat_statements properly Dave Cramer <davecramer@gmail.com>
2021-07-14 18:47 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 18:58 ` Dave Cramer <davecramer@gmail.com>
2021-07-14 19:09 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:21 ` Dave Cramer <davecramer@gmail.com>
2021-07-14 19:33 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-14 19:43 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-15 11:40 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 15:01 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:09 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 15:17 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:15 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:21 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 15:29 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 15:43 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 16:11 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:13 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-15 16:16 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 16:25 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:35 ` Dave Cramer <davecramer@gmail.com>
2021-07-15 16:35 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 16:46 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:58 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 17:10 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:14 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 18:26 ` Bruce Momjian <bruce@momjian.us>
2021-07-15 18:30 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 18:51 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-15 20:24 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 23:18 ` Jan Wieck <jan@wi3ck.info>
2021-07-15 23:31 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:15 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-15 16:31 ` Robert Eckhardt <eckhardtr@vmware.com>
2021-07-15 16:38 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 01:52 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 04:35 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 11:02 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 14:56 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 15:01 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 15:10 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 15:17 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 15:24 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 15:46 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 16:14 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 18:04 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-29 18:14 ` Jan Wieck <jan@wi3ck.info>
2021-07-30 02:02 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:03 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 10:39 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 10:48 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:07 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:18 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:28 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 11:33 ` Dave Cramer <davecramer@postgres.rocks>
2021-07-30 11:40 ` Julien Rouhaud <rjuju123@gmail.com>
2021-07-30 16:44 ` Jan Wieck <jan@wi3ck.info>
2021-07-30 16:43 ` Jan Wieck <jan@wi3ck.info>
2021-07-30 17:05 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-30 17:28 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 15:28 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:36 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 15:39 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:46 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 16:12 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 15:42 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 16:00 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:16 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 16:22 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 16:34 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 17:00 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 17:10 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 17:13 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 17:15 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 18:28 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 18:35 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 18:38 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 18:36 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 17:43 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 18:06 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 18:19 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-29 19:08 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 19:06 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 19:27 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 19:56 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 21:01 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:11 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 22:19 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:26 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 22:29 ` Tom Lane <tgl@sss.pgh.pa.us>
2021-07-29 22:38 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 23:06 ` Dave Cramer <davecramer@gmail.com>
2021-07-29 23:26 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2021-07-30 16:40 ` Bruce Momjian <bruce@momjian.us>
2021-08-03 16:00 ` Bruce Momjian <bruce@momjian.us>
2021-08-03 16:13 ` Justin Pryzby <pryzby@telsasoft.com>
2021-08-03 16:26 ` Bruce Momjian <bruce@momjian.us>
2021-08-03 15:39 ` Bruce Momjian <bruce@momjian.us>
2021-07-29 16:28 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 16:44 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 16:55 ` Jan Wieck <jan@wi3ck.info>
2021-07-29 17:05 ` David G. Johnston <david.g.johnston@gmail.com>
2021-07-29 15:40 ` Bruce Momjian <bruce@momjian.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox