public inbox for [email protected]
help / color / mirror / Atom feedRequire suggestions for Issue #2874
33+ messages / 7 participants
[nested] [flat]
* Require suggestions for Issue #2874
@ 2024-09-04 11:38 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-04 11:38 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
I have made the necessary changes for issue #2874
<https://github.com/pgadmin-org/pgadmin4/issues/2874; based on the theme
requirements.
I have attached screenshots showing how the updates look across all themes
for your reference.
If the current color does not fit well with the theme or if you have any
suggestions for improvements, please let me know.
Thanks,
Rohit Bhati
EnterpriseDB
Attachments:
[image/png] dark.png (122.4K, ../../CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com/3-dark.png)
download | view image
[image/png] light.png (134.3K, ../../CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com/4-light.png)
download | view image
[image/png] high-contrast.png (150.4K, ../../CABscKVgnoB8=KcYSa0tp8LAwdw4Gq4-G5ywcmWz353jtH8RH1A@mail.gmail.com/5-high-contrast.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-05 07:27 ` Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-05 07:27 UTC (permalink / raw)
To: pgadmin-hackers
Hi Hackers,
Please check the updated attached screenshot for an alternate background
color of table rows.
The images also shows alternate row color with some selected rows color
from the table.
Thanks,
Rohit Bhati
EnterpriseDB
On Wed, Sep 4, 2024 at 5:08 PM Rohit Bhati <[email protected]>
wrote:
> Hi Hackers,
>
> I have made the necessary changes for issue #2874
> <https://github.com/pgadmin-org/pgadmin4/issues/2874; based on the theme
> requirements.
>
> I have attached screenshots showing how the updates look across all themes
> for your reference.
>
> If the current color does not fit well with the theme or if you have any
> suggestions for improvements, please let me know.
>
> Thanks,
> Rohit Bhati
> EnterpriseDB
>
Attachments:
[image/png] HC.png (179.7K, ../../CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com/3-HC.png)
download | view image
[image/png] Dark-theme.png (144.8K, ../../CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com/4-Dark-theme.png)
download | view image
[image/png] Std.png (138.4K, ../../CABscKVg+1gh1CjPPX8k4_9A407hzfd8DTbP7e0U+-jcoO7awQg@mail.gmail.com/5-Std.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-05 10:21 ` Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-05 10:21 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <[email protected]>
wrote:
> Hi Hackers,
>
> Please check the updated attached screenshot for an alternate background
> color of table rows.
> The images also shows alternate row color with some selected rows color
> from the table.
>
>
I think that looks good. Are you making it a preference, so users that
prefer non-stripey grids can keep the current look?
Whilst you're hacking on that, I believe there is another ticket (which I
can't find right now) about changing the colour of the row number column to
give it better visual distinction from the data columns. Probably worth
working on that one at the same time?
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-05 11:19 ` Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-05 11:19 UTC (permalink / raw)
To: Dave Page <[email protected]>; pgadmin-hackers
Hi,
Currently it is just theme based, whenever the user changes the theme
accordingly the color changes.
Not for any specific preference option for this right now, But if we want
that we can add.
And if i am not wrong you are talking about this #7863
<https://github.com/pgadmin-org/pgadmin4/issues/7863; . If this is the
issue then I can work together on both.
Rohit Bhati
EnterpriseDB
On Thu, Sep 5, 2024 at 3:51 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Hackers,
>>
>> Please check the updated attached screenshot for an alternate background
>> color of table rows.
>> The images also shows alternate row color with some selected rows color
>> from the table.
>>
>>
> I think that looks good. Are you making it a preference, so users that
> prefer non-stripey grids can keep the current look?
>
> Whilst you're hacking on that, I believe there is another ticket (which I
> can't find right now) about changing the colour of the row number column to
> give it better visual distinction from the data columns. Probably worth
> working on that one at the same time?
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-05 11:32 ` Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-05 11:32 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
On Thu, 5 Sept 2024 at 12:19, Rohit Bhati <[email protected]>
wrote:
> Hi,
>
> Currently it is just theme based, whenever the user changes the theme
> accordingly the color changes.
> Not for any specific preference option for this right now, But if we want
> that we can add.
>
Let's just go with it for now, and if people don't like it, we can add a
preference.
>
> And if i am not wrong you are talking about this #7863
> <https://github.com/pgadmin-org/pgadmin4/issues/7863; . If this is the
> issue then I can work together on both.
>
Yes, that's the one :-)
>
>
> Rohit Bhati
> EnterpriseDB
>
> On Thu, Sep 5, 2024 at 3:51 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please check the updated attached screenshot for an alternate
>>> background color of table rows.
>>> The images also shows alternate row color with some selected rows color
>>> from the table.
>>>
>>>
>> I think that looks good. Are you making it a preference, so users that
>> prefer non-stripey grids can keep the current look?
>>
>> Whilst you're hacking on that, I believe there is another ticket (which I
>> can't find right now) about changing the colour of the row number column to
>> give it better visual distinction from the data columns. Probably worth
>> working on that one at the same time?
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-05 13:38 ` Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-05 13:38 UTC (permalink / raw)
To: Dave Page <[email protected]>; pgadmin-hackers
Hi,
I have made changes for issue #7863
<https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
requirements.
I have attached screenshots showing how the updates look across all themes
for your reference.
If the current color does not fit well with the theme or if you have any
suggestions for improvements, please let me know.
Note :- As I also follow this DBEAVER
<https://dbeaver.io/wp-content/uploads/2018/03/data_edit-450x220.png;
image which
the user shares on the issue #7863
<https://github.com/pgadmin-org/pgadmin4/issues/7863;.
Thanks,
Rohit Bhati
EnterpriseDB
On Thu, Sep 5, 2024 at 5:03 PM Rohit Bhati <[email protected]>
wrote:
> Ok
>
> On Thu, Sep 5, 2024 at 5:03 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, 5 Sept 2024 at 12:19, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> Currently it is just theme based, whenever the user changes the theme
>>> accordingly the color changes.
>>> Not for any specific preference option for this right now, But if we
>>> want that we can add.
>>>
>>
>> Let's just go with it for now, and if people don't like it, we can add a
>> preference.
>>
>>
>>>
>>> And if i am not wrong you are talking about this #7863
>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; . If this is the
>>> issue then I can work together on both.
>>>
>>
>> Yes, that's the one :-)
>>
>>
>>>
>>>
>>> Rohit Bhati
>>> EnterpriseDB
>>>
>>> On Thu, Sep 5, 2024 at 3:51 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, 5 Sept 2024 at 08:27, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please check the updated attached screenshot for an alternate
>>>>> background color of table rows.
>>>>> The images also shows alternate row color with some selected rows
>>>>> color from the table.
>>>>>
>>>>>
>>>> I think that looks good. Are you making it a preference, so users that
>>>> prefer non-stripey grids can keep the current look?
>>>>
>>>> Whilst you're hacking on that, I believe there is another ticket (which
>>>> I can't find right now) about changing the colour of the row number column
>>>> to give it better visual distinction from the data columns. Probably worth
>>>> working on that one at the same time?
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
Attachments:
[image/png] cell-dark.png (126.9K, ../../CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com/3-cell-dark.png)
download | view image
[image/png] cell-light.png (144.6K, ../../CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com/4-cell-light.png)
download | view image
[image/png] cell-highcontrast.png (148.3K, ../../CABscKVjEzXqeYu4LcHhAn1uhO5o3_-ALe1_bsK9UicOcEHq47A@mail.gmail.com/5-cell-highcontrast.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-05 13:41 ` Dave Page <[email protected]>
2024-09-06 04:39 ` Re: Require suggestions for Issue #2874 Yogesh Mahajan <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
0 siblings, 2 replies; 33+ messages in thread
From: Dave Page @ 2024-09-05 13:41 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
wrote:
> Hi,
>
> I have made changes for issue #7863
> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
> requirements.
>
> I have attached screenshots showing how the updates look across all themes
> for your reference.
>
> If the current color does not fit well with the theme or if you have any
> suggestions for improvements, please let me know.
>
Is the colour contrast high enough on the row numbers for selected rows in
the high contrast theme? The black on grey seems like it might not be to
me, but I haven't tested.
I wonder also if we should make the row numbers bold all the time. Thoughts?
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-06 04:39 ` Yogesh Mahajan <[email protected]>
1 sibling, 0 replies; 33+ messages in thread
From: Yogesh Mahajan @ 2024-09-06 04:39 UTC (permalink / raw)
To: Dave Page <[email protected]>; Rohit Bhati <[email protected]>; pgadmin-hackers
On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
Hi,
Hi
>
> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi,
>>
>> I have made changes for issue #7863
>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>> requirements.
>>
>> I have attached screenshots showing how the updates look across all
>> themes for your reference.
>>
>> If the current color does not fit well with the theme or if you have any
>> suggestions for improvements, please let me know.
>>
>
> Is the colour contrast high enough on the row numbers for selected rows in
> the high contrast theme? The black on grey seems like it might not be to
> me, but I haven't tested.
>
> I wonder also if we should make the row numbers bold all the time.
> Thoughts?
>
Yes. We should.
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-06 07:05 ` Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
1 sibling, 1 reply; 33+ messages in thread
From: Khushboo Vashi @ 2024-09-06 07:05 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Rohit Bhati <[email protected]>; pgadmin-hackers
On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi,
>>
>> I have made changes for issue #7863
>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>> requirements.
>>
>> I have attached screenshots showing how the updates look across all
>> themes for your reference.
>>
>> If the current color does not fit well with the theme or if you have any
>> suggestions for improvements, please let me know.
>>
>
> Is the colour contrast high enough on the row numbers for selected rows in
> the high contrast theme? The black on grey seems like it might not be to
> me, but I haven't tested.
>
> I wonder also if we should make the row numbers bold all the time.
> Thoughts?
>
We can check how it looks. Also the cell border doesn't look good to me.
>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
@ 2024-09-06 08:18 ` Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-06 08:18 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
I have removed the border and background color, just made the row numbers
bold.
I have attached screenshots showing how the updates look across all themes.
On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
[email protected]> wrote:
>
>
> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> I have made changes for issue #7863
>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>>> requirements.
>>>
>>> I have attached screenshots showing how the updates look across all
>>> themes for your reference.
>>>
>>> If the current color does not fit well with the theme or if you have any
>>> suggestions for improvements, please let me know.
>>>
>>
>> Is the colour contrast high enough on the row numbers for selected rows
>> in the high contrast theme? The black on grey seems like it might not be to
>> me, but I haven't tested.
>>
>> I wonder also if we should make the row numbers bold all the time.
>> Thoughts?
>>
> We can check how it looks. Also the cell border doesn't look good to me.
>
>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
Attachments:
[image/png] Bold-Dark.png (128.9K, ../../CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com/3-Bold-Dark.png)
download | view image
[image/png] bold-HC.png (145.1K, ../../CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com/4-bold-HC.png)
download | view image
[image/png] bold-std.png (140.3K, ../../CABscKViGC-C6dBx6c=M3TQvCXrM+KGXWED7cj9BX2uB7qNb0Tg@mail.gmail.com/5-bold-std.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-06 08:21 ` Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-06 08:21 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <[email protected]>
wrote:
> Hi,
>
> I have removed the border and background color, just made the row numbers
> bold.
>
> I have attached screenshots showing how the updates look across all themes
> .
>
That doesn't look bold at all to me - and I think we still need some other
visual distinction, such as the column background colour.
>
>
> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have made changes for issue #7863
>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>>>> requirements.
>>>>
>>>> I have attached screenshots showing how the updates look across all
>>>> themes for your reference.
>>>>
>>>> If the current color does not fit well with the theme or if you have
>>>> any suggestions for improvements, please let me know.
>>>>
>>>
>>> Is the colour contrast high enough on the row numbers for selected rows
>>> in the high contrast theme? The black on grey seems like it might not be to
>>> me, but I haven't tested.
>>>
>>> I wonder also if we should make the row numbers bold all the time.
>>> Thoughts?
>>>
>> We can check how it looks. Also the cell border doesn't look good to me.
>>
>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>
>>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-06 08:25 ` Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-06 08:25 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
I have made some more changes with changing background color.
I have attached screenshots showing how the updates look across all themes.
On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi,
>>
>> I have removed the border and background color, just made the row
>> numbers bold.
>>
>> I have attached screenshots showing how the updates look across all themes
>> .
>>
>
> That doesn't look bold at all to me - and I think we still need some other
> visual distinction, such as the column background colour.
>
>
>>
>>
>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have made changes for issue #7863
>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>>>>> requirements.
>>>>>
>>>>> I have attached screenshots showing how the updates look across all
>>>>> themes for your reference.
>>>>>
>>>>> If the current color does not fit well with the theme or if you have
>>>>> any suggestions for improvements, please let me know.
>>>>>
>>>>
>>>> Is the colour contrast high enough on the row numbers for selected rows
>>>> in the high contrast theme? The black on grey seems like it might not be to
>>>> me, but I haven't tested.
>>>>
>>>> I wonder also if we should make the row numbers bold all the time.
>>>> Thoughts?
>>>>
>>> We can check how it looks. Also the cell border doesn't look good to me.
>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
Attachments:
[image/png] HC-update.png (142.8K, ../../CABscKVihMj687AzJh3mWt6Dt+EiO=qanhp3bQUtQmqqv3Hg07g@mail.gmail.com/3-HC-update.png)
download | view image
[image/png] std-update.png (137.3K, ../../CABscKVihMj687AzJh3mWt6Dt+EiO=qanhp3bQUtQmqqv3Hg07g@mail.gmail.com/4-std-update.png)
download | view image
[image/png] dark-update.png (134.5K, ../../CABscKVihMj687AzJh3mWt6Dt+EiO=qanhp3bQUtQmqqv3Hg07g@mail.gmail.com/5-dark-update.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-06 08:30 ` Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-06 08:30 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <[email protected]>
wrote:
> I have made some more changes with changing background color.
>
Yeah, that looks weird again, specifically on the selected rows. I believe
the issue is that we should not highlight the row number column when a row
is selected at all. That makes sense, as we should only be highlighting the
columns that would get copied in a copy/paste operation anyway.
Also, the bold still doesn't look bold. I think the weight needs to be
increased.
>
> I have attached screenshots showing how the updates look across all themes
> .
>
> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> I have removed the border and background color, just made the row
>>> numbers bold.
>>>
>>> I have attached screenshots showing how the updates look across all
>>> themes.
>>>
>>
>> That doesn't look bold at all to me - and I think we still need some
>> other visual distinction, such as the column background colour.
>>
>>
>>>
>>>
>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have made changes for issue #7863
>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on theme
>>>>>> requirements.
>>>>>>
>>>>>> I have attached screenshots showing how the updates look across all
>>>>>> themes for your reference.
>>>>>>
>>>>>> If the current color does not fit well with the theme or if you have
>>>>>> any suggestions for improvements, please let me know.
>>>>>>
>>>>>
>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>> be to me, but I haven't tested.
>>>>>
>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>> Thoughts?
>>>>>
>>>> We can check how it looks. Also the cell border doesn't look good to me.
>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-09 09:18 ` Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-09 09:18 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I have made changes as per your suggestions.
I have attached screenshots showing how the updates look across all themes
for your reference.
If the current changes does not fit well with the theme or if you have any
suggestions for improvements, please let me know.
Thanks
Rohit Bhati
EnterpriseDB
On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>
>
> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <[email protected]>
> wrote:
>
>> I have made some more changes with changing background color.
>>
>
> Yeah, that looks weird again, specifically on the selected rows. I believe
> the issue is that we should not highlight the row number column when a row
> is selected at all. That makes sense, as we should only be highlighting the
> columns that would get copied in a copy/paste operation anyway.
>
> Also, the bold still doesn't look bold. I think the weight needs to be
> increased.
>
>
>>
>> I have attached screenshots showing how the updates look across all themes
>> .
>>
>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I have removed the border and background color, just made the row
>>>> numbers bold.
>>>>
>>>> I have attached screenshots showing how the updates look across all
>>>> themes.
>>>>
>>>
>>> That doesn't look bold at all to me - and I think we still need some
>>> other visual distinction, such as the column background colour.
>>>
>>>
>>>>
>>>>
>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have made changes for issue #7863
>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>> theme requirements.
>>>>>>>
>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>> themes for your reference.
>>>>>>>
>>>>>>> If the current color does not fit well with the theme or if you have
>>>>>>> any suggestions for improvements, please let me know.
>>>>>>>
>>>>>>
>>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>>> be to me, but I haven't tested.
>>>>>>
>>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>>> Thoughts?
>>>>>>
>>>>> We can check how it looks. Also the cell border doesn't look good to
>>>>> me.
>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> EDB: https://www.enterprisedb.com
>>>>>>
>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>
>>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
Attachments:
[image/png] HC-.png (163.2K, ../../CABscKVhYEkFCuF+MT0XBumbVn9NsNseBLjKS=mxiMenv1sRxwA@mail.gmail.com/3-HC-.png)
download | view image
[image/png] DM-.png (147.3K, ../../CABscKVhYEkFCuF+MT0XBumbVn9NsNseBLjKS=mxiMenv1sRxwA@mail.gmail.com/4-DM-.png)
download | view image
[image/png] LM-.png (156.0K, ../../CABscKVhYEkFCuF+MT0XBumbVn9NsNseBLjKS=mxiMenv1sRxwA@mail.gmail.com/5-LM-.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-09 09:59 ` Dave Page <[email protected]>
2024-09-09 10:36 ` Re: Require suggestions for Issue #2874 Anil Sahoo <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 2 replies; 33+ messages in thread
From: Dave Page @ 2024-09-09 09:59 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
>
> I have made changes as per your suggestions.
> I have attached screenshots showing how the updates look across all themes
> for your reference.
>
> If the current changes does not fit well with the theme or if you have any
> suggestions for improvements, please let me know.
>
The colours etc. look correct now (ie. there are no weird borders), but I
still don't think the row number looks visually distinct from the rest of
the data. The bold text simply isn't very bold - I think it still needs
more weight.
>
> Thanks
> Rohit Bhati
> EnterpriseDB
>
>
> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>
>>
>>
>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> I have made some more changes with changing background color.
>>>
>>
>> Yeah, that looks weird again, specifically on the selected rows. I
>> believe the issue is that we should not highlight the row number column
>> when a row is selected at all. That makes sense, as we should only be
>> highlighting the columns that would get copied in a copy/paste operation
>> anyway.
>>
>> Also, the bold still doesn't look bold. I think the weight needs to be
>> increased.
>>
>>
>>>
>>> I have attached screenshots showing how the updates look across all
>>> themes.
>>>
>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> I have removed the border and background color, just made the row
>>>>> numbers bold.
>>>>>
>>>>> I have attached screenshots showing how the updates look across all
>>>>> themes.
>>>>>
>>>>
>>>> That doesn't look bold at all to me - and I think we still need some
>>>> other visual distinction, such as the column background colour.
>>>>
>>>>
>>>>>
>>>>>
>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I have made changes for issue #7863
>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>>> theme requirements.
>>>>>>>>
>>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>>> themes for your reference.
>>>>>>>>
>>>>>>>> If the current color does not fit well with the theme or if you
>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>
>>>>>>>
>>>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>>>> be to me, but I haven't tested.
>>>>>>>
>>>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>>>> Thoughts?
>>>>>>>
>>>>>> We can check how it looks. Also the cell border doesn't look good to
>>>>>> me.
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>
>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>
>>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-09 10:36 ` Anil Sahoo <[email protected]>
1 sibling, 0 replies; 33+ messages in thread
From: Anil Sahoo @ 2024-09-09 10:36 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Rohit Bhati <[email protected]>; pgadmin-hackers
Hi Rohit/Dave,
If we can remove the alternate background color from the row number column
and give light grey or different color to the row number column and the
column header, that will make the data distinct with the alternate
background color from the headers and row number column.
Any thoughts on this?
Thanks
Anil
--
<http://www.enterprisedb.com;
*Anil Sahoo*
Software Engineer
www.enterprisedb.com
Power to Postgres
<https://www.linkedin.com/company/edbpostgres;
<https://twitter.com/edbpostgres?lang=en;
<https://www.facebook.com/EDBpostgres;
<https://www.instagram.com/EDBpostgres/;
On Mon, Sep 9, 2024 at 3:30 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I have made changes as per your suggestions.
>> I have attached screenshots showing how the updates look across all
>> themes for your reference.
>>
>> If the current changes does not fit well with the theme or if you have
>> any suggestions for improvements, please let me know.
>>
>
> The colours etc. look correct now (ie. there are no weird borders), but I
> still don't think the row number looks visually distinct from the rest of
> the data. The bold text simply isn't very bold - I think it still needs
> more weight.
>
>
>
>>
>> Thanks
>> Rohit Bhati
>> EnterpriseDB
>>
>>
>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> I have made some more changes with changing background color.
>>>>
>>>
>>> Yeah, that looks weird again, specifically on the selected rows. I
>>> believe the issue is that we should not highlight the row number column
>>> when a row is selected at all. That makes sense, as we should only be
>>> highlighting the columns that would get copied in a copy/paste operation
>>> anyway.
>>>
>>> Also, the bold still doesn't look bold. I think the weight needs to be
>>> increased.
>>>
>>>
>>>>
>>>> I have attached screenshots showing how the updates look across all
>>>> themes.
>>>>
>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have removed the border and background color, just made the row
>>>>>> numbers bold.
>>>>>>
>>>>>> I have attached screenshots showing how the updates look across all
>>>>>> themes.
>>>>>>
>>>>>
>>>>> That doesn't look bold at all to me - and I think we still need some
>>>>> other visual distinction, such as the column background colour.
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I have made changes for issue #7863
>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>>>> theme requirements.
>>>>>>>>>
>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>> all themes for your reference.
>>>>>>>>>
>>>>>>>>> If the current color does not fit well with the theme or if you
>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>>>>> be to me, but I haven't tested.
>>>>>>>>
>>>>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>>>>> Thoughts?
>>>>>>>>
>>>>>>> We can check how it looks. Also the cell border doesn't look good to
>>>>>>> me.
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>
>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>
>>>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-09 10:41 ` Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
1 sibling, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-09 10:41 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
I already set weight to 900.
If we need to be more distinct then I think we can have some shadow or if
anything else please suggest.
On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I have made changes as per your suggestions.
>> I have attached screenshots showing how the updates look across all
>> themes for your reference.
>>
>> If the current changes does not fit well with the theme or if you have
>> any suggestions for improvements, please let me know.
>>
>
> The colours etc. look correct now (ie. there are no weird borders), but I
> still don't think the row number looks visually distinct from the rest of
> the data. The bold text simply isn't very bold - I think it still needs
> more weight.
>
>
>
>>
>> Thanks
>> Rohit Bhati
>> EnterpriseDB
>>
>>
>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> I have made some more changes with changing background color.
>>>>
>>>
>>> Yeah, that looks weird again, specifically on the selected rows. I
>>> believe the issue is that we should not highlight the row number column
>>> when a row is selected at all. That makes sense, as we should only be
>>> highlighting the columns that would get copied in a copy/paste operation
>>> anyway.
>>>
>>> Also, the bold still doesn't look bold. I think the weight needs to be
>>> increased.
>>>
>>>
>>>>
>>>> I have attached screenshots showing how the updates look across all
>>>> themes.
>>>>
>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I have removed the border and background color, just made the row
>>>>>> numbers bold.
>>>>>>
>>>>>> I have attached screenshots showing how the updates look across all
>>>>>> themes.
>>>>>>
>>>>>
>>>>> That doesn't look bold at all to me - and I think we still need some
>>>>> other visual distinction, such as the column background colour.
>>>>>
>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I have made changes for issue #7863
>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>>>> theme requirements.
>>>>>>>>>
>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>> all themes for your reference.
>>>>>>>>>
>>>>>>>>> If the current color does not fit well with the theme or if you
>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>>>>> be to me, but I haven't tested.
>>>>>>>>
>>>>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>>>>> Thoughts?
>>>>>>>>
>>>>>>> We can check how it looks. Also the cell border doesn't look good to
>>>>>>> me.
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>
>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>
>>>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-10 07:37 ` Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-10 07:37 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I have added shadow to make the text more distinct and attached screenshots
based on themes.
Please once check and let me know if we can go ahead with this or provide
suggestions if need to make changes.
Thanks & Regards
Rohit Bhati
On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <[email protected]>
wrote:
> I already set weight to 900.
> If we need to be more distinct then I think we can have some shadow or if
> anything else please suggest.
>
> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> I have made changes as per your suggestions.
>>> I have attached screenshots showing how the updates look across all
>>> themes for your reference.
>>>
>>> If the current changes does not fit well with the theme or if you have
>>> any suggestions for improvements, please let me know.
>>>
>>
>> The colours etc. look correct now (ie. there are no weird borders), but I
>> still don't think the row number looks visually distinct from the rest of
>> the data. The bold text simply isn't very bold - I think it still needs
>> more weight.
>>
>>
>>
>>>
>>> Thanks
>>> Rohit Bhati
>>> EnterpriseDB
>>>
>>>
>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> I have made some more changes with changing background color.
>>>>>
>>>>
>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>> believe the issue is that we should not highlight the row number column
>>>> when a row is selected at all. That makes sense, as we should only be
>>>> highlighting the columns that would get copied in a copy/paste operation
>>>> anyway.
>>>>
>>>> Also, the bold still doesn't look bold. I think the weight needs to be
>>>> increased.
>>>>
>>>>
>>>>>
>>>>> I have attached screenshots showing how the updates look across all
>>>>> themes.
>>>>>
>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I have removed the border and background color, just made the row
>>>>>>> numbers bold.
>>>>>>>
>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>> themes.
>>>>>>>
>>>>>>
>>>>>> That doesn't look bold at all to me - and I think we still need some
>>>>>> other visual distinction, such as the column background colour.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>>>>> theme requirements.
>>>>>>>>>>
>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>> all themes for your reference.
>>>>>>>>>>
>>>>>>>>>> If the current color does not fit well with the theme or if you
>>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Is the colour contrast high enough on the row numbers for selected
>>>>>>>>> rows in the high contrast theme? The black on grey seems like it might not
>>>>>>>>> be to me, but I haven't tested.
>>>>>>>>>
>>>>>>>>> I wonder also if we should make the row numbers bold all the time.
>>>>>>>>> Thoughts?
>>>>>>>>>
>>>>>>>> We can check how it looks. Also the cell border doesn't look good
>>>>>>>> to me.
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> EDB: https://www.enterprisedb.com
>>>>>>
>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
Attachments:
[image/png] light-shadow.png (225.8K, ../../CABscKVizf-FPqHjmvmF9cfvPCuNpRgR5858-tyyCeK0B_rYRbA@mail.gmail.com/3-light-shadow.png)
download | view image
[image/png] Dark-shadow.png (165.3K, ../../CABscKVizf-FPqHjmvmF9cfvPCuNpRgR5858-tyyCeK0B_rYRbA@mail.gmail.com/4-Dark-shadow.png)
download | view image
[image/png] HC-shadow.png (178.6K, ../../CABscKVizf-FPqHjmvmF9cfvPCuNpRgR5858-tyyCeK0B_rYRbA@mail.gmail.com/5-HC-shadow.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-10 09:12 ` Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-10 09:12 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
Shadow is more visible, but it doesn't really follow the material UI
styling which is flat rather than 3D.
I think Anil's idea is worth exploring; remove the alternating colour for
the row number column, and use a different background shade for it entirely.
On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
>
> I have added shadow to make the text more distinct and attached
> screenshots based on themes.
> Please once check and let me know if we can go ahead with this or provide
> suggestions if need to make changes.
>
> Thanks & Regards
> Rohit Bhati
>
>
> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <[email protected]>
> wrote:
>
>> I already set weight to 900.
>> If we need to be more distinct then I think we can have some shadow or if
>> anything else please suggest.
>>
>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> I have made changes as per your suggestions.
>>>> I have attached screenshots showing how the updates look across all
>>>> themes for your reference.
>>>>
>>>> If the current changes does not fit well with the theme or if you have
>>>> any suggestions for improvements, please let me know.
>>>>
>>>
>>> The colours etc. look correct now (ie. there are no weird borders), but
>>> I still don't think the row number looks visually distinct from the rest of
>>> the data. The bold text simply isn't very bold - I think it still needs
>>> more weight.
>>>
>>>
>>>
>>>>
>>>> Thanks
>>>> Rohit Bhati
>>>> EnterpriseDB
>>>>
>>>>
>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> I have made some more changes with changing background color.
>>>>>>
>>>>>
>>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>>> believe the issue is that we should not highlight the row number column
>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>> anyway.
>>>>>
>>>>> Also, the bold still doesn't look bold. I think the weight needs to be
>>>>> increased.
>>>>>
>>>>>
>>>>>>
>>>>>> I have attached screenshots showing how the updates look across all
>>>>>> themes.
>>>>>>
>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>> numbers bold.
>>>>>>>>
>>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>>> themes.
>>>>>>>>
>>>>>>>
>>>>>>> That doesn't look bold at all to me - and I think we still need some
>>>>>>> other visual distinction, such as the column background colour.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>>>>>> theme requirements.
>>>>>>>>>>>
>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>> all themes for your reference.
>>>>>>>>>>>
>>>>>>>>>>> If the current color does not fit well with the theme or if you
>>>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>
>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>> time. Thoughts?
>>>>>>>>>>
>>>>>>>>> We can check how it looks. Also the cell border doesn't look good
>>>>>>>>> to me.
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>
>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>
>>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>
>>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-10 11:42 ` Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-10 11:42 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Hi Dave,
I have made some changes and made the header and serial number row
column color the same.
Please once check the attached images.
Thanks
On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
> Hi
>
> Shadow is more visible, but it doesn't really follow the material UI
> styling which is flat rather than 3D.
>
> I think Anil's idea is worth exploring; remove the alternating colour for
> the row number column, and use a different background shade for it entirely.
>
> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I have added shadow to make the text more distinct and attached
>> screenshots based on themes.
>> Please once check and let me know if we can go ahead with this or provide
>> suggestions if need to make changes.
>>
>> Thanks & Regards
>> Rohit Bhati
>>
>>
>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <[email protected]>
>> wrote:
>>
>>> I already set weight to 900.
>>> If we need to be more distinct then I think we can have some shadow or
>>> if anything else please suggest.
>>>
>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> I have made changes as per your suggestions.
>>>>> I have attached screenshots showing how the updates look across all
>>>>> themes for your reference.
>>>>>
>>>>> If the current changes does not fit well with the theme or if you have
>>>>> any suggestions for improvements, please let me know.
>>>>>
>>>>
>>>> The colours etc. look correct now (ie. there are no weird borders), but
>>>> I still don't think the row number looks visually distinct from the rest of
>>>> the data. The bold text simply isn't very bold - I think it still needs
>>>> more weight.
>>>>
>>>>
>>>>
>>>>>
>>>>> Thanks
>>>>> Rohit Bhati
>>>>> EnterpriseDB
>>>>>
>>>>>
>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>>
>>>>>>
>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> I have made some more changes with changing background color.
>>>>>>>
>>>>>>
>>>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>>>> believe the issue is that we should not highlight the row number column
>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>> anyway.
>>>>>>
>>>>>> Also, the bold still doesn't look bold. I think the weight needs to
>>>>>> be increased.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>> themes.
>>>>>>>
>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>>> numbers bold.
>>>>>>>>>
>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>> all themes.
>>>>>>>>>
>>>>>>>>
>>>>>>>> That doesn't look bold at all to me - and I think we still need
>>>>>>>> some other visual distinction, such as the column background colour.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi
>>>>>>>>>>>
>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based on
>>>>>>>>>>>> theme requirements.
>>>>>>>>>>>>
>>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>>> all themes for your reference.
>>>>>>>>>>>>
>>>>>>>>>>>> If the current color does not fit well with the theme or if you
>>>>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>
>>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>>> time. Thoughts?
>>>>>>>>>>>
>>>>>>>>>> We can check how it looks. Also the cell border doesn't look good
>>>>>>>>>> to me.
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Dave Page
>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>
>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>
>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> EDB: https://www.enterprisedb.com
>>>>>>
>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>
>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>
>
Attachments:
[image/png] Dark1.png (148.1K, ../../CABscKVjrvCDfwgzkRh8z_2ekcR5gYimV5FKxXsa=pC4Jnn3i=Q@mail.gmail.com/3-Dark1.png)
download | view image
[image/png] Light1.png (171.5K, ../../CABscKVjrvCDfwgzkRh8z_2ekcR5gYimV5FKxXsa=pC4Jnn3i=Q@mail.gmail.com/4-Light1.png)
download | view image
[image/png] HC1.png (187.6K, ../../CABscKVjrvCDfwgzkRh8z_2ekcR5gYimV5FKxXsa=pC4Jnn3i=Q@mail.gmail.com/5-HC1.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-10 12:04 ` Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-10 12:04 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: pgadmin-hackers
Hi
On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
>
> I have made some changes and made the header and serial number row
> column color the same.
>
> Please once check the attached images.
>
I think that looks much better!
Thanks.
>
> Thanks
>
> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Shadow is more visible, but it doesn't really follow the material UI
>> styling which is flat rather than 3D.
>>
>> I think Anil's idea is worth exploring; remove the alternating colour for
>> the row number column, and use a different background shade for it entirely.
>>
>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> I have added shadow to make the text more distinct and attached
>>> screenshots based on themes.
>>> Please once check and let me know if we can go ahead with this or
>>> provide suggestions if need to make changes.
>>>
>>> Thanks & Regards
>>> Rohit Bhati
>>>
>>>
>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> I already set weight to 900.
>>>> If we need to be more distinct then I think we can have some shadow or
>>>> if anything else please suggest.
>>>>
>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> I have made changes as per your suggestions.
>>>>>> I have attached screenshots showing how the updates look across all
>>>>>> themes for your reference.
>>>>>>
>>>>>> If the current changes does not fit well with the theme or if you
>>>>>> have any suggestions for improvements, please let me know.
>>>>>>
>>>>>
>>>>> The colours etc. look correct now (ie. there are no weird borders),
>>>>> but I still don't think the row number looks visually distinct from the
>>>>> rest of the data. The bold text simply isn't very bold - I think it still
>>>>> needs more weight.
>>>>>
>>>>>
>>>>>
>>>>>>
>>>>>> Thanks
>>>>>> Rohit Bhati
>>>>>> EnterpriseDB
>>>>>>
>>>>>>
>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>
>>>>>>>
>>>>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>>>>> believe the issue is that we should not highlight the row number column
>>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>>> anyway.
>>>>>>>
>>>>>>> Also, the bold still doesn't look bold. I think the weight needs to
>>>>>>> be increased.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>>> themes.
>>>>>>>>
>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>>>> numbers bold.
>>>>>>>>>>
>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>> all themes.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> That doesn't look bold at all to me - and I think we still need
>>>>>>>>> some other visual distinction, such as the column background colour.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If the current color does not fit well with the theme or if
>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>
>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>>>> time. Thoughts?
>>>>>>>>>>>>
>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look
>>>>>>>>>>> good to me.
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Dave Page
>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>
>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>
>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>
>>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>
>>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-10 12:11 ` Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-10 12:11 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
Ok, I am applying that.
Thanks for the suggestions.
On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
> Hi
>
>
> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I have made some changes and made the header and serial number row
>> column color the same.
>>
>> Please once check the attached images.
>>
>
> I think that looks much better!
>
> Thanks.
>
>
>>
>> Thanks
>>
>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Shadow is more visible, but it doesn't really follow the material UI
>>> styling which is flat rather than 3D.
>>>
>>> I think Anil's idea is worth exploring; remove the alternating colour
>>> for the row number column, and use a different background shade for it
>>> entirely.
>>>
>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> I have added shadow to make the text more distinct and attached
>>>> screenshots based on themes.
>>>> Please once check and let me know if we can go ahead with this or
>>>> provide suggestions if need to make changes.
>>>>
>>>> Thanks & Regards
>>>> Rohit Bhati
>>>>
>>>>
>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>> [email protected]> wrote:
>>>>
>>>>> I already set weight to 900.
>>>>> If we need to be more distinct then I think we can have some shadow or
>>>>> if anything else please suggest.
>>>>>
>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I have made changes as per your suggestions.
>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>> themes for your reference.
>>>>>>>
>>>>>>> If the current changes does not fit well with the theme or if you
>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>
>>>>>>
>>>>>> The colours etc. look correct now (ie. there are no weird borders),
>>>>>> but I still don't think the row number looks visually distinct from the
>>>>>> rest of the data. The bold text simply isn't very bold - I think it still
>>>>>> needs more weight.
>>>>>>
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Thanks
>>>>>>> Rohit Bhati
>>>>>>> EnterpriseDB
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>>>>>> believe the issue is that we should not highlight the row number column
>>>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>>>> anyway.
>>>>>>>>
>>>>>>>> Also, the bold still doesn't look bold. I think the weight needs to
>>>>>>>> be increased.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>> all themes.
>>>>>>>>>
>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>>>>> numbers bold.
>>>>>>>>>>>
>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>> all themes.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> That doesn't look bold at all to me - and I think we still need
>>>>>>>>>> some other visual distinction, such as the column background colour.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If the current color does not fit well with the theme or if
>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>>>>> time. Thoughts?
>>>>>>>>>>>>>
>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look
>>>>>>>>>>>> good to me.
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>
>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>
>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>
>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> EDB: https://www.enterprisedb.com
>>>>>>
>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>
>>>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>
>>>
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-12 03:43 ` Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Aditya Toshniwal @ 2024-09-12 03:43 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Rohit,
It is actually the same as existing with only difference is alternate row
backgrounds. If later we remove the alternate bg using preferences then
issue of distinguishing row numbers will remain un-fixed.
On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <[email protected]>
wrote:
> Ok, I am applying that.
>
> Thanks for the suggestions.
>
> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>>
>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> I have made some changes and made the header and serial number row
>>> column color the same.
>>>
>>> Please once check the attached images.
>>>
>>
>> I think that looks much better!
>>
>> Thanks.
>>
>>
>>>
>>> Thanks
>>>
>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> Shadow is more visible, but it doesn't really follow the material UI
>>>> styling which is flat rather than 3D.
>>>>
>>>> I think Anil's idea is worth exploring; remove the alternating colour
>>>> for the row number column, and use a different background shade for it
>>>> entirely.
>>>>
>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> I have added shadow to make the text more distinct and attached
>>>>> screenshots based on themes.
>>>>> Please once check and let me know if we can go ahead with this or
>>>>> provide suggestions if need to make changes.
>>>>>
>>>>> Thanks & Regards
>>>>> Rohit Bhati
>>>>>
>>>>>
>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> I already set weight to 900.
>>>>>> If we need to be more distinct then I think we can have some shadow
>>>>>> or if anything else please suggest.
>>>>>>
>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> I have made changes as per your suggestions.
>>>>>>>> I have attached screenshots showing how the updates look across all
>>>>>>>> themes for your reference.
>>>>>>>>
>>>>>>>> If the current changes does not fit well with the theme or if you
>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>
>>>>>>>
>>>>>>> The colours etc. look correct now (ie. there are no weird borders),
>>>>>>> but I still don't think the row number looks visually distinct from the
>>>>>>> rest of the data. The bold text simply isn't very bold - I think it still
>>>>>>> needs more weight.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>> Rohit Bhati
>>>>>>>> EnterpriseDB
>>>>>>>>
>>>>>>>>
>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Yeah, that looks weird again, specifically on the selected rows. I
>>>>>>>>> believe the issue is that we should not highlight the row number column
>>>>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>> anyway.
>>>>>>>>>
>>>>>>>>> Also, the bold still doesn't look bold. I think the weight needs
>>>>>>>>> to be increased.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>> all themes.
>>>>>>>>>>
>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi
>>>>>>>>>>>
>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi,
>>>>>>>>>>>>
>>>>>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>>>>>> numbers bold.
>>>>>>>>>>>>
>>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>>> all themes.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> That doesn't look bold at all to me - and I think we still need
>>>>>>>>>>> some other visual distinction, such as the column background colour.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> If the current color does not fit well with the theme or if
>>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>>>>>> time. Thoughts?
>>>>>>>>>>>>>>
>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look
>>>>>>>>>>>>> good to me.
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Dave Page
>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>
>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>
>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>
>>>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>
>>>>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
@ 2024-09-12 04:07 ` Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Aditya Toshniwal @ 2024-09-12 04:07 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi,
It can be something like below. I've removed the shadows completely.
[image: image.png]
On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi Rohit,
>
> It is actually the same as existing with only difference is alternate row
> backgrounds. If later we remove the alternate bg using preferences then
> issue of distinguishing row numbers will remain un-fixed.
>
> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <[email protected]>
> wrote:
>
>> Ok, I am applying that.
>>
>> Thanks for the suggestions.
>>
>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>>
>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi Dave,
>>>>
>>>> I have made some changes and made the header and serial number row
>>>> column color the same.
>>>>
>>>> Please once check the attached images.
>>>>
>>>
>>> I think that looks much better!
>>>
>>> Thanks.
>>>
>>>
>>>>
>>>> Thanks
>>>>
>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> Shadow is more visible, but it doesn't really follow the material UI
>>>>> styling which is flat rather than 3D.
>>>>>
>>>>> I think Anil's idea is worth exploring; remove the alternating colour
>>>>> for the row number column, and use a different background shade for it
>>>>> entirely.
>>>>>
>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> I have added shadow to make the text more distinct and attached
>>>>>> screenshots based on themes.
>>>>>> Please once check and let me know if we can go ahead with this or
>>>>>> provide suggestions if need to make changes.
>>>>>>
>>>>>> Thanks & Regards
>>>>>> Rohit Bhati
>>>>>>
>>>>>>
>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> I already set weight to 900.
>>>>>>> If we need to be more distinct then I think we can have some shadow
>>>>>>> or if anything else please suggest.
>>>>>>>
>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>> all themes for your reference.
>>>>>>>>>
>>>>>>>>> If the current changes does not fit well with the theme or if you
>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>
>>>>>>>>
>>>>>>>> The colours etc. look correct now (ie. there are no weird borders),
>>>>>>>> but I still don't think the row number looks visually distinct from the
>>>>>>>> rest of the data. The bold text simply isn't very bold - I think it still
>>>>>>>> needs more weight.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>> Rohit Bhati
>>>>>>>>> EnterpriseDB
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Yeah, that looks weird again, specifically on the selected rows.
>>>>>>>>>> I believe the issue is that we should not highlight the row number column
>>>>>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>> anyway.
>>>>>>>>>>
>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight needs
>>>>>>>>>> to be increased.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>> all themes.
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have removed the border and background color, just made the row
>>>>>>>>>>>>> numbers bold.
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still need
>>>>>>>>>>>> some other visual distinction, such as the column background colour.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> If the current color does not fit well with the theme or if
>>>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all the
>>>>>>>>>>>>>>> time. Thoughts?
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look
>>>>>>>>>>>>>> good to me.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Dave Page
>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>
>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>
>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>
>>>>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> pgAdmin: https://www.pgadmin.org
>>>>> PostgreSQL: https://www.postgresql.org
>>>>> EDB: https://www.enterprisedb.com
>>>>>
>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>
>>>>>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>
--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
<https://www.enterprisedb.com/;
"Don't Complain about Heat, Plant a TREE"
Attachments:
[image/png] image.png (377.1K, ../../CAM9w-_nw2RsEGAMFwtkz-f6cRWuivC4bgbux0Ytv5yW49YY_wg@mail.gmail.com/3-image.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
@ 2024-09-12 10:09 ` Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-12 10:09 UTC (permalink / raw)
To: Aditya Toshniwal <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Dave,
As per Aditya suggestion, I have made some changes and attached images.
Please check and let me know if you need any changes.
Thanks and Regards
Rohit Bhati
On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
[email protected]> wrote:
> Hi,
>
> It can be something like below. I've removed the shadows completely.
> [image: image.png]
>
> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi Rohit,
>>
>> It is actually the same as existing with only difference is alternate row
>> backgrounds. If later we remove the alternate bg using preferences then
>> issue of distinguishing row numbers will remain un-fixed.
>>
>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Ok, I am applying that.
>>>
>>> Thanks for the suggestions.
>>>
>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>>
>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> I have made some changes and made the header and serial number row
>>>>> column color the same.
>>>>>
>>>>> Please once check the attached images.
>>>>>
>>>>
>>>> I think that looks much better!
>>>>
>>>> Thanks.
>>>>
>>>>
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>> Shadow is more visible, but it doesn't really follow the material UI
>>>>>> styling which is flat rather than 3D.
>>>>>>
>>>>>> I think Anil's idea is worth exploring; remove the alternating colour
>>>>>> for the row number column, and use a different background shade for it
>>>>>> entirely.
>>>>>>
>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>> screenshots based on themes.
>>>>>>> Please once check and let me know if we can go ahead with this or
>>>>>>> provide suggestions if need to make changes.
>>>>>>>
>>>>>>> Thanks & Regards
>>>>>>> Rohit Bhati
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> I already set weight to 900.
>>>>>>>> If we need to be more distinct then I think we can have some shadow
>>>>>>>> or if anything else please suggest.
>>>>>>>>
>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Dave,
>>>>>>>>>>
>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>> all themes for your reference.
>>>>>>>>>>
>>>>>>>>>> If the current changes does not fit well with the theme or if you
>>>>>>>>>> have any suggestions for improvements, please let me know.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>> it still needs more weight.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>> Rohit Bhati
>>>>>>>>>> EnterpriseDB
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected rows.
>>>>>>>>>>> I believe the issue is that we should not highlight the row number column
>>>>>>>>>>> when a row is selected at all. That makes sense, as we should only be
>>>>>>>>>>> highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>> anyway.
>>>>>>>>>>>
>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight needs
>>>>>>>>>>> to be increased.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>>> all themes.
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme or
>>>>>>>>>>>>>>>>> if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all
>>>>>>>>>>>>>>>> the time. Thoughts?
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't look
>>>>>>>>>>>>>>> good to me.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>
>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Dave Page
>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>
>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>> EDB: https://www.enterprisedb.com
>>>>>>
>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>
>>>>>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
> <https://www.enterprisedb.com/;
> "Don't Complain about Heat, Plant a TREE"
>
Attachments:
[image/png] image.png (377.1K, ../../CABscKVgc4_zHZjbvUwF6TH_nbz2RDU390D__D7nEPATV713nUQ@mail.gmail.com/3-image.png)
download | view image
[image/png] Screenshot 2024-09-12 at 3.09.38 PM.png (295.6K, ../../CABscKVgc4_zHZjbvUwF6TH_nbz2RDU390D__D7nEPATV713nUQ@mail.gmail.com/4-Screenshot%202024-09-12%20at%203.09.38%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2024-09-12 at 3.10.16 PM.png (344.1K, ../../CABscKVgc4_zHZjbvUwF6TH_nbz2RDU390D__D7nEPATV713nUQ@mail.gmail.com/5-Screenshot%202024-09-12%20at%203.10.16%E2%80%AFPM.png)
download | view image
[image/png] Screenshot 2024-09-12 at 3.12.43 PM.png (360.5K, ../../CABscKVgc4_zHZjbvUwF6TH_nbz2RDU390D__D7nEPATV713nUQ@mail.gmail.com/6-Screenshot%202024-09-12%20at%203.12.43%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-12 14:19 ` Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
0 siblings, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-12 14:19 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi
Aditya made a good point - however, the colour on the standard theme didn't
look right to me so I checked on the styleguide and it doesn't seem like
you used one of the standard colours? For the dark theme it looks like you
used border-color, whilst for high contrast, gray-light perhaps? I wonder
if border-color would be appropriate in all cases?
On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
> As per Aditya suggestion, I have made some changes and attached images.
> Please check and let me know if you need any changes.
>
> Thanks and Regards
> Rohit Bhati
>
> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
> [email protected]> wrote:
>
>> Hi,
>>
>> It can be something like below. I've removed the shadows completely.
>> [image: image.png]
>>
>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Rohit,
>>>
>>> It is actually the same as existing with only difference is alternate
>>> row backgrounds. If later we remove the alternate bg using preferences then
>>> issue of distinguishing row numbers will remain un-fixed.
>>>
>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>> [email protected]> wrote:
>>>
>>>> Ok, I am applying that.
>>>>
>>>> Thanks for the suggestions.
>>>>
>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>>
>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> I have made some changes and made the header and serial number row
>>>>>> column color the same.
>>>>>>
>>>>>> Please once check the attached images.
>>>>>>
>>>>>
>>>>> I think that looks much better!
>>>>>
>>>>> Thanks.
>>>>>
>>>>>
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>> Shadow is more visible, but it doesn't really follow the material UI
>>>>>>> styling which is flat rather than 3D.
>>>>>>>
>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>> it entirely.
>>>>>>>
>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>> screenshots based on themes.
>>>>>>>> Please once check and let me know if we can go ahead with this or
>>>>>>>> provide suggestions if need to make changes.
>>>>>>>>
>>>>>>>> Thanks & Regards
>>>>>>>> Rohit Bhati
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> I already set weight to 900.
>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>
>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>
>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>> all themes for your reference.
>>>>>>>>>>>
>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>> it still needs more weight.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>> anyway.
>>>>>>>>>>>>
>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme or
>>>>>>>>>>>>>>>>>> if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all
>>>>>>>>>>>>>>>>> the time. Thoughts?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Dave Page
>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>
>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>
>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>
>>>>>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>> <https://www.enterprisedb.com/;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> Thanks,
>> Aditya Toshniwal
>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>> <https://www.enterprisedb.com/;
>> "Don't Complain about Heat, Plant a TREE"
>>
>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
Attachments:
[image/png] image.png (377.1K, ../../CA+OCxoxEcmFgW450SZ6vvEBD6ctGes2jFemFHVy+iVZ=6v1EJg@mail.gmail.com/3-image.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-24 12:17 ` Rohit Bhati <[email protected]>
2024-09-25 05:18 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-30 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
0 siblings, 2 replies; 33+ messages in thread
From: Rohit Bhati @ 2024-09-24 12:17 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi Dave,
I haven't used any border colors for any cases previously.
However, I tried using border colors for all cases, but this approach
overlaps the column and header separators,
which doesn't look good. I've attached a screenshot below for your
reference.
On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
> Hi
>
> Aditya made a good point - however, the colour on the standard theme
> didn't look right to me so I checked on the styleguide and it doesn't seem
> like you used one of the standard colours? For the dark theme it looks like
> you used border-color, whilst for high contrast, gray-light perhaps? I
> wonder if border-color would be appropriate in all cases?
>
> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>> As per Aditya suggestion, I have made some changes and attached images.
>> Please check and let me know if you need any changes.
>>
>> Thanks and Regards
>> Rohit Bhati
>>
>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi,
>>>
>>> It can be something like below. I've removed the shadows completely.
>>> [image: image.png]
>>>
>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi Rohit,
>>>>
>>>> It is actually the same as existing with only difference is alternate
>>>> row backgrounds. If later we remove the alternate bg using preferences then
>>>> issue of distinguishing row numbers will remain un-fixed.
>>>>
>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>> [email protected]> wrote:
>>>>
>>>>> Ok, I am applying that.
>>>>>
>>>>> Thanks for the suggestions.
>>>>>
>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>>
>>>>>> Hi
>>>>>>
>>>>>>
>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Dave,
>>>>>>>
>>>>>>> I have made some changes and made the header and serial number row
>>>>>>> column color the same.
>>>>>>>
>>>>>>> Please once check the attached images.
>>>>>>>
>>>>>>
>>>>>> I think that looks much better!
>>>>>>
>>>>>> Thanks.
>>>>>>
>>>>>>
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>> Shadow is more visible, but it doesn't really follow the material
>>>>>>>> UI styling which is flat rather than 3D.
>>>>>>>>
>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>> it entirely.
>>>>>>>>
>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>>> screenshots based on themes.
>>>>>>>>> Please once check and let me know if we can go ahead with this or
>>>>>>>>> provide suggestions if need to make changes.
>>>>>>>>>
>>>>>>>>> Thanks & Regards
>>>>>>>>> Rohit Bhati
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> I already set weight to 900.
>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>
>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi
>>>>>>>>>>>
>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>
>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>> I have attached screenshots showing how the updates look across
>>>>>>>>>>>> all themes for your reference.
>>>>>>>>>>>>
>>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme or
>>>>>>>>>>>>>>>>>>> if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers for
>>>>>>>>>>>>>>>>>> selected rows in the high contrast theme? The black on grey seems like it
>>>>>>>>>>>>>>>>>> might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all
>>>>>>>>>>>>>>>>>> the time. Thoughts?
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>
>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Dave Page
>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>
>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Dave Page
>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>
>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>
>>>>>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>> <https://www.enterprisedb.com/;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
>
Attachments:
[image/png] image.png (377.1K, ../../CABscKVgO0fhdRaGPCnZsd=8D6JY_gHQr5c8n016f61YCawLx=g@mail.gmail.com/3-image.png)
download | view image
[image/png] Screenshot 2024-09-24 at 5.32.38 PM.png (300.0K, ../../CABscKVgO0fhdRaGPCnZsd=8D6JY_gHQr5c8n016f61YCawLx=g@mail.gmail.com/4-Screenshot%202024-09-24%20at%205.32.38%E2%80%AFPM.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-25 05:18 ` Khushboo Vashi <[email protected]>
2024-09-25 05:31 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-25 05:34 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
1 sibling, 2 replies; 33+ messages in thread
From: Khushboo Vashi @ 2024-09-25 05:18 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: Dave Page <[email protected]>; Aditya Toshniwal <[email protected]>; pgadmin-hackers
On Tue, Sep 24, 2024 at 5:47 PM Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
>
> I haven't used any border colors for any cases previously.
> However, I tried using border colors for all cases, but this approach
> overlaps the column and header separators,
> which doesn't look good.
>
I liked it :)
Can you please post the other themes' screen-shot as well?
> I've attached a screenshot below for your reference.
>
>
> On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Aditya made a good point - however, the colour on the standard theme
>> didn't look right to me so I checked on the styleguide and it doesn't seem
>> like you used one of the standard colours? For the dark theme it looks like
>> you used border-color, whilst for high contrast, gray-light perhaps? I
>> wonder if border-color would be appropriate in all cases?
>>
>> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>> As per Aditya suggestion, I have made some changes and attached images.
>>> Please check and let me know if you need any changes.
>>>
>>> Thanks and Regards
>>> Rohit Bhati
>>>
>>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> It can be something like below. I've removed the shadows completely.
>>>> [image: image.png]
>>>>
>>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Rohit,
>>>>>
>>>>> It is actually the same as existing with only difference is alternate
>>>>> row backgrounds. If later we remove the alternate bg using preferences then
>>>>> issue of distinguishing row numbers will remain un-fixed.
>>>>>
>>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Ok, I am applying that.
>>>>>>
>>>>>> Thanks for the suggestions.
>>>>>>
>>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>>
>>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> I have made some changes and made the header and serial number row
>>>>>>>> column color the same.
>>>>>>>>
>>>>>>>> Please once check the attached images.
>>>>>>>>
>>>>>>>
>>>>>>> I think that looks much better!
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> Shadow is more visible, but it doesn't really follow the material
>>>>>>>>> UI styling which is flat rather than 3D.
>>>>>>>>>
>>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>>> it entirely.
>>>>>>>>>
>>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Dave,
>>>>>>>>>>
>>>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>>>> screenshots based on themes.
>>>>>>>>>> Please once check and let me know if we can go ahead with this or
>>>>>>>>>> provide suggestions if need to make changes.
>>>>>>>>>>
>>>>>>>>>> Thanks & Regards
>>>>>>>>>> Rohit Bhati
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> I already set weight to 900.
>>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates
>>>>>>>>>>>>>>>>>>>> look across all themes for your reference.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme
>>>>>>>>>>>>>>>>>>>> or if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers
>>>>>>>>>>>>>>>>>>> for selected rows in the high contrast theme? The black on grey seems like
>>>>>>>>>>>>>>>>>>> it might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all
>>>>>>>>>>>>>>>>>>> the time. Thoughts?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Dave Page
>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>
>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>>
Attachments:
[image/png] image.png (377.1K, ../../CAFOhELe6AT5pBaAGbxn9YD3VhZb+JXYCg846=9YvjrDYsBdUrw@mail.gmail.com/3-image.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-25 05:18 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
@ 2024-09-25 05:31 ` Rohit Bhati <[email protected]>
2024-09-26 06:48 ` Re: Require suggestions for Issue #2874 Akshay Joshi <[email protected]>
1 sibling, 1 reply; 33+ messages in thread
From: Rohit Bhati @ 2024-09-25 05:31 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi Khushboo,
I have attached screenshots of the remaining themes.
On Wed, Sep 25, 2024 at 10:49 AM Khushboo Vashi <
[email protected]> wrote:
>
>
> On Tue, Sep 24, 2024 at 5:47 PM Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I haven't used any border colors for any cases previously.
>> However, I tried using border colors for all cases, but this approach
>> overlaps the column and header separators,
>> which doesn't look good.
>>
>
> I liked it :)
> Can you please post the other themes' screen-shot as well?
>
>
>> I've attached a screenshot below for your reference.
>>
>>
>> On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Aditya made a good point - however, the colour on the standard theme
>>> didn't look right to me so I checked on the styleguide and it doesn't seem
>>> like you used one of the standard colours? For the dark theme it looks like
>>> you used border-color, whilst for high contrast, gray-light perhaps? I
>>> wonder if border-color would be appropriate in all cases?
>>>
>>> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi Dave,
>>>> As per Aditya suggestion, I have made some changes and attached images.
>>>> Please check and let me know if you need any changes.
>>>>
>>>> Thanks and Regards
>>>> Rohit Bhati
>>>>
>>>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> It can be something like below. I've removed the shadows completely.
>>>>> [image: image.png]
>>>>>
>>>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Rohit,
>>>>>>
>>>>>> It is actually the same as existing with only difference is alternate
>>>>>> row backgrounds. If later we remove the alternate bg using preferences then
>>>>>> issue of distinguishing row numbers will remain un-fixed.
>>>>>>
>>>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Ok, I am applying that.
>>>>>>>
>>>>>>> Thanks for the suggestions.
>>>>>>>
>>>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have made some changes and made the header and serial number row
>>>>>>>>> column color the same.
>>>>>>>>>
>>>>>>>>> Please once check the attached images.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I think that looks much better!
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> Shadow is more visible, but it doesn't really follow the material
>>>>>>>>>> UI styling which is flat rather than 3D.
>>>>>>>>>>
>>>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>>>> it entirely.
>>>>>>>>>>
>>>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>
>>>>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>>>>> screenshots based on themes.
>>>>>>>>>>> Please once check and let me know if we can go ahead with this
>>>>>>>>>>> or provide suggestions if need to make changes.
>>>>>>>>>>>
>>>>>>>>>>> Thanks & Regards
>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I already set weight to 900.
>>>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have made some more changes with changing background
>>>>>>>>>>>>>>>> color.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates
>>>>>>>>>>>>>>>>>>>>> look across all themes for your reference.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme
>>>>>>>>>>>>>>>>>>>>> or if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers
>>>>>>>>>>>>>>>>>>>> for selected rows in the high contrast theme? The black on grey seems like
>>>>>>>>>>>>>>>>>>>> it might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold
>>>>>>>>>>>>>>>>>>>> all the time. Thoughts?
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>
>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>>
Attachments:
[image/png] image.png (377.1K, ../../CABscKViC3AMPSKvxDF7KT7TuwfMnWO3-CgJKnF0Diz3GA=en6A@mail.gmail.com/3-image.png)
download | view image
[image/png] Screenshot 2024-09-25 at 10.58.59 AM.png (305.5K, ../../CABscKViC3AMPSKvxDF7KT7TuwfMnWO3-CgJKnF0Diz3GA=en6A@mail.gmail.com/4-Screenshot%202024-09-25%20at%2010.58.59%E2%80%AFAM.png)
download | view image
[image/png] Screenshot 2024-09-25 at 10.59.39 AM.png (331.3K, ../../CABscKViC3AMPSKvxDF7KT7TuwfMnWO3-CgJKnF0Diz3GA=en6A@mail.gmail.com/5-Screenshot%202024-09-25%20at%2010.59.39%E2%80%AFAM.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-25 05:18 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-25 05:31 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-26 06:48 ` Akshay Joshi <[email protected]>
0 siblings, 0 replies; 33+ messages in thread
From: Akshay Joshi @ 2024-09-26 06:48 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: Khushboo Vashi <[email protected]>; Dave Page <[email protected]>; Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi Rohit,
I was not too fond of this new changes, rather like the old one that you
have send earlier.
On Wed, Sep 25, 2024 at 4:48 PM Rohit Bhati <[email protected]>
wrote:
> Hi Khushboo,
> I have attached screenshots of the remaining themes.
>
> On Wed, Sep 25, 2024 at 10:49 AM Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Tue, Sep 24, 2024 at 5:47 PM Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>>
>>> I haven't used any border colors for any cases previously.
>>> However, I tried using border colors for all cases, but this approach
>>> overlaps the column and header separators,
>>> which doesn't look good.
>>>
>>
>> I liked it :)
>> Can you please post the other themes' screen-shot as well?
>>
>>
>>> I've attached a screenshot below for your reference.
>>>
>>>
>>> On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> Aditya made a good point - however, the colour on the standard theme
>>>> didn't look right to me so I checked on the styleguide and it doesn't seem
>>>> like you used one of the standard colours? For the dark theme it looks like
>>>> you used border-color, whilst for high contrast, gray-light perhaps? I
>>>> wonder if border-color would be appropriate in all cases?
>>>>
>>>> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Dave,
>>>>> As per Aditya suggestion, I have made some changes and attached images.
>>>>> Please check and let me know if you need any changes.
>>>>>
>>>>> Thanks and Regards
>>>>> Rohit Bhati
>>>>>
>>>>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> It can be something like below. I've removed the shadows completely.
>>>>>> [image: image.png]
>>>>>>
>>>>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Rohit,
>>>>>>>
>>>>>>> It is actually the same as existing with only difference is
>>>>>>> alternate row backgrounds. If later we remove the alternate bg using
>>>>>>> preferences then issue of distinguishing row numbers will remain un-fixed.
>>>>>>>
>>>>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Ok, I am applying that.
>>>>>>>>
>>>>>>>> Thanks for the suggestions.
>>>>>>>>
>>>>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Dave,
>>>>>>>>>>
>>>>>>>>>> I have made some changes and made the header and serial number
>>>>>>>>>> row column color the same.
>>>>>>>>>>
>>>>>>>>>> Please once check the attached images.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> I think that looks much better!
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>>
>>>>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi
>>>>>>>>>>>
>>>>>>>>>>> Shadow is more visible, but it doesn't really follow the
>>>>>>>>>>> material UI styling which is flat rather than 3D.
>>>>>>>>>>>
>>>>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>>>>> it entirely.
>>>>>>>>>>>
>>>>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>
>>>>>>>>>>>> I have added shadow to make the text more distinct and
>>>>>>>>>>>> attached screenshots based on themes.
>>>>>>>>>>>> Please once check and let me know if we can go ahead with this
>>>>>>>>>>>> or provide suggestions if need to make changes.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks & Regards
>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> I already set weight to 900.
>>>>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> If the current changes does not fit well with the theme or
>>>>>>>>>>>>>>> if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have made some more changes with changing background
>>>>>>>>>>>>>>>>> color.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we
>>>>>>>>>>>>>>>>>> still need some other visual distinction, such as the column background
>>>>>>>>>>>>>>>>>> colour.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates
>>>>>>>>>>>>>>>>>>>>>> look across all themes for your reference.
>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme
>>>>>>>>>>>>>>>>>>>>>> or if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers
>>>>>>>>>>>>>>>>>>>>> for selected rows in the high contrast theme? The black on grey seems like
>>>>>>>>>>>>>>>>>>>>> it might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold
>>>>>>>>>>>>>>>>>>>>> all the time. Thoughts?
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Dave Page
>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>
>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Thanks,
>>>>>>> Aditya Toshniwal
>>>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>>>> <https://www.enterprisedb.com/;
>>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> pgAdmin: https://www.pgadmin.org
>>>> PostgreSQL: https://www.postgresql.org
>>>> EDB: https://www.enterprisedb.com
>>>>
>>>>
Attachments:
[image/png] image.png (377.1K, ../../CANxoLDfaQ=qQ3RSYiixKjjuiKX8WZ2db3RwYQk5cpDSBfSLhOw@mail.gmail.com/3-image.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-25 05:18 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
@ 2024-09-25 05:34 ` Rohit Bhati <[email protected]>
1 sibling, 0 replies; 33+ messages in thread
From: Rohit Bhati @ 2024-09-25 05:34 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi Khushboo,
I have attached screenshots of the remaining themes.
On Wed, Sep 25, 2024 at 10:49 AM Khushboo Vashi <
[email protected]> wrote:
>
>
> On Tue, Sep 24, 2024 at 5:47 PM Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I haven't used any border colors for any cases previously.
>> However, I tried using border colors for all cases, but this approach
>> overlaps the column and header separators,
>> which doesn't look good.
>>
>
> I liked it :)
> Can you please post the other themes' screen-shot as well?
>
>
>> I've attached a screenshot below for your reference.
>>
>>
>> On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Aditya made a good point - however, the colour on the standard theme
>>> didn't look right to me so I checked on the styleguide and it doesn't seem
>>> like you used one of the standard colours? For the dark theme it looks like
>>> you used border-color, whilst for high contrast, gray-light perhaps? I
>>> wonder if border-color would be appropriate in all cases?
>>>
>>> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi Dave,
>>>> As per Aditya suggestion, I have made some changes and attached images.
>>>> Please check and let me know if you need any changes.
>>>>
>>>> Thanks and Regards
>>>> Rohit Bhati
>>>>
>>>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> It can be something like below. I've removed the shadows completely.
>>>>> [image: image.png]
>>>>>
>>>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Rohit,
>>>>>>
>>>>>> It is actually the same as existing with only difference is alternate
>>>>>> row backgrounds. If later we remove the alternate bg using preferences then
>>>>>> issue of distinguishing row numbers will remain un-fixed.
>>>>>>
>>>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Ok, I am applying that.
>>>>>>>
>>>>>>> Thanks for the suggestions.
>>>>>>>
>>>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have made some changes and made the header and serial number row
>>>>>>>>> column color the same.
>>>>>>>>>
>>>>>>>>> Please once check the attached images.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I think that looks much better!
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> Shadow is more visible, but it doesn't really follow the material
>>>>>>>>>> UI styling which is flat rather than 3D.
>>>>>>>>>>
>>>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>>>> it entirely.
>>>>>>>>>>
>>>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>
>>>>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>>>>> screenshots based on themes.
>>>>>>>>>>> Please once check and let me know if we can go ahead with this
>>>>>>>>>>> or provide suggestions if need to make changes.
>>>>>>>>>>>
>>>>>>>>>>> Thanks & Regards
>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I already set weight to 900.
>>>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have made some more changes with changing background
>>>>>>>>>>>>>>>> color.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates
>>>>>>>>>>>>>>>>>>>>> look across all themes for your reference.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme
>>>>>>>>>>>>>>>>>>>>> or if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers
>>>>>>>>>>>>>>>>>>>> for selected rows in the high contrast theme? The black on grey seems like
>>>>>>>>>>>>>>>>>>>> it might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold
>>>>>>>>>>>>>>>>>>>> all the time. Thoughts?
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>
>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>>
Attachments:
[image/png] image.png (377.1K, ../../CABscKVjZEmeakMzZw24mr-espKbUUr-uy_mukc858QYagni1hw@mail.gmail.com/3-image.png)
download | view image
[image/png] Screenshot 2024-09-25 at 11.02.34 AM.png (146.2K, ../../CABscKVjZEmeakMzZw24mr-espKbUUr-uy_mukc858QYagni1hw@mail.gmail.com/4-Screenshot%202024-09-25%20at%2011.02.34%E2%80%AFAM.png)
download | view image
[image/png] Screenshot 2024-09-25 at 11.03.28 AM.png (132.1K, ../../CABscKVjZEmeakMzZw24mr-espKbUUr-uy_mukc858QYagni1hw@mail.gmail.com/5-Screenshot%202024-09-25%20at%2011.03.28%E2%80%AFAM.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
@ 2024-09-30 09:12 ` Dave Page <[email protected]>
2024-09-30 11:15 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
1 sibling, 1 reply; 33+ messages in thread
From: Dave Page @ 2024-09-30 09:12 UTC (permalink / raw)
To: Rohit Bhati <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi
On Tue, 24 Sept 2024 at 13:17, Rohit Bhati <[email protected]>
wrote:
> Hi Dave,
>
> I haven't used any border colors for any cases previously.
> However, I tried using border colors for all cases, but this approach
> overlaps the column and header separators,
> which doesn't look good. I've attached a screenshot below for your
> reference.
>
No, it doesn't look great.
But just to be clear; I'm more concerned that we use the existing colours
in the styleguide, than that we stick to using them for exactly what the
name suggests they are for. We should definitely *not* be using any new
colours that are not already in the styleguide.
>
>
> On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Aditya made a good point - however, the colour on the standard theme
>> didn't look right to me so I checked on the styleguide and it doesn't seem
>> like you used one of the standard colours? For the dark theme it looks like
>> you used border-color, whilst for high contrast, gray-light perhaps? I
>> wonder if border-color would be appropriate in all cases?
>>
>> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
>> wrote:
>>
>>> Hi Dave,
>>> As per Aditya suggestion, I have made some changes and attached images.
>>> Please check and let me know if you need any changes.
>>>
>>> Thanks and Regards
>>> Rohit Bhati
>>>
>>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>>> [email protected]> wrote:
>>>
>>>> Hi,
>>>>
>>>> It can be something like below. I've removed the shadows completely.
>>>> [image: image.png]
>>>>
>>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Rohit,
>>>>>
>>>>> It is actually the same as existing with only difference is alternate
>>>>> row backgrounds. If later we remove the alternate bg using preferences then
>>>>> issue of distinguishing row numbers will remain un-fixed.
>>>>>
>>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Ok, I am applying that.
>>>>>>
>>>>>> Thanks for the suggestions.
>>>>>>
>>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>> Hi
>>>>>>>
>>>>>>>
>>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Dave,
>>>>>>>>
>>>>>>>> I have made some changes and made the header and serial number row
>>>>>>>> column color the same.
>>>>>>>>
>>>>>>>> Please once check the attached images.
>>>>>>>>
>>>>>>>
>>>>>>> I think that looks much better!
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> Shadow is more visible, but it doesn't really follow the material
>>>>>>>>> UI styling which is flat rather than 3D.
>>>>>>>>>
>>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>>> it entirely.
>>>>>>>>>
>>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Dave,
>>>>>>>>>>
>>>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>>>> screenshots based on themes.
>>>>>>>>>> Please once check and let me know if we can go ahead with this or
>>>>>>>>>> provide suggestions if need to make changes.
>>>>>>>>>>
>>>>>>>>>> Thanks & Regards
>>>>>>>>>> Rohit Bhati
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> I already set weight to 900.
>>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>
>>>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have made some more changes with changing background color.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates
>>>>>>>>>>>>>>>>>>>> look across all themes for your reference.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme
>>>>>>>>>>>>>>>>>>>> or if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers
>>>>>>>>>>>>>>>>>>> for selected rows in the high contrast theme? The black on grey seems like
>>>>>>>>>>>>>>>>>>> it might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold all
>>>>>>>>>>>>>>>>>>> the time. Thoughts?
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Dave Page
>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>
>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>
>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>
>>>>>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Aditya Toshniwal
>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>> <https://www.enterprisedb.com/;
>>>> "Don't Complain about Heat, Plant a TREE"
>>>>
>>>
>>
>> --
>> Dave Page
>> pgAdmin: https://www.pgadmin.org
>> PostgreSQL: https://www.postgresql.org
>> EDB: https://www.enterprisedb.com
>>
>>
--
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
EDB: https://www.enterprisedb.com
Attachments:
[image/png] image.png (377.1K, ../../CA+OCxoz-Ut7XRCu28-05FznDQp7f9MOW7Rb8gHjQXPcYaRS9Mw@mail.gmail.com/3-image.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
* Re: Require suggestions for Issue #2874
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 11:19 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-05 13:38 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 07:05 ` Re: Require suggestions for Issue #2874 Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-06 08:25 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 09:18 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-09 10:41 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 11:42 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-10 12:11 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Re: Require suggestions for Issue #2874 Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
2024-09-24 12:17 ` Re: Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-30 09:12 ` Re: Require suggestions for Issue #2874 Dave Page <[email protected]>
@ 2024-09-30 11:15 ` Rohit Bhati <[email protected]>
0 siblings, 0 replies; 33+ messages in thread
From: Rohit Bhati @ 2024-09-30 11:15 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Aditya Toshniwal <[email protected]>; pgadmin-hackers
Hi Dave,
As i am only using the color which is present in styleguide for the
background colors based on themes.
On Mon, Sep 30, 2024 at 2:43 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Tue, 24 Sept 2024 at 13:17, Rohit Bhati <[email protected]>
> wrote:
>
>> Hi Dave,
>>
>> I haven't used any border colors for any cases previously.
>> However, I tried using border colors for all cases, but this approach
>> overlaps the column and header separators,
>> which doesn't look good. I've attached a screenshot below for your
>> reference.
>>
>
> No, it doesn't look great.
>
> But just to be clear; I'm more concerned that we use the existing colours
> in the styleguide, than that we stick to using them for exactly what the
> name suggests they are for. We should definitely *not* be using any new
> colours that are not already in the styleguide.
>
>
>>
>>
>> On Thu, Sep 12, 2024 at 7:49 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Aditya made a good point - however, the colour on the standard theme
>>> didn't look right to me so I checked on the styleguide and it doesn't seem
>>> like you used one of the standard colours? For the dark theme it looks like
>>> you used border-color, whilst for high contrast, gray-light perhaps? I
>>> wonder if border-color would be appropriate in all cases?
>>>
>>> On Thu, 12 Sept 2024 at 11:10, Rohit Bhati <[email protected]>
>>> wrote:
>>>
>>>> Hi Dave,
>>>> As per Aditya suggestion, I have made some changes and attached images.
>>>> Please check and let me know if you need any changes.
>>>>
>>>> Thanks and Regards
>>>> Rohit Bhati
>>>>
>>>> On Thu, Sep 12, 2024 at 9:37 AM Aditya Toshniwal <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> It can be something like below. I've removed the shadows completely.
>>>>> [image: image.png]
>>>>>
>>>>> On Thu, Sep 12, 2024 at 9:13 AM Aditya Toshniwal <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Rohit,
>>>>>>
>>>>>> It is actually the same as existing with only difference is alternate
>>>>>> row backgrounds. If later we remove the alternate bg using preferences then
>>>>>> issue of distinguishing row numbers will remain un-fixed.
>>>>>>
>>>>>> On Tue, Sep 10, 2024 at 5:41 PM Rohit Bhati <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Ok, I am applying that.
>>>>>>>
>>>>>>> Thanks for the suggestions.
>>>>>>>
>>>>>>> On Tue, Sep 10, 2024 at 5:34 PM Dave Page <[email protected]> wrote:
>>>>>>>
>>>>>>>> Hi
>>>>>>>>
>>>>>>>>
>>>>>>>> On Tue, 10 Sep 2024 at 12:43, Rohit Bhati <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have made some changes and made the header and serial number row
>>>>>>>>> column color the same.
>>>>>>>>>
>>>>>>>>> Please once check the attached images.
>>>>>>>>>
>>>>>>>>
>>>>>>>> I think that looks much better!
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>> On Tue, Sep 10, 2024 at 2:42 PM Dave Page <[email protected]>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Hi
>>>>>>>>>>
>>>>>>>>>> Shadow is more visible, but it doesn't really follow the material
>>>>>>>>>> UI styling which is flat rather than 3D.
>>>>>>>>>>
>>>>>>>>>> I think Anil's idea is worth exploring; remove the alternating
>>>>>>>>>> colour for the row number column, and use a different background shade for
>>>>>>>>>> it entirely.
>>>>>>>>>>
>>>>>>>>>> On Tue, 10 Sept 2024 at 08:38, Rohit Bhati <
>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>
>>>>>>>>>>> I have added shadow to make the text more distinct and attached
>>>>>>>>>>> screenshots based on themes.
>>>>>>>>>>> Please once check and let me know if we can go ahead with this
>>>>>>>>>>> or provide suggestions if need to make changes.
>>>>>>>>>>>
>>>>>>>>>>> Thanks & Regards
>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Mon, Sep 9, 2024 at 4:11 PM Rohit Bhati <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> I already set weight to 900.
>>>>>>>>>>>> If we need to be more distinct then I think we can have some
>>>>>>>>>>>> shadow or if anything else please suggest.
>>>>>>>>>>>>
>>>>>>>>>>>> On Mon, Sep 9, 2024 at 3:29 PM Dave Page <[email protected]>
>>>>>>>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Mon, 9 Sept 2024 at 10:18, Rohit Bhati <
>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi Dave,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> I have made changes as per your suggestions.
>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>> across all themes for your reference.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> If the current changes does not fit well with the theme or if
>>>>>>>>>>>>>> you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> The colours etc. look correct now (ie. there are no weird
>>>>>>>>>>>>> borders), but I still don't think the row number looks visually distinct
>>>>>>>>>>>>> from the rest of the data. The bold text simply isn't very bold - I think
>>>>>>>>>>>>> it still needs more weight.
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>> Rohit Bhati
>>>>>>>>>>>>>> EnterpriseDB
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 2:01 PM Dave Page <[email protected]>
>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:25, Rohit Bhati <
>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have made some more changes with changing background
>>>>>>>>>>>>>>>> color.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Yeah, that looks weird again, specifically on the selected
>>>>>>>>>>>>>>> rows. I believe the issue is that we should not highlight the row number
>>>>>>>>>>>>>>> column when a row is selected at all. That makes sense, as we should only
>>>>>>>>>>>>>>> be highlighting the columns that would get copied in a copy/paste operation
>>>>>>>>>>>>>>> anyway.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Also, the bold still doesn't look bold. I think the weight
>>>>>>>>>>>>>>> needs to be increased.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 1:51 PM Dave Page <[email protected]>
>>>>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Fri, 6 Sept 2024 at 09:19, Rohit Bhati <
>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have removed the border and background color, just made
>>>>>>>>>>>>>>>>>> the row numbers bold.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates look
>>>>>>>>>>>>>>>>>> across all themes.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> That doesn't look bold at all to me - and I think we still
>>>>>>>>>>>>>>>>> need some other visual distinction, such as the column background colour.
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> On Fri, Sep 6, 2024 at 12:35 PM Khushboo Vashi <
>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> On Thu, Sep 5, 2024 at 7:11 PM Dave Page <
>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> On Thu, 5 Sept 2024 at 14:38, Rohit Bhati <
>>>>>>>>>>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> Hi,
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I have made changes for issue #7863
>>>>>>>>>>>>>>>>>>>>> <https://github.com/pgadmin-org/pgadmin4/issues/7863; based
>>>>>>>>>>>>>>>>>>>>> on theme requirements.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> I have attached screenshots showing how the updates
>>>>>>>>>>>>>>>>>>>>> look across all themes for your reference.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>> If the current color does not fit well with the theme
>>>>>>>>>>>>>>>>>>>>> or if you have any suggestions for improvements, please let me know.
>>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> Is the colour contrast high enough on the row numbers
>>>>>>>>>>>>>>>>>>>> for selected rows in the high contrast theme? The black on grey seems like
>>>>>>>>>>>>>>>>>>>> it might not be to me, but I haven't tested.
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> I wonder also if we should make the row numbers bold
>>>>>>>>>>>>>>>>>>>> all the time. Thoughts?
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>> We can check how it looks. Also the cell border doesn't
>>>>>>>>>>>>>>>>>>> look good to me.
>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> PGDay UK 2024, 11th September, London:
>>>>>>>>>>>>>>> https://2024.pgday.uk/
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> --
>>>>>>>>>>>>> Dave Page
>>>>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>>>>
>>>>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Dave Page
>>>>>>>>>> pgAdmin: https://www.pgadmin.org
>>>>>>>>>> PostgreSQL: https://www.postgresql.org
>>>>>>>>>> EDB: https://www.enterprisedb.com
>>>>>>>>>>
>>>>>>>>>> PGDay UK 2024, 11th September, London: https://2024.pgday.uk/
>>>>>>>>>>
>>>>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks,
>>>>>> Aditya Toshniwal
>>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>>> <https://www.enterprisedb.com/;
>>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanks,
>>>>> Aditya Toshniwal
>>>>> pgAdmin Hacker | Sr. Software Architect | *enterprisedb.com*
>>>>> <https://www.enterprisedb.com/;
>>>>> "Don't Complain about Heat, Plant a TREE"
>>>>>
>>>>
>>>
>>> --
>>> Dave Page
>>> pgAdmin: https://www.pgadmin.org
>>> PostgreSQL: https://www.postgresql.org
>>> EDB: https://www.enterprisedb.com
>>>
>>>
>
> --
> Dave Page
> pgAdmin: https://www.pgadmin.org
> PostgreSQL: https://www.postgresql.org
> EDB: https://www.enterprisedb.com
>
>
Attachments:
[image/png] image.png (377.1K, ../../CABscKVgQTbE3Dh+L9WZhw9KB1Zmd4oR-vEbOUi5mU3CdcMHEKg@mail.gmail.com/3-image.png)
download | view image
^ permalink raw reply [nested|flat] 33+ messages in thread
end of thread, other threads:[~2024-09-30 11:15 UTC | newest]
Thread overview: 33+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-09-04 11:38 Require suggestions for Issue #2874 Rohit Bhati <[email protected]>
2024-09-05 07:27 ` Rohit Bhati <[email protected]>
2024-09-05 10:21 ` Dave Page <[email protected]>
2024-09-05 11:19 ` Rohit Bhati <[email protected]>
2024-09-05 11:32 ` Dave Page <[email protected]>
2024-09-05 13:38 ` Rohit Bhati <[email protected]>
2024-09-05 13:41 ` Dave Page <[email protected]>
2024-09-06 04:39 ` Yogesh Mahajan <[email protected]>
2024-09-06 07:05 ` Khushboo Vashi <[email protected]>
2024-09-06 08:18 ` Rohit Bhati <[email protected]>
2024-09-06 08:21 ` Dave Page <[email protected]>
2024-09-06 08:25 ` Rohit Bhati <[email protected]>
2024-09-06 08:30 ` Dave Page <[email protected]>
2024-09-09 09:18 ` Rohit Bhati <[email protected]>
2024-09-09 09:59 ` Dave Page <[email protected]>
2024-09-09 10:36 ` Anil Sahoo <[email protected]>
2024-09-09 10:41 ` Rohit Bhati <[email protected]>
2024-09-10 07:37 ` Rohit Bhati <[email protected]>
2024-09-10 09:12 ` Dave Page <[email protected]>
2024-09-10 11:42 ` Rohit Bhati <[email protected]>
2024-09-10 12:04 ` Dave Page <[email protected]>
2024-09-10 12:11 ` Rohit Bhati <[email protected]>
2024-09-12 03:43 ` Aditya Toshniwal <[email protected]>
2024-09-12 04:07 ` Aditya Toshniwal <[email protected]>
2024-09-12 10:09 ` Rohit Bhati <[email protected]>
2024-09-12 14:19 ` Dave Page <[email protected]>
2024-09-24 12:17 ` Rohit Bhati <[email protected]>
2024-09-25 05:18 ` Khushboo Vashi <[email protected]>
2024-09-25 05:31 ` Rohit Bhati <[email protected]>
2024-09-26 06:48 ` Akshay Joshi <[email protected]>
2024-09-25 05:34 ` Rohit Bhati <[email protected]>
2024-09-30 09:12 ` Dave Page <[email protected]>
2024-09-30 11:15 ` Rohit Bhati <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox