agora inbox for [email protected]  

help / color / mirror / Atom feed

[PATCH v20 3/6] Refactor index_concurrently_create_copy() for use with REPACK (CONCURRENTLY).
65+ messages / 2 participants
[nested] [flat]

* [PATCH v20 3/6] Refactor index_concurrently_create_copy() for use with REPACK (CONCURRENTLY).
@ 2025-08-11 13:31  Antonin Houska <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Antonin Houska @ 2025-08-11 13:31 UTC (permalink / raw)

This patch moves the code to index_create_copy() and adds a "concurrently"
parameter so it can be used by REPACK (CONCURRENTLY).

With the CONCURRENTLY option, REPACK cannot simply swap the heap file and
rebuild its indexes. Instead, it needs to build a separate set of indexes
(including system catalog entries) *before* the actual swap, to reduce the
time AccessExclusiveLock needs to be held for.
---
 src/backend/catalog/index.c | 36 ++++++++++++++++++++++++++++--------
 src/include/catalog/index.h |  3 +++
 2 files changed, 31 insertions(+), 8 deletions(-)

diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index 3063abff9a5..0dee1b1a9d8 100644
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -1290,15 +1290,31 @@ index_create(Relation heapRelation,
 /*
  * index_concurrently_create_copy
  *
- * Create concurrently an index based on the definition of the one provided by
- * caller.  The index is inserted into catalogs and needs to be built later
- * on.  This is called during concurrent reindex processing.
- *
- * "tablespaceOid" is the tablespace to use for this index.
+ * Variant of index_create_copy(), called during concurrent reindex
+ * processing.
  */
 Oid
 index_concurrently_create_copy(Relation heapRelation, Oid oldIndexId,
 							   Oid tablespaceOid, const char *newName)
+{
+	return index_create_copy(heapRelation, oldIndexId, tablespaceOid, newName,
+							 true);
+}
+
+/*
+ * index_create_copy
+ *
+ * Create an index based on the definition of the one provided by caller.  The
+ * index is inserted into catalogs and needs to be built later on.
+ *
+ * "tablespaceOid" is the tablespace to use for this index.
+ *
+ * The actual implementation of index_concurrently_create_copy(), reusable for
+ * other purposes.
+ */
+Oid
+index_create_copy(Relation heapRelation, Oid oldIndexId, Oid tablespaceOid,
+				  const char *newName, bool concurrently)
 {
 	Relation	indexRelation;
 	IndexInfo  *oldInfo,
@@ -1317,6 +1333,7 @@ index_concurrently_create_copy(Relation heapRelation, Oid oldIndexId,
 	List	   *indexColNames = NIL;
 	List	   *indexExprs = NIL;
 	List	   *indexPreds = NIL;
+	int			flags = 0;
 
 	indexRelation = index_open(oldIndexId, RowExclusiveLock);
 
@@ -1325,9 +1342,9 @@ index_concurrently_create_copy(Relation heapRelation, Oid oldIndexId,
 
 	/*
 	 * Concurrent build of an index with exclusion constraints is not
-	 * supported.
+	 * supported. If !concurrently, ii_ExclusinOps is currently not needed.
 	 */
-	if (oldInfo->ii_ExclusionOps != NULL)
+	if (oldInfo->ii_ExclusionOps != NULL && concurrently)
 		ereport(ERROR,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 				 errmsg("concurrent index creation for exclusion constraints is not supported")));
@@ -1435,6 +1452,9 @@ index_concurrently_create_copy(Relation heapRelation, Oid oldIndexId,
 		stattargets[i].isnull = isnull;
 	}
 
+	if (concurrently)
+		flags = INDEX_CREATE_SKIP_BUILD | INDEX_CREATE_CONCURRENT;
+
 	/*
 	 * Now create the new index.
 	 *
@@ -1458,7 +1478,7 @@ index_concurrently_create_copy(Relation heapRelation, Oid oldIndexId,
 							  indcoloptions->values,
 							  stattargets,
 							  reloptionsDatum,
-							  INDEX_CREATE_SKIP_BUILD | INDEX_CREATE_CONCURRENT,
+							  flags,
 							  0,
 							  true, /* allow table to be a system catalog? */
 							  false,	/* is_internal? */
diff --git a/src/include/catalog/index.h b/src/include/catalog/index.h
index 4daa8bef5ee..063a891351a 100644
--- a/src/include/catalog/index.h
+++ b/src/include/catalog/index.h
@@ -99,6 +99,9 @@ extern Oid	index_concurrently_create_copy(Relation heapRelation,
 										   Oid oldIndexId,
 										   Oid tablespaceOid,
 										   const char *newName);
+extern Oid	index_create_copy(Relation heapRelation, Oid oldIndexId,
+							  Oid tablespaceOid, const char *newName,
+							  bool concurrently);
 
 extern void index_concurrently_build(Oid heapRelationId,
 									 Oid indexRelationId);
-- 
2.39.5


--3q6txozlgl6t37td
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename="v20-0004-Move-conversion-of-a-historic-to-MVCC-snapshot-t.patch"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

* [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length
@ 2026-03-12 15:12  Álvaro Herrera <[email protected]>
  0 siblings, 0 replies; 65+ messages in thread

From: Álvaro Herrera @ 2026-03-12 15:12 UTC (permalink / raw)

---
 src/backend/commands/cluster.c                            | 2 +-
 src/backend/replication/pgoutput_repack/pgoutput_repack.c | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
index 29440fb75cd..244843ee1cf 100644
--- a/src/backend/commands/cluster.c
+++ b/src/backend/commands/cluster.c
@@ -3113,7 +3113,7 @@ restore_tuple(BufFile *file, Relation relation, MemoryContext cxt)
 	uint32		t_len;
 	HeapTuple	tup;
 	MemoryContext oldcxt;
-	uint32		natt_ext;
+	int			natt_ext;
 	List	   *attrs_ext = NIL;
 
 	oldcxt = MemoryContextSwitchTo(cxt);
diff --git a/src/backend/replication/pgoutput_repack/pgoutput_repack.c b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
index 79fc611b9ff..61cd7c52ae6 100644
--- a/src/backend/replication/pgoutput_repack/pgoutput_repack.c
+++ b/src/backend/replication/pgoutput_repack/pgoutput_repack.c
@@ -175,7 +175,7 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 	BufFile    *file;
 	char		kind_byte = (char) kind;
 	List	   *attrs_ext = NIL;
-	uint32		natt_ext;
+	int			natt_ext;
 
 	dstate = (RepackDecodingState *) ctx->output_writer_private;
 	file = dstate->file;
@@ -237,14 +237,12 @@ store_change(LogicalDecodingContext *ctx, Relation relation,
 				Assert(VARATT_IS_EXTERNAL_ONDISK(varlena_pointer));
 			}
 		}
-		natt_ext = list_length(attrs_ext);
 	}
-	else
-		natt_ext = 0;
 
 	/* Write the number of external attributes. */
+	natt_ext = list_length(attrs_ext);
 	BufFileWrite(file, &natt_ext, sizeof(natt_ext));
-	/* ... and the attributes themselves, if there are some. */
+	/* ... and the attributes themselves, if any */
 	foreach_ptr(varlena, attr_val, attrs_ext)
 	{
 		varlena    *ext_val;
-- 
2.47.3


--pnppmxqkefjd4hu2
Content-Type: text/plain; charset=utf-8
Content-Disposition: attachment;
	filename="0007-no-need-for-palloc0-here-simple-palloc-is-enough.nocfbot.txt"



^ permalink  raw  reply  [nested|flat] 65+ messages in thread

end of thread, other threads:[~2026-03-12 15:12 UTC | newest]

Thread overview: 65+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-08-11 13:31 [PATCH v20 3/6] Refactor index_concurrently_create_copy() for use with REPACK (CONCURRENTLY). Antonin Houska <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>
2026-03-12 15:12 [PATCH 6/9] use 'int' instead of 'uint32' for the result of list_length Álvaro Herrera <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox